Jira (PUP-11229) Update puppet `instance?` methods to use `instance_of?` instead of `is_a?`
Title: Message Title Josh Cooper updated an issue Puppet / PUP-11229 Update puppet `instance?` methods to use `instance_of?` instead of `is_a?` Change By: Josh Cooper Team: Phoenix Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.413157.1629790983000.14261.1684347120520%40Atlassian.JIRA.
Jira (PUP-11229) Update puppet `instance?` methods to use `instance_of?` instead of `is_a?`
Title: Message Title Josh Cooper updated an issue Puppet / PUP-11229 Update puppet `instance?` methods to use `instance_of?` instead of `is_a?` Change By: Josh Cooper Epic Link: PUP-5773 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.413157.1629790983000.14260.1684347120475%40Atlassian.JIRA.
Jira (PUP-11229) Update puppet `instance?` methods to use `instance_of?` instead of `is_a?`
Title: Message Title Josh Cooper updated an issue Puppet / PUP-11229 Update puppet `instance?` methods to use `instance_of?` instead of `is_a?` Change By: Josh Cooper Labels: performance Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.413157.1629790983000.14259.1684347120428%40Atlassian.JIRA.
Jira (PUP-11229) Update puppet `instance?` methods to use `instance_of?` instead of `is_a?`
Title: Message Title Ciprian Badescu updated an issue Puppet / PUP-11229 Update puppet `instance?` methods to use `instance_of?` instead of `is_a?` Change By: Ciprian Badescu Epic Link: PUP-5773 Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.413157.1629790983000.134673.1632215820190%40Atlassian.JIRA.
Jira (PUP-11229) Update puppet `instance?` methods to use `instance_of?` instead of `is_a?`
Title: Message Title Victor Bobosila created an issue Puppet / PUP-11229 Update puppet `instance?` methods to use `instance_of?` instead of `is_a?` Issue Type: Improvement Assignee: Unassigned Created: 2021/08/24 12:43 AM Priority: Normal Reporter: Victor Bobosila The Jira issue PUP-10105, solved an issue where puppet resource --to_yaml would emit puppet class tags by updating the way PScalarDataType#instance? checks whether an object is an instance of the said type. The problem was that some of the resource's fields would be ProcessOutput objects, which is a child class of ruby String, and the instance? method used `is_a?` to check whether the ProcessOutput object was an instance. In this case, due to the way `is_a?` works, the instance? method would return true, since the object is a child of String. To fix this issue, we updated the method to use `instance_of?` when checking Strings, so it would only return true for actual ruby Strings. The next step would be to update the `instance?` methods for the rest of Data and RichData data types such as (Integer/Float/Fixnum/Bignum/Rational) Add Comment
