Jira (PUP-11236) Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb`
Title: Message Title Parker Leach updated an issue Puppet / PUP-11236 Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb` Change By: Parker Leach Labels: docs_reviewed Add Comment This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.414011.1630500702000.1156.1638938580086%40Atlassian.JIRA.
Jira (PUP-11236) Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb`
Title: Message Title Josh Cooper updated an issue Puppet / PUP-11236 Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb` Change By: Josh Cooper Release Notes: Bug Fix Release Notes Summary: Reduce lexer memory usage Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.414011.1630500702000.159987.1634757840089%40Atlassian.JIRA.
Jira (PUP-11236) Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb`
Title: Message Title Josh Cooper commented on PUP-11236 Re: Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb` Passed CI in 8b4331b9f5 Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.414011.1630500702000.159985.1634757780134%40Atlassian.JIRA.
Jira (PUP-11236) Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb`
Title: Message Title Ciprian Badescu updated an issue Puppet / PUP-11236 Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb` Change By: Ciprian Badescu Team: Night's Watch Coremunity Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.414011.1630500702000.159123.1634715240030%40Atlassian.JIRA.
Jira (PUP-11236) Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb`
Title: Message Title Ciprian Badescu updated an issue Puppet / PUP-11236 Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb` Change By: Ciprian Badescu Sprint: NW - 2021-10-20 Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.414011.1630500702000.159122.1634715180037%40Atlassian.JIRA.
Jira (PUP-11236) Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb`
Title: Message Title Josh Cooper commented on PUP-11236 Re: Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb` Merged to 6.x in https://github.com/puppetlabs/puppet/commit/08531619e776052efbf60b211eabfa710c35fd01 Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.414011.1630500702000.156774.1634335800030%40Atlassian.JIRA.
Jira (PUP-11236) Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb`
Title: Message Title Josh Cooper updated an issue Puppet / PUP-11236 Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb` Change By: Josh Cooper Fix Version/s: PUP 6.26.0 Fix Version/s: PUP 7.13.0 Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.414011.1630500702000.156622.1634327700034%40Atlassian.JIRA.
Jira (PUP-11236) Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb`
Title: Message Title Josh Cooper assigned an issue to Josh Cooper Puppet / PUP-11236 Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb` Change By: Josh Cooper Assignee: Josh Cooper Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.414011.1630500702000.156604.1634326860055%40Atlassian.JIRA.
Jira (PUP-11236) Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb`
Title: Message Title Josh Cooper commented on PUP-11236 Re: Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb` This is due to a ruby bug https://bugs.ruby-lang.org/issues/16906. In MRI, our ThreadLocalSingleton doesn't behave like a singleton, so we create N copies of Puppet::Pops::Parser::Lexer2. One workaround is to avoid using Thread#thread_variable? Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.414011.1630500702000.156584.1634325840039%40Atlassian.JIRA.
Jira (PUP-11236) Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb`
Title: Message Title Ciprian Badescu updated an issue Puppet / PUP-11236 Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb` Change By: Ciprian Badescu Story Points: 3 Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.414011.1630500702000.148093.1633507800032%40Atlassian.JIRA.
Jira (PUP-11236) Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb`
Title: Message Title Ciprian Badescu updated an issue Puppet / PUP-11236 Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb` Change By: Ciprian Badescu Sprint: NW - 2021-10-20 Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.414011.1630500702000.139946.1632750780061%40Atlassian.JIRA.
Jira (PUP-11236) Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb`
Title: Message Title Ciprian Badescu updated an issue Puppet / PUP-11236 Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb` Change By: Ciprian Badescu Epic Link: PUP-11073 Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.414011.1630500702000.133828.1632147660034%40Atlassian.JIRA.
Jira (PUP-11236) Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb`
Title: Message Title Luchian Nemes updated an issue Puppet / PUP-11236 Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb` Change By: Luchian Nemes Attachment: mem_profile_15614.txt Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.414011.1630500702000.121945.1630566420042%40Atlassian.JIRA.
Jira (PUP-11236) Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb`
Title: Message Title Luchian Nemes created an issue Puppet / PUP-11236 Reduce allocated memory in `lib/puppet/pops/parser/lexer2.rb` Issue Type: Bug Assignee: Unassigned Created: 2021/09/01 5:51 AM Priority: Normal Reporter: Luchian Nemes PUP-11232 added # frozen_string_literal: true to some high memory consumption files but even after that, lib/puppet/pops/parser/lexer2.rb still seems to have the most memory allocated. Proposed investigation direction as stated by Josh Cooper: I'm guessing the lexer2 allocations are due to the closure scope bound to each lambda? I'm thinking Ruby may be doing more work than is necessary to create the Binding as each token is scanned and the corresponding lambda is called? Or perhaps it's the byteslice calls? Add Comment
