Jira (PUP-8498) No title provided and "foo" is not a valid resource reference

2018-03-13 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8498  
 
 
  No title provided and "foo" is not a valid resource reference   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Fix Version/s: 
 PUP 5.5.0  
 
 
Fix Version/s: 
 PUP 5.5.z  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8498) No title provided and "foo" is not a valid resource reference

2018-03-09 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8498  
 
 
  No title provided and "foo" is not a valid resource reference   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Fix Version/s: 
 PUP 4.10.z  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8498) No title provided and "foo" is not a valid resource reference

2018-03-09 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8498  
 
 
  No title provided and "foo" is not a valid resource reference   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Sub-team: 
 Coremunity  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8498) No title provided and "foo" is not a valid resource reference

2018-03-09 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg commented on  PUP-8498  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: No title provided and "foo" is not a valid resource reference   
 

  
 
 
 
 

 
 The error occurs when the validator is asking if the given value is a resource. It errors out prematurely instead of getting the higher quality error message from the validator. This is an easy fix for the logic around line 35 (if it errors when getting the resource with the specific error) it should take that as a not found. Alternatively it should call "extract type and title" on its own to not be exposed to other types of errors (which we do want to surface).  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8498) No title provided and "foo" is not a valid resource reference

2018-03-09 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg assigned an issue to Henrik Lindberg  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8498  
 
 
  No title provided and "foo" is not a valid resource reference   
 

  
 
 
 
 

 
Change By: 
 Henrik Lindberg  
 
 
Assignee: 
 Henrik Lindberg  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8498) No title provided and "foo" is not a valid resource reference

2018-03-09 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8498  
 
 
  No title provided and "foo" is not a valid resource reference   
 

  
 
 
 
 

 
Change By: 
 Henrik Lindberg  
 
 
Affects Version/s: 
 PUP 5.3.3  
 
 
Affects Version/s: 
 PUP 4.10.0  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8498) No title provided and "foo" is not a valid resource reference

2018-03-09 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8498  
 
 
  No title provided and "foo" is not a valid resource reference   
 

  
 
 
 
 

 
Change By: 
 Henrik Lindberg  
 
 
Fix Version/s: 
 PUP 5.5.0  
 
 
Fix Version/s: 
 PUP 5.3.z  
 
 
Fix Version/s: 
 PUP 4.10.z  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8498) No title provided and "foo" is not a valid resource reference

2018-03-09 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8498  
 
 
  No title provided and "foo" is not a valid resource reference   
 

  
 
 
 
 

 
Change By: 
 Henrik Lindberg  
 
 
Issue Type: 
 Improvement Bug  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8498) No title provided and "foo" is not a valid resource reference

2018-03-09 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg commented on  PUP-8498  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: No title provided and "foo" is not a valid resource reference   
 

  
 
 
 
 

 
 This comes from the catalog validation - I ran the relevant part of the example with --trace and this is what I got:  
 
 
 
 
 Error: No title provided and "xyz" is not a valid resource reference on node henrik2  
 
 
 /Users/henrik/git/puppet/lib/puppet/resource.rb:592:in `extract_type_and_title'  
 
 
 /Users/henrik/git/puppet/lib/puppet/resource.rb:577:in `type_and_title'  
 
 
 /Users/henrik/git/puppet/lib/puppet/resource/catalog.rb:371:in `resource'  
 
 
 /Users/henrik/git/puppet/lib/puppet/parser/compiler/catalog_validator/relationship_validator.rb:35:in `block in validate_relationship'  
 
 
 /Users/henrik/git/puppet/lib/puppet/parser/compiler/catalog_validator/relationship_validator.rb:33:in `each'  
 
 
 /Users/henrik/git/puppet/lib/puppet/parser/compiler/catalog_validator/relationship_validator.rb:33:in `validate_relationship'  
 
 
 /Users/henrik/git/puppet/lib/puppet/parser/compiler/catalog_validator/relationship_validator.rb:11:in `block (2 levels) in validate'
  
 
 
 
  So, it looks like a validation problem after compilation.  
 

  
 
 
 
 

 
 
 

Jira (PUP-8498) No title provided and "foo" is not a valid resource reference

2018-03-05 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8498  
 
 
  No title provided and "foo" is not a valid resource reference   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Team: 
 Platform Core  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8498) No title provided and "foo" is not a valid resource reference

2018-03-05 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-8498  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: No title provided and "foo" is not a valid resource reference   
 

  
 
 
 
 

 
 Thanks Gavin Williams, makes sense the error message should be better to explain that puppet was expecting something of the form Type[title]. I assume the issue is because the error is generated agent-side when the catalog is converted from a resource catalog to a RAL catalog, and we try to generate the autorelations. /cc Henrik Lindberg  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8498) No title provided and "foo" is not a valid resource reference

2018-02-28 Thread Gavin Williams (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gavin Williams updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8498  
 
 
  No title provided and "foo" is not a valid resource reference   
 

  
 
 
 
 

 
Change By: 
 Gavin Williams  
 

  
 
 
 
 

 
 *Puppet Version:* 5.3.3 *Puppet Server Version:* N/AUpon creating some rspec-puppet tests for a new Puppet module, the following error was encountered:{code:java}  1) actora on centos-7-x86_64 with defaults should compile into a catalogue without dependency cyclesFailure/Error: it { should compile }error during compilation: No title provided and "actora" is not a valid resource reference on node lt0772.local{code}As there was no traceback to a specific file/line provided, this one proved challenging to track down. In the end, the following code was at fault:{code:java}  ## install actora rpm (which should install nodejs and npm)package { $actora::package_name:  ensure => $actora::version,  notify => $actora::service_name,  tag => ['actora::package']}{code}The notify here resolves to {{'actora'}}.A simple reproducer is:{code:java}  $ cat foo/manifests/init.ppclass foo () {  notify { 'testing':notify => xyz,  }}$ puppet apply -t --exec 'include foo'Info: Loading factsError: No title provided and "xyz" is not a valid resource reference on node host.example.net{code}Thanks to [~JohnsonEarls] for  the  reproducer.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574)  
 
 

   

Jira (PUP-8498) No title provided and "foo" is not a valid resource reference

2018-02-28 Thread Gavin Williams (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gavin Williams created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8498  
 
 
  No title provided and "foo" is not a valid resource reference   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Affects Versions: 
 PUP 5.3.3  
 
 
Assignee: 
 Unassigned  
 
 
Components: 
 AIO  
 
 
Created: 
 2018/02/28 8:43 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Gavin Williams  
 

  
 
 
 
 

 
 Puppet Version: 5.3.3 Puppet Server Version: N/A Upon creating some rspec-puppet tests for a new Puppet module, the following error was encountered:  
 
 
 
 
 1) actora on centos-7-x86_64 with defaults should compile into a catalogue without dependency cycles  
 
 
 Failure/Error: it { should compile }  
 
 
 error during compilation: No title provided and "actora" is not a valid resource reference on node lt0772.local
  
 
 
 
  As there was no traceback to a specific file/line provided, this one proved