Jira (FACT-183) PR (590): Extract Facter execution methods to mixin - adrienthebo
Title: Message Title Joshua Cooper commented on an issue Re: PR (590): Extract Facter execution methods to mixin - adrienthebo Merged into facter-2 in commit 2ff7ae91064d and released in 2.0.1 Add Comment Facter / FACT-183 PR (590): Extract Facter execution methods to mixin - adrienthebo h2. Extract Facter execution methods to mixin * Author: Adrien Thebo git+git...@somethingsinistral.net * Company: Puppet Labs * Github ID: [adrienthebo|https://github.com/adrienthebo] * [Pull Request 590 Discussion|https://github.com/puppetlabs/facter/pull/590] * [Pull Request 590 File Diff|https://github.com/puppetlabs/facter/pull/590/files] h2 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-183) PR (590): Extract Facter execution methods to mixin - adrienthebo
Title: Message Title gepetto-bot commented on an issue Re: PR (590): Extract Facter execution methods to mixin - adrienthebo Pull request Extract Facter execution methods to mixin has been closed. Add Comment Facter / FACT-183 PR (590): Extract Facter execution methods to mixin - adrienthebo h2. Extract Facter execution methods to mixin * Author: Adrien Thebo git+git...@somethingsinistral.net * Company: Puppet Labs * Github ID: [adrienthebo|https://github.com/adrienthebo] * [Pull Request 590 Discussion|https://github.com/puppetlabs/facter/pull/590] * [Pull Request 590 File Diff|https://github.com/puppetlabs/facter/pull/590/files] h2 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
Jira (FACT-183) PR (590): Extract Facter execution methods to mixin - adrienthebo
Title: Message Title gepetto-bot created an issue Facter / FACT-183 PR (590): Extract Facter execution methods to mixin - adrienthebo Issue Type: Task Assignee: Eric Sorenson Components: Community Created: 31/Dec/13 9:45 AM Labels: github Priority: Normal Reporter: gepetto-bot Extract Facter execution methods to mixin Author: Adrien Thebo git+git...@somethingsinistral.net Company: Puppet Labs Github ID: adrienthebo Pull Request 590 Discussion Pull Request 590 File Diff Pull Request Description The command
Jira (FACT-183) PR (590): Extract Facter execution methods to mixin - adrienthebo
Title: Message Title
gepetto-bot commented on an issue
Re: PR (590): Extract Facter execution methods to mixin - adrienthebo
jhoblitt commented:
Are there any external users of `Facter::Util::Resolution` as a instance? I'm wondering if it wouldn't be easier to leave the execution class methods under the current namespace, since these are likely used by a majority of facts, and move away the resolution instance methods to a new namespace like `Facter::Core:: {Resolution,Verdict, etc.}
`.
Add Comment
Facter / FACT-183
PR (590): Extract Facter execution methods to mixin - adrienthebo
h2. Extract Facter execution methods to mixin * Author: Adrien Thebo git+git...@somethingsinistral.net * Company: Puppet Labs * Github ID: [adrienthebo|https://github.com/adrienthebo] * [Pull Request 590 Discussion|https://github.com/puppetlabs/facter/pull/590] * [Pull Request 590 File Diff|https://github.com/puppetlabs/facter/pull/590/files] h2
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet
Jira (FACT-183) PR (590): Extract Facter execution methods to mixin - adrienthebo
Title: Message Title gepetto-bot commented on an issue Re: PR (590): Extract Facter execution methods to mixin - adrienthebo adrienthebo commented: `Facter::Util::Resolution` extends `Facter::Util::Execution`, so all existing invocations of `Facter::Util::Resolution.exec` and related still work. It's a pure refactor and shouldn't break any existing behavior. Add Comment Facter / FACT-183 PR (590): Extract Facter execution methods to mixin - adrienthebo h2. Extract Facter execution methods to mixin * Author: Adrien Thebo git+git...@somethingsinistral.net * Company: Puppet Labs * Github ID: [adrienthebo|https://github.com/adrienthebo] * [Pull Request 590 Discussion|https://github.com/puppetlabs/facter/pull/590] * [Pull Request 590 File Diff|https://github.com/puppetlabs/facter/pull/590/files] h2 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to
Jira (FACT-183) PR (590): Extract Facter execution methods to mixin - adrienthebo
Title: Message Title gepetto-bot commented on an issue Re: PR (590): Extract Facter execution methods to mixin - adrienthebo puppetcla commented: CLA signed by all contributors. Add Comment Facter / FACT-183 PR (590): Extract Facter execution methods to mixin - adrienthebo h2. Extract Facter execution methods to mixin * Author: Adrien Thebo git+git...@somethingsinistral.net * Company: Puppet Labs * Github ID: [adrienthebo|https://github.com/adrienthebo] * [Pull Request 590 Discussion|https://github.com/puppetlabs/facter/pull/590] * [Pull Request 590 File Diff|https://github.com/puppetlabs/facter/pull/590/files] h2 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/groups/opt_out.
