Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title Jean Bond updated an issue Facter / FACT-1889 Windows operating system facts should resolve correctly for Server 2019 Change By: Jean Bond Labels: resolved-issue-added Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title Enis Inan commented on FACT-1889 Re: Windows operating system facts should resolve correctly for Server 2019 This will be resolved once it passes master CI. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title Enis Inan updated an issue Facter / FACT-1889 Windows operating system facts should resolve correctly for Server 2019 Change By: Enis Inan Fix Version/s: FACT 3.12.1 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title Enis Inan commented on FACT-1889 Re: Windows operating system facts should resolve correctly for Server 2019 Geoff Nichols Done. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title Enis Inan updated an issue Facter / FACT-1889 Windows operating system facts should resolve correctly for Server 2019 Change By: Enis Inan Release Notes Summary: Facter now correctly distinguishes between Windows Server 2016 and Windows Server 2019. Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title Geoff Nichols commented on FACT-1889 Re: Windows operating system facts should resolve correctly for Server 2019 Enis Inan, when you have a chance, could you please add release notes (or indicate that they're not needed)? Thanks! Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title Geoff Nichols updated an issue Facter / FACT-1889 Windows operating system facts should resolve correctly for Server 2019 Change By: Geoff Nichols Fix Version/s: FACT 3.11.5 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title Glenn Sarti commented on FACT-1889 Re: Windows operating system facts should resolve correctly for Server 2019 As long as FACT-1881 is scheduled (it's currently blocked), +1 from me! Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title Enis Inan assigned an issue to Enis Inan Facter / FACT-1889 Windows operating system facts should resolve correctly for Server 2019 Change By: Enis Inan Assignee: Enis Inan Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title Branan Riley commented on FACT-1889 Re: Windows operating system facts should resolve correctly for Server 2019 Given we have to get windows 2019 support landed in the next couple of days, I'm still inclined to stick with the current codebase and implement it as Enis Inan described above. It's simple, and it gets us 2019 support today, which is important to our customers. We should absolutely start on FACT-1881 sooner than later for a Facter 3.y in puppet-agent 6.1.0. Once we've got that implemented, it's totally reasonable to consider backporting it to 5.5 and/or 6.0 if there's customer demand and if, once we've seen how it behaves, we're comfortable with the risks. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title Casey Williams assigned an issue to Unassigned Facter / FACT-1889 Windows operating system facts should resolve correctly for Server 2019 Change By: Casey Williams Assignee: Casey Williams Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title Glenn Sarti commented on FACT-1889 Re: Windows operating system facts should resolve correctly for Server 2019 I think I disagree with Branan Riley although I may have misinterpreted. IMO we should not have two different ways of detecting OS versions running at the same time i.e. Having Facter 3.13 "proper way" and puppet 5.5 and 6.0 using the hacky way. (perhaps I read that wrong, in which case forgive me Branan) In my mind we have two issues; 1. Detecting the correct version (This is an implementation concern) 2. Displaying that information to the user as a series of facts (This is a UX concern) and we should be able to address these separately and simultaneously. Phase 1: IMO we should be implementing the work in FACT-1881 to do the detection of the Windows OS (BUT NOT displaying this as a fact. That comes later). We could then output the results of the ReleaseID etc. as Debug statements for the time being. This means we would have a better/stable way to detect the plethora of Windows OS versions out there. We would then use the new detection method to output the SAME fact information we currently have (A standard refactor). This will reduce Branan's feel of major surgery (which I agree with BTW) and give confidence for going forward Phase 2: Introduce detecting Windows Server 2019 into the existing factset, similar to what Enis proposed above. This means facter will now somewhat detect Server 2019 and get us over the line for 2019 support This will fix Problem 1, I stated above (Implementation concern) Phase 3: While Phase 1/2 are going on, this gives us time to reconsider the fact structure to accommodate the windows OS stuff we implemented in Phase 1. And we can then implement it either as a breaking change (Facter 4.x) or as a backwards-compatible change (Facter 3.y) This will then fix Problem 2, the UX concern. What do you think? Ping John O'Connor Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title Casey Williams assigned an issue to Casey Williams Facter / FACT-1889 Windows operating system facts should resolve correctly for Server 2019 Change By: Casey Williams Assignee: Casey Williams Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title Branan Riley commented on FACT-1889 Re: Windows operating system facts should resolve correctly for Server 2019 FACT-1881 feels like pretty major surgery to me. I think we should consider how to implement it (in a backwards-compatible way) for puppet-agent 6.1 (facter 3.13?), but we'll probably want to stick with the hackier method for the 5.5 and 6.0 series Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title Enis Inan updated an issue Facter / FACT-1889 Windows operating system facts should resolve correctly for Server 2019 Change By: Enis Inan Team: Platform OS Sprint: Platform OS Kanban Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title
Enis Inan commented on FACT-1889
Re: Windows operating system facts should resolve correctly for Server 2019
Modifying https://github.com/puppetlabs/facter/blob/2ad48c341831ac261c9ef16e94f94e74735959c2/lib/src/facts/win... to do something like:
if consumerrel {
result.release = "10"
} elseif (buildno >= 17623) {
result.release = "2019"
} else {
result.release = "2016"
}
would work. I've (informally) tested this on our Windows Server 2016 and Windows Server 2019 machines. Note that 17623 is the lowest build number for the Windows Server 2019 series based on https://en.wikipedia.org/wiki/Windows_Server_2019. Also confirmed with John O'Connor that this is the correct approach for this ticket until we finish FACT-1881, whereby we could consider cleaning this up.
Add Comment
Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title Enis Inan updated an issue Facter / FACT-1889 Windows operating system facts should resolve correctly for Server 2019 Change By: Enis Inan Affects Version/s: FACT 3.11.4 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title Enis Inan updated an issue Facter / FACT-1889 Windows operating system facts should resolve correctly for Server 2019 Change By: Enis Inan Some assumptions were made in FACT-1492 about how Windows version numbers should resolve (currently codified [here|https://github.com/puppetlabs/facter/blob/2ad48c341831ac261c9ef16e94f94e74735959c2/lib/src/facts/windows/operating_system_resolver.cc#L103-L104]). Now that Windows 2019 server is out, we should update those assumptions to use the build number, which lets us distinguish between Windows 2016 and Windows 2019. We can get the build number from [RtlGetVersion|https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/content/wdm/nf-wdm-rtlgetversion], which we already do so [here|https://github.com/puppetlabs/facter/blob/3.11.x/lib/src/facts/windows/kernel_resolver.cc#L17-L42] Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet
Jira (FACT-1889) Windows operating system facts should resolve correctly for Server 2019
Title: Message Title Enis Inan created an issue Facter / FACT-1889 Windows operating system facts should resolve correctly for Server 2019 Issue Type: Bug Assignee: Unassigned Created: 2018/10/11 12:36 PM Priority: Normal Reporter: Enis Inan Some assumptions were made in FACT-1492 about how Windows version numbers should resolve (currently codified here). Now that Windows 2019 server is out, we should update those assumptions to use the build number, which lets us distinguish between Windows 2016 and Windows 2019. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
