Jira (FACT-1902) Facter should validate that external/custom/executable facts output proper UTF-8
Title: Message Title
Bogdan Irimie commented on FACT-1902
Re: Facter should validate that external/custom/executable facts output proper UTF-8
Josh Cooper yes, Facter 4 does the validation e.g. a custom facts with a invalid UTF-8 result
Facter.add(:my_custom_fact) do
setcode do
"\xc3\x28"
end
end
will give
[2021-01-27 11:42:10.579028 ] ERROR Facter - Fact resolution fact='my_custom_fact', resolution='' resolved to an invalid value: String "\xC3(" doesn't match the reported encoding UTF-8
and the value of the fact will not be reported along with the other facts. The validation is done for custom and external facts (executable facts are external facts as well). Facter 3 does not seam to validate the results. e.g. Same external facts and Facter 3 reports
my_custom_fact => �(
Jira (FACT-1902) Facter should validate that external/custom/executable facts output proper UTF-8
Title: Message Title Josh Cooper commented on FACT-1902 Re: Facter should validate that external/custom/executable facts output proper UTF-8 I believe Facter 4 does this https://github.com/puppetlabs/facter/blob/33586eca494cc05fd6f0afb1eea15f6f690ef594/lib/facter/custom_facts/util/normalization.rb#L59-L70. Maybe it is still an issue for facter 3.x? Thoughts Bogdan Irimie? Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.290197.1546471789000.124765.1611683580024%40Atlassian.JIRA.
Jira (FACT-1902) Facter should validate that external/custom/executable facts output proper UTF-8
Title: Message Title Josh Cooper updated an issue Facter / FACT-1902 Facter should validate that external/custom/executable facts output proper UTF-8 Change By: Josh Cooper Team: Platform OS Night's Watch Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.290197.1546471789000.124757.1611683340244%40Atlassian.JIRA.
Jira (FACT-1902) Facter should validate that external/custom/executable facts output proper UTF-8
Title: Message Title Charlie Sharpsteen commented on FACT-1902 Re: Facter should validate that external/custom/executable facts output proper UTF-8 This also came up today in community slack where a windows user couldn't get a catalog due some fact not producing UTF-8 data. Without this sort of checking in Facter, it is very difficult to determine which fact is the problem. Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.290197.1546471789000.108393.1594827720216%40Atlassian.JIRA.
Jira (FACT-1902) Facter should validate that external/custom/executable facts output proper UTF-8
Title: Message Title Charlie Sharpsteen commented on FACT-1902 Re: Facter should validate that external/custom/executable facts output proper UTF-8 We should also validate that fact output does not contain null characters in addition to being valid UTF-8. This is because Postgres rejects any strings that include nulls. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1902) Facter should validate that external/custom/executable facts output proper UTF-8
Title: Message Title Adam Bottchen updated an issue Facter / FACT-1902 Facter should validate that external/custom/executable facts output proper UTF-8 Change By: Adam Bottchen CS Priority: Reviewed Major Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1902) Facter should validate that external/custom/executable facts output proper UTF-8
Title: Message Title Adam Bottchen updated an issue Facter / FACT-1902 Facter should validate that external/custom/executable facts output proper UTF-8 Change By: Adam Bottchen Priority: Normal Major Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1902) Facter should validate that external/custom/executable facts output proper UTF-8
Title: Message Title Adam Bottchen updated an issue Facter / FACT-1902 Facter should validate that external/custom/executable facts output proper UTF-8 Change By: Adam Bottchen CS Priority: Needs Priority Reviewed Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1902) Facter should validate that external/custom/executable facts output proper UTF-8
Title: Message Title Scott McClellan updated an issue Facter / FACT-1902 Facter should validate that external/custom/executable facts output proper UTF-8 Change By: Scott McClellan Labels: custom-facts utf-8 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1902) Facter should validate that external/custom/executable facts output proper UTF-8
Title: Message Title Charlie Sharpsteen updated an issue Facter / FACT-1902 Facter should validate that external/custom/executable facts output proper UTF-8 Change By: Charlie Sharpsteen CS Priority: Needs Priority Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1902) Facter should validate that external/custom/executable facts output proper UTF-8
Title: Message Title Charlie Sharpsteen updated an issue Facter / FACT-1902 Facter should validate that external/custom/executable facts output proper UTF-8 Change By: Charlie Sharpsteen Modern versions of Puppet require that the data they serialize to JSON is proper UTF-8. When facts have an incorrect encoding, this currently does not raise an error until it is serialized, at which point it is far too late, and the error message is not helpful.Instead, Facter itself should raise an error about this, indicating the specific fact which returned bad data. This will provide better context fordebugging. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at
Jira (FACT-1902) Facter should validate that external/custom/executable facts output proper UTF-8
Title: Message Title Branan Riley created an issue Facter / FACT-1902 Facter should validate that external/custom/executable facts output proper UTF-8 Issue Type: Improvement Assignee: Unassigned Created: 2019/01/02 3:29 PM Priority: Normal Reporter: Branan Riley Modern versions of Puppet require that the data they serialize to JSON is proper UTF-8. When facts have an incorrect encoding, this currently does not raise an error until it is serialized, at which point it is far too late, and the error message is not helpful. Instead, Facter itself should raise an error about this, indicating the specific fact which returned bad data. This will provide better context for Add Comment This message was
