Jira (FACT-2887) retrieve_default_interface uses incorrect method and doesn't work when IPv6-only

2020-12-08 Thread Bogdan Irimie (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Bogdan Irimie updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2887  
 
 
  retrieve_default_interface uses incorrect method and doesn't work when IPv6-only   
 

  
 
 
 
 

 
Change By: 
 Bogdan Irimie  
 
 
Labels: 
 networking_resolver  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.379995.1607224967000.93200.1607417400038%40Atlassian.JIRA.


Jira (FACT-2887) retrieve_default_interface uses incorrect method and doesn't work when IPv6-only

2020-12-07 Thread Sebastian Miclea (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Sebastian Miclea assigned an issue to Sebastian Miclea  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2887  
 
 
  retrieve_default_interface uses incorrect method and doesn't work when IPv6-only   
 

  
 
 
 
 

 
Change By: 
 Sebastian Miclea  
 
 
Assignee: 
 Sebastian Miclea  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.379995.1607224967000.92198.1607339280027%40Atlassian.JIRA.


Jira (FACT-2887) retrieve_default_interface uses incorrect method and doesn't work when IPv6-only

2020-12-06 Thread Mihai Buzgau (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihai Buzgau updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2887  
 
 
  retrieve_default_interface uses incorrect method and doesn't work when IPv6-only   
 

  
 
 
 
 

 
Change By: 
 Mihai Buzgau  
 
 
Team: 
 Night's Watch  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.379995.1607224967000.92149.1607327580072%40Atlassian.JIRA.


Jira (FACT-2887) retrieve_default_interface uses incorrect method and doesn't work when IPv6-only

2020-12-06 Thread Mihai Buzgau (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihai Buzgau updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2887  
 
 
  retrieve_default_interface uses incorrect method and doesn't work when IPv6-only   
 

  
 
 
 
 

 
Change By: 
 Mihai Buzgau  
 
 
Sub-team: 
 ghost  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.379995.1607224967000.92150.1607327580116%40Atlassian.JIRA.


Jira (FACT-2887) retrieve_default_interface uses incorrect method and doesn't work when IPv6-only

2020-12-06 Thread Mihai Buzgau (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihai Buzgau updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2887  
 
 
  retrieve_default_interface uses incorrect method and doesn't work when IPv6-only   
 

  
 
 
 
 

 
Change By: 
 Mihai Buzgau  
 
 
Sprint: 
 ghost-9.12  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.379995.1607224967000.92148.1607327520057%40Atlassian.JIRA.


Jira (FACT-2887) retrieve_default_interface uses incorrect method and doesn't work when IPv6-only

2020-12-05 Thread Kenyon Ralph (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Kenyon Ralph updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2887  
 
 
  retrieve_default_interface uses incorrect method and doesn't work when IPv6-only   
 

  
 
 
 
 

 
Change By: 
 Kenyon Ralph  
 

  
 
 
 
 

 
 Here: https://github.com/puppetlabs/facter/blob/2c87e9e700dc1f75bda71f3a7805449f37fa1945/lib/facter/resolvers/networking_linux_resolver.rb#L144{{ip route get 1}} is not the right way to get the default route egress interface. That's the equivalent of {{ip route get 1.0.0.0}}. There is nothing special about the 1.0.0.0 address, so it should not be treated like a way to find out the default route egress interface.A better way to get the default route egress interface would be to use the output of {{ip route show default}}.  This is how it's done with the old tools here: https://github.com/puppetlabs/facter/blob/23a6be6494c0729eaf439e173020bb3be88b75c6/lib/facter/resolvers/networking_resolver.rb#L23 Also, this method currently neglects to take IPv6 into consideration. There should be a retrieve_default_interface_v6 method that looks at {{ip -6 route show default}} and populates a {{networking.primary6}} fact.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

 

Jira (FACT-2887) retrieve_default_interface uses incorrect method and doesn't work when IPv6-only

2020-12-05 Thread Kenyon Ralph (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Kenyon Ralph created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2887  
 
 
  retrieve_default_interface uses incorrect method and doesn't work when IPv6-only   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2020/12/05 7:22 PM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Kenyon Ralph  
 

  
 
 
 
 

 
 Here: https://github.com/puppetlabs/facter/blob/2c87e9e700dc1f75bda71f3a7805449f37fa1945/lib/facter/resolvers/networking_linux_resolver.rb#L144 ip route get 1 is not the right way to get the default route egress interface. That's the equivalent of ip route get 1.0.0.0. There is nothing special about the 1.0.0.0 address, so it should not be treated like a way to find out the default route egress interface. A better way to get the default route egress interface would be to use the output of ip route show default. Also, this method currently neglects to take IPv6 into consideration. There should be a retrieve_default_interface_v6 method that looks at ip -6 route show default and populates a networking.primary6 fact.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment