Jira (FACT-3004) Do not auto promote dotted facts to structured

2021-04-15 Thread Gheorghe Popescu (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gheorghe Popescu updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3004  
 
 
  Do not auto promote dotted facts to structured   
 

  
 
 
 
 

 
Change By: 
 Gheorghe Popescu  
 
 
Release Notes Summary: 
 Changes the way Facter 4 treats dots in fact names, reverting to the same behaviour as Facter 3. This means that by default, any dot in custom or external fact names will be considered as part of the fact name and not a delimiter for structured facts.This also adds a global setting ` autopromote force - dotted dot - facts resolution ` which can be set to enable the conversion of dotted facts to structured.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393702.1617359453000.10003.1618467840032%40Atlassian.JIRA.


Jira (FACT-3004) Do not auto promote dotted facts to structured

2021-04-13 Thread Claire Cadman (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Claire Cadman updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3004  
 
 
  Do not auto promote dotted facts to structured   
 

  
 
 
 
 

 
Change By: 
 Claire Cadman  
 
 
Labels: 
 doc_reviewed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393702.1617359453000.7437.1618319940624%40Atlassian.JIRA.


Jira (FACT-3004) Do not auto promote dotted facts to structured

2021-04-06 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3004  
 
 
  Do not auto promote dotted facts to structured   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Flagged: 
 Impediment  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393702.1617359453000.2282.1617731340034%40Atlassian.JIRA.


Jira (FACT-3004) Do not auto promote dotted facts to structured

2021-04-06 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  FACT-3004  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Do not auto promote dotted facts to structured   
 

  
 
 
 
 

 
 Holding off on resolving this as there is some discussion around the name of the facter setting  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393702.1617359453000.2202.1617729600133%40Atlassian.JIRA.


Jira (FACT-3004) Do not auto promote dotted facts to structured

2021-04-06 Thread Gheorghe Popescu (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gheorghe Popescu updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3004  
 
 
  Do not auto promote dotted facts to structured   
 

  
 
 
 
 

 
Change By: 
 Gheorghe Popescu  
 
 
Release Notes Summary: 
 Changes the way Facter 4 treats dots in fact names, reverting to the same behaviour as Facter 3. This means that by default, any dot in custom or external fact names will be considered as part of the fact name and not a delimiter for structured facts.This also adds a global setting `autopromote-dotted-facts` which can be set to enable the conversion of dotted facts to structured.   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393702.1617359453000.1725.1617710280042%40Atlassian.JIRA.


Jira (FACT-3004) Do not auto promote dotted facts to structured

2021-04-06 Thread Gheorghe Popescu (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gheorghe Popescu updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3004  
 
 
  Do not auto promote dotted facts to structured   
 

  
 
 
 
 

 
Change By: 
 Gheorghe Popescu  
 
 
Release Notes: 
 Bug Fix  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393702.1617359453000.1726.1617710280101%40Atlassian.JIRA.


Jira (FACT-3004) Do not auto promote dotted facts to structured

2021-04-06 Thread Gheorghe Popescu (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gheorghe Popescu updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3004  
 
 
  Do not auto promote dotted facts to structured   
 

  
 
 
 
 

 
Change By: 
 Gheorghe Popescu  
 

  
 
 
 
 

 
 Dotted Facter 4 (up to 4.0.52) provides a way to create structured  facts  from multiple fact definitions. However, the feature is not compatible with other parts of the Puppet ecosystem and can cause facts to be named differently in Facter 4 than in Facter 2/3.In order to avoid changing Puppet manifests, hiera lookups, PE classification rules, dotted facts  should not be automatically promoted to structured facts. This functionality can Treating those facts as structured will still  be  enabled trough  possible by  usging  a global facter setting which by default is set to false.Eg:default behavior{code:ruby}# custom factFacter.add('a.b.c') do  setcode { "d" }end# external facta.b.c=dis represented as { "a.b.c": "d" }{code}setting true{code:ruby}# custom factFacter.add('a.b.c') do  setcode { "d" }end# external facta.b.c=dis represented as {  "a": {"b": {  "c": "d"}  }{code}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 
 

Jira (FACT-3004) Do not auto promote dotted facts to structured

2021-04-06 Thread Gheorghe Popescu (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gheorghe Popescu updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3004  
 
 
  Do not auto promote dotted facts to structured   
 

  
 
 
 
 

 
Change By: 
 Gheorghe Popescu  
 

  
 
 
 
 

 
 Facter 4 (up to 4.0.52) provides a way to create structured facts from multiple fact definitions. However, the feature is not compatible with other parts of the Puppet ecosystem and can cause facts to be named differently in Facter 4 than in Facter 2/3.In order to avoid changing Puppet manifests, hiera lookups, PE classification rules, dotted  custom and external  facts should not be automatically promoted to structured facts.Treating those facts as structured will still be possible by  usging a global facter setting which by default is set to false.Eg:default behavior{code:ruby}# custom factFacter.add('a.b.c') do  setcode { "d" }end# external facta.b.c=dis represented as { "a.b.c": "d" }{code}setting true{code:ruby}# custom factFacter.add('a.b.c') do  setcode { "d" }end# external facta.b.c=dis represented as {  "a": {"b": {  "c": "d"}  }{code}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

   

Jira (FACT-3004) Do not auto promote dotted facts to structured

2021-04-05 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  FACT-3004  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Do not auto promote dotted facts to structured   
 

  
 
 
 
 

 
 This passed puppet-agent#main CI, but puppet-agent#6.x is still pinned to facter 4.0.50, which will be handled in PA-3693.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393702.1617359453000.1202.1617652020255%40Atlassian.JIRA.


Jira (FACT-3004) Do not auto promote dotted facts to structured

2021-04-05 Thread Gheorghe Popescu (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gheorghe Popescu updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3004  
 
 
  Do not auto promote dotted facts to structured   
 

  
 
 
 
 

 
Change By: 
 Gheorghe Popescu  
 
 
Story Points: 
 3  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393702.1617359453000.728.1617619200048%40Atlassian.JIRA.


Jira (FACT-3004) Do not auto promote dotted facts to structured

2021-04-05 Thread Gheorghe Popescu (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gheorghe Popescu updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3004  
 
 
  Do not auto promote dotted facts to structured   
 

  
 
 
 
 

 
Change By: 
 Gheorghe Popescu  
 
 
Sprint: 
 NW - 2021-04-14  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393702.1617359453000.729.1617619200069%40Atlassian.JIRA.


Jira (FACT-3004) Do not auto promote dotted facts to structured

2021-04-02 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3004  
 
 
  Do not auto promote dotted facts to structured   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Fix Version/s: 
 FACT 4.0.53  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393702.1617359453000.193.1617381480165%40Atlassian.JIRA.


Jira (FACT-3004) Do not auto promote dotted facts to structured

2021-04-02 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper assigned an issue to Gheorghe Popescu  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3004  
 
 
  Do not auto promote dotted facts to structured   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Assignee: 
 Gheorghe Popescu  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393702.1617359453000.192.1617381480120%40Atlassian.JIRA.


Jira (FACT-3004) Do not auto promote dotted facts to structured

2021-04-02 Thread Gheorghe Popescu (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gheorghe Popescu updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3004  
 
 
  Do not auto promote dotted facts to structured   
 

  
 
 
 
 

 
Change By: 
 Gheorghe Popescu  
 

  
 
 
 
 

 
 Dotted facts should not be automatically promoted to structured facts.This functionality can be enabled trough a global facter setting which by default is set to false.Eg:default behavior{code:ruby} # custom fact Facter.add('a.b.c') do  setcode { "d" }end # external facta.b.c=d is represented as { "a.b.c": "d" }{code}setting true{code:ruby} # custom fact Facter.add('a.b.c') do  setcode { "d" }end # external facta.b.c=d is represented as {  "a": {"b": {  "c": "d"}  }{code}  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit 

Jira (FACT-3004) Do not auto promote dotted facts to structured

2021-04-02 Thread Gheorghe Popescu (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gheorghe Popescu created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-3004  
 
 
  Do not auto promote dotted facts to structured   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2021/04/02 3:30 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Gheorghe Popescu  
 

  
 
 
 
 

 
 Dotted facts should not be automatically promoted to structured facts. This functionality can be enabled trough a global facter setting which by default is set to false. Eg: default behavior  
 
 
 
 
 Facter.add('a.b.c') do  
 
 
   setcode { "d" }  
 
 
 end  
 
 
    
 
 
 is represented as { "a.b.c": "d" }
  
 
 
 
  setting true