Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title Kurt Wall updated an issue Puppet / PUP-1106 Resource refreshes don't check for failed dependencies Change By: Kurt Wall QA Contact: NarmadhaPerumal KurtWall Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title Kurt Wall assigned an issue to Kurt Wall Puppet / PUP-1106 Resource refreshes don't check for failed dependencies Change By: Kurt Wall Assignee: KurtWall Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title Kurt Wall updated an issue Puppet / PUP-1106 Resource refreshes don't check for failed dependencies Change By: Kurt Wall QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title Kurt Wall updated an issue Puppet / PUP-1106 Resource refreshes don't check for failed dependencies Change By: Kurt Wall Assignee: KurtWall Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title Michael Smith assigned an issue to Michael Smith Puppet / PUP-1106 Resource refreshes don't check for failed dependencies Change By: Michael Smith Assignee: MichaelSmith Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title Michael Smith commented on PUP-1106 Re: Resource refreshes don't check for failed dependencies Merged with fixed acceptance test: https://github.com/puppetlabs/puppet/commit/45c6fa0b05870e95b99cf714c17ea703534810e6 Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title Adrien Thebo commented on PUP-1106 Re: Resource refreshes don't check for failed dependencies This change broke an acceptance test; I've reverted it for now and will make another pass at it shortly. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title Michael Smith assigned an issue to Michael Smith Puppet / PUP-1106 Resource refreshes don't check for failed dependencies Change By: Michael Smith Assignee: MichaelSmith Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title Michael Smith commented on PUP-1106 Re: Resource refreshes don't check for failed dependencies Merged in https://github.com/puppetlabs/puppet/commit/ec03dee5ac403d0c110cb8c65103c0f4a2ee8391 FR should spend more time on possible side-effects and test coverage. I've done some spot testing. PUP-2280 should cover other cases mentioned in the mailing list discussion. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-1106 Resource refreshes don't check for failed dependencies Change By: Kylo Ginsberg Sprint: Platform2014-09-17,PlatformClient2014-10-29,PlatformClient2014-11-12 ,PlatformClient2014-11-26 Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title Steve Barlow updated an issue Puppet / PUP-1106 Resource refreshes don't check for failed dependencies Change By: Steve Barlow Sprint: Platform2014-09-17,PlatformClient2014-10-29 ,PlatformClient2014-11-12 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title
Adrien Thebo commented on an issue
Re: Resource refreshes don't check for failed dependencies
Andy Parker are you still reviewing this issue or can we unassign it so that someone else may review it?
Add Comment
Puppet / PUP-1106
Resource refreshes don't check for failed dependencies
Given this manifest: {code} exec{moo: command = /usr/bin/cowsay 'fail :(', refreshonly = true, logoutput = true, require = Exec[false], subscribe = [ File[/tmp/1], File[/tmp/2], File[/tmp/3] ] } file{/tmp/1: content = 1} file{/tmp/2: content = 2} file{/tmp/3: content = 3} exec{false: command...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title Andy Parker assigned an issue to Unassigned Taking myself off of it. The consensus on the mailing list was that the approach was correct. What I still needed to check for was: code clarity, unintended side effects, test coverage, etc. Puppet / PUP-1106 Resource refreshes don't check for failed dependencies Change By: Andy Parker Assignee: AndyParker Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title Adrien Thebo updated an issue Puppet / PUP-1106 Resource refreshes don't check for failed dependencies Change By: Adrien Thebo Sprint: Platform2014-09-17 ,PlatformClient2014-10-29 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title
Andy Parker commented on an issue
Re: Resource refreshes don't check for failed dependencies
I think the consensus on the mailing lists was that this is the right change. It doesn't solve all of the problems brought up in the comments on the original Redmine issue, but does solve some of them.
Add Comment
Puppet / PUP-1106
Resource refreshes don't check for failed dependencies
Given this manifest: {code} exec{moo: command = /usr/bin/cowsay 'fail :(', refreshonly = true, logoutput = true, require = Exec[false], subscribe = [ File[/tmp/1], File[/tmp/2], File[/tmp/3] ] } file{/tmp/1: content = 1} file{/tmp/2: content = 2} file{/tmp/3: content = 3} exec{false: command...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit
Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title
Andy Parker commented on an issue
Re: Resource refreshes don't check for failed dependencies
Because of how fundamental and sensitive this is, and because of the amount of discussion that has happened, I've asked on puppet-dev for help in evaluating if this is the right change.
Add Comment
Puppet / PUP-1106
Resource refreshes don't check for failed dependencies
Given this manifest: {code} exec{moo: command = /usr/bin/cowsay 'fail :(', refreshonly = true, logoutput = true, require = Exec[false], subscribe = [ File[/tmp/1], File[/tmp/2], File[/tmp/3] ] } file{/tmp/1: content = 1} file{/tmp/2: content = 2} file{/tmp/3: content = 3} exec{false: command...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title Andy Parker assigned an issue to Andy Parker Puppet / PUP-1106 Resource refreshes don't check for failed dependencies Change By: Andy Parker Assignee: AndyParker Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title Adrien Thebo updated an issue Puppet / PUP-1106 Resource refreshes don't check for failed dependencies Change By: Adrien Thebo Story Points: 2 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title Adrien Thebo updated an issue Puppet / PUP-1106 Resource refreshes don't check for failed dependencies Change By: Adrien Thebo Sprint: 2014-09-17 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title
Felix Frank commented on an issue
Re: Resource refreshes don't check for failed dependencies
That looks quite elegant, Adrien Thebo.
I'm very much tempted to venture back into Redmine and do some reading, because I vaguely remember some endless discussion going on, and I wonder whether we're missing something important now which has been brought up back in the day.
Add Comment
Puppet / PUP-1106
Resource refreshes don't check for failed dependencies
Given this manifest: {code} exec{moo: command = /usr/bin/cowsay 'fail :(', refreshonly = true, logoutput = true, require = Exec[false], subscribe = [ File[/tmp/1], File[/tmp/2], File[/tmp/3] ] } file{/tmp/1: content = 1} file{/tmp/2: content = 2} file{/tmp/3: content = 3} exec{false: command...
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to
Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title
Adrien Thebo commented on an issue
Re: Resource refreshes don't check for failed dependencies
The same bug that triggers this can cause unscheduled resources to be refreshed as well:
schedule { AM:
period = daily,
range = 0 - 1,
}
exec{unscheduled:
command = /usr/bin/cowsay 'fail :(',
logoutput = true,
subscribe = Exec[true],
schedule = AM,
}
exec{true: command = /bin/true}
└ bexec puppet apply test-unscheduled.pp --no-ignoreschedules
Notice: Compiled catalog for grey.somethingsinistral.net in environment production in 0.03 seconds
Notice: /Stage[main]/Main/Exec[true]/returns: executed successfully
Notice: /Stage[main]/Main/Exec[unscheduled]/returns: _
Notice: /Stage[main]/Main/Exec[unscheduled]/returns: fail :(
Notice: /Stage[main]/Main/Exec[unscheduled]/returns: -
Notice: /Stage[main]/Main/Exec[unscheduled]/returns: \ ^__^
Notice: /Stage[main]/Main/Exec[unscheduled]/returns: \ (oo)\___
Notice: /Stage[main]/Main/Exec[unscheduled]/returns: (__)\ )\/\
Notice: /Stage[main]/Main/Exec[unscheduled]/returns: ||w |
Notice: /Stage[main]/Main/Exec[unscheduled]/returns: || ||
Notice: /Stage[main]/Main/Exec[unscheduled]: Triggered 'refresh' from 1 events
Notice: Finished catalog run in 0.20 seconds
Add Comment
Puppet / PUP-1106
Resource refreshes don't check for failed dependencies
Given this manifest: {code} exec{moo: command = /usr/bin/cowsay 'fail :(', refreshonly = true, logoutput =
Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-1106 Resource refreshes don't check for failed dependencies Change By: Kylo Ginsberg Fix Version/s: 4.0.0 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title
Felix Frank updated an issue
Puppet / PUP-1106
Resource refreshes don't check for failed dependencies
Change By:
Felix Frank
Giventhismanifest:{code}exec{moo:command=/usr/bin/cowsay'fail:(',refreshonly=true,logoutput=true,require=Exec[false],subscribe=[File[/tmp/1],File[/tmp/2],File[/tmp/3]]}file{/tmp/1:content=1}file{/tmp/2:content=2}file{/tmp/3:content=3}exec{false:command=/bin/false}{code}TheExec\[moo]shouldn'trunitrequiresExec\[false]whichwillalwaysfail,butitgetsnotifiedbythefileresourcesviaitssubscribesandthenrunsanywayregardlessofthestateoftherequiredresources.Inversion2.6.5thismightberelatedto#5670butIamfilinganewbugsinceIthinkitsnotasthisbugisalsopresentin0.25.xwhiletheonein#5670is2.6.xonly{code}notice://File[/tmp/1]/content:definedcontentas'unknownchecksum'notice://File[/tmp/3]/content:definedcontentas'unknownchecksum'err://Exec[false]/returns:changefromnotrunto0failed:/bin/falsereturned1insteadofoneof[0]at/home/rip/test.pp:12notice://File[/tmp/2]/content:definedcontentas'unknownchecksum'notice://Exec[moo]:Dependencyexec[/bin/false]has1failureswarning://Exec[moo]:Skippingbecauseoffaileddependenciesnotice://Exec[moo]:Triggering'refresh'from3dependenciesnotice://Exec[moo]/returns:_notice://Exec[moo]/returns: lt; fail:( gt; notice://Exec[moo]/returns:-notice://Exec[moo]/returns:\^__^notice://Exec[moo]/returns:\(oo)\___notice://Exec[moo]/returns:(__)\)\/\notice://Exec[moo]/returns:||w|notice://Exec[moo]/returns:{code}
Add Comment
This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
--
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group
Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title
Charlie Sharpsteen updated an issue
Puppet / PUP-1106
Resource refreshes don't check for failed dependencies
This is one of the more long-standing issues with Puppet and there is a lot of history that lead to things being the way they are. The way things currently work can be summarized as:
When responding to refresh events, resources do not check the failure state of their dependencies. This is because the skip? check (which checks for failed dependencies, among other things) only affects resource syncing. Resource refreshes occur outside of of the block guarded by skip?.
The following examples demonstrate that the receipt of an event is the only thing that controls resource refreshes:
exec{'/bin/false':}
exec{'/bin/true':}
exec{'with_failed_requirement':
command = '/bin/echo This should not happen as the required /bin/false failed.',
logoutput = true,
refreshonly = true,
require = Exec['/bin/false'],
subscribe = Exec['/bin/true'],
}
# This should also fail as subscribe implies require.
exec{'with_failed_subscription':
command = '/bin/echo This should not happen as the subscribed /bin/false failed.',
logoutput = true,
refreshonly = true,
subscribe = [ Exec['/bin/true'], Exec['/bin/false'] ],
}
Linking to PUP-2242, hopefully we can bring some closure to this in 4.x.
Change By:
Charlie Sharpsteen
Summary:
RequireandSubscribeonthesamerefreshonlyexecdoesntwork Resourcerefreshesdon'tcheckforfaileddependencies
Add Comment
Jira (PUP-1106) Resource refreshes don't check for failed dependencies
Title: Message Title Charlie Sharpsteen updated an issue Puppet / PUP-1106 Resource refreshes don't check for failed dependencies Change By: Charlie Sharpsteen Assignee: CharlieSharpsteen Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
