Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-07-07 Thread Josh Cooper (JIRA)
Title: Message Title










 

 Josh Cooper commented on an issue


















  Re: Remove win32console gem in ruby 2.0 on windows 










Verified:
x64

Color and unicode box characters correctly drawn:


C:\work\puppet [master +11 ~0 -0 !] bundle exec puppet module list
DL is deprecated, please use Fiddle
DL is deprecated, please use Fiddle
C:/ProgramData/PuppetLabs/puppet/etc/modules
├── dprince-qpid (v1.0.2)
├── duritong-sysctl (v0.0.4)



Color correctly displayed for debug levels:


C:\work\puppet [master] bundle exec puppet resource service --debug
DL is deprecated, please use Fiddle
DL is deprecated, please use Fiddle
Debug: Runtime environment: puppet_version=3.6.2, ruby_version=2.0.0, run_mode=user, default_encoding=IBM437
Debug: Puppet::Type::Service::ProviderDaemontools: file /usr/bin/svc does not exist



and win32console is not a gem dependency:


C:\work\puppet [master +11 ~0 -0 !] bundle exec gem list | grep win32console
DL is deprecated, please use Fiddle



x86

Color and unicode box characters drawn correctly:


C:\work\puppet [master +11 ~0 -0 !] bundle exec puppet module list
C:/ProgramData/PuppetLabs/puppet/etc/modules
├── dprince-qpid (v1.0.2)
├── duritong-sysctl (v0.0.4)



Debug log levels are colorized:


C:\work\puppet [master] bundle exec puppet agent --debug
Debug: Failed to load library 'syslog' for feature 'syslog'
Debug: Failed to load library 'selinux' for feature 'selinux'



And win32console is a gem dependency:


C:\work\puppet [master] bundle exec gem list | grep win32console
win32console (1.3.2 x86-mingw32)















   


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-07-03 Thread Ethan Brown (JIRA)
Title: Message Title










 

 Ethan Brown commented on an issue


















  Re: Remove win32console gem in ruby 2.0 on windows 










Josh Cooper good idea, but looks like we might need to still do a workaround of some sort. It's pry that drags it in, and I don't think we want a spurious warning when debugging tools are installed.



C:\source\puppetdel gemfile.lock






C:\source\puppettype gemfile.lock
The system cannot find the file specified.






C:\source\puppetbundle install --path .bundle/gems
DL is deprecated, please use Fiddle
Fetching gem metadata from https://rubygems.org/.
Fetching additional metadata from https://rubygems.org/..
Resolving dependencies...
Using rake 10.1.1
Using i18n 0.6.9
Using multi_json 1.10.1
Using builder 3.0.4
Using arel 3.0.3
Using tzinfo 0.3.39
Using debug_inspector 0.0.2
Using columnize 0.8.9
Using debugger-linecache 1.2.0
Using coderay 1.1.0
Using mime-types 1.25.1
Using diff-lcs 1.1.3
Using ffi 1.9.3
Using json_pure 1.8.1
Using metaclass 0.0.4
Using method_source 0.8.2
Using minitar 0.5.4
Using msgpack 0.5.8
Using net-ssh 2.9.1
Using slop 3.5.0
Using win32console 1.3.2
Using puppet-lint 0.3.2
Using rspec-core 2.11.1
Using rspec-mocks 2.11.3
Using rack 1.5.2
Using rgen 0.6.5
Using ruby-prof 0.15.1
Using sqlite3 1.3.9
Using stomp 1.3.2
Using structured_warnings 0.1.4
Using bundler 1.6.3
Using activesupport 3.2.19
Using binding_of_caller 0.7.2
Using byebug 2.7.0
Using rest-client 1.6.7
Using rspec-expectations 2.11.3
Using win32-dir 0.4.9
Using win32-security 0.2.5
Using win32-eventlog 0.6.1
Using win32-process 0.7.4
Using win32-service 0.8.5
Using hiera 1.3.4
Using mocha 0.10.5
Using pry 0.10.0
Using win32-taskscheduler 0.3.0
Using activemodel 3.2.19
Using couchrest 1.2.0
Using rspec 2.11.0
Using facter 2.1.0
Using pry-byebug 1.3.3
Using pry-stack_explorer 0.4.9.1
Using activerecord 3.2.19
Using rspec-puppet 1.0.1
Using yarjuf 1.0.5
Using puppetlabs_spec_helper 0.6.0
Using puppet 3.6.2 from source at C:/source/puppet
Your bundle is complete!
It was installed into ./.bundle/gems






C:\source\puppettype gemfile.lock
PATH
  remote: .
  specs:
puppet (3.6.2)
  facter (= 1.7,  3)
  hiera (~ 1.0)

GEM
  remote: https://rubygems.org/
  specs:
activemodel (3.2.19)
  activesupport (= 3.2.19)
  builder (~ 3.0.0)
activerecord (3.2.19)
  activemodel (= 3.2.19)
  activesupport (= 3.2.19)
  arel (~ 3.0.2)
  tzinfo (~ 0.3.29)
activesupport (3.2.19)
  i18n (~ 0.6, = 0.6.4)
  multi_json (~ 1.0)
arel (3.0.3)
binding_of_caller (0.7.2)
  debug_inspector (= 0.0.1)
builder (3.0.4)
byebug (2.7.0)
  columnize (~ 0.3)
  debugger-linecache (~ 1.2)
coderay (1.1.0)
columnize (0.8.9)
couchrest (1.2.0)
  mime-types (~ 1.15)
  multi_json (~ 1.0)
  rest-client (~ 1.6.1)
debug_inspector (0.0.2)
debugger-linecache (1.2.0)
diff-lcs (1.1.3)
facter (2.1.0-x64-mingw32)
  ffi (~ 1.9.3)
  win32-dir (~ 0.4.8)
  win32-security (~ 0.2.5)
ffi (1.9.3-x64-mingw32)
hiera (1.3.4)
  json_pure
i18n (0.6.9)

Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-07-03 Thread Rob Reynolds (JIRA)
Title: Message Title










 

 Rob Reynolds assigned an issue to Rob Reynolds


















 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 










Change By:

 Rob Reynolds




Assignee:

 RobReynolds












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-07-03 Thread Rob Reynolds (JIRA)
Title: Message Title










 

 Rob Reynolds commented on an issue


















  Re: Remove win32console gem in ruby 2.0 on windows 










I'd say it might be more bundler that is pulling it in.












   

 Add Comment

























 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 







 Ruby 2.0 on windows supports ANSI escape sequences, so the win32console gem is unnecessary. Also, ruby 2.0 likely support unicode character output correctly (such as the unicode box characters used in module tool output), so the windows-specific code in `lib/puppet/util/colors.rb` to force wide character output can be removed.   See https://github.com/l...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-07-03 Thread Josh Cooper (JIRA)
Title: Message Title










 

 Josh Cooper assigned an issue to Josh Cooper


















 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 










Change By:

 Josh Cooper




Assignee:

 JoshCooper












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-07-03 Thread Josh Cooper (JIRA)
Title: Message Title










 

 Josh Cooper commented on an issue


















  Re: Remove win32console gem in ruby 2.0 on windows 










Merged to master in 6b5032db












   

 Add Comment

























 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 







 Ruby 2.0 on windows supports ANSI escape sequences, so the win32console gem is unnecessary. Also, ruby 2.0 likely support unicode character output correctly (such as the unicode box characters used in module tool output), so the windows-specific code in `lib/puppet/util/colors.rb` to force wide character output can be removed.   See https://github.com/l...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-07-03 Thread Josh Cooper (JIRA)
Title: Message Title










 

 Josh Cooper commented on an issue


















  Re: Remove win32console gem in ruby 2.0 on windows 










This failed CI:


failed Puppet::Util::Colors on Windows in Ruby 1.x should wrap $stdout with Puppet::Util::Colors::WideIO
expected #IO:STDOUT to be an instance of Puppet::Util::Colors::WideIO
./spec/unit/util/colors_spec.rb:76:in `block (3 levels) in top (required)'



I think (but haven't been able to reproduce locally) that this fails because the jenkins agent redirects $stdout and $stderr to a socket (or possibly a file).












   

 Add Comment

























 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 







 Ruby 2.0 on windows supports ANSI escape sequences, so the win32console gem is unnecessary. Also, ruby 2.0 likely support unicode character output correctly (such as the unicode box characters used in module tool output), so the windows-specific code in `lib/puppet/util/colors.rb` to force wide character output can be removed.   See https://github.com/l...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 



Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-07-03 Thread Josh Cooper (JIRA)
Title: Message Title










 

 Josh Cooper assigned an issue to Josh Cooper


















 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 










Change By:

 Josh Cooper




Assignee:

 JoshCooper












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-07-03 Thread Josh Cooper (JIRA)
Title: Message Title










 

 Josh Cooper commented on an issue


















  Re: Remove win32console gem in ruby 2.0 on windows 










Merged test fix in 250492d












   

 Add Comment

























 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 







 Ruby 2.0 on windows supports ANSI escape sequences, so the win32console gem is unnecessary. Also, ruby 2.0 likely support unicode character output correctly (such as the unicode box characters used in module tool output), so the windows-specific code in `lib/puppet/util/colors.rb` to force wide character output can be removed.   See https://github.com/l...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-07-03 Thread Rob Reynolds (JIRA)
Title: Message Title










 

 Rob Reynolds commented on an issue


















  Re: Remove win32console gem in ruby 2.0 on windows 










I had the defined tests in there and pulled them out b/c I saw them as unnecessary once testing the stdout/stderr. And it came back around that they were necessary. 
On Thursday, July 3, 2014, Josh Cooper (JIRA) issue-upda...@puppetlabs.com
–  Rob Reynolds Developer, Puppet Labs
*Join us at PuppetConf 2014 http://www.puppetconf.com/, September 20-24 in San Francisco* *Register by July 31st to take advantage of the Early Bird discount https://puppetconf2014.eventbrite.com/?discount=EarlyBird *--save $249!












   

 Add Comment

























 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 







 Ruby 2.0 on windows supports ANSI escape sequences, so the win32console gem is unnecessary. Also, ruby 2.0 likely support unicode character output correctly (such as the unicode box characters used in module tool output), so the windows-specific code in `lib/puppet/util/colors.rb` to force wide character output can be removed.   See https://github.com/l...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 






Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-07-02 Thread Ethan Brown (JIRA)
Title: Message Title










 

 Ethan Brown commented on an issue


















  Re: Remove win32console gem in ruby 2.0 on windows 










I'm getting a failure in Ruby 2 when gems are installed for both Ruby 1.9.3 and Ruby 2.0.0.
The gems can be happily installed in a local .bundle/gems folder side-by-side for different Ruby runtime environments... so I don't know that the current test is correct / sufficient.



Failures:

  1) Puppet::Util::Colors on Windows in Ruby 2.x should not load win32console
 Failure/Error: Gem.loaded_specs[win32console].should be_nil
   expected: nil
got: #Gem::Specification:0x1f2a304 win32console-1.3.2
 # ./spec/unit/util/colors_spec.rb:78:in `block (3 levels) in top (required)'



To repro:


In same local source tree, run bundle install --path .bundle/gems


Notice that there is a .bundle/gems/ruby/1.9.1 directory and a .bundle/gems/ruby/2.0.0 directory


bundle exec rspec spec works fine in each separate environment after installing gems














   

 Add Comment

























 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 







 Ruby 2.0 on windows supports ANSI escape sequences, so the win32console gem is unnecessary. Also, ruby 2.0 likely support 

Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-07-02 Thread Josh Cooper (JIRA)
Title: Message Title










 

 Josh Cooper commented on an issue


















  Re: Remove win32console gem in ruby 2.0 on windows 










Ethan Brown I suspect that Gemfile.lock is causing you issues.












   

 Add Comment

























 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 







 Ruby 2.0 on windows supports ANSI escape sequences, so the win32console gem is unnecessary. Also, ruby 2.0 likely support unicode character output correctly (such as the unicode box characters used in module tool output), so the windows-specific code in `lib/puppet/util/colors.rb` to force wide character output can be removed.   See https://github.com/l...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-07-01 Thread Rob Reynolds (JIRA)
Title: Message Title










 

 Rob Reynolds assigned an issue to Rob Reynolds


















 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 










Change By:

 Rob Reynolds




Assignee:

 RobReynolds












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-07-01 Thread Rob Reynolds (JIRA)
Title: Message Title










 

 Rob Reynolds commented on an issue


















  Re: Remove win32console gem in ruby 2.0 on windows 










Fixing some of the other specs and sending a new PR.












   

 Add Comment

























 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 







 Ruby 2.0 on windows supports ANSI escape sequences, so the win32console gem is unnecessary. Also, ruby 2.0 likely support unicode character output correctly (such as the unicode box characters used in module tool output), so the windows-specific code in `lib/puppet/util/colors.rb` to force wide character output can be removed.   See https://github.com/l...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-07-01 Thread Rob Reynolds (JIRA)
Title: Message Title










 

 Rob Reynolds commented on an issue


















  Re: Remove win32console gem in ruby 2.0 on windows 










Actually doesn't appear that this is necessary.












   

 Add Comment

























 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 







 Ruby 2.0 on windows supports ANSI escape sequences, so the win32console gem is unnecessary. Also, ruby 2.0 likely support unicode character output correctly (such as the unicode box characters used in module tool output), so the windows-specific code in `lib/puppet/util/colors.rb` to force wide character output can be removed.   See https://github.com/l...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-07-01 Thread Josh Cooper (JIRA)
Title: Message Title










 

 Josh Cooper assigned an issue to Josh Cooper


















 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 










Change By:

 Josh Cooper




Assignee:

 JoshCooper












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-07-01 Thread Josh Cooper (JIRA)
Title: Message Title










 

 Josh Cooper commented on an issue


















  Re: Remove win32console gem in ruby 2.0 on windows 










Verified ruby 1.9.3 x86:
Specs pass, color correctlyshown when running bundle exec rake ci:spec, and when installing a module (the version component is colorized):


C:\work\puppetbundle exec puppet module install puppetlabs/registry
...
C:/ProgramData/PuppetLabs/puppet/etc/modules
└─┬ puppetlabs-registry (v1.0.0)
  └── puppetlabs-stdlib (v4.2.1)



Verified ruby 2.0.0 x64
Color specific specs pass (not all specs pass yet), color correctly shown when running specs, and when listing modules:


C:\work\puppet bundle exec puppet module list
DL is deprecated, please use Fiddle
DL is deprecated, please use Fiddle
C:/ProgramData/PuppetLabs/puppet/etc/modules
├── dprince-qpid (v1.0.2)
├── duritong-sysctl (v0.0.4)
├── garethr-erlang (v0.3.0)
├── puppetlabs-apache (v1.0.1)
...















   

 Add Comment

























 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 







 Ruby 2.0 on windows supports ANSI escape sequences, so the win32console gem is unnecessary. Also, ruby 2.0 likely support unicode character output correctly (such as the unicode box characters used in module tool output), so the windows-specific code in `lib/puppet/util/colors.rb` to force wide character output can be removed.   See https://github.com/l...


 

Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-07-01 Thread Josh Cooper (JIRA)
Title: Message Title










 

 Josh Cooper commented on an issue


















  Re: Remove win32console gem in ruby 2.0 on windows 










Merged in b5171fc11 to master to be released in 3.7.0












   

 Add Comment

























 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 







 Ruby 2.0 on windows supports ANSI escape sequences, so the win32console gem is unnecessary. Also, ruby 2.0 likely support unicode character output correctly (such as the unicode box characters used in module tool output), so the windows-specific code in `lib/puppet/util/colors.rb` to force wide character output can be removed.   See https://github.com/l...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-06-30 Thread Rob Reynolds (JIRA)
Title: Message Title










 

 Rob Reynolds assigned an issue to Rob Reynolds


















 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 










Change By:

 Rob Reynolds




Assignee:

 RobReynolds












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-06-30 Thread Rob Reynolds (JIRA)
Title: Message Title










 

 Rob Reynolds commented on an issue


















  Re: Remove win32console gem in ruby 2.0 on windows 










Rebasing against PUP-2777.












   

 Add Comment

























 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 







 Ruby 2.0 on windows supports ANSI escape sequences, so the win32console gem is unnecessary. Also, ruby 2.0 likely support unicode character output correctly (such as the unicode box characters used in module tool output), so the windows-specific code in `lib/puppet/util/colors.rb` to force wide character output can be removed.   See https://github.com/l...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-06-28 Thread Rob Reynolds (JIRA)
Title: Message Title










 

 Rob Reynolds commented on an issue


















  Re: Remove win32console gem in ruby 2.0 on windows 










The first part of this is at https://github.com/puppetlabs/puppet/pull/2817. It is going to require PUP-2777 to be finished first as part of this.












   

 Add Comment

























 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 







 Ruby 2.0 on windows supports ANSI escape sequences, so the win32console gem is unnecessary. Also, ruby 2.0 likely support unicode character output correctly (such as the unicode box characters used in module tool output), so the windows-specific code in `lib/puppet/util/colors.rb` to force wide character output can be removed.   See https://github.com/l...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-06-27 Thread Ethan Brown (JIRA)
Title: Message Title










 

 Ethan Brown commented on an issue


















  Re: Remove win32console gem in ruby 2.0 on windows 










Yeah, this one is going to be tricky.. I also noticed that in my Ruby 2.0 x64 branch that we get a bunch of tests fails on the output comparison, where we get colored vs not-colored output now.












   

 Add Comment

























 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 







 Ruby 2.0 on windows supports ANSI escape sequences, so the win32console gem is unnecessary. Also, ruby 2.0 likely support unicode character output correctly (such as the unicode box characters used in module tool output), so the windows-specific code in `lib/puppet/util/colors.rb` to force wide character output can be removed.   See https://github.com/l...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit 

Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-06-26 Thread Ethan Brown (JIRA)
Title: Message Title










 

 Ethan Brown assigned an issue to Rob Reynolds


















 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 










Change By:

 Ethan Brown




Assignee:

 RobReynolds












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-06-26 Thread Rob Reynolds (JIRA)
Title: Message Title










 

 Rob Reynolds commented on an issue


















  Re: Remove win32console gem in ruby 2.0 on windows 










And of course we are going for the harder fix... 












   

 Add Comment

























 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 







 Ruby 2.0 on windows supports ANSI escape sequences, so the win32console gem is unnecessary. Also, ruby 2.0 likely support unicode character output correctly (such as the unicode box characters used in module tool output), so the windows-specific code in `lib/puppet/util/colors.rb` to force wide character output can be removed.   See https://github.com/l...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-06-16 Thread Josh Cooper (JIRA)
Title: Message Title










 

 Josh Cooper updated an issue


















 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 










Change By:

 Josh Cooper




Sprint:

 Week2014-6- 18 25 to2014- 6 7 - 25 2












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-05-29 Thread Joshua Cooper (JIRA)
Title: Message Title










 

 Joshua Cooper updated an issue


















 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 










Change By:

 Joshua Cooper




Component/s:

 Client












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-05-28 Thread Joshua Cooper (JIRA)
Title: Message Title










 

 Joshua Cooper updated an issue


















 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 










Change By:

 Joshua Cooper




Sprint:

 Week2014-6- 11 18 to2014-6- 18 25












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-05-27 Thread Joshua Cooper (JIRA)
Title: Message Title










 

 Joshua Cooper updated an issue


















 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 










Change By:

 Joshua Cooper




Sprint:

 Week2014-6-4to2014-6-11












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-05-27 Thread Joshua Cooper (JIRA)
Title: Message Title










 

 Joshua Cooper updated an issue


















 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 










Change By:

 Joshua Cooper




Sprint:

 Week2014-6- 4 11 to2014-6- 11 18












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-04-29 Thread Joshua Cooper (JIRA)
Title: Message Title










 

 Joshua Cooper updated an issue


















 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 










Change By:

 Joshua Cooper




Issue Type:

 Bug Task












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-04-07 Thread Joshua Cooper (JIRA)
Title: Message Title










 

 Joshua Cooper updated an issue


















 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 










Change By:

 Joshua Cooper




Story Points:

 2












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2014-04-07 Thread Joshua Cooper (JIRA)
Title: Message Title










 

 Joshua Cooper commented on an issue


















  Re: Remove win32console gem in ruby 2.0 on windows 










The easy fix is to just rip out the win32console gem from puppet-win32-ruby and the specific code in Puppet::Util::Colors, once we move to ruby 2. Then run the puppet module tool with --debug, and verify that the unicode box characters are displayed correctly and the colors are correct. Also make sure to try running from powershell and cmd.exe as they have different default background colors.
We also need to check facter and hiera to see if they use win32console.
The harder fix is to try to support ruby 1.9 and 2.0 simultaneously.












   

 Add Comment

























 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 







 Ruby 2.0 on windows supports ANSI escape sequences, so the win32console gem is unnecessary. Also, ruby 2.0 likely support unicode character output correctly (such as the unicode box characters used in module tool output), so the windows-specific code in `lib/puppet/util/colors.rb` to force wide character output can be removed.   See https://github.com/l...















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 






Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2013-12-30 Thread redmine.exporter (JIRA)
Title: Message Title










 

 redmine.exporter created an issue


















 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 










Issue Type:

  Bug




Assignee:


 Unassigned




Created:


 30/Dec/13 10:28 AM




Labels:


 redmine




Priority:

  Normal




Reporter:

 redmine.exporter










Ruby 2.0 on windows supports ANSI escape sequences, so the win32console gem is unnecessary. Also, ruby 2.0 likely support unicode character output correctly (such as the unicode box characters used in module tool output), so the windows-specific code in `lib/puppet/util/colors.rb` to force wide character output can be removed.
See https://github.com/luislavena/win32console/issues/17#issuecomment-20811539












   

 Add Comment














 

Jira (PUP-1281) Remove win32console gem in ruby 2.0 on windows

2013-12-30 Thread Joshua Cooper (JIRA)
Title: Message Title










 

 Joshua Cooper updated an issue


















 Puppet /  PUP-1281



  Remove win32console gem in ruby 2.0 on windows 










Change By:

 Joshua Cooper




Labels:

 redmine windows












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/groups/opt_out.