Jira (PUP-2927) Facter logs should be surfaced during Puppet runs
Title: Message Title Michael Smith assigned an issue to Michael Smith Puppet / PUP-2927 Facter logs should be surfaced during Puppet runs Change By: Michael Smith Assignee: MichaelSmith Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2927) Facter logs should be surfaced during Puppet runs
Title: Message Title
Michael Smith commented on PUP-2927
Re: Facter logs should be surfaced during Puppet runs
Tried various combinations of custom facts
Facter.add('test') do
setcode do
'foo'
end
end
Facter.add('err') do
setcode do
raise Because I can
end
end
Jira (PUP-2927) Facter logs should be surfaced during Puppet runs
Title: Message Title Michael Smith assigned an issue to Unassigned Puppet / PUP-2927 Facter logs should be surfaced during Puppet runs Change By: Michael Smith Assignee: MichaelSmith Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2927) Facter logs should be surfaced during Puppet runs
Title: Message Title Peter Huene commented on PUP-2927 Re: Facter logs should be surfaced during Puppet runs For FR: With a facter or cfacter out of their respective master, ensure that --debug and --trace are respected when passed to Puppet. I used a custom fact that logs debug / warning messages to test. Note for testing with cfacter: cfacter needs to be installed into the system (make install) and the gem needs to be present for Puppet. The easiest way to do the latter is to create a Gemfile.local for Puppet containing the following: gem 'cfacter', :path = 'full_path_to_cfacter_gem_directory_here' Then use bundler to activate Puppet and pass the --cfacter option. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2927) Facter logs should be surfaced during Puppet runs
Title: Message Title Eric Sorenson commented on PUP-2927 Re: Facter logs should be surfaced during Puppet runs Kylo Ginsberg could you add a point estimate to this please? From the comments, it seems like it's underway already too, should it be past ready for engineering? Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2927) Facter logs should be surfaced during Puppet runs
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-2927 Facter logs should be surfaced during Puppet runs Change By: Kylo Ginsberg Assignee: KyloGinsberg PeterHuene Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2927) Facter logs should be surfaced during Puppet runs
Title: Message Title Kylo Ginsberg commented on PUP-2927 Re: Facter logs should be surfaced during Puppet runs Peter Huene since you demo'd this I'm going to consider this In Progress and assign it to you Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2927) Facter logs should be surfaced during Puppet runs
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-2927 Facter logs should be surfaced during Puppet runs Change By: Kylo Ginsberg Story Points: 2 Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2927) Facter logs should be surfaced during Puppet runs
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-2927 Facter logs should be surfaced during Puppet runs Change By: Kylo Ginsberg Sprint: PlatformClient2014-12-10 Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2927) Facter logs should be surfaced during Puppet runs
Title: Message Title Peter Huene commented on PUP-2927 Re: Facter logs should be surfaced during Puppet runs As I now have Facter logging going through Puppet's log, do we want Puppet's --debug to enable Facter's debug output? Facter 2.x doesn't have the most useful debug messages, but cfacter has lots of potentially useful information in debug messages (but it might get pretty verbose). Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2927) Facter logs should be surfaced during Puppet runs
Title: Message Title Peter Huene commented on PUP-2927 Re: Facter logs should be surfaced during Puppet runs Should we set Facter's trace option with Puppet's --trace? Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2927) Facter logs should be surfaced during Puppet runs
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-2927 Facter logs should be surfaced during Puppet runs Change By: Kylo Ginsberg Fix Version/s: PUP4.0.0 Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2927) Facter logs should be surfaced during Puppet runs
Title: Message Title Peter Huene commented on PUP-2927 Re: Facter logs should be surfaced during Puppet runs Kylo Ginsberg by the way, I started work on this ticket for testing out the Facter ticket; it's under my pup/2927 branch. If we decide to enable debugging/trace, I'll add the corresponding methods to cfacter's Ruby API. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2927) Facter logs should be surfaced during Puppet runs
Title: Message Title Kylo Ginsberg commented on PUP-2927 Re: Facter logs should be surfaced during Puppet runs Yes, offhand I'd think: if puppet is emitting warning messages, then it emits facter warning messages (and higher) if puppet is emitting debug messages, then it emits facter debug messages (and higher) Re native facter verbosity, I'm inclined to try it this way and then tweak it if we find it's just too chatty. Re trace, I'm less sure. I think it'd be valuable to set trace for facter if it's set for puppet. But not sure what that would mean for native facter Thoughts? Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2927) Facter logs should be surfaced during Puppet runs
Title: Message Title Peter Huene commented on PUP-2927 Re: Facter logs should be surfaced during Puppet runs For native facter, I think we can make it mean what it currently means for Ruby facter: Ruby stack traces are printed. Currently native facter's Ruby API will always log stack traces, so it's treating this option as always on. We don't print stack traces for native exceptions currently since there's no good cross-platform way I know of doing so. Native facter currently supports a - trace option, but it means enable trace level output (highest verbosity). I think we should rename that option to something else and treat -trace as print stack traces for custom fact exceptions for parity with Ruby facter. Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2927) Facter logs should be surfaced during Puppet runs
Title: Message Title Eric Sorenson commented on PUP-2927 Re: Facter logs should be surfaced during Puppet runs Yes, setting debug on Puppet ought to invoke facter with debugging enabled. If it didn't, how else would you enable it? Add Comment This message was sent by Atlassian JIRA (v6.3.7#6337-sha1:2ed701e) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2927) Facter logs should be surfaced during Puppet runs
Title: Message Title Andy Parker commented on an issue Re: Facter logs should be surfaced during Puppet runs Shouldn't this be a facter ticket? And then have a ticket for Puppet to use the new facility? Add Comment Puppet / PUP-2927 Facter logs should be surfaced during Puppet runs Information logged by Hiera [is forwarded to Puppet loggers|https://github.com/puppetlabs/hiera/blob/master/lib/hiera/puppet_logger.rb] when Hiera is running as part of a Puppet process. Facter should do the same thing. For Facter, this is especially critical since custom facts contain arbitrary user-written code that can have a variety of side effects... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2927) Facter logs should be surfaced during Puppet runs
Title: Message Title Kylo Ginsberg commented on an issue Re: Facter logs should be surfaced during Puppet runs I agree, sounds like this needs a matching facter ticket. Why is this in the 'JSON All the Things!' epic? I'm missing something. Add Comment Puppet / PUP-2927 Facter logs should be surfaced during Puppet runs Information logged by Hiera [is forwarded to Puppet loggers|https://github.com/puppetlabs/hiera/blob/master/lib/hiera/puppet_logger.rb] when Hiera is running as part of a Puppet process. Facter should do the same thing. For Facter, this is especially critical since custom facts contain arbitrary user-written code that can have a variety of side effects... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit
Jira (PUP-2927) Facter logs should be surfaced during Puppet runs
Title: Message Title Andy Parker commented on an issue Re: Facter logs should be surfaced during Puppet runs I added it to JSON All the Things because I noticed that the message the facter produces when it hits non-UTF-8 facts doesn't go through puppet's logging system, which means that it wouldn't make it into a report. I was thinking that part of making a good user experience for JSON All the Things would be to include logs about when non-UTF-8 data is hit. Can't do this for the master side, but it should be doable for the agent side. Add Comment Puppet / PUP-2927 Facter logs should be surfaced during Puppet runs Information logged by Hiera [is forwarded to Puppet loggers|https://github.com/puppetlabs/hiera/blob/master/lib/hiera/puppet_logger.rb] when Hiera is running as part of a Puppet process. Facter should do the same thing. For Facter, this is especially critical since custom facts contain arbitrary user-written code that can have a variety of side effects... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and
Jira (PUP-2927) Facter logs should be surfaced during Puppet runs
Title: Message Title Kylo Ginsberg commented on an issue Re: Facter logs should be surfaced during Puppet runs Adding a little more context about how hiera handles pluggable logging: 1) Hiera can be told what logger to use: https://github.com/puppetlabs/hiera/blob/1.3.4/lib/hiera.rb#L16-L36 2 ) Hiera has a few, including a puppet logger: https://github.com/puppetlabs/hiera/blob/master/lib/hiera/puppet_logger.rb 3) Puppet tells hiera to use itself as logger: https://github.com/puppetlabs/puppet/blob/master/lib/hiera_puppet.rb#L65 Peter Huene any thoughts on the cleanest way to add pluggable logging to facter in such a way that it will also work with facter 3 (cfacter)? (Yes, the facter side of this should ultimately be farmed out to a facter ticket once we sort out when we can do what.) Add Comment Puppet / PUP-2927 Facter logs should be surfaced during Puppet runs Information logged by Hiera [is forwarded to Puppet loggers|https://github.com/puppetlabs/hiera/blob/master/lib/hiera/puppet_logger.rb] when Hiera is running as part of a Puppet process. Facter should do the same thing. For Facter, this is especially critical since custom facts contain arbitrary user-written code that can have a variety of side effects... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)
Jira (PUP-2927) Facter logs should be surfaced during Puppet runs
Title: Message Title Peter Huene commented on an issue Re: Facter logs should be surfaced during Puppet runs I'd like us to avoid making Puppet calls from Facter (ugh!). I think Facter::Core::Logging should be extended to register a callback interface that has methods corresponding to the log levels (in facter it's just debug and warn; in cfacter it's trace, debug, warn, error, and fatal). Puppet would implement this interface and pass through the calls into the corresponding Puppet methods and register it with Facter. That's something we can easily implement in Ruby and C++. Add Comment Puppet / PUP-2927 Facter logs should be surfaced during Puppet runs Information logged by Hiera [is forwarded to Puppet loggers|https://github.com/puppetlabs/hiera/blob/master/lib/hiera/puppet_logger.rb] when Hiera is running as part of a Puppet process. Facter should do the same thing. For Facter, this is especially critical since custom facts contain arbitrary user-written code that can have a variety of side effects... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs
Jira (PUP-2927) Facter logs should be surfaced during Puppet runs
Title: Message Title Charlie Sharpsteen commented on an issue Re: Facter logs should be surfaced during Puppet runs Kylo Ginsberg: Any thoughts about getting this one into Facter 2.2? Not getting log output during Puppet runs makes it really difficult to track down some classes of bugs. Add Comment Puppet / PUP-2927 Facter logs should be surfaced during Puppet runs Information logged by Hiera [is forwarded to Puppet loggers|https://github.com/puppetlabs/hiera/blob/master/lib/hiera/puppet_logger.rb] when Hiera is running as part of a Puppet process. Facter should do the same thing. For Facter, this is especially critical since custom facts contain arbitrary user-written code that can have a variety of side effects... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit
Jira (PUP-2927) Facter logs should be surfaced during Puppet runs
Title: Message Title Charlie Sharpsteen updated an issue Puppet / PUP-2927 Facter logs should be surfaced during Puppet runs Change By: Charlie Sharpsteen Priority: Normal Major Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-2927) Facter logs should be surfaced during Puppet runs
Title: Message Title Charlie Sharpsteen created an issue Puppet / PUP-2927 Facter logs should be surfaced during Puppet runs Issue Type: New Feature Affects Versions: 3.6.2 Assignee: Kylo Ginsberg Components: Client Created: 11/Jul/14 9:10 AM Labels: customer facter logging Priority: Normal Reporter: Charlie Sharpsteen Information logged by Hiera is forwarded to Puppet loggers when Hiera is running as part of a Puppet process. Facter should do the same thing. For Facter, this is especially critical since custom facts contain arbitrary user-written code that can have a variety of side effects — including halting the entire process. Without access to Facter logging info, even when Puppet is running with --debug verbosity, all the user can determine is that the Puppet agent died with doing... something.
