Jira (PUP-3258) puppet apply + ENC + 3.7.x: does not read the .pp file
Title: Message Title Henrik Lindberg commented on PUP-3258 Re: puppet apply + ENC + 3.7.x: does not read the .pp file Robert Brooks I created PUP-6119 as this is probably a different issue (similar symptom but different cause). Closing this issue again. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3258) puppet apply + ENC + 3.7.x: does not read the .pp file
Title: Message Title
Robert Brooks commented on PUP-3258
Re: puppet apply + ENC + 3.7.x: does not read the .pp file
This issue is still present in puppet-3.8.6-1puppetlabs on Ubuntu 14.04:
ENC returning nothing...
root@trusty:~# /vagrant/enc
---
classes: []
root@trusty:~# cat test.pp
notify { "test.pp": }
notify { "${environment}": }
root@trusty:~# puppet apply test.pp
Notice: Compiled catalog for trusty.vagrant in environment vagrant in 0.42 seconds
Jira (PUP-3258) puppet apply + ENC + 3.7.x: does not read the .pp file
Title: Message Title Britt Gresham assigned an issue to Britt Gresham Puppet / PUP-3258 puppet apply + ENC + 3.7.x: does not read the .pp file Change By: Britt Gresham Assignee: BrittGresham Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3258) puppet apply + ENC + 3.7.x: does not read the .pp file
Title: Message Title
Britt Gresham commented on an issue
Re: puppet apply + ENC + 3.7.x: does not read the .pp file
As a part of the FR I made sure that the results on stable match those before the regressions introduced after 3.6.1.
site.pp:
notify { 'You should be able to see me': }
On Puppet 3.6.1:
britt at BrittMac in ~/projects/ruby/puppet on (detached from 3.6.1)*
$ be puppet apply ./site.pp --test
Warning: Setting modulepath is deprecated in puppet.conf. See http://links.puppetlabs.com/env-settings-deprecations
(at /Users/britt/projects/ruby/puppet/lib/puppet/settings.rb:1067:in `each')
Info: Loading facts in /Users/britt/Downloads/puppet-vapply-bug/modules/stdlib/lib/facter/facter_dot_d.rb
Info: Loading facts in /Users/britt/Downloads/puppet-vapply-bug/modules/stdlib/lib/facter/pe_version.rb
Info: Loading facts in /Users/britt/Downloads/puppet-vapply-bug/modules/stdlib/lib/facter/puppet_vardir.rb
Jira (PUP-3258) puppet apply + ENC + 3.7.x: does not read the .pp file
Title: Message Title Britt Gresham updated an issue Puppet / PUP-3258 puppet apply + ENC + 3.7.x: does not read the .pp file Change By: Britt Gresham Assignee: BrittGresham Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3258) puppet apply + ENC + 3.7.x: does not read the .pp file
Title: Message Title Andy Parker updated an issue Puppet / PUP-3258 puppet apply + ENC + 3.7.x: does not read the .pp file Change By: Andy Parker Flagged: Impediment Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3258) puppet apply + ENC + 3.7.x: does not read the .pp file
Title: Message Title Andy Parker commented on an issue Re: puppet apply + ENC + 3.7.x: does not read the .pp file Merged PR 3144 into stable in 766cce. This will be released in 3.7.2 Add Comment Puppet / PUP-3258 puppet apply + ENC + 3.7.x: does not read the .pp file Running 'puppet apply' with an ENC and a .pp file on the command line (full example supplied): at 3.6.1, the 'notice's in the .pp file are executed; at 3.7.x, they are not. 'puppet agent' 3.7.x does the right thing (same as 3.6.1). See the README file in the attached .tar.gz (a complete example). I ran './vapply --noop' (it needed sudo in my case; ma... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3258) puppet apply + ENC + 3.7.x: does not read the .pp file
Title: Message Title Rob Reynolds updated an issue Puppet / PUP-3258 puppet apply + ENC + 3.7.x: does not read the .pp file Change By: Rob Reynolds Assignee: AndyParker Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3258) puppet apply + ENC + 3.7.x: does not read the .pp file
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-3258 puppet apply + ENC + 3.7.x: does not read the .pp file Change By: Henrik Lindberg Sprint: Platform2014-10-15 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3258) puppet apply + ENC + 3.7.x: does not read the .pp file
Title: Message Title Andy Parker updated an issue Puppet / PUP-3258 puppet apply + ENC + 3.7.x: does not read the .pp file Change By: Andy Parker Story Points: 1 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3258) puppet apply + ENC + 3.7.x: does not read the .pp file
Title: Message Title Andy Parker updated an issue Puppet / PUP-3258 puppet apply + ENC + 3.7.x: does not read the .pp file Change By: Andy Parker Fix Version/s: 3.7.2 Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3258) puppet apply + ENC + 3.7.x: does not read the .pp file
Title: Message Title Andy Parker updated an issue Puppet / PUP-3258 puppet apply + ENC + 3.7.x: does not read the .pp file Change By: Andy Parker Component/s: Server Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3258) puppet apply + ENC + 3.7.x: does not read the .pp file
Title: Message Title Andy Parker commented on an issue Re: puppet apply + ENC + 3.7.x: does not read the .pp file Thanks Felix Frank for working on this. I'm marked it as 3.7.2, which we are still deciding if we are going to do. Add Comment Puppet / PUP-3258 puppet apply + ENC + 3.7.x: does not read the .pp file Running 'puppet apply' with an ENC and a .pp file on the command line (full example supplied): at 3.6.1, the 'notice's in the .pp file are executed; at 3.7.x, they are not. 'puppet agent' 3.7.x does the right thing (same as 3.6.1). See the README file in the attached .tar.gz (a complete example). I ran './vapply --noop' (it needed sudo in my case; ma... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3258) puppet apply + ENC + 3.7.x: does not read the .pp file
Title: Message Title Felix Frank assigned an issue to Felix Frank Puppet / PUP-3258 puppet apply + ENC + 3.7.x: does not read the .pp file Change By: Felix Frank Assignee: FelixFrank Add Comment This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-3258) puppet apply + ENC + 3.7.x: does not read the .pp file
Title: Message Title
Felix Frank commented on an issue
Re: puppet apply + ENC + 3.7.x: does not read the .pp file
I can reproduce with 3.7.0 and the following.
# /tmp/site.pp
notify { '/tmp/site.pp is in use': }
class foo { notify { 'class foo is included': } }
# ~/.puppet/manifests/site.pp
notify { '~/.puppet/manifests/site.pp is in use': }
#!/bin/sh
# /tmp/enc
cat EOF
classes:
- foo
EOF
This invocation should notify about /tmp/site.pp being in use, but does not.
$ bundle exec puppet apply /tmp/site.pp --node_terminus exec --external_nodes /tmp/enc
...
Notice: ~/.puppet/manifests/site.pp is in use
With 3.6.1, it works as expected.
$ bundle exec puppet apply /tmp/site.pp --node_terminus exec --external_nodes /tmp/enc
...
Notice: /tmp/site.pp is in use
With 3.7.0, it *does* work fine if a plain ENC is used.
$ /tmp/enc /tmp/nodes.yaml
$ bundle exec puppet apply /tmp/site.pp --external_nodes /tmp/nodes.yaml
...
Notice: /tmp/site.pp is in use
Current master 868bf83 is still affected.
Apparently the ENC support broke in some exciting way. I shall bisect between 3.6.1 and 3.7.0, let's see when this happened.
Add Comment
Jira (PUP-3258) puppet apply + ENC + 3.7.x: does not read the .pp file
Title: Message Title Felix Frank commented on an issue Re: puppet apply + ENC + 3.7.x: does not read the .pp file The suspect is commit 53d391b37f0a5f8f5937fcd7584fb6aae6db424b (PUP-2519) Create fallback environment only for default production Looks plausible, digging further. Add Comment Puppet / PUP-3258 puppet apply + ENC + 3.7.x: does not read the .pp file Running 'puppet apply' with an ENC and a .pp file on the command line (full example supplied): at 3.6.1, the 'notice's in the .pp file are executed; at 3.7.x, they are not. 'puppet agent' 3.7.x does the right thing (same as 3.6.1). See the README file in the attached .tar.gz (a complete example). I ran './vapply --noop' (it needed sudo in my case; ma... This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To
Jira (PUP-3258) puppet apply + ENC + 3.7.x: does not read the .pp file
Title: Message Title
Felix Frank commented on an issue
Re: puppet apply + ENC + 3.7.x: does not read the .pp file
More to the point, this patch introduces the breakage:
diff --git a/lib/puppet/application/apply.rb b/lib/puppet/application/apply.rb
index 22f2955..bd854e7 100644
--- a/lib/puppet/application/apply.rb
+++ b/lib/puppet/application/apply.rb
@@ -187,7 +187,7 @@ Copyright (c) 2011 Puppet Labs, LLC Licensed under the Apache 2.0 License
configured_environment.override_with(:manifest = manifest) :
configured_environment
-Puppet.override(:environments = Puppet::Environments::Static.new(apply_environment)) do
+Puppet.override(:current_environment = apply_environment) do
# Find our Node
unless node = Puppet::Node.indirection.find(Puppet[:node_name_value])
raise Could not find node #{Puppet[:node_name_value]}
Note that the apply_environment is a simple stub that overrides the manifest setting with what was given on the commandline (apparently). Not wrapping this in a static environment does not seem to be adequate any longer - perhaps the manifest search path must be overridden as well (or something along those lines).
Add Comment
Puppet / PUP-3258
puppet apply + ENC + 3.7.x: does not read the .pp file
Running 'puppet apply' with an ENC and a .pp file on the command line (full example supplied): at 3.6.1, the 'notice's in the .pp file are executed; at 3.7.x, they are not. 'puppet agent' 3.7.x does the right thing (same as 3.6.1). See the README file in the attached .tar.gz (a complete example). I ran './vapply --noop' (it needed sudo in my case; ma...
Jira (PUP-3258) puppet apply + ENC + 3.7.x: does not read the .pp file
Title: Message Title Felix Frank commented on an issue Re: puppet apply + ENC + 3.7.x: does not read the .pp file Hah, bad mojo. This patch seems to fix it: diff --git a/lib/puppet/indirector/node/exec.rb b/lib/puppet/indirector/node/exec.rb index d4faf74..2535ffa 100644 --- a/lib/puppet/indirector/node/exec.rb +++ b/lib/puppet/indirector/node/exec.rb @@ -21,7 +21,7 @@ class Puppet::Node::Exec Puppet::Indirector::Exec # Set the requested environment if it wasn't overridden # If we don't do this it gets set to the local default -result[:environment] ||= request.environment.name +result[:environment] ||= request.environment create_node(request.key, result) end Directory environments don't seem to work with string representations of environments. Looks like Andy Parker fixed this for LDAP back in the day ( PUP-1118 ), so it appears even more plausible that it should be done this way. Add Comment Puppet / PUP-3258 puppet apply + ENC + 3.7.x: does not read the .pp file Running 'puppet apply' with an ENC and a .pp file on the command line (full example supplied): at 3.6.1, the 'notice's in the .pp file are executed; at 3.7.x, they are not. 'puppet agent' 3.7.x does the right thing (same as 3.6.1). See the README file in the attached .tar.gz (a complete example). I ran './vapply --noop' (it needed sudo in my case; ma...
Jira (PUP-3258) puppet apply + ENC + 3.7.x: does not read the .pp file
Title: Message Title Will Partain created an issue Puppet / PUP-3258 puppet apply + ENC + 3.7.x: does not read the .pp file Issue Type: Bug Affects Versions: 3.7.0 Assignee: Unassigned Attachments: puppet-vapply-bug.tar.gz Created: 16/Sep/14 9:01 AM Environment: Debian jessie/amd64 Priority: Normal Reporter: Will Partain Running 'puppet apply' with an ENC and a .pp file on the command line (full example supplied): at 3.6.1, the 'notice's in the .pp file are executed; at 3.7.x, they are not. 'puppet agent' 3.7.x does the right thing (same as 3.6.1). See the README file in the attached .tar.gz (a complete example). I ran './vapply --noop' (it needed sudo in my case; maybe not for you). I have no idea on the possible cause; maybe I missed something.
