Jira (PUP-4356) Remove undocumented puppetversion key functionality in module metadata
Title: Message Title Kurt Wall updated an issue Puppet / PUP-4356 Remove undocumented puppetversion key functionality in module metadata Change By: Kurt Wall QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4356) Remove undocumented puppetversion key functionality in module metadata
Title: Message Title Anderson Mills commented on PUP-4356 Re: Remove undocumented puppetversion key functionality in module metadata Steve Barlow This ticket is being worked on PF-230. That ticket is in the current sprint, and is only waiting for CI to go green. Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4356) Remove undocumented puppetversion key functionality in module metadata
Title: Message Title Steve Barlow commented on PUP-4356 Re: Remove undocumented puppetversion key functionality in module metadata Reading the comments, it seems like this ticket is being actively worked, and it is targeted at PUP 4.2.0, but it is not in an active sprint. Are we expecting this to be done and in PUP 4.2.0? Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4356) Remove undocumented puppetversion key functionality in module metadata
Title: Message Title Anderson Mills updated an issue Puppet / PUP-4356 Remove undocumented puppetversion key functionality in module metadata Change By: Anderson Mills The[validate_puppet_version](https://github.com/puppetlabs/puppet/blob/04a60fbff5dbc0d2a5818c671cecc20032b0fae7/lib/puppet/module.rb#L286)methodinthePuppet::Moduleclasswilllookfor`puppetversion`inamodule'smetadata.Itwillcomparethatstring(cannotspecifyarrayorrange)againsttherunningPuppetversionandfailtoinstallthemoduleiftherunningversionandtheexpressedpuppetversiondon'tmatch.We'llneedtoremovethisfunctionality.Thisticketisthepublicreferencetothisbehavior. EDIT:Welefttheaccessorandfunctionsassociatedsoasnottomakeabreakingchange.Thisisonlymakingthecheckneverfailfornow. Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4356) Remove undocumented puppetversion key functionality in module metadata
Title: Message Title Anderson Mills updated an issue Puppet / PUP-4356 Remove undocumented puppetversion key functionality in module metadata Change By: Anderson Mills Release Notes: BugFix Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4356) Remove undocumented puppetversion key functionality in module metadata
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-4356 Remove undocumented puppetversion key functionality in module metadata Change By: Kylo Ginsberg Fix Version/s: PUP4.x Fix Version/s: PUP4.2.0 Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4356) Remove undocumented puppetversion key functionality in module metadata
Title: Message Title Adrien Thebo commented on PUP-4356 Re: Remove undocumented puppetversion key functionality in module metadata Merged in 69b468a. Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4356) Remove undocumented puppetversion key functionality in module metadata
Title: Message Title Henrik Lindberg commented on PUP-4356 Re: Remove undocumented puppetversion key functionality in module metadata So PF-230 says that there are 6 releases on the forge that use this. This is both good and somewhat disappointing. Going forward there will be the reason to cap the lowest version a module will work with due to language changes. It is a different issue where / when this should be resolved and result in an error or warning. The exact match / error is a very blunt instrument and that can clearly be dropped. it could be changed to = version match, that would also stop the errors. Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4356) Remove undocumented puppetversion key functionality in module metadata
Title: Message Title Henrik Lindberg commented on PUP-4356 Re: Remove undocumented puppetversion key functionality in module metadata I am curious about why this functionality needs to be removed, and if the removal means removing the information about puppet version, or just the failure if versions do not match. Is this because matching logic is not good, or some other reason? Should it be replaced with a warning? Or is this a matter of install-time vs. run-time - you should be able to install and checks should really be made at runtime? Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4356) Remove undocumented puppetversion key functionality in module metadata
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-4356 Remove undocumented puppetversion key functionality in module metadata Change By: Kylo Ginsberg Fix Version/s: PUP4.1.0 Fix Version/s: PUP4.x Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4356) Remove undocumented puppetversion key functionality in module metadata
Title: Message Title Kylo Ginsberg commented on PUP-4356 Re: Remove undocumented puppetversion key functionality in module metadata Bumping this to 4.x. Once it's in a sprint we can retarget to 4.1.0 or 4.2.0 or ... as appropriate. Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4356) Remove undocumented puppetversion key functionality in module metadata
Title: Message Title Anderson Mills updated an issue Puppet / PUP-4356 Remove undocumented puppetversion key functionality in module metadata Change By: Anderson Mills Fix Version/s: PUP4.1.0 Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4356) Remove undocumented puppetversion key functionality in module metadata
Title: Message Title Anderson Mills created an issue Puppet / PUP-4356 Remove undocumented puppetversion key functionality in module metadata Issue Type: Task Affects Versions: PUP 3.7.5, PUP 4.0.0 Assignee: Unassigned Components: PMT Created: 2015/03/31 2:47 PM Labels: pmt module Priority: Normal Reporter: Anderson Mills The [validate_puppet_version](https://github.com/puppetlabs/puppet/blob/04a60fbff5dbc0d2a5818c671cecc20032b0fae7/lib/puppet/module.rb#L286) method in the Puppet::Module class will look for `puppetversion` in a module's metadata. It will compare that string (cannot specify array or range) against the running Puppet version and fail to install the module if the running version and the expressed puppetversion don't match. We'll need to remove this functionality. This ticket is the public reference to this behavior.
Jira (PUP-4356) Remove undocumented puppetversion key functionality in module metadata
Title: Message Title Anderson Mills assigned an issue to Anderson Mills Puppet / PUP-4356 Remove undocumented puppetversion key functionality in module metadata Change By: Anderson Mills Assignee: AndersonMills Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
