Jira (PUP-4660) Stop checking Puppet.features.external_facts?
Title: Message Title John Duarte updated an issue Puppet / PUP-4660 Stop checking Puppet.features.external_facts? Change By: John Duarte QA Risk Assessment: Low Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4660) Stop checking Puppet.features.external_facts?
Title: Message Title John Duarte updated an issue Puppet / PUP-4660 Stop checking Puppet.features.external_facts? Change By: John Duarte Release Notes: Not Needed Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4660) Stop checking Puppet.features.external_facts?
Title: Message Title John Duarte updated an issue Puppet / PUP-4660 Stop checking Puppet.features.external_facts? Change By: John Duarte QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4660) Stop checking Puppet.features.external_facts?
Title: Message Title Eric Thompson assigned an issue to qa Puppet / PUP-4660 Stop checking Puppet.features.external_facts? Change By: Eric Thompson Status: Ready for CI Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4660) Stop checking Puppet.features.external_facts?
Title: Message Title William Hopper assigned an issue to Unassigned Puppet / PUP-4660 Stop checking Puppet.features.external_facts? Change By: William Hopper Assignee: William Hopper Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4660) Stop checking Puppet.features.external_facts?
Title: Message Title William Hopper updated an issue Puppet / PUP-4660 Stop checking Puppet.features.external_facts? Change By: William Hopper Fix Version/s: PUP 4.6.0 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4660) Stop checking Puppet.features.external_facts?
Title: Message Title William Hopper assigned an issue to William Hopper Puppet / PUP-4660 Stop checking Puppet.features.external_facts? Change By: William Hopper Assignee: William Hopper Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4660) Stop checking Puppet.features.external_facts?
Title: Message Title Kylo Ginsberg commented on PUP-4660 Re: Stop checking Puppet.features.external_facts? Ah, thanks for that Josh Cooper! Yes I was looking at .gemspec, not ext/project_data.yaml. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4660) Stop checking Puppet.features.external_facts?
Title: Message Title Josh Cooper commented on PUP-4660 Re: Stop checking Puppet.features.external_facts? For better or worse, puppet's .gemspec is only used when running puppet from source, and that's where we bumped the facter dependency. The packaging repo uses the dependencies in ext/project_data.yaml to build puppet as a gem, and there we already had a dependency on facter > 2. For example, puppet 4.5.2 gem shows the correct facter dependency: https://rubygems.org/gems/puppet/versions/4.5.2. So I think we're ok to make this change in puppet 4.y. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4660) Stop checking Puppet.features.external_facts?
Title: Message Title Kylo Ginsberg commented on PUP-4660 Re: Stop checking Puppet.features.external_facts? One question here is whether bumping the facter minimum up a major (i.e. from 1.7 to 2.0) requires a puppet major. If so, this should have a fixVersion of puppet 5. Thoughts Josh Cooper? Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4660) Stop checking Puppet.features.external_facts?
Title: Message Title Andrew Henroid updated an issue Puppet / PUP-4660 Stop checking Puppet.features.external_facts? Change By: Andrew Henroid Scope Change Category: Adopted Scope Change Reason: onboarding Sprint: Client 2016-07-13 (HA, 1.5.3) Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4660) Stop checking Puppet.features.external_facts?
Title: Message Title Andrew Henroid assigned an issue to Andrew Henroid Puppet / PUP-4660 Stop checking Puppet.features.external_facts? Change By: Andrew Henroid Assignee: Andrew Henroid Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4660) Stop checking Puppet.features.external_facts?
Title: Message Title William Hopper updated an issue Puppet / PUP-4660 Stop checking Puppet.features.external_facts? Change By: William Hopper Labels: client-onboarding Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4660) Stop checking Puppet.features.external_facts?
Title: Message Title Josh Cooper commented on PUP-4660 Re: Stop checking Puppet.features.external_facts? /cc Michael Smith Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4660) Stop checking Puppet.features.external_facts?
Title: Message Title Josh Cooper updated an issue Puppet / PUP-4660 Stop checking Puppet.features.external_facts? Change By: Josh Cooper Scrum Team: ClientPlatform Story Points: 1 Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4660) Stop checking Puppet.features.external_facts?
Title: Message Title Josh Cooper created an issue Puppet / PUP-4660 Stop checking Puppet.features.external_facts? Issue Type: Task Assignee: Unassigned Created: 2015/05/27 2:34 PM Priority: Normal Reporter: Josh Cooper When puppet performs pluginsync, it only downloads external facts when Puppet.features.external_facts? is true, and that is always the case when using Facter 2.0.1 or later, including native facter. So basically the check is always true, and can be removed, simplifying the code and testing. As part of this ticket, we should Remove the conditional logic in Puppet::Configurer::PluginHandler#download_plugins Remove the conditional logic in Puppet::Node::Facts::Facter#find Remove/cleanup tests that test when external_facts is false Ensure the various places where we express puppet's dependency on facter require at least 2.0.1 or greater, when the external_facts logic was added to facter https://github.com/puppetlabs/facter/commit/1590a4c5475da93f8f609a14b7f9a4e63511f8dc. It looks like this includes Gemfile, .gemspec, ext/build_defaults.yaml, where only .gemspec needs to be updated.
