Jira (PUP-4703) Optimize future_parser? checks for faster catalog production
Title: Message Title Eric Thompson assigned an issue to Unassigned Puppet / PUP-4703 Optimize future_parser? checks for faster catalog production Change By: Eric Thompson Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4703) Optimize future_parser? checks for faster catalog production
Title: Message Title Kylo Ginsberg assigned an issue to qa Puppet / PUP-4703 Optimize future_parser? checks for faster catalog production Change By: Kylo Ginsberg Status: Readyfor CI Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4703) Optimize future_parser? checks for faster catalog production
Title: Message Title Henrik Lindberg commented on PUP-4703 Re: Optimize future_parser? checks for faster catalog production Fihue Romain You are right in that it gets called once per resource. The difficulty in doing additional optimizations is that it is uncertain who exactly calls copy_as_resource since it is not private. It is known to be called from old parser, and from the catalog, but there could be other places. The method could have a parameter that defaults to calling Puppet.future_parser? and the two calls in the puppet code base could remember if the future parser is on or off. The places from where copy_as_resource are called are in Resource.to_ral and in the Catalog.to_catalog - at that point, the optimization started to snowball with lots of questions about tradeoffs - should each resource know about parser? should it be passed in the calls (it copies recursively IIRC), which is more expensive? etc. etc. The optimization that I added should reduce the time, but is not (by far) the best we could do. In fact, the best we could do is to rewrite the entire copy_as_resource/to_ral etc. and the generally excessive copying of Resource objects used as references. I simply did not have time to do this and as the time requird to do a good job grew I questioned the value of such an investment since the entire problem is gone in 4.0. So, good enough? - you would see a speed improvement on par with what you got with the simple replacement of Puppet[:parser]. Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4703) Optimize future_parser? checks for faster catalog production
Title: Message Title Romain Fihue commented on PUP-4703 Re: Optimize future_parser? checks for faster catalog production Henrik Lindberg Thanks for the fix. Just a question on it : Is it sufficient ? I mean, we could have done a bit better by moving the call out of the Resources loop instead of the Attributes loop. With this fix, it will still call future_parser? for each resource, right ? The parser won't change in the middle of a catalog isn't it ? Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4703) Optimize future_parser? checks for faster catalog production
Title: Message Title Romain Fihue commented on PUP-4703 Re: Optimize future_parser? checks for faster catalog production Fair enough. And you're right, as this is gone in 4.0, it's not reasonnable to put too much effort on it... Thanks again ! Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4703) Optimize future_parser? checks for faster catalog production
Title: Message Title Thomas Hallgren assigned an issue to Thomas Hallgren Puppet / PUP-4703 Optimize future_parser? checks for faster catalog production Change By: Thomas Hallgren Assignee: ThomasHallgren Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4703) Optimize future_parser? checks for faster catalog production
Title: Message Title Thomas Hallgren assigned an issue to Unassigned Puppet / PUP-4703 Optimize future_parser? checks for faster catalog production Change By: Thomas Hallgren Assignee: ThomasHallgren Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4703) Optimize future_parser? checks for faster catalog production
Title: Message Title Thomas Hallgren commented on PUP-4703 Re: Optimize future_parser? checks for faster catalog production Merged to 3.x at 97038f1, to stable at 8bb282f and to master at 568f8ab. The merge to stable and master didn't change any code since the optimization isn't applicable there. Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4703) Optimize future_parser? checks for faster catalog production
Title: Message Title Kurt Wall updated an issue Puppet / PUP-4703 Optimize future_parser? checks for faster catalog production Change By: Kurt Wall QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4703) Optimize future_parser? checks for faster catalog production
Title: Message Title Kurt Wall updated an issue Puppet / PUP-4703 Optimize future_parser? checks for faster catalog production Change By: Kurt Wall QA Risk Assessment: Low Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4703) Optimize future_parser? checks for faster catalog production
Title: Message Title Kurt Wall updated an issue Puppet / PUP-4703 Optimize future_parser? checks for faster catalog production Change By: Kurt Wall QA Risk Assessment Reason: Perfimprovement Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4703) Optimize future_parser? checks for faster catalog production
Title: Message Title Steve Barlow updated an issue Puppet / PUP-4703 Optimize future_parser? checks for faster catalog production Change By: Steve Barlow Sprint: Language2015-06-10 ,Language2015-06-24 Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4703) Optimize future_parser? checks for faster catalog production
Title: Message Title Steve Barlow updated an issue Puppet / PUP-4703 Optimize future_parser? checks for faster catalog production Change By: Steve Barlow Story Points: 1 Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-4703) Optimize future_parser? checks for faster catalog production
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-4703 Optimize future_parser? checks for faster catalog production Change By: Henrik Lindberg UPDATE---Asuboptimalimplementationwaschangedtoreducethenumberofcallsthecatalogproductionprocessmakestocheckifrunningwithparser=futureinthecurrentenvironment.Theolderlogiccheckedthisoncepercopiedresourceattribute.Theoptimizedlogiconlyonceperresource.Thisaffectsallusersirrespectiveofifrunningwithparser=futureornot.Theamountofspeedupdependsonthenumberofresourcesinthecatalog,andtheratioofattributesperresource.Asnotedincommentsaspeedup(measuredslightlydifferently)saved7secondsona17secondrun(areductionby42%).ORIGINAL---
Jira (PUP-4703) Optimize future_parser? checks for faster catalog production
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-4703 Optimize future_parser? checks for faster catalog production Change By: Henrik Lindberg Summary: Compilinglaunchesloadsof Optimize future_parser? checksforfastercatalogproduction Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) -- You received this message because you are subscribed to the Google Groups Puppet Bugs group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
