Jira (PUP-5231) Resource overrides for defined types is order dependent
Title: Message Title John Duarte updated an issue Puppet / PUP-5231 Resource overrides for defined types is order dependent Change By: John Duarte Labels: needs_decision triaged Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5231) Resource overrides for defined types is order dependent
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5231 Resource overrides for defined types is order dependent Change By: Henrik Lindberg Team: Puppet Developer Support Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5231) Resource overrides for defined types is order dependent
Title: Message Title
Peter Huene created an issue
Puppet / PUP-5231
Resource overrides for defined types is order dependent
Issue Type:
Bug
Affects Versions:
PUP 4.2.2
Assignee:
Unassigned
Created:
2015/09/11 2:00 PM
Priority:
Normal
Reporter:
Peter Huene
The following compiles:
define foo($bar) {
notice $bar
}
Jira (PUP-5231) Resource overrides for defined types is order dependent
Title: Message Title
Peter Huene updated an issue
Puppet / PUP-5231
Resource overrides for defined types is order dependent
Change By:
Peter Huene
The following compiles:{code}define foo($bar) {notice $bar}foo { foo:}Foo[foo] {bar => baz}{code}The notice is with "baz" as expected. This happens to work because Foo[foo] exists when the override _expression_ is evaluated. However, swapping the resource override with the resource declaration:{code}define foo($bar) {notice $bar}Foo[foo] {bar => baz}foo { foo:}{code}Results in:{code}Error: Must pass bar to Foo[foo] at foo.pp:9 on node foo{code}This is because resource overrides for resources that have not yet been declared are processed by the compiler after generating the defined types. To fix this, a check should be performed for an overrides that exist for the defined type about to be evaluated and they should be evaluated at that time.
Add Comment
This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5231) Resource overrides for defined types is order dependent
Title: Message Title
Peter Huene updated an issue
Puppet / PUP-5231
Resource overrides for defined types is order dependent
Change By:
Peter Huene
The following compiles:{code}define foo($bar) {notice $bar}foo { foo:}Foo[foo] {bar => baz}{code}The notice is with "baz" as expected. This happens to work because Foo[foo] exists when the override _expression_ is evaluated.However, swapping the resource override with the resource declaration:{code}define foo($bar) {notice $bar}Foo[foo] {bar => baz}foo { foo:}{code}Results in:{code}Error: Must pass bar to Foo[foo] at foo.pp:9 on node foo{code}This is because resource overrides for resources that have not yet been declared are processed by the compiler after generating the defined types. To fix this, a check should be performed for an overrides that exist for the defined type about to be evaluated and they should be evaluated at that time.
Add Comment
This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5231) Resource overrides for defined types is order dependent
Title: Message Title
Peter Huene updated an issue
Puppet / PUP-5231
Resource overrides for defined types is order dependent
Change By:
Peter Huene
The following compiles:{code}define foo($bar) {notice $bar}foo { foo:}Foo[foo] {bar => baz}{code}The notice is with "baz" as expected. This happens to work because Foo[foo] exists when the override _expression_ is evaluated.However, swapping the resource override with the resource declaration:{code}define foo($bar) {notice $bar}Foo[foo] {bar => baz}foo { foo:}{code}Results in:{code}Error: Must pass bar to Foo[foo] at foo.pp:9 on node foo{code}This is because resource overrides for resources that have not yet been declared are processed by the compiler after generating the defined types. To fix this, a check should be performed for overrides that exist for the defined type about to be evaluated and they should be evaluated at that time, although resource overrides that use a collector could further complicate a fix :/
Add Comment
This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5231) Resource overrides for defined types is order dependent
Title: Message Title
Peter Huene updated an issue
Puppet / PUP-5231
Resource overrides for defined types is order dependent
Change By:
Peter Huene
The following compiles:{code}define foo($bar) {notice $bar}foo { foo:}Foo[foo] {bar => baz}{code}The notice is with "baz" as expected. This happens to work because Foo[foo] exists when the override _expression_ is evaluated.However, swapping the resource override with the resource declaration:{code}define foo($bar) {notice $bar}Foo[foo] {bar => baz}foo { foo:}{code}Results in:{code}Error: Must pass bar to Foo[foo] at foo.pp:9 on node foo{code}This is because resource overrides for resources that have not yet been declared are processed by the compiler after generating the defined types. To fix this, a check should be performed for overrides that exist for the defined type about to be evaluated and they should be evaluated at that time . , although resource overrides that use a collector could further complicate a fix :/
Add Comment
This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5231) Resource overrides for defined types is order dependent
Title: Message Title Henrik Lindberg commented on PUP-5231 Re: Resource overrides for defined types is order dependent Is this a regression from 3x ? or from earlier 4.x ? If this problem exists in earlier versions I suspect it can only be changed on a major version boundary as it will alter behavior; I hesitate because it seems like it would always generate an error in the current version - fixing that is more a new feature than altered behavior; but I suspect there are other concerns, like parameters that are not required to be set (in this case meta parameters). Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5231) Resource overrides for defined types is order dependent
Title: Message Title Peter Huene commented on PUP-5231 Re: Resource overrides for defined types is order dependent I haven't checked, but I suspect this is not a regression. Other than metaparameters, I can't think up a use case where it would compile today and fixing the override behavior would alter the resulting catalog. I'm not sure how many users access metaparameters as variables within the defined type's scope, but it would be affected if we were to fix this. Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
