Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Thomas Hallgren commented on PUP-5834 Re: Handle extended data in the catalog I think it's bad practice to move a resolved ticket back to 'Ready for engineering'. I'm not even convinced that this ticket is at fault. My guess is that it has revealed a problem where some non json-compatible object leaks into the catalog. That could go undetected in the past. In any case, whether this is a regression or something else, it should not cause a reopen of this ticket IMO. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title William Hopper commented on PUP-5834 Re: Handle extended data in the catalog This series of commits or another on top of it has caused a failure in PEZ in the 2016.5.x pipeline: https://jenkins.puppetlabs.com/job/enterprise_pe-acceptance-tests-feature-branch_integration-system_pe_fb_smoke-monolithic_2016.5.x/LAYOUT=64mcd,LEGACY_AGENT_VERSION=NONE,PLATFORM=redhat7,UPGRADE_FROM=NONE,label=beaker/7/console 19:50:16 Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Unable to serialize non-Data type parameters unless a serializer is provided Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title William Hopper assigned an issue to qa Puppet / PUP-5834 Handle extended data in the catalog Change By: William Hopper Status: Ready for CI Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Henrik Lindberg commented on PUP-5834 Re: Handle extended data in the catalog Moving this to ready for CI since all follow on problems found (to date) during CI for this functionality have been addressed. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5834 Handle extended data in the catalog Change By: Henrik Lindberg Scrum Team: Language Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title William Hopper commented on PUP-5834 Re: Handle extended data in the catalog Follow up PR to fix the erroneous call to is_json_type instead of is_json_type?: https://github.com/puppetlabs/puppet/pull/5313 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title William Hopper assigned an issue to William Hopper Puppet / PUP-5834 Handle extended data in the catalog Change By: William Hopper Assignee: qa William Hopper Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title William Hopper assigned an issue to qa Puppet / PUP-5834 Handle extended data in the catalog Change By: William Hopper Status: Ready for CI Test Assignee: qa Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Henrik Lindberg commented on PUP-5834 Re: Handle extended data in the catalog This needs acceptance test(s) that agent gets instances of Regexp, time types Timespan, and Timestamp, and Binary instead of stringified versions of those data types when both master and agent have --rich_data turned on. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5834 Handle extended data in the catalog Change By: Henrik Lindberg Fix Version/s: PUP 4.y Fix Version/s: PUP 4.8.0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Henrik Lindberg commented on PUP-5834 Re: Handle extended data in the catalog Merged to master at: 375bdee (There is a feature switch to turn on this enabling/experimental feature - should be turned on for both agent and master side) Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Henrik Lindberg assigned an issue to Unassigned Puppet / PUP-5834 Handle extended data in the catalog Change By: Henrik Lindberg Assignee: Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Thomas Hallgren assigned an issue to Henrik Lindberg Puppet / PUP-5834 Handle extended data in the catalog Change By: Thomas Hallgren Assignee: Thomas Hallgren Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Henrik Lindberg assigned an issue to Thomas Hallgren Puppet / PUP-5834 Handle extended data in the catalog Change By: Henrik Lindberg Assignee: Henrik Lindberg Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Thomas Hallgren assigned an issue to Henrik Lindberg Puppet / PUP-5834 Handle extended data in the catalog Change By: Thomas Hallgren Assignee: Thomas Hallgren Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Henrik Lindberg assigned an issue to Thomas Hallgren Puppet / PUP-5834 Handle extended data in the catalog Change By: Henrik Lindberg Assignee: Henrik Lindberg Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Craig Gomes updated an issue Puppet / PUP-5834 Handle extended data in the catalog Change By: Craig Gomes Sprint: PDS 2016-09-21 , PDS 2016-10-05 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Thomas Hallgren assigned an issue to Henrik Lindberg Puppet / PUP-5834 Handle extended data in the catalog Change By: Thomas Hallgren Assignee: Thomas Hallgren Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Henrik Lindberg assigned an issue to Thomas Hallgren Puppet / PUP-5834 Handle extended data in the catalog Change By: Henrik Lindberg Assignee: Henrik Lindberg Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Henrik Lindberg assigned an issue to Henrik Lindberg Puppet / PUP-5834 Handle extended data in the catalog Change By: Henrik Lindberg Assignee: Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Henrik Lindberg commented on PUP-5834 Re: Handle extended data in the catalog I think we have conversion for two reasons; arguments / parameter values when creating resources, and when calling 3.x functions. We should continue to transform values for 3.x function calls after this change (or they will start breaking). Timespan and Timestamp have not been released yet, so no users could possibly have been using those with the expectation that they transform to strings. For SemVer, SemVerRange it is different as users may have adopted using those and then relying on the transformation to turn it into a string. There are resource types that deal with version in string format. For Regexp since it has been in the language for a long time that there are users who rely on the transformation - however, before 4.x / future-parser it was not possible to get an actual regular _expression_ into a variable, or into a resource, so the risk is minimal. The tricky thing here is that it is really the resource type and the providers that must be prepared to deal with the richer data type. There can be logic both in the type and in the provider that needs to be changed. To cover all bases: Send rich data in catalog for types that supports this This means adding a feature to the Resource API to allow the type to turn this on We need to add support for that in the pcore representation of a resource type A provider that can handle rich data types should declare that it has this feature/capability The type's API would then, if the selected provider does not support rich data types (when the type does), needs to transform the rich data types to strings (like we now do). This could possibly be simplified so that rich data is always sent. On the agent side (unless the type supports rich data) the transformation to strings takes place as part of deserialization/instantiation. We still need to deal with providers. That is a massive amount of conditional logic for the purpose of guarding against a fairly small risk (basically getting a Regexp instead of a string since the rest of the types are not yet in general use). Our implementation of this is brand new and it should be considered experimental at first. Therefore it seems reasonable to simply use a feature flag. That will enable us to learn how this works in practice and if we need to add the more elaborate scheme of supporting opt in per type and provider, or if it is simply a matter of "don't send rich data types to resource types that do not support that" - it is more or less the
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Thomas Hallgren commented on PUP-5834 Re: Handle extended data in the catalog Do we need some kind of feature-switch to enable this functionality in 4.y? For instance, the Puppet::Pops::Evaluator::Runtime3Converter will currently convert Regexp, SemVer, SemVerRange, Timespan, and Timestamp into strings. It won't need to once ext_parameters support is enabled but I guess changing that behavior must be considered a breaking change? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Henrik Lindberg commented on PUP-5834 Re: Handle extended data in the catalog The agent side certainly has all of the code in place that is in puppet. It also gets everything that the master decides to "plugin sync" to the agent. The plugin synced things ends up in the file system in a different structure than when it is in the layout used on the master. The agent is still using an Environment, but of a different implementation kind (IIRC RemoteEnvironment). There are probably issues with 4.x loaders and the smart-paths as they may be different. Also probable issues related to env object being different, as well as there being no Scope, and no Compiler. Thinking ahead, there is a desire to later be able to support things like "agent side functions" - which is worth taking into consideration when designing how to deal with loaders on the agent side (even if not part of this ticket per se). Code-wise, there is no clear delineation between agent and master code except that things under "puppet/parser" is thought to be master side only. The rest is open ended... Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Henrik Lindberg commented on PUP-5834 Re: Handle extended data in the catalog The investigation will tell how easy it is - it basically reads the entire thing, then uses "from_data_hash" to create instances. That data hash could include the ext_parameters in already instantiated form. Currently the object itself does its own post processing (changing a string "environment" to a reference to an instance of Environment, and similar actions). It is desirable that all such actions are done outside of the objects being deserialized. Using (a corrected) definition of the Data type to determine how something is serialized seems fine. That should cover all nested structures as well. We have some data types that are actually references and that are encoded in string format - they may be instances of Resource now that serialize to a string representation of the reference to that resource. Thus the CatalogEntry types needs some special rule as they are not Data. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Thomas Hallgren commented on PUP-5834 Re: Handle extended data in the catalog I know that I've asked this before, but what is in place on the agent side and how is that subset managed? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Thomas Hallgren commented on PUP-5834 Re: Handle extended data in the catalog I think it would be relatively easy to keep the ext_parameters inside a resource and still achieve efficient tabulation. It should just be a matter of using one single deserializer instance for all such serializations within a catalog. I will investigate this. I assume that during deserialization, all parameter values found in a catalog that are not of type Data (as described in the spec after the last update), will be serialized as ext_parameters automatically. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Henrik Lindberg commented on PUP-5834 Re: Handle extended data in the catalog A couple of questions regarding the description: "each json property is an object" - how is that different from today's 'parameters'? There is no differentiation between a hash and an object "the scheme should reflect that" - what "scheme" is referenced here? The catalog schema? The json schema right about where it says that. The problem is that the json schema does not say if the objects are objects or hashes. There is no way to state that. "ext_properties encoding" - what is that? How things are encoded in an ext_property - whatever is decided (when this was written we did not have Pcore or Pcore serialization). given that the serialization must be capable of handling all conceivable types, what additional support is needed there to manage `ext_parameters`? Could we turn this around and make `ext_parameters` reuse the JSON format used by the serialization? It has the advantage of being extensible using the new Object type. Yes we could, the format inside of the ext_parameter is not important. The idea here is to make it possible to wire new data types to agents that know about them without blowing up tools that are unaware of their existence. Also, that the changes required are not too extensive (thus making it feasible to do them with reasonable effort and without disturbing too much of the agent's code base). There are other options: Make the entire catalog be a pcore serialization - boom, no weird "ext_parameters". This is in line with the epic "remove PSON". The downside is that everything in the toolchain must be able to handle the format which makes this into a very Big Bang. Move the ext_parameters from being inside a resource, as instead
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Thomas Hallgren commented on PUP-5834 Re: Handle extended data in the catalog A couple of questions regarding the description: "each json property is an object" - how is that different from today's 'parameters'? "the scheme should reflect that" - what "scheme" is referenced here? The catalog schema? "ext_properties encoding" - what is that? given that the serialization must be capable of handling all conceivable types, what additional support is needed there to manage `ext_parameters`? Could we turn this around and make `ext_parameters` reuse the JSON format used by the serialization? It has the advantage of being extensible using the new Object type. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Henrik Lindberg commented on PUP-5834 Re: Handle extended data in the catalog Yes, although the Binary type was expected to be the first to trailblaze through. We could have done it with the regexp. The intent was though to get suppot for "new" and similar things from the Binary implementation. As it turned out we followed a slightly different track. The Binary is a good candidate to use since it should naturally be binary encoded when serialized in a binary format, and something like Base64 in a textual format. Using it as the model is therefore a good thing. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Thomas Hallgren commented on PUP-5834 Re: Handle extended data in the catalog Why is this ticket blocked by the Binary type specifically? Isn't this also needed to handle Regexp, Timespan, and Timestamp properly in the catalog? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Thomas Hallgren updated an issue Puppet / PUP-5834 Handle extended data in the catalog Change By: Thomas Hallgren Sprint: PDS Triage 2016-09-21 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Thomas Hallgren assigned an issue to Thomas Hallgren Puppet / PUP-5834 Handle extended data in the catalog Change By: Thomas Hallgren Assignee: Thomas Hallgren Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5834 Handle extended data in the catalog Change By: Henrik Lindberg Sprint: PDS 2016-09-21 Triage Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5834 Handle extended data in the catalog Change By: Henrik Lindberg Team: Puppet Developer Support Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5834 Handle extended data in the catalog Change By: Henrik Lindberg Sprint: Language Triage PDS 2016-09-21 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title
Thomas Hallgren updated an issue
Puppet / PUP-5834
Handle extended data in the catalog
Change By:
Thomas Hallgren
In our current catalog format, parameters of a resource are encoded in json like this:{code:json}"parameters": { "description": "Parameters: regex is from http://docs.puppetlabs.com/puppet/3/reference/lang_reserved.html", "type": "object", "patternProperties": { "^[a-z][a-z0-9_]*$": {} }, "additionalProperties": false}{code}This is not enough as it does not allow for any non Json native types to be expressed.In order to retain the existing format, we should add a new "ext_parameters" that allows for more complex values (in particular {{Binary}} and {{Sensitive}}. {code:json} "ext_parameters": { "description": "Parameters: regex is from http://docs.puppetlabs.com/puppet/3/reference/lang_reserved.html", "type": "object", "patternProperties": { "^[a-z][a-z0-9_]*$": {} }, "additionalProperties": false}{code}The only difference is that the values of each json property is an object (the scheme should reflect that). The values are encoded using ext_properties encoding (since we need to be able handling a {{Binary}} inside of a {{Sensitive}}.In this ticket:* The catalog schema should be updated* The serialization should have a mechanism for ext_parameters* The deserialization should have a mechanism for ext_parameters* When serializing check the version of the catalog that will be produced, and fail if there is an attempt to serialize unsupported data types (i.e. the use case when older agent requests a catalog and the data is too advanced).* when this ticket is accepted, log tickets for other projects (PDB, Catalog Preview, etc.)* unit test both server (serialization), and client side (deserialization)This ticket is blocked by the Binary type (PUP-5831); as without it, there is no sensible data to serialize/deserialize as all such special types needs to be handled specifically at both ends.
Add Comment
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title
Henrik Lindberg created an issue
Puppet / PUP-5834
Handle extended data in the catalog
Issue Type:
New Feature
Assignee:
Unassigned
Created:
2016/02/07 10:03 AM
Priority:
Normal
Reporter:
Henrik Lindberg
In our current catalog format, parameters of a resource are encoded in json like this:
"parameters": {
"description": "Parameters: regex is from http://docs.puppetlabs.com/puppet/3/reference/lang_reserved.html",
"type": "object",
"patternProperties": {
Jira (PUP-5834) Handle extended data in the catalog
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-5834 Handle extended data in the catalog Change By: Henrik Lindberg Fix Version/s: PUP 4.x Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
