Jira (PUP-6312) Load XPP instead of .pp if present and feature flag is on
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6312 Load XPP instead of .pp if present and feature flag is on Change By: Henrik Lindberg Labels: triaged Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6312) Load XPP instead of .pp if present and feature flag is on
Title: Message Title Henrik Lindberg assigned an issue to Unassigned Puppet / PUP-6312 Load XPP instead of .pp if present and feature flag is on Change By: Henrik Lindberg Assignee: Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6312) Load XPP instead of .pp if present and feature flag is on
Title: Message Title Henrik Lindberg commented on PUP-6312 Re: Load XPP instead of .pp if present and feature flag is on nope, removed from 4.8.0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6312) Load XPP instead of .pp if present and feature flag is on
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6312 Load XPP instead of .pp if present and feature flag is on Change By: Henrik Lindberg Fix Version/s: PUP 4.8.0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6312) Load XPP instead of .pp if present and feature flag is on
Title: Message Title Kenn Hussey commented on PUP-6312 Re: Load XPP instead of .pp if present and feature flag is on Henrik Lindberg is this still in progress? Should it be added to the current sprint? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6312) Load XPP instead of .pp if present and feature flag is on
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6312 Load XPP instead of .pp if present and feature flag is on Change By: Henrik Lindberg Team: Puppet Developer Support Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6312) Load XPP instead of .pp if present and feature flag is on
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6312 Load XPP instead of .pp if present and feature flag is on Change By: Henrik Lindberg Sprint: Language Triage Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6312) Load XPP instead of .pp if present and feature flag is on
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6312 Load XPP instead of .pp if present and feature flag is on Change By: Henrik Lindberg Fix Version/s: PUP 4.6.0 Fix Version/s: PUP 4.7.0 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6312) Load XPP instead of .pp if present and feature flag is on
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6312 Load XPP instead of .pp if present and feature flag is on Change By: Henrik Lindberg Sprint: Language 2016-07-27 Triage Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6312) Load XPP instead of .pp if present and feature flag is on
Title: Message Title Steve Barlow updated an issue Puppet / PUP-6312 Load XPP instead of .pp if present and feature flag is on Change By: Steve Barlow Sprint: Language 2016-07- 13 27 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6312) Load XPP instead of .pp if present and feature flag is on
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6312 Load XPP instead of .pp if present and feature flag is on Change By: Henrik Lindberg Sprint: Language 2016- 06 07 - 29 13 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6312) Load XPP instead of .pp if present and feature flag is on
Title: Message Title Steve Barlow updated an issue Puppet / PUP-6312 Load XPP instead of .pp if present and feature flag is on Change By: Steve Barlow Sprint: Language 2016-06- 15 29 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6312) Load XPP instead of .pp if present and feature flag is on
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6312 Load XPP instead of .pp if present and feature flag is on Change By: Henrik Lindberg Fix Version/s: PUP 4.6.0 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6312) Load XPP instead of .pp if present and feature flag is on
Title: Message Title Henrik Lindberg commented on PUP-6312 Re: Load XPP instead of .pp if present and feature flag is on The loading logic is spread out in Files (some general knowledge about names and paths), Module (searches for paths, mixes in 'init.pp' in the search), TypeLoader (known about what is loaded in terms of names and which files have been loaded). A big problem is that the search quickly changes from a symbolic type/name search to path based. If we instead use the 4.x loaders: Con: The visibility directed by metadata is not 100% compatible if modules in use have incorrect meta data Con: 4.x assumes there is a 1:M mapping name to file, but not M:M as the autoloader. (this can be added and is wanted for type loading) Pro: Enables private classes and resource types (cannot be implemented in autoloader). Pro: Very small change to Files, Module, and TypeLoader classes Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6312) Load XPP instead of .pp if present and feature flag is on
Title: Message Title Henrik Lindberg commented on PUP-6312 Re: Load XPP instead of .pp if present and feature flag is on Exploring the implementation of this: Loading of functions and types; here it was easiest to just add an .xpp loader in front of the .pp loader The loading of site.pp takes place in Node::Environment#perform_initial_import where a check is made if manifest is a file or a directory, parsing takes place, and the result is combined (if manifest is a directory). This logic needs to be conditional to the --xpp flag and: load xpp if the manifest path points inside of the environment, and load pp otherwise side note: all files in the manifests directory are loaded!! not just site.pp The autoloader loads all other puppet manifests Puppet::Parser::TypeLoader#try_load_fqname is at the top of the loading and it is given the name of the thing to load; it expands the paths that are then loaded with a follow-up check if the searched name was actually loaded. Here we could just prepend a set of .xpp paths to load. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
Jira (PUP-6312) Load XPP instead of .pp if present and feature flag is on
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6312 Load XPP instead of .pp if present and feature flag is on Change By: Henrik Lindberg Sprint: Language 2106 2016 -06- 01 15 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6312) Load XPP instead of .pp if present and feature flag is on
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6312 Load XPP instead of .pp if present and feature flag is on Change By: Henrik Lindberg Story Points: 3 2 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6312) Load XPP instead of .pp if present and feature flag is on
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6312 Load XPP instead of .pp if present and feature flag is on Change By: Henrik Lindberg Sprint: Language 2106-06-01 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6312) Load XPP instead of .pp if present and feature flag is on
Title: Message Title
Henrik Lindberg updated an issue
Puppet / PUP-6312
Load XPP instead of .pp if present and feature flag is on
Change By:
Henrik Lindberg
If an XPP file is present that is current and represents a given .pp file and the feature flag to use -xpp is on, then the parser should deserialize the content of the XPP file and either return the parsed result. If the result contains warnings and errors they should be reported and if it contains error, an error should be raised. * The boolean feature flag {{\--\[no]xpp}} should control the behavior* The loaders that load .pp should use the XPP instead of reading the .pp file and giving it to the Ruby parser implementation* The initial import of "site.pp" should use XPP* The autoloader's path to .pp files (that ends up in the ParserAdapter) should divert the calls to XPP
Add Comment
This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6312) Load XPP instead of .pp if present and feature flag is on
Title: Message Title Henrik Lindberg assigned an issue to Henrik Lindberg Puppet / PUP-6312 Load XPP instead of .pp if present and feature flag is on Change By: Henrik Lindberg Assignee: Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6312) Load XPP instead of .pp if present and feature flag is on
Title: Message Title Henrik Lindberg created an issue Puppet / PUP-6312 Load XPP instead of .pp if present and feature flag is on Issue Type: New Feature Assignee: Unassigned Created: 2016/05/16 1:45 PM Priority: Normal Reporter: Henrik Lindberg If an XPP file is present that is current and represents a given .pp file and the feature flag to use -xpp is on, then the parser should deserialize the content of the XPP file and either return the parsed result. If the result contains warnings and errors they should be reported and if it contains error, an error should be raised. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9)
