Jira (PUP-6457) Mount resources could handle invalid options better

2016-11-04 Thread Thomas Kornack (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Kornack commented on  PUP-6457 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 
 
As Branan Riley suggested in his answer to 

PUP-6457
 I'll gladly add some examples where the puppet agent remounts a share at every run and where fstab options and output of mount differ. All the cases did not occur prior to the update to puppet agent v1.8.0: 


1st Example:
 (2 Hosts) Distro: Ubuntu 12.04.05 LTS FS type, issue: nfs, remout with every agent run fstab: 
 
 
 
 
 
 
some.ip.add.ress:/home/some.user	/home/some.user	nfs	_netdev,vers=3,bg,soft,intr,retry=5	0	0
 
 
 
 
 
 
 
mtab: 
 
 
 
 
 
 
some.ip.add.ress:/home/some.user /home/some.user nfs rw,vers=3,bg,soft,intr,retry=5 0 0
 
 
 
 
 
 
 


2nd example:
 Distro: Ubuntu 14.04.05 LTS FS type, issue: tmpfs, remout with every agent run fstab: 
 
 
 
 
 
 
/dev/shm	/var/lib/amavis/tmp	tmpfs	defaults,size=250m,mode=770,uid=amavis,gid=amavis	0	0
 
 
 
 
 
 
 
mtab: 
 
 
 
 
 
 
   

Jira (PUP-6457) Mount resources could handle invalid options better

2016-11-03 Thread Branan Riley (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Branan Riley commented on  PUP-6457 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 
 
The general crux of the problem here is that the output of mount does not always match what's in /etc/fstab. I'm trying to understand the ways that this can go wrong on different filesystems and OS versions so that I can (hopefully) figure out a better algorithm for determining if they're in sync, or worst case give up and revert this. 
If you're experiencing issues, please comment on PUP-6861 with the following: 
 

Your Distro and version
 

The FS type you're encountering issues with
 

The appropriate lines from /etc/fstab and /etc/mtab
 
 
This will help me better understand the various ways this can go wrong. Some (like bind) are possibly easy, but as I've dug in to some of the failure cases this stuff is pretty hairy, so any new information will be a huge help to me right now. It will also help us to expand our test cases around filesystem and mountpoint handling, which have been historically kinda iffy. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-11-03 Thread Mateusz Gozdek (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Mateusz Gozdek commented on  PUP-6457 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 
 
I'm also affected by this. Maybe it would be nice to create a separate issue for this. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-11-03 Thread Ruben Laban (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Ruben Laban commented on  PUP-6457 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 
 
Thomas, the UID/GID stuff wouldn't explain the (possibly erroneous) log messages: "options changed 'foo,bar' to 'foo,bar'". In your case it logs username/groupname for both. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-11-03 Thread Thomas Kornack (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Kornack commented on  PUP-6457 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 
 
I have a similar issue since the installation of puppet-agent v1.8.0 yesterday which might also be related to the changes: 
The mount of a ram disk gets executed at every puppet agent run. The Logfile reads: 
 
 
 
 
 
 
/Nov  3 13:55:32 host007 puppet-agent[20688]: (/Stage[main]/Mailserver::Amavis/Mount[/var/lib/amavis/tmp]/options) options changed 'defaults,size=250m,mode=770,uid=amavis,gid=amavis' to 'defaults,size=250m,mode=770,uid=amavis,gid=amavis'
 
 
 
 
 
 
 
I think I found the reason for the problem: Mount option and output of 'mount' differ: The given options for the mount object are those found in the logs (see above). Mount reports: 
 
 
 
 
 
 
root@host007:/var/log/puppet# mount |grep amavis 
 
 
 
 
/run/shm on /var/lib/amavis/tmp type tmpfs (rw,size=250m,mode=770,uid=109,gid=115)
 
 
 
 
 
 
 
Mount options use user name and group name while 'mount outputs' uid and gid. I cannot change the mount options to use ids because uid and gid differ on different hosts. Is there an easier solution than to write own facts to read the right uid/gid? 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 

Jira (PUP-6457) Mount resources could handle invalid options better

2016-11-02 Thread Ruben Laban (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Ruben Laban commented on  PUP-6457 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 
 
I'm not completely sure if what I'm seeing is related to this change, but it's the closest I could find. 
After updating from puppet-agent 1.7.1 to puppet-agent 1.8.0 my bind-mount resources are "broken": 
2016-11-02 11:18:55 +0100 /Stage[main]/Ism::Vsftpd/Mount[/home/ftp/ftp_belloya_beta_01/var-exim]/options (notice): options changed 'bind,rw' to 'bind,rw' 2016-11-02 11:18:55 +0100 /Stage[main]/Ism::Vsftpd/Mount[/home/ftp/ftp_belloya_beta_01/var-exim] (notice): Triggered 'refresh' from 1 events 
Ran it with --debug as well but that didn't show much useful info either. 
I'm guessing the change in logic to parse the `mount` output is breaking this scenario. 
This is relevant part of the manifest: 
 mount  { '/home/ftp/ftp_belloya_beta_01/var-exim': ensure => 'mounted', device => '/var/www/vhosts/Beta/source/var/exim/', fstype => 'none', options => 'bind,rw', } 
Relevant line in /etc/fstab: 
/var/www/vhosts/Beta/source/var/exim/ /home/ftp/ftp_belloya_beta_01/var-exim none bind,rw 0 0 
Relevant output of `mount`: 
/dev/mapper/belloya-

web01


vg001-sys


var
-www on /home/ftp/ftp_belloya_beta_01/var-exim type ext4 (rw,relatime,data="" 
Relevant output of `findmnt`: 

 
 


/home/ftp/ftp_belloya_beta_01/var-exim /dev/mapper/belloya


web01


vg001-sys


var
-www[/vhosts/Beta/source/var/exim] ext4 rw,relatime,data=""
 
 

 
 
 
 
 
 
 
 
 
 
 
 
 

Jira (PUP-6457) Mount resources could handle invalid options better

2016-10-30 Thread Geoff Nichols (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Geoff Nichols updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6457 
 
 
 
  Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 

Change By:
 
 Geoff Nichols 
 
 
 

Fix Version/s:
 
 PUP 4.8.0 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-09-20 Thread Kurt Wall (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Kurt Wall commented on  PUP-6457 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 
 
After kicking this around yesterday, I'm not able to reproduce the reported errors. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-09-19 Thread Geoff Nichols (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Geoff Nichols assigned an issue to Kurt Wall 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6457 
 
 
 
  Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 

Change By:
 
 Geoff Nichols 
 
 
 

Assignee:
 
 qa Kurt Wall 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-09-16 Thread Maggie Dreyer (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Maggie Dreyer assigned an issue to qa 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6457 
 
 
 
  Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 

Change By:
 
 Maggie Dreyer 
 
 
 

Status:
 
 Ready for  CI  Test 
 
 
 

Assignee:
 
 Maggie Dreyer qa 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-09-16 Thread Geoff Nichols (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Geoff Nichols assigned an issue to Maggie Dreyer 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6457 
 
 
 
  Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 

Change By:
 
 Geoff Nichols 
 
 
 

Assignee:
 
 Maggie Dreyer 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-09-12 Thread Branan Riley (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Branan Riley updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6457 
 
 
 
  Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 

Change By:
 
 Branan Riley 
 
 
 

Story Points:
 
 5 0 
 
 
 

Sprint:
 
 Client 2016-07-13 (HA, 1.5.3), Client 2016-07-27, Client 2016-08-10, Client 2016-08-24, Client 2016-09-07 , APS 2016-09-21 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-09-12 Thread Branan Riley (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Branan Riley updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6457 
 
 
 
  Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 

Change By:
 
 Branan Riley 
 
 
 

Scrum Team:
 
 Client Platform 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-09-12 Thread Branan Riley (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Branan Riley updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6457 
 
 
 
  Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 

Change By:
 
 Branan Riley 
 
 
 

Sprint:
 
 Client 2016-07-13 (HA, 1.5.3), Client 2016-07-27, Client 2016-08-10, Client 2016-08-24, Client 2016-09-07 , Client 2016-09-21 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-09-12 Thread Branan Riley (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Branan Riley updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6457 
 
 
 
  Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 

Change By:
 
 Branan Riley 
 
 
 

Team:
 
 Agent & Platform Support 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-09-07 Thread David Kramer (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 David Kramer updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6457 
 
 
 
  Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 

Change By:
 
 David Kramer 
 
 
 

Sprint:
 
 Client 2016-07-13 (HA, 1.5.3), Client 2016-07-27, Client 2016-08-10, Client 2016-08-24, Client 2016-09-07 , Client 2016-09-21 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-08-24 Thread David Kramer (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 David Kramer updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6457 
 
 
 
  Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 

Change By:
 
 David Kramer 
 
 
 

Sprint:
 
 Client 2016-07-13 (HA, 1.5.3), Client 2016-07-27, Client 2016-08-10, Client 2016-08-24 , Client 2016-09-07 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-08-11 Thread Hailee Kenney (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Hailee Kenney commented on  PUP-6457 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 
 
Bill Niestempski No worries at all! Sorry there's been so many delays on this ticket. Usually if something is unassigned and in "ready for merge" that means it's waiting for a second pair of eyes to get the pull request merged. Now that the release is out this should get moving again soon.  
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-08-11 Thread Bill Niestempski (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Bill Niestempski commented on  PUP-6457 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 
 
Hailee Kenney Thanks for the explanation. I hope I didn't imply I was trying to rush things. I just didn't understand what it meant for the ticket not to have an assignee. I do appreciate all you help on this. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-08-11 Thread Hailee Kenney (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Hailee Kenney commented on  PUP-6457 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 
 
Bill Niestempski the ticket isn't assigned to anyone right now because the pull request is waiting for review. We've been really behind on reviewing/merging pull requests this sprint due to some issues with the release. Someone should be reviewing the pull request soon so it can be merged. Sorry for the delay! 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-08-10 Thread Steve Barlow (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Steve Barlow updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6457 
 
 
 
  Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 

Change By:
 
 Steve Barlow 
 
 
 

Sprint:
 
 Client 2016-07-13 (HA, 1.5.3), Client 2016-07-27, Client 2016-08-10 , Client 2016-08-24 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-07-27 Thread Kylo Ginsberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Kylo Ginsberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6457 
 
 
 
  Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 

Change By:
 
 Kylo Ginsberg 
 
 
 

Sprint:
 
 Client 2016-07-13 (HA, 1.5.3), Client 2016-07-27 , Client 2016-08-10 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-07-25 Thread Bill Niestempski (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Bill Niestempski commented on  PUP-6457 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 
 
Hailee Kenney In the notes above I see: 
"When puppet attempts to mount a resource with invalid options, the mount will fail BUT the new options will be listed in /etc/fstab. On the next puppet run, puppet will compare the defined resource to /etc/fstab and find that the options match, thus it will not attempt to remount. So puppet will give the impression that the remount with the new options is no longer failing which is incorrect." 
If the mount fails, should there be an entry for it in /etc/fstab? If there is no entry, would we not then see an attempted mount on the next puppet run? That is what the customer is looking for, a history of failed attempts which will notify him that something is wrong. 
Also I see - 
"This was all working until we realized the difference between /etc/fstab and the output of mount for default mount options. /etc/fstab will list the string "defaults" but mount will list the full list of default options. That means for this case, it's impossible to compare if the two are in sync unless we devise some kind of insane lookup table that tells us for each type of file system and operating system (and probably some more parameters honesty) what the list of default options should look like." 
Rather than a lookup table, would it be possible to mount a dummy filesystem of the proper type with 'default's in order to generate the list of defaults by then querying mount? That would be ugly but might be better than a static lookup table for every supported filesystem type. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, 

Jira (PUP-6457) Mount resources could handle invalid options better

2016-07-13 Thread Kylo Ginsberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Kylo Ginsberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6457 
 
 
 
  Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 

Change By:
 
 Kylo Ginsberg 
 
 
 

Sprint:
 
 Client 2016-07-13 (HA, 1.5.3) , Client 2016-07-27 facter.conf 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-07-13 Thread Hailee Kenney (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Hailee Kenney commented on  PUP-6457 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 
 
So it's entirely possible that I'm not using the mount_providers module right, but I've tried created a mouttab, a moutpoint, and both together and they don't seem to be a solution to this problem. They don't even complain about the bogus options in the first place, no matter how many times I apply the manifest. It's not clear to me exactly what mounttab and mountpoint manage, maybe they don't deal with any actual mounting I'm not sure. But they don't seem to be raising the first error to begin with which makes impossible for me to verify if they're a solution to this problem. 
Maybe I need to talk to someone who knows more about these resources and their intended use, I just wrote a quick manifest based on the output of 'puppet describe'. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-07-12 Thread Hailee Kenney (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Hailee Kenney commented on  PUP-6457 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 
 
That's a good point Kylo Ginsberg, I'll check if that module still has this problem before moving ahead with anything else. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-07-11 Thread Kylo Ginsberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Kylo Ginsberg commented on  PUP-6457 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 
 
I haven't dug into this at all, but do we know if https://github.com/puppetlabs/puppetlabs-mount_providers has this problem? My understanding is that the module is generally recommended/better in several regards. If it handles this issue properly, perhaps we recommend that as the path going forward. And otoh, if not, we should probably put up a ticket to fix the same issue in the module. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-07-11 Thread Hailee Kenney (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Hailee Kenney commented on  PUP-6457 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 
 
With a lot of help from Adrien Thebo, I've been making progress on this ticket. I've hit a little bit of a roadblock however. 
The beginnings of the solution we came up with can be found in this commit. The problem basically is that puppet is failing to detect when a mount has failed due to bad options and does not attempt to remount. This is because it is comparing only two sources and ensuring they match but neither source reflects what is actually mounted. When puppet attempts to mount a resource with invalid options, the mount will fail BUT the new options will be listed in /etc/fstab. On the next puppet run, puppet will compare the defined resource to /etc/fstab and find that the options match, thus it will not attempt to remount. So puppet will give the impression that the remount with the new options is no longer failing which is incorrect.
  
However, the output of the mount command does reveal that the resource did not successfully remount with the new problematic options. The options listed for the mounted file system from the mount command are not the update options which match the manifest, but the old ones which do not match the user defined resource. Thus we decided that the way to solve this problem was to also check the options for the mounted file system as they are in the output of the mount command, and if they do not match we know that the resource is not in sync with what is on the system and that we should attempt another remount. 
This was all working until we realized the difference between /etc/fstab and the output of mount for default mount options. /etc/fstab will list the string "defaults" but mount will list the full list of default options. That means for this case, it's impossible to compare if the two are in sync unless we devise some kind of insane lookup table that tells us for each type of file system and operating system (and probably some more parameters honesty) what the list of default options should look like. 
This has left us stumped, and we're looking for some ideas. Either a new approach, or a solution to the problem just described. Or the go ahead to attempt to construct the insane archive of default options for every OS we support. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 

Jira (PUP-6457) Mount resources could handle invalid options better

2016-06-30 Thread Hailee Kenney (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Hailee Kenney assigned an issue to Hailee Kenney 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6457 
 
 
 
  Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 

Change By:
 
 Hailee Kenney 
 
 
 

Assignee:
 
 Hailee Kenney 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-06-29 Thread Eric Thompson (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Eric Thompson updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6457 
 
 
 
  Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 

Change By:
 
 Eric Thompson 
 
 
 

QA Risk Assessment:
 
 Medium 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-6457) Mount resources could handle invalid options better

2016-06-29 Thread Steve Barlow (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Steve Barlow moved an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-6457 
 
 
 
  Mount resources could handle invalid options better  
 
 
 
 
 
 
 
 
 

Change By:
 
 Steve Barlow 
 
 
 

Key:
 
 PE PUP - 15102 6457 
 
 
 

Project:
 
 Puppet  Enterprise [Internal] 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.