Jira (PUP-6531) puppet service provider recognition on Ubuntu can be improved
Title: Message Title Josh Cooper commented on PUP-6531 Re: puppet service provider recognition on Ubuntu can be improved Since this ticket was filed, we've modified the systemd provider to make use of defaultfor and notdefaultfor so that we don't need to bump the file every time a new version comes out. We've also confined the provider based on /proc/1/comm, see PUP-10016. So I believe all of the issues described here and I'm going to close this. Add Comment This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.142751.1469140509000.53067.1623289740042%40Atlassian.JIRA.
Jira (PUP-6531) puppet service provider recognition on Ubuntu can be improved
Title: Message Title Branan Riley updated an issue Puppet / PUP-6531 puppet service provider recognition on Ubuntu can be improved Change By: Branan Riley Sprint: Platform OS Community PR Kanban Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6531) puppet service provider recognition on Ubuntu can be improved
Title: Message Title Branan Riley updated an issue Puppet / PUP-6531 puppet service provider recognition on Ubuntu can be improved Change By: Branan Riley Labels: service systemd triaged type_and_provider ubuntu Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6531) puppet service provider recognition on Ubuntu can be improved
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6531 puppet service provider recognition on Ubuntu can be improved Change By: Geoff Nichols Sprint: Platform OS Community PR Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6531) puppet service provider recognition on Ubuntu can be improved
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6531 puppet service provider recognition on Ubuntu can be improved Change By: Geoff Nichols Team: Platform Core OS Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6531) puppet service provider recognition on Ubuntu can be improved
Title: Message Title Nishanth Aravamudan commented on PUP-6531 Re: puppet service provider recognition on Ubuntu can be improved Ah I didn't realize Kylo had left – would explain why there was no response in my PR I think the PR itself is still valid (and what we do on Ubuntu now). It might be something worth genericizes to more distributions, as systemd I think is consistent that /run/systemd/system existing implies it is running. If the PR is bad or needs work, feel free to ping there or here and I'll update/iterate! Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6531) puppet service provider recognition on Ubuntu can be improved
Title: Message Title Nicholas Fagerlund commented on PUP-6531 Re: puppet service provider recognition on Ubuntu can be improved It looks like Kylo was looking at this before he left, and then it went into limbo. But we're in the process of making the backlogs usable again, so hopefully someone can get back to this soon. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6531) puppet service provider recognition on Ubuntu can be improved
Title: Message Title Nicholas Fagerlund updated an issue Puppet / PUP-6531 puppet service provider recognition on Ubuntu can be improved Change By: Nicholas Fagerlund Labels: triaged Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6531) puppet service provider recognition on Ubuntu can be improved
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6531 puppet service provider recognition on Ubuntu can be improved Change By: Geoff Nichols Team: Agent & Platform Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6531) puppet service provider recognition on Ubuntu can be improved
Title: Message Title Nishanth Aravamudan commented on PUP-6531 Re: puppet service provider recognition on Ubuntu can be improved The above PR now passes CI and I think is the right direction. Not sure if it could be generalized for other OSes yet or not, but I think generally the presence of /run/systemd/system is meant to indicate systemd should be used (rather than relying on any specific versions). Certainly at least for Ubuntu. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6531) puppet service provider recognition on Ubuntu can be improved
Title: Message Title Nishanth Aravamudan commented on PUP-6531 Re: puppet service provider recognition on Ubuntu can be improved https://github.com/puppetlabs/puppet/pull/5133 Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6531) puppet service provider recognition on Ubuntu can be improved
Title: Message Title Nishanth Aravamudan commented on PUP-6531 Re: puppet service provider recognition on Ubuntu can be improved Hi Kylo Ginsberg! Thanks for the feedback; yep, I'll try and provide something via a normal PR. I think the regex changes are good, but still too limited for saying there's a pivot point. We also have the benefit in Ubuntu of saying this particular package of puppet is only supported on this version of Ubuntu, so we can break backwards-compat I think to fix it properly upstream will take some more thought for those that are running puppet from source/upstream on older versions of Ubuntu. Then again, I think the systemd detection on Debian-family distributions is always correct to do with just /run/systemd/system's presence. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6531) puppet service provider recognition on Ubuntu can be improved
Title: Message Title Kylo Ginsberg assigned an issue to Unassigned Puppet / PUP-6531 puppet service provider recognition on Ubuntu can be improved Change By: Kylo Ginsberg Assignee: Kylo Ginsberg Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6531) puppet service provider recognition on Ubuntu can be improved
Title: Message Title Kylo Ginsberg commented on PUP-6531 Re: puppet service provider recognition on Ubuntu can be improved Hi Nishanth Aravamudan! Thanks for digging into the code! Can you capture your pseudocode improvement(s) in a PR against https://github.com/puppetlabs/puppet? Btw, wrt not requiring version patches per each version of Ubuntu, that would definitely be a nice code improvement (not just for ubuntu, but for any versioned osfamily/distro). As mentioned over in https://github.com/puppetlabs/puppet/pull/5009, one step in that direction, recently submitted, is https://github.com/puppetlabs/puppet/pull/5069. Add Comment This message was sent by Atlassian JIRA (v6.4.13#64028-sha1:b7939e9) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6531) puppet service provider recognition on Ubuntu can be improved
Title: Message Title Nishanth Aravamudan created an issue Puppet / PUP-6531 puppet service provider recognition on Ubuntu can be improved Issue Type: Improvement Assignee: Kylo Ginsberg Components: Types and Providers Created: 2016/07/21 3:35 PM Environment: Ubuntu 16.04, 16.10, 17.04 etc. Priority: Normal Reporter: Nishanth Aravamudan It would appear that, at least for Ubuntu's service provider detection, a combination of /run/systemd/system existence and a version check are done. Technically speaking, the version check is unnecessary, in that if systemd is detected (which /run/systemd/system is sufficient for), then no version check should be done. This way patches aren't necessary forever to puppet as systemd is the default going forward in Ubuntu releases. Ideally, the pseudo-logic would be "if systemd is detected then use the systemd provider; else if upstart is suitable, use the upstart provider; else use the init provider", I think. That is, upstart shouldn't be used at all if systemd is detected. We are seeing a bug in the Ubuntu packages on upgrade from 14.04 -> 16.04 where the 'upstart' package is installed (so e.g., /sbin/start is present and the upstart service provider is suitable), but systemd is running – our version of puppet is a bit older in 16.04 (3.8.5) and that didn't have
