Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6670 Newlines break Puppet tag validation Change By: Geoff Nichols Fix Version/s: PUP 4.7.1 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6670 Newlines break Puppet tag validation Change By: Geoff Nichols Fix Version/s: PUP 4.7.1 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Eric Thompson assigned an issue to Unassigned Puppet / PUP-6670 Newlines break Puppet tag validation Change By: Eric Thompson Assignee: Eric Thompson Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Eric Thompson assigned an issue to Eric Thompson Puppet / PUP-6670 Newlines break Puppet tag validation Change By: Eric Thompson Assignee: Eric Thompson Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title
Eric Thompson commented on PUP-6670
Re: Newlines break Puppet tag validation
from the puppet side this fix didn't seem to change anything with regards to File resources. i can create them with newlines, as charlie stated. but puppet resource doesn't know how to deal with them:
[root@lug256ijz7pgt6p ~]# puppet resource file $'/tmp/one\ntwo'
file { '/tmp/one
two':
ensure => 'absent',
}
[root@lug256ijz7pgt6p ~]# ls $'one
> two'
one?two
we have some simple exported resource tests, but they use the catalog as the source of resources, which does not contain the tags. so i think any tests around this will have to go into pe_acceptance_tests
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Eric Thompson assigned an issue to Eric Thompson Puppet / PUP-6670 Newlines break Puppet tag validation Change By: Eric Thompson Assignee: qa Eric Thompson Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Charlie Sharpsteen commented on PUP-6670 Re: Newlines break Puppet tag validation If we're lucky, all "automatic" tags are added through the tag_if_valid function, which silently discards strings that don't pass the regex: https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/tagging.rb#L42 That was the case for the issue that uncovered this bug: resource titles were being added to the tag set if they passed the regex. Additionally, having an invalid tag attached to a resource didn't seem to bother the agent at all. Puppet runs were succeeding and catalogs were being applied without error and successful reports were being sent back. The reason we noticed the issue was that exported resources weren't available for collection, which led us to notice the catalog in PuppetDB was months out of date, which led to the error messages about new catalogs being rejected due to bad tags. So, agent-side testing might not uncover any errors when invalid tags are being accepted. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Henrik Lindberg commented on PUP-6670 Re: Newlines break Puppet tag validation I was just saying that tags may come from "puppet resource". One way would be to create a file with a newline in its filename (horrible, but that is what people are doing), and then get puppet resource to generate a resource. That would test if puppet resource would exercise a different code path than that used by the compiler / apply. I am not sure what the result will be. I am also not sure if such a test is needed. What we want to ensure is that tags never end up containing illegal characters. Fixing this may reveal other problems with tagging (such as attempting to tag with newlines without appropriate filtering; but each such problem should be treated as a separate ticket. (Ping Kranium Gikos) Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title
Eric Thompson commented on PUP-6670
Re: Newlines break Puppet tag validation
hmmm... Henrik Lindberg i'm not clear on how i could get puppet resource to generate resources based on system state. i don't think you can use puppet code in a resource attribute value via puppet resource:
[root@h62o539kxvp8rso ~]# puppet resource file /tmp/blah ensure=present content='$::uptime'
Notice: /File[/tmp/blah]/content: content changed '{md5}213bb22700c84651b3b717d0a52a94d6' to '{md5}436b94998775021e93ea0fb687287db8'
file { '/tmp/blah':
ensure => 'file',
content => '{md5}436b94998775021e93ea0fb687287db8',
}
[root@h62o539kxvp8rso ~]# cat /tmp/blah
$::uptime[root@h62o539kxvp8rso ~]#
maybe there is an implicit way, like the resource name comes from some other puppet resource containing system state?
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Henrik Lindberg commented on PUP-6670 Re: Newlines break Puppet tag validation I meant when using "puppet resource" and it generates resources from the state of the node/host/machine the agent is running on - since it generates resource descriptions and they may contain tags (but I don't know if the actually do), and those tags may be generated a different way then when the compiler is compiling a catalog. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Eric Thompson commented on PUP-6670 Re: Newlines break Puppet tag validation thanks Henrik Lindberg what does agent's state mean above and how would that alter the tags when generating resources? is this like when using, say #map, with an array of namevars, that might depend on some agent state, to generate resources? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Henrik Lindberg commented on PUP-6670 Re: Newlines break Puppet tag validation There are several ways to get tags; automatically from the titles of resources and their containers, or by explicit tagging. There are rules for what tags may contain, and those rules were not enforced everywhere. Thus, the logic that set unfiltered tags from titles managed to create corrupt tags. One area not looked into is tags being set by the resource framework when resources are generated from the agent's state. Not sure if that is covered by unit tests. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Henrik Lindberg commented on PUP-6670 Re: Newlines break Puppet tag validation The reason it was reverted is because there was a desire to keep stable unchanged, not because the change actually broke anything. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Eric Thompson commented on PUP-6670 Re: Newlines break Puppet tag validation what CI did this not pass at first? I'm curious how we might want to test this in pe_acceptance_tests. or... is there a way to test it in puppet acceptance? are we talking about automatic resource tagging here? i'd think they'd be in the catalog, or we could test with puppet agent --test --tags? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Henrik Lindberg commented on PUP-6670 Re: Newlines break Puppet tag validation Thanks Branan Riley and I agree about how we should deal with tickets when we need to handle a situation like this. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Branan Riley commented on PUP-6670 Re: Newlines break Puppet tag validation I think if we have to do this in the future: We should have left this in PDS as blocked, and opened a new ticket in AP to track the revert (and revert-revert). That way we could have avoided bouncing it around between team sprints. Sean McDonald Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Branan Riley updated an issue Puppet / PUP-6670 Newlines break Puppet tag validation Change By: Branan Riley Team: Agent & Platform Puppet Developer Support Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Branan Riley updated an issue Puppet / PUP-6670 Newlines break Puppet tag validation Change By: Branan Riley Sprint: AP PDS 2016-10-05, AP 2016-09-21 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Branan Riley commented on PUP-6670 Re: Newlines break Puppet tag validation Maggie Dreyer It looks like the last stage this hit before we pulled it was "Ready for CI", so I think it probably should go back into a PDS sprint as "ready for test". /cc Henrik Lindberg - Heads up that I'm changing your sprint. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Maggie Dreyer commented on PUP-6670 Re: Newlines break Puppet tag validation This passed CI again after being unreverted; was there still more validation work needed, or is it finished? Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Maggie Dreyer assigned an issue to qa Puppet / PUP-6670 Newlines break Puppet tag validation Change By: Maggie Dreyer Status: Ready for CI Test Assignee: Sean McDonald qa Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Geoff Nichols assigned an issue to Sean McDonald Puppet / PUP-6670 Newlines break Puppet tag validation Change By: Geoff Nichols Assignee: Kylo Ginsberg Sean McDonald Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Kylo Ginsberg assigned an issue to Kylo Ginsberg Puppet / PUP-6670 Newlines break Puppet tag validation Change By: Kylo Ginsberg Assignee: Sean McDonald Kylo Ginsberg Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6670 Newlines break Puppet tag validation Change By: Geoff Nichols Sprint: Windows AP 2016- 09 10 - 21 05 , AP 2016-09-21 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Geoff Nichols updated an issue Puppet / PUP-6670 Newlines break Puppet tag validation Change By: Geoff Nichols Sprint: Windows 2016-09-21, AP 2016-09-21 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Branan Riley commented on PUP-6670 Re: Newlines break Puppet tag validation Pulled this into our sprint and marked it blocked. This is all set for Sean McDonald to pick up when he's done with the 4.7.0 stuff Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Branan Riley updated an issue Puppet / PUP-6670 Newlines break Puppet tag validation Change By: Branan Riley Sprint: Language 2016-09-07, PDS APS 2016-09-21 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Branan Riley assigned an issue to Sean McDonald Puppet / PUP-6670 Newlines break Puppet tag validation Change By: Branan Riley Assignee: Sean McDonald Team: Agent & Platform Support Scrum Team: Language Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Branan Riley commented on PUP-6670 Re: Newlines break Puppet tag validation I've updated the fix version to 4.7.1, and bumped this back to "Ready for Engineering". Once we tag 4.7.0 we'll revert the revert and get this back in for the next Z Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Branan Riley updated an issue Puppet / PUP-6670 Newlines break Puppet tag validation Change By: Branan Riley Fix Version/s: PUP 4.6.3 Fix Version/s: PUP 4.7.1 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Sean McDonald commented on PUP-6670 Re: Newlines break Puppet tag validation Henrik Lindberg Charlie Sharpsteen This commit has been removed from stable, as we need the 4.7.0 release to be as small as possible from a component standpoint (since we are updating to a new ruby) /cc Geoff Nichols Branan Riley Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6670 Newlines break Puppet tag validation Change By: Henrik Lindberg Sprint: Language 2016-09-07, Language PDS 2016-09-21 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-6670 Newlines break Puppet tag validation Change By: Kenn Hussey Sprint: Language 2016-09-07 , Language 2016-09-21 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Henrik Lindberg commented on PUP-6670 Re: Newlines break Puppet tag validation cherry picked commit to stable and merged stable to master Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6670 Newlines break Puppet tag validation Change By: Henrik Lindberg Fix Version/s: PUP 4.6.3 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Henrik Lindberg commented on PUP-6670 Re: Newlines break Puppet tag validation ok, Charlie Sharpsteen I can merge it to stable for 4.6.3 / 4.7.z whatever comes first. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Charlie Sharpsteen commented on PUP-6670 Re: Newlines break Puppet tag validation Dang it, I meant to target this at the stable branch instead of master. Since this causes PuppetDB to fairly silently reject catalogs, it would be great to get it into a 4.7.z release. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6670 Newlines break Puppet tag validation Change By: Henrik Lindberg Acceptance Criteria: That a tag containing a new-line results in an error. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6670 Newlines break Puppet tag validation Change By: Henrik Lindberg Component/s: DOCS Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Henrik Lindberg commented on PUP-6670 Re: Newlines break Puppet tag validation merged to master at: 5bf4d5d Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6670 Newlines break Puppet tag validation Change By: Henrik Lindberg Fix Version/s: PUP 4.8.0 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Henrik Lindberg assigned an issue to Charlie Sharpsteen Puppet / PUP-6670 Newlines break Puppet tag validation Change By: Henrik Lindberg Assignee: Charlie Sharpsteen Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title John Duarte updated an issue Puppet / PUP-6670 Newlines break Puppet tag validation Change By: John Duarte QA Risk Assessment: Medium Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title John Duarte updated an issue Puppet / PUP-6670 Newlines break Puppet tag validation Change By: John Duarte QA Status: Reviewed Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title John Duarte updated an issue Puppet / PUP-6670 Newlines break Puppet tag validation Change By: John Duarte QA Risk Assessment Reason: Unlikely to regress, but should be validated on Windows Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-6670 Newlines break Puppet tag validation Change By: Henrik Lindberg Story Points: 1 Release Notes Summary: Tags containing newlines caused problems in Puppet DB as they were silently accepted when compiling a catalog. Now an error will be raised when compiling. Sprint: Language 2016-09-07 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6670) Newlines break Puppet tag validation
Title: Message Title Charlie Sharpsteen created an issue Puppet / PUP-6670 Newlines break Puppet tag validation Issue Type: Bug Affects Versions: PUP 4.6.1 Assignee: Unassigned Components: Language Created: 2016/09/01 9:03 AM Labels: compiler Priority: Major Reporter: Charlie Sharpsteen The Puppet compiler uses the following regex to determine whether or not a tag\ is valid: ^[0-9A-Za-z_][0-9A-Za-z_:.-]*$
