Jira (PUP-6713) Vim should highlight data types in a class definition
Title: Message Title Branan Riley updated an issue Puppet / PUP-6713 Vim should highlight data types in a class definition Change By: Branan Riley Labels: help_wanted Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6713) Vim should highlight data types in a class definition
Title: Message Title Henrik Lindberg commented on PUP-6713 Re: Vim should highlight data types in a class definition The stale/abandoned vim and emacs support in the PUP repo has been removed in Puppet 5.0.0. Please see https://github.com/rodjek/vim-puppet and log any issues there. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6713) Vim should highlight data types in a class definition
Title: Message Title Maggie Dreyer updated an issue Puppet / PUP-6713 Vim should highlight data types in a class definition Change By: Maggie Dreyer Labels: help_wanted triaged Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6713) Vim should highlight data types in a class definition
Title: Message Title Henrik Lindberg commented on PUP-6713 Re: Vim should highlight data types in a class definition There are many things not working: string interpolation is most certainly broken differentiation of whitespace before brackets is not supported differentiation of new line containing whitespace before () is not supported bare words, hyphen rules are probably not correct type names are probably not correct functions are only recognized if they are in a hard coded list keywords are missing doubt it does the right thing on unquoted numbers Not sure it helps with individual tickets for all of these as the existing implementation is flawed. At the moment it is better with all of these problems under one umbrella ticket. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You
Jira (PUP-6713) Vim should highlight data types in a class definition
Title: Message Title Paul Anderson commented on PUP-6713 Re: Vim should highlight data types in a class definition Tobias Wolter, PUP-6725 opened and linked Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6713) Vim should highlight data types in a class definition
Title: Message Title Tobias Wolter commented on PUP-6713 Re: Vim should highlight data types in a class definition If this triggers a syntax file overhaul, be advised that heredocs are broken in a similar fashion. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6713) Vim should highlight data types in a class definition
Title: Message Title Henrik Lindberg commented on PUP-6713 Re: Vim should highlight data types in a class definition I took a quick look at the highlighter code - it has not changed since 2010 and even at that point in time it could not have done a good job. While it may be possible to shoehorn support for parameter type definitions there are a lot of things missing or just downright wrong. Looks like a rewrite is needed as the entire thing needs to be constructed from the bottom up in a way that allows things to be lexically recognized and then semantically interpreted depending on context. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6713) Vim should highlight data types in a class definition
Title: Message Title Paul Anderson commented on PUP-6713 Re: Vim should highlight data types in a class definition Some additional investigation has been done between Tobias Wolter and myself: I wrote a quick puppet manifest to install a puppet developer environment (specifically vim, vim-puppet and puppet-lint): https://gist.github.com/hpcprofessional/03100e873b244da48f46fcd1d207bdb2 I saw some inconsistent behavior between puppetlabs/puppet-syntax-vim and rodjek/puppet-vim, and Tobias Wolter did too. A screen shot of a slightly more complicated example is attached. Notice the issue starts on line 8: Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6713) Vim should highlight data types in a class definition
Title: Message Title Paul Anderson updated an issue Puppet / PUP-6713 Vim should highlight data types in a class definition Screen shots provided by Tobias Wolter Change By: Paul Anderson Attachment: Screenshot from 2016-09-20 13-28-50.png Attachment: Screenshot from 2016-09-20 13-38-20.png Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6713) Vim should highlight data types in a class definition
Title: Message Title Tobias Wolter commented on PUP-6713 Re: Vim should highlight data types in a class definition Reporter here, spent a couple of minutes trying to fix it with setting a syntax region that recognizes the brackets after the data type, but that didn't seem to lead anywhere due to lack of vimfu on my side. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6713) Vim should highlight data types in a class definition
Title: Message Title Paul Anderson updated an issue Puppet / PUP-6713 Vim should highlight data types in a class definition Change By: Paul Anderson Attachment: Screen Shot 2016-09-19 at 15.24.07.png Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6713) Vim should highlight data types in a class definition
Title: Message Title
Paul Anderson commented on PUP-6713
Re: Vim should highlight data types in a class definition
Additional info:
User provided a sample use case trying to validate paths. Here is a sample:
class vim_syntax
Unknown macro: { Pattern[/A[A-Za-z_-1-9 ./] $path_to_somewhere Pattern[/A[A-Za-z_-1-9 ./] $path_to_somewhere_else String $my_string }
For convenience, here is the regex in action: http://rubular.com/r/yPZ9EQsIBn
Suspect code is here: https://github.com/rodjek/vim-puppet/blob/d881b93dc4a8ed1374ad44439aeeb47808a6b91a/syntax/puppet.vim#L19-L28
Add Comment
This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6713) Vim should highlight data types in a class definition
Title: Message Title Paul Anderson updated an issue Puppet / PUP-6713 Vim should highlight data types in a class definition Change By: Paul Anderson Environment: https://github.com/puppetlabs/puppet-syntax-vim also https://github.com/rodjek/vim-puppet on Vim 7 , code that includes .4 on Ubuntu/Debian Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6713) Vim should highlight data types in a class definition
Title: Message Title Paul Anderson commented on PUP-6713 Re: Vim should highlight data types in a class definition I started a private e-mail chain with the user to get some additional details that were not in the tweets. I will post updates as they become available. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6713) Vim should highlight data types in a class definition
Title: Message Title Eric Sorenson assigned an issue to Lindsey Smith Puppet / PUP-6713 Vim should highlight data types in a class definition Change By: Eric Sorenson Assignee: Eric Sorenson Lindsey Smith Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6713) Vim should highlight data types in a class definition
Title: Message Title Eric Sorenson updated an issue Puppet / PUP-6713 Vim should highlight data types in a class definition Change By: Eric Sorenson Team: Puppet Developer Support Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6713) Vim should highlight data types in a class definition
Title: Message Title Eric Sorenson commented on PUP-6713 Re: Vim should highlight data types in a class definition Lindsey Smith the vim syntax highliter plugin is a popular development tool and it's languished with respect to new language features. Something for team to consider. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-6713) Vim should highlight data types in a class definition
Title: Message Title Paul Anderson created an issue Puppet / PUP-6713 Vim should highlight data types in a class definition Issue Type: New Feature Affects Versions: PUP 4.6.2 Assignee: Eric Sorenson Components: Community Created: 2016/09/19 1:13 PM Environment: https://github.com/puppetlabs/puppet-syntax-vim also https://github.com/rodjek/vim-puppet on Vim 7, code that includes Priority: Normal Reporter: Paul Anderson Source: @towo on Twitter https://twitter.com/towo/status/777600724985315328 Does anybody have a puppet.vim that actually does highlighting of data types in a class definition? Pattern[...] breaks a lot of things.— Tobias Wolter (@towo) September 18, 2016 @puppetize You lot maybe? Even your officialish repo (https://t.co/lSVtsu6J77) is broken in that regard.— Tobias Wolter (@towo) September 18, 2016
