Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2020-04-22 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-7507  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: puppet lookup --facts  can't modify $facts hash   
 

  
 
 
 
 

 
 One problem with the way this was implemented is that the supplied facts are added to the node after classification. So you can reference the facts in your hiera config and manifests, but you can't override facts used for classification (trusted facts or otherwise). I'll file a separate ticket about that.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.190026.149437729.44890.1587598140029%40Atlassian.JIRA.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2018-01-23 Thread Branan Riley (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Branan Riley updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7507 
 
 
 
  puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 

Change By:
 
 Branan Riley 
 
 
 

Fix Version/s:
 
 PUP 4.10.z 
 
 
 

Fix Version/s:
 
 PUP 5.3.4 
 
 
 

Fix Version/s:
 
 PUP 4.10.10 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-30 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg assigned an issue to Eric Delaney 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7507 
 
 
 
  puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Assignee:
 
 Eric Delaney 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-30 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-7507 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 
 
Assigning to Eric Delaney (I think this ticket is now ready to be resolved, but delegating to let you decide). 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-30 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-7507 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 
 
Created PUP-8220 for the trusted facts discussion. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-30 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-7507 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 
 
I think we should open a separate ticket regarding the handling of trusted facts as this ticket is about a different specific problem that is now solved, and we need to move that along. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-29 Thread Thomas Hallgren (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren commented on  PUP-7507 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 
 
Gerhardus Geldenhuis, I agree that specifying a --facts file would supersede anything else. My concern is that some of the trusted facts are derived from other facts. In other words, what's provided in the --facts file might contradict itself. I'd like to know how that should be handled. 
Henrik Lindberg, specifying all of trusted seems weird. Isn't the normal use-case that you would rely on the derived trusted facts and specify the extensions? 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg assigned an issue to Unassigned 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7507 
 
 
 
  puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Assignee:
 
 Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-7507 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 
 
We could use --facts to simply set the facts (including trusted). That naturally requires specifying all the values you want. We could also add a --merge_facts to use deep merge to merge values into facts obtained for the node. That could be useful in debugging a small change that has not yet taken effect on the node since it allows you to specify only the fact that you need to override). (Alternatively always specify facts with --facts and let --merge_facts be a boolean flag). 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-29 Thread Eric Delaney (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Eric Delaney assigned an issue to Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7507 
 
 
 
  puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 

Change By:
 
 Eric Delaney 
 
 
 

Assignee:
 
 Eric Delaney Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-29 Thread Gerhardus Geldenhuis (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Gerhardus Geldenhuis commented on  PUP-7507 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 
 
Thomas Hallgren my view would be that if you specify a fact via puppet lookup it should supersede everything else. I view --facts as primarily a debugging tool. It should override anything else that is already set and as long as the behaviour clearly documented then it is not a problem. Henrik Lindberg if you need to specify all of trusted to work then that needs to be very clearly documented. My assumption with specifying additional facts with --facts is that it would override and merge. I was not aware that it was an all or nothing approach.  
My view with this has been that it is a debugging aide to be able to specify facts with --facts if you have to build a large amount of "scaffolding" to get it to work properly/correctly then its usefulness diminishes. It might very well be that the intent of the tool is entirely different but then that should be made really clear in the documentation.  
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-7507 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 
 
You need to specify all of trusted for it to work - don't imagine that we will start supporting deep merge in this context. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-29 Thread Thomas Hallgren (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren commented on  PUP-7507 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 
 
No, my example is wrong. Should read: 
 
 
 
 
 
 
{ 'trusted => { domain' => 'other.name'} }
 
 
 
 
 
 
 
The real problem is that much of the trusted information is derived from other facts and, for obvious reasons, not designed to be modified once it's set. We need to specify how ambiguities are resolved when explicitly given values conflict with derived ones. Which take precedence? Is it an error? 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-29 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-7507 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 
 
Thomas Hallgren Does it actually support dotted keys to provide values inside hashes? As I imagine this working is that you would have to provide the entire hash for trusted (as a fact) - the same way as it gets loaded from PDB when a node's "parameters" are read. It is ok to allow manipulation of trusted information since user must be on the master to run this and need to have a way to do "what-if" including trusted information. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-28 Thread Eric Delaney (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Eric Delaney commented on  PUP-7507 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 
 
Gerhardus Geldenhuis Could I get you to create a separate ticket for the 'trusted' case and what you see as the problem. That way we won't lose the issue and we can work on it there. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-28 Thread Thomas Hallgren (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren commented on  PUP-7507 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 
 
The PR does not address trusted facts (it was created before Gerhardus Geldenhuis replied to my question). 
Henrik Lindberg, I didn't perceive it as we reach a conclusion. Some of the trusted facts are derived from other facts and it's not trivial to just allow them to be overridden. It also raises a couple of questions. What would it meant to provide both 
 
 
 
 
 
 
{ 'clientcert' => 'some.domain.name' }
 
 
 
 
 
 
 
and 
 
 
 
 
 
 
{'trusted.domain' => 'other.name'}
 
 
 
 
 
 
 
? Also, should be allowed to override 'trusted.authenticated'? 
A middle ground could be to allow 'trusted.extensions' since they don't seem to be derived from anything. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 

Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-28 Thread Gerhardus Geldenhuis (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Gerhardus Geldenhuis commented on  PUP-7507 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 
 
Eric Delaney does this also resolve the issue for trusted facts? 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-28 Thread Eric Delaney (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Eric Delaney commented on  PUP-7507 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 
 
Tested on SHA=5db2a7ea45c377429a62761b401ca066b55f15b6 SUITE_VERSION=1.10.8.116.g5db2a7e 
Using the reproduce above: 
 
 
 
 
 
 
[root@xltdnqmuemyejo7 ~]# puppet lookup ntp::servers --environment production --facts ./facts.yaml 
 
 
 
 
--- 1.2.3.4 
 
 
 
 
... 
 
 
 
 
[root@xltdnqmuemyejo7 ~]#
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups 

Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-27 Thread Eric Delaney (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Eric Delaney assigned an issue to Eric Delaney 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7507 
 
 
 
  puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 

Change By:
 
 Eric Delaney 
 
 
 

Assignee:
 
 Eric Delaney 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-20 Thread Eric Delaney (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Eric Delaney updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7507 
 
 
 
  puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 

Change By:
 
 Eric Delaney 
 
 
 

QA Risk Assessment Reason:
 
 We should make a test for this in puppet and facter 
 
 
 

QA Risk Assessment:
 
 Needs Assessment Automate 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-17 Thread Melissa Stone (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Melissa Stone commented on  PUP-7507 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 
 
This has passed CI 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-16 Thread Gerhardus Geldenhuis (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Gerhardus Geldenhuis commented on  PUP-7507 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 
 
Perhaps to be absolutely clear, my expectation is that I should be able to fully simulate an actual hiera lookup with a combination of facts provided via --facts which should be compatible with what I would get if I did a facter -y or -j and also be compatible with the output of any fact hashes like trusted and lastly combine anything remaining from PuppetDB if available. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-16 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-7507 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 
 
Thomas Hallgren I think we ended up with the idea of allowing the key trusted in the given facts, to be treated as the information that ends up in $trusted - that would be the same way this gets done when a node's data is obtained from PDB. Not sure that is tested though. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-16 Thread Gerhardus Geldenhuis (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Gerhardus Geldenhuis commented on  PUP-7507 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 
 
Thomas Hallgren I was expecting the following to be made available to my hiera hierarchy via a custom file passed via --facts : ``` — trusted: extensions: Company: Puppet pp_zone: INTERNAL pp_datacenter: London pp_environment: Production ``` 
I am using a number of custom extensions and an extract from my hierarchy looks as follows: hierarchy: ``` -name: "Company Group Name" path: "company/% {trusted.extensions.Company} 
.yaml" -name: "Datacenter" path: "datacenter/% {trusted.extensions.pp_datacenter} 
.yaml" ``` 
I have named my custom extensions using $confdir/custom_trusted_oid_mapping.yaml but that should not matter. 
The original intend was to use puppet lookup as a cheaper way of testing and verifying my hierarchy since currently beaker( which is probably better) has a bit of a steep learning curve, not helped by very poor documentation. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-16 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7507 
 
 
 
  puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Sprint:
 
 Platform Core KANBAN 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-16 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7507 
 
 
 
  puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Release Notes Summary:
 
 The {{lookup}} command line tool did not set facts given on the command line such that they ended up in {{$facts}} variable. 
 
 
 

Release Notes:
 
 Bug Fix 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-16 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg assigned an issue to Unassigned 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7507 
 
 
 
  puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Assignee:
 
 Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-16 Thread Thomas Hallgren (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren assigned an issue to Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7507 
 
 
 
  puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 

Change By:
 
 Thomas Hallgren 
 
 
 

Assignee:
 
 Thomas Hallgren Henrik Lindberg 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-16 Thread Thomas Hallgren (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Thomas Hallgren commented on  PUP-7507 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 
 
Solving the problem properly setting the facts hash is relatively easy but I have a question regarding the expectations on trusted hash. 
I tested by passing a  { 'clientcert' => 'some.domain.name' } 
 as a fact and by doing so, the explain for the 'trusted' value outputs: 
 
 
 
 
 
 
Found key: "trusted" value: { 
 
 
 
 
  "authenticated" => "local", 
 
 
 
 
  "certname" => "some.domain.name", 
 
 
 
 
  "extensions" => {}, 
 
 
 
 
  "hostname" => "some", 
 
 
 
 
  "domain" => "domain.name'" 
 
 
 
 
}
 
 
 
 
 
 
 
This looks OK to me. Gerhardus Geldenhuis, do you expect to be able to pass trusted facts verbatim in the facts file or is what I just described OK? 
 
 
 
 
 
 
 
 
 
 
 
 
   

Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-16 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-7507 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 
 
Depending on what the issue is, I would like this fixed on 4.x. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-16 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7507 
 
 
 
  puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Fix Version/s:
 
 PUP 4.10.z 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-16 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-7507 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 
 
Thanks for the reproducer Craig Dunn! That helps us look into this. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-16 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg assigned an issue to Thomas Hallgren 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7507 
 
 
 
  puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Assignee:
 
 Thomas Hallgren 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-16 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7507 
 
 
 
  puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Fix Version/s:
 
 PUP 5.4.0 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-16 Thread Gerhardus Geldenhuis (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Gerhardus Geldenhuis commented on  PUP-7507 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 
 
I can confirm that the same problem exists for $trusted hash. Passing trusted facts via --facts gets ignored when running puppet lookup from the command line. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-11-16 Thread Craig Dunn (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Craig Dunn commented on  PUP-7507 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 
 
I'm seeing this problem too. 
Configuration of Hiera 
 
 
 
 
 
 
[root@puppet /]# cat /etc/puppetlabs/code/environments/production/hiera.yaml 
 
 
 
 
  
 
 
 
 
--- 
 
 
 
 
version: 5 
 
 
 
 
  
 
 
 
 
defaults:  
 
 
 
 
  datadir: data 
 
 
 
 
  data_hash: yaml_data 
 
 
 
 
  
 
 
 
 
hierarchy: 
 
 
 
 
  - name: "env" 
 

Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-10-25 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg commented on  PUP-7507 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 
 
A unit or acceptance test that shows the problems (or that asserts that they are fixed?) would be great. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-05-18 Thread Moses Mendoza (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Moses Mendoza updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7507 
 
 
 
  puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 

Change By:
 
 Moses Mendoza 
 
 
 

Team:
 
 Agent 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-05-16 Thread Josh Cooper (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Josh Cooper updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7507 
 
 
 
  puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 

Change By:
 
 Josh Cooper 
 
 
 

Labels:
 
 hiera  triaged 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-05-16 Thread Josh Cooper (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Josh Cooper commented on  PUP-7507 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 
 
puppet lookup --facts  should consume facts that are generated from facter --json 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-05-15 Thread Henrik Lindberg (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Henrik Lindberg updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7507 
 
 
 
  puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 

Change By:
 
 Henrik Lindberg 
 
 
 

Component/s:
 
 Hiera & Lookup 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-7507) puppet lookup --facts can't modify $facts hash

2017-05-09 Thread Nicholas Fagerlund (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Nicholas Fagerlund created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-7507 
 
 
 
  puppet lookup --facts  can't modify $facts hash  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Created:
 

 2017/05/09 5:48 PM 
 
 
 

Labels:
 

 hiera 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 Nicholas Fagerlund 
 
 
 
 
 
 
 
 
 
 
I was trying to simulate a change to my $facts['networking'] fact, so I ran facter --json > ~/Desktop/facts.json, edited the appropriate spot, and tried to pass that to puppet lookup --facts. No dice: my change was ignored.  
That's because I was using facts.networking in my hierarchy, and apparently --facts doesn't actually set the $facts variable — it just sets top-scope variables with names from the JSON.  
 

Problem one: That's unexpected, and it interferes with using facter --json as a basis for simulating other nodes.
 
 
So, I tried wrapping the facts json in another object with only a "facts": key. Which resulted in the following error: "Error: Could not run: Attempt to assign to a reserved variable name: 'facts'" 
 

Problem two: If your hierarchy uses the $facts variable like we recommend (instead of ::factname vars), it's impossible to simulate any changes with the puppet lookup CLI. I expect this blocks setting other values for $trusted or