Jira (PUP-8486) Warning for undefined variables is slow in jruby
Title: Message Title Enis Inan updated an issue Puppet / PUP-8486 Warning for undefined variables is slow in jruby Change By: Enis Inan Fix Version/s: PUP 5.5.z Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8486) Warning for undefined variables is slow in jruby
Title: Message Title Enis Inan updated an issue Puppet / PUP-8486 Warning for undefined variables is slow in jruby Change By: Enis Inan Fix Version/s: PUP 5.5.1 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8486) Warning for undefined variables is slow in jruby
Title: Message Title Henrik Lindberg commented on PUP-8486 Re: Warning for undefined variables is slow in jruby Merged to 5.5.x branch at a6f4e90 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8486) Warning for undefined variables is slow in jruby
Title: Message Title Henrik Lindberg assigned an issue to Unassigned Puppet / PUP-8486 Warning for undefined variables is slow in jruby Change By: Henrik Lindberg Assignee: Patrick Carlisle Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8486) Warning for undefined variables is slow in jruby
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-8486 Warning for undefined variables is slow in jruby Change By: Henrik Lindberg Fix Version/s: PUP 5.5.z Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8486) Warning for undefined variables is slow in jruby
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-8486 Warning for undefined variables is slow in jruby Change By: Henrik Lindberg Release Notes Summary: Internal performance related issue - not user facing. Sprint: Platform Core KANBAN Release Notes: Not Needed Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8486) Warning for undefined variables is slow in jruby
Title: Message Title Henrik Lindberg commented on PUP-8486 Re: Warning for undefined variables is slow in jruby I put up a PR - the logic needing change was actually in Puppet - so no need to change the hiera gem. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8486) Warning for undefined variables is slow in jruby
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-8486 Warning for undefined variables is slow in jruby Change By: Henrik Lindberg Fix Version/s: PUP 6.0.0 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8486) Warning for undefined variables is slow in jruby
Title: Message Title Henrik Lindberg assigned an issue to Patrick Carlisle Puppet / PUP-8486 Warning for undefined variables is slow in jruby Change By: Henrik Lindberg Assignee: Patrick Carlisle Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8486) Warning for undefined variables is slow in jruby
Title: Message Title Patrick Carlisle commented on PUP-8486 Re: Warning for undefined variables is slow in jruby It seems worth it to me. I don't like having it in one more place either but it would probably be pretty small. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8486) Warning for undefined variables is slow in jruby
Title: Message Title Henrik Lindberg commented on PUP-8486 Re: Warning for undefined variables is slow in jruby Do you think it is worth making the change in hiera 3? It would need to catch the not-found and issue a warning or an error under the control of the strictness settings. (it would be yet another place where this takes place - there are two already; the one you linked to for the general case of logic not handling the throw, and one in the evaluator. The places where this is handled are different in terms of the knowledge they have about the context and it is difficult to have them share an implementation - same thing with the hiera case. It could be an improvement though as hiera could provide information regarding the context in which it looks up the variable which I think is missing as it is now. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8486) Warning for undefined variables is slow in jruby
Title: Message Title Patrick Carlisle commented on PUP-8486 Re: Warning for undefined variables is slow in jruby https://github.com/puppetlabs/puppet/blob/master/lib/puppet/parser/scope.rb#L525-L544 If you're not in strict mode it doesn't fail. The exception gets caught here and turned into a warning, which I think is consistent with non-strict mode in general. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8486) Warning for undefined variables is slow in jruby
Title: Message Title Henrik Lindberg commented on PUP-8486 Re: Warning for undefined variables is slow in jruby Irrespective of my earlier comment, it would naturally be better if the hiera implementation was explicit about "not found variable", but it should probably then also check if in strict mode for missing variables etc. I am however nervous about making any changes to hiera 3 due to lack of test coverage. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8486) Warning for undefined variables is slow in jruby
Title: Message Title Henrik Lindberg commented on PUP-8486 Re: Warning for undefined variables is slow in jruby Well, shouldn't those fail in that case? And if so, does it really matter if it fails a bit more slowly? Or is there a rescue higher up that turns the error into some kind of "not found"? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8486) Warning for undefined variables is slow in jruby
Title: Message Title Patrick Carlisle commented on PUP-8486 Re: Warning for undefined variables is slow in jruby Coming back to this, it looks like it's the calls to lookupvar here that can fail without a catch https://github.com/puppetlabs/puppet/blob/master/lib/hiera/scope.rb#L23-L25 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8486) Warning for undefined variables is slow in jruby
Title: Message Title Patrick Carlisle commented on PUP-8486 Re: Warning for undefined variables is slow in jruby Based on further conversation with Henrik outside of this ticket I think this can be fixed by adding a catch in our code somewhere so it doesn't fall back to raising an exception. I'm investigating. Add Comment This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8486) Warning for undefined variables is slow in jruby
Title: Message Title Josh Cooper commented on PUP-8486 Re: Warning for undefined variables is slow in jruby Henrik Lindberg We should always be doing perf measurements for compiler code against jruby. Soon it will be the only supported server stack. Add Comment This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8486) Warning for undefined variables is slow in jruby
Title: Message Title Henrik Lindberg commented on PUP-8486 Re: Warning for undefined variables is slow in jruby We need supported code paths to be fast and still handle when people just call scope and do not handle the error case. We found that a throw is much faster than a raise. At the point (in scope) where a variable is referenced it cannot be determined what a missing var should result in - hence the gymnastics of a throw followed by an exception if the throw was unhandled. Change is certainly possible, but it must be considered API. Add Comment This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8486) Warning for undefined variables is slow in jruby
Title: Message Title Patrick Carlisle commented on PUP-8486 Re: Warning for undefined variables is slow in jruby I only found a couple places that either the throw or raise would be caught and it's not skipping any code paths, just returning a sentinel would work as well and not be as goto-like. It's possible I'm missing some cases though. It also seems like depending on the code path here the warning message is different for the same error. Add Comment This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8486) Warning for undefined variables is slow in jruby
Title: Message Title Henrik Lindberg commented on PUP-8486 Re: Warning for undefined variables is slow in jruby They are both needed as it is implemented now - the throw may occur in a context where there is no catcher, and a throw is much faster than always generating an exception (at least on MRI). We did however not optimize for the warning case (error case not needed since it is going to stop anyway), so worth revisiting. Add Comment This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8486) Warning for undefined variables is slow in jruby
Title: Message Title Patrick Carlisle created an issue Puppet / PUP-8486 Warning for undefined variables is slow in jruby Issue Type: Improvement Assignee: Unassigned Created: 2018/02/22 4:13 PM Priority: Normal Reporter: Patrick Carlisle The use of exceptions here https://github.com/puppetlabs/puppet/blob/master/lib/puppet/parser/scope.rb#L530-L543 when running in :warning mode (the default) is slow on JRuby. With a single undefined variable referenced in my hiera hierarchy I found handling this without exceptions resulted in a 20% runtime improvement. I suspect both the throw and the exceptions are unnecessary. Add Comment This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574)
