Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Josh Cooper assigned an issue to Unassigned Puppet / PUP-8562 File performance nearly twice as slow after update Change By: Josh Cooper Assignee: Josh Cooper Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Josh Cooper commented on PUP-8562 Re: File performance nearly twice as slow after update Verified 5.3.5 with 200 empty file resources takes 19.33 seconds: $ time bx puppet agent -t --server orcdhca1u7lulpb.delivery.puppetlabs.net Info: Using configured environment 'production' Info: Retrieving pluginfacts Info: Retrieving plugin Info: Retrieving locales Info: Caching catalog for chara.corp.puppetlabs.net Info: Applying configuration version '1523049920' Notice: Applied catalog in 19.33 seconds bundle exec puppet agent -t --server orcdhca1u7lulpb.delivery.puppetlabs.net 19.24s user 1.59s system 83% cpu 24.880 total While it only takes 2.94 seconds in commit c87cb14a1f2ce1729fea68381f15a0b9f381f7fd $ time bx puppet agent -t --server orcdhca1u7lulpb.delivery.puppetlabs.net Info: Using configured
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Josh Cooper assigned an issue to Josh Cooper Puppet / PUP-8562 File performance nearly twice as slow after update Change By: Josh Cooper Assignee: Josh Cooper Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Melissa Stone updated an issue Puppet / PUP-8562 File performance nearly twice as slow after update Change By: Melissa Stone QA Risk Assessment: Needs Assessment Manual Release Notes Summary: Prior to this change, we were overpopulating the context stack with the server version. This caused file resources that required source content from the master to add this to the stack with every check in. This drastically increased the time it took to parse the context stack for every request made, because there was a massive amount of redundant data in it. This change ensures we do not overpopulate the stack with duplicate information. Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Kenn Hussey commented on PUP-8562 Re: File performance nearly twice as slow after update Melissa Stone please add release notes for this issue, if needed. Thanks! Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Eric Delaney commented on PUP-8562 Re: File performance nearly twice as slow after update Merged to 5.3.x at https://github.com/puppetlabs/puppet/commit/6525ac3a68f6045a0b98bdfa5d72c9e03daf692c Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Melissa Stone assigned an issue to Melissa Stone Puppet / PUP-8562 File performance nearly twice as slow after update Change By: Melissa Stone Assignee: Kris Bosland Melissa Stone Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Kris Bosland assigned an issue to Kris Bosland Puppet / PUP-8562 File performance nearly twice as slow after update Change By: Kris Bosland Assignee: Melissa Stone Kris Bosland Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Josh Cooper updated an issue Puppet / PUP-8562 File performance nearly twice as slow after update Change By: Josh Cooper Fix Version/s: PUP 5.5.1 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Josh Cooper commented on PUP-8562 Re: File performance nearly twice as slow after update This is a problem because future requests lookup server and serverport in the context, and rely on the context raising an exception when the values aren't set (as is the case when not using server_list)). The exception message contains the entire context stack (serialized as a string). The agent rescues the exception and never looks at the message. After 100 or so requests, the exception message string has length > 200K. So the slowness is due to allocating large chunks of memory unnecessarily. We shouldn't be relying on exceptions for flow control, and the context shouldn't include stack.inspect in the exception message. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Josh Cooper assigned an issue to Melissa Stone Puppet / PUP-8562 File performance nearly twice as slow after update Change By: Josh Cooper Assignee: Josh Cooper Melissa Stone Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Josh Cooper updated an issue Puppet / PUP-8562 File performance nearly twice as slow after update Change By: Josh Cooper Fix Version/s: PUP 5.3.6 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Josh Cooper updated an issue Puppet / PUP-8562 File performance nearly twice as slow after update Change By: Josh Cooper Affects Version/s: PUP 5.3.4 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Josh Cooper commented on PUP-8562 Re: File performance nearly twice as slow after update # git bisect bad 7c29116766e33e119b67421912379cf302dc6c22 is the first bad commit commit 7c29116766e33e119b67421912379cf302dc6c22 Author: Jennifer SolmanDate: Mon Dec 11 15:42:27 2017 -0800 (PUP-8177) prevent agent from requesting locales on older server :04 04 c1c866745916524c5a8ee4fa162a5321920dd985 e4b33cf83d1547f29fbc02a5eae824d1b4406fc3 M lib :04 04 884717c67a1a4bebb33dacac36f06d89e7352351 8bb3a0f0d95eec408f4f671691a59471367a8571 M spec It looks like we're pushing the server version into the context for every http response, but never popping. And the context has an array of things to ignore. Any cache miss causes us to traverse the ignores array causing the linear slow down.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Josh Cooper commented on PUP-8562 Re: File performance nearly twice as slow after update 5.3.4 and 5.3.5 show many more stats of /etc/localtime than 5.3.3 using 200 file resources with remote puppet:///modules/... sources. # puppet --version 5.3.5 # strace -c puppet agent -t Info: Using configured environment 'production' Info: Retrieving pluginfacts Info: Retrieving plugin Info: Caching catalog for ajdsosztd6m0cqa.delivery.puppetlabs.net Info: Applying configuration version '1521778299' Notice: Applied catalog in 20.97 seconds % time seconds usecs/call callserrors syscall -- --- --- - - 36.160.020571 0203692 24913 stat 30.010.017074122014
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Josh Cooper updated an issue Puppet / PUP-8562 File performance nearly twice as slow after update Change By: Josh Cooper Attachment: fileevaltimes.png Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Josh Cooper updated an issue Puppet / PUP-8562 File performance nearly twice as slow after update Change By: Josh Cooper Attachment: fileresourceevaltimes.png Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Josh Cooper updated an issue Puppet / PUP-8562 File performance nearly twice as slow after update Change By: Josh Cooper Attachment: fileresourceevaltimes.png Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Josh Cooper commented on PUP-8562 Re: File performance nearly twice as slow after update Working with Sebastian we found the following catalog application times by puppet version: Version Time (seconds) 5.2.0 59.48 5.3.3 68.65 5.3.4 broken 5.3.5 177.12 5.4.0 163,63 5.5.0 185.17 That rules out PUP-7451 and PUP-7308. Also, the aren't using http/https file resources. In looking at the last run reports, the increase is spread out across all of the file resources being managed (as opposed to any one file). For example, the longest file resource in 5.2.0 is 0.175718651 seconds, but there are over 280 files over that time in 5.3.5, with the largest one being 0.899495322 seconds. The file evaluation distribution looks to be linear, which makes me think the issue is related to PUP-8096. As the size of the persistent transaction store depends on the number of resources being managed.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Melissa Stone assigned an issue to Josh Cooper Puppet / PUP-8562 File performance nearly twice as slow after update Change By: Melissa Stone Assignee: Melissa Stone Josh Cooper Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Melissa Stone updated an issue Puppet / PUP-8562 File performance nearly twice as slow after update Change By: Melissa Stone Sprint: Platform Core Grooming KANBAN Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Melissa Stone assigned an issue to Melissa Stone Puppet / PUP-8562 File performance nearly twice as slow after update Change By: Melissa Stone Assignee: Melissa Stone Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Josh Cooper commented on PUP-8562 Re: File performance nearly twice as slow after update Ah, my mistake, I thought you said the issues was introduced in 5.5.0, but I see you said it's 5.4.0. One thing that comes to mind is the fix for PUP-7451, whereby if the server (or load-balancer) returns an HTTP 429 or 503 response with a Retry-After header then the agent will backoff and sleep. The corresponding server change was made in SERVER-1767. If that's the case, then I would expect to see warning messages in the agent like "Received a response from the server. Sleeping for ... seconds". Another possibility is when that if you are running FIPS enabled hosts, then puppet will switch the default file checksum type from md5 to sha256. I wouldn't expect the file time to double though. /cc Melissa Stone Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Sebastian commented on PUP-8562 Re: File performance nearly twice as slow after update R.I.Pienaar mentioned that you maybe expect the graphs or metrics to be wrong. That is not the case, the observed runtime nearly doubled. I can provide a full debug run in private if you want. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Sebastian commented on PUP-8562 Re: File performance nearly twice as slow after update Alright i attached the output. We are indeed switching the environment via https://github.com/Zetten/puppet-hiera-enc. profile.txt Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Sebastian updated an issue Puppet / PUP-8562 File performance nearly twice as slow after update Change By: Sebastian Attachment: profile.txt Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Josh Cooper updated an issue Puppet / PUP-8562 File performance nearly twice as slow after update Change By: Josh Cooper Sprint: Platform Core Grooming Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Josh Cooper updated an issue Puppet / PUP-8562 File performance nearly twice as slow after update Change By: Josh Cooper Team: Coremunity Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Josh Cooper commented on PUP-8562 Re: File performance nearly twice as slow after update This may be related to PUP-920 as pluginsync is implemented by applying a file resource with a remote source. One change we made was to accumulate metrics, which makes me think the File metric may be higher now Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8562) File performance nearly twice as slow after update
Title: Message Title Scott McClellan moved an issue Puppet / PUP-8562 File performance nearly twice as slow after update Change By: Scott McClellan Affects Version/s: puppet-agent 5.4.0 Affects Version/s: PUP 5.4.0 Key: PA PUP - 1917 8562 Project: Puppet Agent Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to