Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2022-02-22 Thread Molly Waggett (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Molly Waggett updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8887  
 
 
  puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
Change By: 
 Molly Waggett  
 
 
Labels: 
 final_triage  has_workaround  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.252611.1527154195000.21475.164860476%40Atlassian.JIRA.


Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2022-02-22 Thread Molly Waggett (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Molly Waggett updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8887  
 
 
  puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
Change By: 
 Molly Waggett  
 
 
Team: 
 Froyo Phoenix  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.252611.1527154195000.21474.164860433%40Atlassian.JIRA.


Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2022-01-12 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-8887  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
 So to summarize the issue, lookup_options set in common_yaml apply, so you get the merged roles:  
 
 
 
 
 Notice: Scope(Class[main]): myhash: {key1 => value1, key2 => value2, role1 => value1, role3 => value3, role2 => value2}
  
 
 
 
  But if the lookup_options are set in firstrole.yaml then the merge doesn't happen:  
 
 
 
 
 Notice: Scope(Class[main]): myhash: {role1 => value1, role2 => value2}
  
 
 
 
  Note there's an different lookup_options caching issue in PUP-9792. In that case, a variable affecting how the hiera config is interpolated changes, but the hiera config & lookup options aren't refreshed.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)  
 
 

 
   

Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2022-01-12 Thread David McTavish (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 David McTavish updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8887  
 
 
  puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
Change By: 
 David McTavish  
 
 
Priority: 
 Normal Low  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.252611.1527154195000.19246.1642012440166%40Atlassian.JIRA.


Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2022-01-12 Thread David McTavish (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 David McTavish updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8887  
 
 
  puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
Change By: 
 David McTavish  
 
 
Labels: 
 final_triage has_workaround  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.20.2#820002-sha1:829506d)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.252611.1527154195000.19247.1642012440213%40Atlassian.JIRA.


Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2018-09-18 Thread Stefan Andres (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Stefan Andres commented on  PUP-8887  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
 We've developed a workaround for us that prevents caching the $roles variable by using loadyaml() directly in die site.pp Here's the workaround code:  
 
 
 
 
 # old  
 
 
 $roles = lookup( 'roles', Array[String], 'unique', [], ) # old style
 
 
    
 
 
 # new  
 
 
 $nodeyaml = loadyaml("/etc/puppetlabs/code/environments/production/manifests/../data/node.yaml")  
 
 
 if $nodeyaml['roles'] {  
 
 
   if $nodeyaml['roles'] !~ Array[String[1]] {  
 
 
 fail('roles: Needs to be an array of strings!')  
 
 
   } else {  
 
 
 $roles = unique($nodeyaml['roles'])  
 
 
   }  
 
 
 } else {  
 
 
   $roles = []  
 
   

Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2018-06-29 Thread Matthias Baur (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Matthias Baur commented on  PUP-8887  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
 Thanks!  Is there anything we can do to get this fixed? This is blocking us from upgrading to 5.5.x on our Puppetservers.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2018-05-28 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg assigned an issue to Thomas Hallgren  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8887  
 
 
  puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
Change By: 
 Henrik Lindberg  
 
 
Assignee: 
 Thomas Hallgren  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2018-05-28 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg commented on  PUP-8887  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
 Stefan Andres Thanks for test - that confirms that there is nothing else that is causing the problem you observed. The change to hiera was unintentional in this respect. We think that the changed logic causes an earlier binding of the lookup_options. This breaks your case since you rely on them being bound on subsequent lookups when roles have been established. We believe that the change in time for when lookup_options get bound uncovered another problem - that lookup_options are not evicted from the cache when the inputs the cached result depends on has changed. We will look into that problem as we think your use case should work (even though we do not recommend hiera configuring itself because self recursion may lead to confusion and loss of performance (the cache must be evicted). Should you want to change, you would need for the nodes to report their roles in a fact if you do not want to use an ENC.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2018-05-28 Thread Stefan Andres (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Stefan Andres assigned an issue to Unassigned  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8887  
 
 
  puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
Change By: 
 Stefan Andres  
 
 
Assignee: 
 Stefan Andres  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2018-05-28 Thread Stefan Andres (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Stefan Andres commented on  PUP-8887  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
 Thank you for taking the time to answer this!   As a matter of fact, we've migrated all nodes from a 100% ENC (own development and therefore hard to maintain vs. just using hiera) environment to a 100% hiera environment. Therefore we are really not looking into an option to implement some kind of ENC logic again (especially because hiera fulfilled all our needs until now).   When assigning the roles variable not by using lookup(), but hardcoding its values it indeed works for >puppet-agent-5.5  
 
 
 
 
 root@c312a1b640ef:/etc/puppetlabs/code/environments/production# cat manifests/site.pp  
 
 
 #$roles = lookup( 'roles', Array[String], 'unique', [], )  
 
 
 $roles = ['firstrole', 'secondrole']  
 
 
 notice("roles: $roles")  
 
 
 $ret = lookup('myhash')  
 
 
 notice("myhash: $ret")  
 
 
 $role1 = lookup('role1')  
 
 
 $role2 = lookup('role2')  
 
 
 notice("role1 var: $role1")  
 
 
 notice("role2 var: $role2")  
 
 
    
 
 

Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2018-05-25 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg assigned an issue to Stefan Andres  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8887  
 
 
  puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
Change By: 
 Henrik Lindberg  
 
 
Assignee: 
 Henrik Lindberg Stefan Andres  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2018-05-25 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg commented on  PUP-8887  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
 Looked at this again. I think the issue is that the feature convert_to requires getting the lookup options and doing that changes at what time the lookup options gets bound. Don't think that will change by reverting the commit in question. The fact remains that it is a really bad idea to have the hiera.config depend on the data it references. It is not designed to handle that. The input to the hiera.config is using must to come from facts, an ENC or from variables set in topscope in site.pp. The variables in top scope that the hiera config makes use of should not be set via a call to lookup as that makes the definition recursive/ambiguous. To make sure that the problem I describe in this comment is what is what is causing the problem - a quick test is to assign the $roles statically in site.pp and observe how that works.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2018-05-24 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg commented on  PUP-8887  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
 Not sure if it will work to just revert it, and it makes convert_to more expensive (yet another lookup of lookup_options).  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2018-05-24 Thread Thomas Hallgren (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Thomas Hallgren assigned an issue to Henrik Lindberg  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8887  
 
 
  puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
Change By: 
 Thomas Hallgren  
 
 
Assignee: 
 Thomas Hallgren Henrik Lindberg  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2018-05-24 Thread Thomas Hallgren (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Thomas Hallgren commented on  PUP-8887  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
 Henrik Lindberg, the commit that breaks this workflow, can it be reverted? Judging from the comment, it's an optimization.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2018-05-24 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg assigned an issue to Thomas Hallgren  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8887  
 
 
  puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
Change By: 
 Henrik Lindberg  
 
 
Assignee: 
 Thomas Hallgren  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2018-05-24 Thread Stefan Andres (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Stefan Andres assigned an issue to Unassigned  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8887  
 
 
  puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
Change By: 
 Stefan Andres  
 
 
Assignee: 
 Stefan Andres  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2018-05-24 Thread Stefan Andres (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Stefan Andres updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8887  
 
 
  puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
Change By: 
 Stefan Andres  
 

  
 
 
 
 

 
 *Puppet Version: 5.5.1*We are using array-iteration in our hiera.yaml to implement some kind of roles-concept.For this we have nodes that can define an array of roles.Those roles will be added to the hiera hierarchy by using the mapped_paths. The %\{roles} variable is defined in our site.pp by using the lookup() function.Prior to 5.5.1 we could could define lookup_options in roles dynamically loaded roles and define merge behavior or hashes defined in thoses roles. With 5.5.1 this does not seem to work anylonger. Values can still be looked up though. Below is a minimal reproducible case:{code:java}  root@c312a1b640ef:/etc/puppetlabs/code/environments/production/manifests# cat ../hiera.yaml---version: 5defaults:hierarchy:  - name: "node"path: node.yaml  - name: "roles"mapped_paths:  - roles  - role  - "%{role}.yaml"  - name: "Other YAML hierarchy levels"paths:  - "common.yaml"  root@c312a1b640ef:/etc/puppetlabs/code/environments/production/manifests# cat ../data/ node.yamlroles:  - firstrole  - secondroleroot@c312a1b640ef:/etc/puppetlabs/code/environments/production/manifests# cat ../data/ common.yamlmyhash:  key1: value1  key2: value2  root@c312a1b640ef:/etc/puppetlabs/code/environments/production/manifests# cat ../data/firstrole.yamllookup_options:  myhash:merge:  strategy: deepmyhash:  role1: value1  role2: value2  role1: role1 root@c312a1b640ef:/etc/puppetlabs/code/environments/production/manifests# cat ../data/secondrole.yamlmyhash:  role1: value1  role3: value3  role2: role2root@c312a1b640ef:/etc/puppetlabs/code/environments/production/manifests# cat site.pp$roles = lookup( 'roles', Array[String], 'unique', [], )notice("roles: $roles")$ret = lookup('myhash')notice("myhash: $ret")$role1 = lookup('role1')$role2 = lookup('role2')notice("role1 var: $role1")notice("role2 var: $role2")puppet-agent-5.4.0:root@c312a1b640ef:/etc/puppetlabs/code/environments/production/manifests# puppet apply site.ppWarning: Undefined variable 'roles'; \n   (file & line not available)Notice: Scope(Class[main]): roles: [firstrole, secondrole]Notice: Scope(Class[main]): myhash: {key1 => value1, key2 => value2, role1 => value1, role3 => value3, role2 => value2}Notice: Scope(Class[main]): role1 var: role1Notice: Scope(Class[main]): role2 var: role2Notice: Compiled catalog for c312a1b640ef in environment production in 0.03 secondsNotice: Applied catalog in 0.01 secondspuppet-agent-5.5.1root@c312a1b640ef:/etc/puppetlabs/code/environments/production/manifests# puppet apply site.ppWarning: Undefined variable 'roles'; \n   (file & line not available)Notice: Scope(Class[main]): roles: [firstrole, secondrole]Notice: Scope(Class[main]): myhash: {role1 => value1, role2 => value2}Notice: Scope(Class[main]): role1 var: role1Notice: Scope(Class[main]): role2 var: role2Notice: Compiled catalog for c312a1b640ef 

Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2018-05-24 Thread Stefan Andres (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Stefan Andres commented on  PUP-8887  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
 Ah, I forgot to paste the node.yaml, of course - this is where our roles for nodes are defined:    
 
 
 
 
 root@c312a1b640ef:/etc/puppetlabs/code/environments/production# cat data/node.yaml  
 
 
 roles:  
 
 
   - firstrole  
 
 
   - secondrole   
 
 
 
   
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   

Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2018-05-24 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg assigned an issue to Stefan Andres  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8887  
 
 
  puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
Change By: 
 Henrik Lindberg  
 
 
Assignee: 
 Thomas Hallgren Stefan Andres  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2018-05-24 Thread Thomas Hallgren (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Thomas Hallgren commented on  PUP-8887  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
 The example seems incomplete. I don't understand how the above code can produce the notice:  
 
 
 
 
 roles: [firstrole, secondrole]
  
 
 
 
  Where did that array come from? Lookup will not find a 'roles' key in any of the listed data files and the provided default value is an empty array. I get the impression that $roles gets its value from a lookup and then is used to actually configure lookup. If that's true, then it's classic chicken-and-egg problem. Constructs like that should be avoided at length.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For 

Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2018-05-24 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg assigned an issue to Thomas Hallgren  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8887  
 
 
  puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
Change By: 
 Henrik Lindberg  
 
 
Assignee: 
 Thomas Hallgren  
 
 
Sub-team: 
 Language  
 
 
Team: 
 Platform Core  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2018-05-24 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8887  
 
 
  puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
Change By: 
 Henrik Lindberg  
 
 
Affects Version/s: 
 PUP 5.5.1  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2018-05-24 Thread Stefan Andres (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Stefan Andres commented on  PUP-8887  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
 The commit that introduced this new behavior is https://github.com/puppetlabs/puppet/commit/36cb716a37e091215ea5f2f9cdb8a29bff11e7b5#diff-9b5fcadd98b4a6f7f471fc1a8d3186dc in the file lib/puppet/pops/lookup/lookup_adapter.rb. When using an a revision older it still works.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2018-05-24 Thread Stefan Andres (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Stefan Andres commented on  PUP-8887  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
 With PUP-8715, this prevents us from upgrading the puppet-agents on our puppetservers (this is where the logic is only used) to puppet-agent-5.5.1.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8887) puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml

2018-05-24 Thread Stefan Andres (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Stefan Andres created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8887  
 
 
  puppet-5.5.0 breaks lookup_options when used post-loading dynamic items from hiera.yaml   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2018/05/24 2:29 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Stefan Andres  
 

  
 
 
 
 

 
 Puppet Version: 5.5.1 We are using array-iteration in our hiera.yaml to implement some kind of roles-concept. For this we have nodes that can define an array of roles. Those roles will be added to the hiera hierarchy by using the mapped_paths. The %{roles} variable is defined in our site.pp by using the lookup() function. Prior to 5.5.1 we could could define lookup_options in roles dynamically loaded roles and define merge behavior or hashes defined in thoses roles. With 5.5.1 this does not seem to work anylonger. Values can still be looked up though.  Below is a minimal reproducible case:  
 
 
 
 
 root@c312a1b640ef:/etc/puppetlabs/code/environments/production/manifests# cat ../hiera.yaml  
 
 
 ---  
 
 
 version: 5  
 
 
 defaults:  
 
 
 hierarchy: