Jira (PUP-8959) FastGetext.default_text_domain appears to be unset

2018-06-26 Thread Josh Cooper (JIRA) 
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-8959  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: FastGetext.default_text_domain appears to be unset   
 

  
 
 
 
 

 
 Should be able to repro as bundle exec rspec --order random:30720 spec/unit/gettext. Thomas Hallgren can you take a look?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-8959) FastGetext.default_text_domain appears to be unset

2018-06-26 Thread Josh Cooper (JIRA) 
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-8959  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: FastGetext.default_text_domain appears to be unset   
 

  
 
 
 
 

 
 Some of the unit tests delete the default text domain: https://github.com/puppetlabs/puppet/blob/7e12e673344ed8f00c276ebec42652691edf239f/spec/unit/gettext/config_spec.rb#L85. It looks like config_spec has some order-dependent issues:  
 
 
 
 
 $ bx rspec --order random spec/unit/gettext  
 
 
 Run options: exclude {:broken=>true, :benchmark=>true}  
 
 
    
 
 
 Randomized with seed 30720  
 
 
 F...  
 
 
    
 
 
 Failures:  
 
 
    
 
 
   1) Puppet::GettextConfig clearing the configured text domain succeeds  
 
 
  Failure/Error: expect(FastGettext.text_domain).to be_nil  
 
 
    
 
 
expected: nil  
 
 
 got: "default-text-domain"

Jira (PUP-8959) FastGetext.default_text_domain appears to be unset

2018-06-26 Thread Michael Smith (JIRA) 
Title: Message Title


 
 
 
 

 
 
 

 
   
 Michael Smith commented on  PUP-8959  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: FastGetext.default_text_domain appears to be unset   
 

  
 
 
 
 

 
 https://github.com/puppetlabs/puppet/blob/master/lib/puppet.rb#L46 should take care of that. Not sure why it wouldn't be setup in spec tests.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-8959) FastGetext.default_text_domain appears to be unset

2018-06-26 Thread Thomas Hallgren (JIRA) 
Title: Message Title


 
 
 
 

 
 
 

 
   
 Thomas Hallgren created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8959  
 
 
  FastGetext.default_text_domain appears to be unset   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2018/06/26 2:01 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Thomas Hallgren  
 

  
 
 
 
 

 
 When running bundle exec rake parallel:spec[12] from the puppet master branch on a Fedora Linux (I've tested 27 and 28) the following statement:  
 
 
 
 
 FastGettext.translation_repositories[FastGettext.default_text_domain]
  
 
 
 
  returns nil which results in the message "undefined method `chain' for nil:NilClass" in file lib/puppet/gettext/config.rb on line 179. This in turn, causes +40 spec test failures. Sample stack trace from one of the failed tests:  
 
 
 
 
   1) Puppet::Resource::Catalog::Compiler when initializing should cache the server metadata and reuse it  
 
 
  Failure/Error: puppet_translations = FastGettext.translation_repositories[FastGettext.default_text_domain].chain