Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Josh Cooper commented on PUP-9268 Re: 5.5.7 breaks custom function This was fixed in 5.5.8 and we preserved the puppet6 behavior during the merge up. Passed CI in puppet#f991e7ab39a44f392e98819d1fad31dcb7f95d60 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Maggie Dreyer updated an issue Puppet / PUP-9268 5.5.7 breaks custom function Change By: Maggie Dreyer Team: Server Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Claire Cadman updated an issue Puppet / PUP-9268 5.5.7 breaks custom function Change By: Claire Cadman Labels: resolved-issue-added Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-9268 5.5.7 breaks custom function Change By: Henrik Lindberg Release Notes Summary: A regression was found that was triggered by illegal construct in functions using the legacy (3.x) function API. We decided to revert the change that caused this regression but will raise errors for the illegal constructs in Puppet 6 as they can seriously screw up the system.If you have 3.x functions that defines methods inside the function body, or outside of the call to `newfunction` those functions *must* be updated to work with Puppet 6 - preferably to use the modern (4x) function API where it is supported to have additional methods. Release Notes: Deprecation Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Kenn Hussey commented on PUP-9268 Re: 5.5.7 breaks custom function Henrik Lindberg please provide release notes for this issue if needed, thanks! /cc Jean Bond Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Henrik Lindberg commented on PUP-9268 Re: 5.5.7 breaks custom function I just figured out what happens with methods defined inside 3.x functions (either inside the function's code block, or outside the call to newfunction - and it is totally HORRIBLE! The horrible thing is that those methods are added as methods on Ruby Object! Thus, all instances of everything will have those methods, and they step on each other (naturally), or worse, a 3.x function using this can end up blowing up the entire system by overwriting some fundamental Object method. So, it is not only Scope that is polluted - it is every instance of everything in Ruby !!! Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Richard Pearce commented on PUP-9268 Re: 5.5.7 breaks custom function Linter sounds reasonable. Would it also be worth considering that in addition to a new configuration flag to turn on/off the new behaviour? allow_legacy_scope_pollution = true|false This allows users to discover if they are impacted and give them an opportunity to address it before the upgrade to 6. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Alexander Fisher commented on PUP-9268 Re: 5.5.7 breaks custom function rubocop-puppet? FWIW, Puppet Inc. already maintains https://github.com/puppetlabs/rubocop-i18n Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Charlie Sharpsteen commented on PUP-9268 Re: 5.5.7 breaks custom function A linting tool makes the most sense to me. Could possibly be added to Forge lint checks along with a large demerit to the quality score if such sub-functions are found. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Henrik Lindberg commented on PUP-9268 Re: 5.5.7 breaks custom function Richard Pearce I have not come up with an obvious way to do that. From the implementation perspective it just uses Ruby to define things - there are lots of them so would make it slow. The implementation basically asks Ruby "do this", and then it hopes that the result is what was expected - it does check if the loaded code for a function actually did define the function - but what happened in between is opaque. To do this right, the ruby code has to be parsed in introspected. We don't want to do that at runtime. There is some more spelunking to do regarding the exact details what happens when there are methods before the function, inside the function, and after with the hope that would reveal a practical approach of providing relevant feedback. Maybe this is best done by a linting tool? But then, not everyone uses that. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Richard Pearce commented on PUP-9268 Re: 5.5.7 breaks custom function I fell over this today, it was exceptionally hard to track it back to this bug. Given that you have decided to revert, would it be possible to implement a warning for functions that 'pollute scope' and output it on the Puppet run? This would give everyone visibility of this problem and drive everyone to adopt the newer API. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Henrik Lindberg commented on PUP-9268 Re: 5.5.7 breaks custom function The specification has been updated with stronger language regarding having extra methods in a legacy (3.x) function. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-9268 5.5.7 breaks custom function Change By: Kenn Hussey Flagged: Impediment Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Josh Cooper commented on PUP-9268 Re: 5.5.7 breaks custom function Merged to 5.5.x in https://github.com/puppetlabs/puppet/commit/4cc0859373d27b4c5aea76c8fc9d65c241e81342 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Kenn Hussey updated an issue Puppet / PUP-9268 5.5.7 breaks custom function Change By: Kenn Hussey Flagged: Impediment Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Kenn Hussey commented on PUP-9268 Re: 5.5.7 breaks custom function I believe a PR is up now to revert the changes for PUP-6964. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title
Henrik Lindberg commented on PUP-9268
Re: 5.5.7 breaks custom function
Alexander Fisher and Tim Meusel - as you can see, the decision is to revert as we do not want the breakage this caused. The specification / documentation should state that it is not allowed to have additional methods inside a 3.x function body, nor outside the function body. The specification for the 4.x API ("modern") currently does say that defined methods in 3.x function API "pollute Scope", and it says that it is allowed in the 4.x API. I agree that "pollute Scope" does not sound so horrible - but it is really bad! I cannot see that documentation says that you are allowed to, nor that it is API in any way, shape or form. The functions in question will have to change. Reverting the change will make that happen when moving to Puppet 6.
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Tim Meusel commented on PUP-9268 Re: 5.5.7 breaks custom function I agree with Alexander Fisher here. To me this looks like a breaking change for something that wasn't optimal and not recommended, but definitely not prohibited. If semantic versioning should be honored, this should only fail in puppet 7, not 5 and not 6. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Alexander Fisher commented on PUP-9268 Re: 5.5.7 breaks custom function 'illegal'? There are a couple of statements in https://github.com/puppetlabs/puppet-specifications/blob/master/language/func-api.md that suggest it's not recommended, but fall a long way short of saying you mustn't do it. > Methods defined in a Function pollute Scope > If an attempt is made to define additional methods inside the new function body, they share the namespace with Scope and all other functions. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Josh Cooper commented on PUP-9268 Re: 5.5.7 breaks custom function Yeah that doesn't make sense. I removed 6.0.4 as a fix version. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9268 5.5.7 breaks custom function Change By: Josh Cooper Fix Version/s: PUP 6.0.4 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Henrik Lindberg commented on PUP-9268 Re: 5.5.7 breaks custom function Josh Cooper You add 6.0.4 as a release version, but if this is to be reverted in 5.5.8, then there is no need to fix anything on 6.0.4 (except reverting the revert), or am I missing something? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9268 5.5.7 breaks custom function Change By: Josh Cooper Fix Version/s: PUP 5.5.8 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9268 5.5.7 breaks custom function Change By: Josh Cooper Fix Version/s: PUP 6.0.4 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Josh Cooper commented on PUP-9268 Re: 5.5.7 breaks custom function Suggest reverting the change in 5.5.x, but keeping the new behavior in 6.0 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Henrik Lindberg commented on PUP-9268 Re: 5.5.7 breaks custom function Josh Cooper What do you think - revert this or accept some breakage from "illegal" stuff ? Maybe I am wrong, but it does not look like it is fixable and keeping PUP-6964. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Josh Cooper assigned an issue to Henrik Lindberg Puppet / PUP-9268 5.5.7 breaks custom function Change By: Josh Cooper Assignee: Henrik Lindberg Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9268 5.5.7 breaks custom function Change By: Josh Cooper Team: Server Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9268 5.5.7 breaks custom function Change By: Josh Cooper Sub-team: Language Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Henrik Lindberg commented on PUP-9268 Re: 5.5.7 breaks custom function It was not a deliberate change to block the use of methods in 3.x functions (although that should have been done a long time ago), the cause of the problem is the ticket PUP-6964 that removes the earlier requirement that 4.x functions were only found if found in a module listed among the dependencies of the calling module. That, together with the requirement that 4.x implementations of functions have higher precedence that 3.x necessitated the change in PUP-6964 that makes the 4.x loaders load also 3.x functions. Our earlier attempts to fix that problems resulted in poor performance. We did not know we were breaking anything since the behavior that is now observed as breaking is illegal, and we have no tests testing that illegal constructs work. We also have no functions in supported modules that does things like that. Now, since the change has been released and it will cause breakage, the question is what to do about it. Should we revert the change or not - it is trading wanted behavior in PUP-6964 for non breaking (illegal) function implementations? Ping Eric Sorenson. Illegal function implementations will still need to change as the change is in Puppet 6. Stefan Seidel Please add a link here to the "upstream" issue to make it easier to find and for me to offer them help if needed. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Stefan Seidel commented on PUP-9268 Re: 5.5.7 breaks custom function I see. Will report upstream. is there a specific change I can point to? Is it PUP-9137 ? Still not cool to break a complete infrastructure on a minor release. After all, the mentioned plugin has more than half a million downloads, so not a fringe problem. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title
Henrik Lindberg commented on PUP-9268
Re: 5.5.7 breaks custom function
It is illegal to define new methods inside of a 3.x function as they end up monkey patching the puppet implementation and all such methods step on each other! They also become sticky in the environment and can cause mysterious problems. Ask the implementor to convert the function to using the 4.x api ("modern function API") where it is acceptable to have definition of new methods inside of the function definition, or change the implementation to not make use of a new method.
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9268) 5.5.7 breaks custom function
Title: Message Title Stefan Seidel created an issue Puppet / PUP-9268 5.5.7 breaks custom function Issue Type: Bug Affects Versions: PUP 5.5.7 Assignee: Unassigned Created: 2018/10/26 4:21 AM Priority: Normal Reporter: Stefan Seidel Puppet Version: 5.5.7 Puppet Server Version: 5.3.6 OS Name/Version: Debian 9 After upgrading Puppet from 5.5.6 to 5.5.7, certain custom functions do not work anymore. Specifically, camptocamp/accounts has a function strformat which doesn't work anymore. The client shows: Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, undefined method `strformat' for Scope(Accounts::Authorized_key[stefan-eris-on-root]):Puppet::Parser::Scope (file: /etc/puppetlabs/code/environments/production/modules/accounts/manifests/authorized_key.pp, line: 32, column: 36) (file: /etc/puppetlabs/code/environments/production/modules/accounts/manifests/account.pp, line: 98) The server log shows: ERROR
