Jira (PUP-9293) read_wide_string hides errors if the string is nil
Title: Message Title Branan Riley updated an issue Puppet / PUP-9293 read_wide_string hides errors if the string is nil Change By: Branan Riley Fix Version/s: PUP 6.0.5 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9293) read_wide_string hides errors if the string is nil
Title: Message Title Branan Riley updated an issue Puppet / PUP-9293 read_wide_string hides errors if the string is nil Change By: Branan Riley Fix Version/s: PUP 5.5.9 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9293) read_wide_string hides errors if the string is nil
Title: Message Title Sean McDonald updated an issue Puppet / PUP-9293 read_wide_string hides errors if the string is nil Change By: Sean McDonald Fix Version/s: PUP 6.1.0 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9293) read_wide_string hides errors if the string is nil
Title: Message Title Erick Banks commented on PUP-9293 Re: read_wide_string hides errors if the string is nil Commit shown as last good PUPPET_COMMIT for 5.5.x via kerminator. Closing as fixed. Last known good build of puppet-agent on 5.5.x: Built at: 20 Nov 2018 10:44:36 PUPPET_AGENT_VERSION: 5.5.8.40.g52070fd PUPPET_AGENT_COMMIT: 52070fd30901a3c5b5552b69c5ae1c420644ce05 PUPPET_AGENT_SHORT_COMMIT: 52070fd30 FACTER_COMMIT: 02647550dd4638cad95a36a6eac1d0ee4402e05a PUPPET_COMMIT: c8a4d7268dee014b56703a6a4a31085f3c7f41bc HIERA_COMMIT: 5f2e56888af715094bac507974437b5d1a7e4ca6 PXPAGENT_COMMIT: d56de5bdc7d7ade6f391b5a962deb4529a3b8937
Jira (PUP-9293) read_wide_string hides errors if the string is nil
Title: Message Title Erick Banks commented on PUP-9293 Re: read_wide_string hides errors if the string is nil Merged into 5.5.x branch per Josh's comment here https://github.com/puppetlabs/puppet/pull/7243 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9293) read_wide_string hides errors if the string is nil
Title: Message Title Erick Banks updated an issue Puppet / PUP-9293 read_wide_string hides errors if the string is nil Change By: Erick Banks Sprint: Windows PupperCon 2018-11-16 , Windows 2018-11-28 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9293) read_wide_string hides errors if the string is nil
Title: Message Title Erick Banks assigned an issue to Erick Banks Puppet / PUP-9293 read_wide_string hides errors if the string is nil Change By: Erick Banks Assignee: Erick Banks Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9293) read_wide_string hides errors if the string is nil
Title: Message Title Glenn Sarti updated an issue Puppet / PUP-9293 read_wide_string hides errors if the string is nil Change By: Glenn Sarti Story Points: 1 Team: Platform OS Windows Sprint: Windows PupperCon 2018-11-16 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9293) read_wide_string hides errors if the string is nil
Title: Message Title Glenn Sarti commented on PUP-9293 Re: read_wide_string hides errors if the string is nil Raised PR - https://github.com/puppetlabs/puppet/pull/7243 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9293) read_wide_string hides errors if the string is nil
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9293 read_wide_string hides errors if the string is nil Change By: Josh Cooper Team: Platform OS Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9293) read_wide_string hides errors if the string is nil
Title: Message Title
Patrick Grant updated an issue
Puppet / PUP-9293
read_wide_string hides errors if the string is nil
Change By:
Patrick Grant
*Puppet Version:* Unknown 5.5.2 (PE 2018.1.2 Master & Agent) *Puppet Server Version:* N/A*OS Name/Version:* Windows Server 2012r2 As part of [ https://puppetlabs.zendesk.com/agent/tickets/32364 ] it was found that there was a bug in the error handler in the read_wide_string method ( [ https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/api_types.rb#L56-L63 ] )Where if {{str}} is nil then an error is raised during the debug statement and raises the wrong error. Instead the Puppet.debug statement should never error and raise the real error
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To
Jira (PUP-9293) read_wide_string hides errors if the string is nil
Title: Message Title Glenn Sarti commented on PUP-9293 Re: read_wide_string hides errors if the string is nil This will probably affect all the way back to 4.10.x Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9293) read_wide_string hides errors if the string is nil
Title: Message Title Glenn Sarti commented on PUP-9293 Re: read_wide_string hides errors if the string is nil Example stack trace Failed to apply catalog: undefined method `dump' for nil:NilClass C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/util/windows/api_types.rb:61:in `rescue in read_wide_string' C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/util/windows/api_types.rb:56:in `read_wide_string' C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/util/windows/registry.rb:213:in `block in read' C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/util/windows/registry.rb:255:in `block (3 levels) in query_value_ex' C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/vendor_ruby/puppet/util/windows/registry.rb:244:in `initialize'
Jira (PUP-9293) read_wide_string hides errors if the string is nil
Title: Message Title Glenn Sarti created an issue Puppet / PUP-9293 read_wide_string hides errors if the string is nil Issue Type: Bug Assignee: Unassigned Created: 2018/10/30 3:27 PM Priority: Normal Reporter: Glenn Sarti Puppet Version: Unknown Puppet Server Version: N/A OS Name/Version: Windows As part of https://puppetlabs.zendesk.com/agent/tickets/32364 it was found that there was a bug in the error handler in the read_wide_string method (https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/api_types.rb#L56-L63) Where if str is nil then an error is raised during the debug statement and raises the wrong error. Instead the Puppet.debug statement should never error and raise the real error Add Comment
