Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title Branan Riley updated an issue Puppet / PUP-9300 Text Fragmentation in Exception Message Change By: Branan Riley Fix Version/s: PUP 6.0.5 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title Branan Riley updated an issue Puppet / PUP-9300 Text Fragmentation in Exception Message Change By: Branan Riley Fix Version/s: PUP 5.5.9 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9300 Text Fragmentation in Exception Message Change By: Josh Cooper Release Notes: Not Needed Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9300 Text Fragmentation in Exception Message Change By: Josh Cooper Fix Version/s: PUP 6.1.0 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9300 Text Fragmentation in Exception Message Change By: Josh Cooper Sprint: Platform Core KANBAN Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title Josh Cooper commented on PUP-9300 Re: Text Fragmentation in Exception Message Merged to 5.5.x in https://github.com/puppetlabs/puppet/commit/d1615c335e12ff091101ad0dd760daa1f84cdb68 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title Erwin Hom updated an issue Puppet / PUP-9300 Text Fragmentation in Exception Message Change By: Erwin Hom Labels: L10n i18n Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title Enis Inan commented on PUP-9300 Re: Text Fragmentation in Exception Message Erwin Hom I favor #3 as well for the same reasons; two colons is annoying but not that bad. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title
Erwin Hom commented on PUP-9300
Re: Text Fragmentation in Exception Message
Enis Inan Would it be possible for error.rb#L14 to be changed one of following ways: #1: super(message + " Reason for Failure: " + #{self.class.format_error_code(code)}", original or #2: super(message + #{self.class.format_error_code(code)}", original'' or #3 Leave error.rb#L14 alone. Make sure service.rb#L719 reads: "Failed to send the %{control_signal} signal to the service. Its current state is %{current_state}. Reason for failure:" Having two colon characters isn't a big deal. " Reason for failure:: . " — I'm guessing that the Puppet::Util::Win::Error class is probably being used in more than one context. — So, I favor #3 since it has the lowest impact. Let me know what you know. Thx!
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title Erwin Hom commented on PUP-9300 Re: Text Fragmentation in Exception Message Enis Inan, We'll go with "Reason for Failure: " then. Thanks! -Erwin Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title Erwin Hom assigned an issue to Erwin Hom Puppet / PUP-9300 Text Fragmentation in Exception Message Change By: Erwin Hom Assignee: Enis Inan Erwin Hom Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title Enis Inan commented on PUP-9300 Re: Text Fragmentation in Exception Message Erwin Hom Yes, "Reason for Failure:" does sound better. And no problem, glad I could help. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title Erwin Hom commented on PUP-9300 Re: Text Fragmentation in Exception Message Enis Inan I favor your second proposal. Maybe "Reason for Failure:" over "Failure reason:" Anyway, proposal is in the right track. Maybe we can get a content writer to finalize it. Thanks! Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title
Enis Inan commented on PUP-9300
Re: Text Fragmentation in Exception Message
Erwin Hom It's phrased that way due to https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/error.rb#L14 so the exception will really read as
Failed to send the %{control_signal} signal to the service. Its current state is %{current_state}. Failed with:
Maybe we could phrase it as
Failed to send the %{control_signal} signal to the service. Its current state is %{current_state}. Failure reason:
?
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title
Erwin Hom updated an issue
Puppet / PUP-9300
Text Fragmentation in Exception Message
Change By:
Erwin Hom
In our localization tool (Transifex), I encountered the following text:"Failed to send the %\{control_signal} signal to the service. Its current state is %\{current_state}. Failed with"*A localizable string should be a complete phrase.*I found the string in puppet.pot and then tracked it to this file:[https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/service.rb#L719]From looking at the code, this text is an exception message.--- Here are two possible resolutions:1) Add placeholder to string ""Failed to send the %\{control_signal} signal to the service. Its current state is %\{current_state}. Failed with %\{more_info}"2) Remove "Failed with" from the string"Failed to send the %\{control_signal} signal to the service. Its current state is %\{current_state}. "—If we go with resolution #1, 1 string resource will have to be changed and code will have to be changed (minor).If we go with resolution #2, 2 string resources will have to be changed.Can you point me where the exception catcher code is?
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title
Erwin Hom updated an issue
Puppet / PUP-9300
Text Fragmentation in Exception Message
Change By:
Erwin Hom
In our localization tool (Transifex), I encountered the following text:"Failed to send the %\{control_signal} signal to the service. Its current state is %\{current_state}. Failed with" *A localizable string should be a complete phrase.* I found the stringin string in puppet.pot and then tracked it to this file:[https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/service.rb#L719] From looking at the code, this text is an exception message. A localizable string should be a complete phrase. --- Here are two possible resolutions:1) Add placeholder to string " "Failed to send the %\{control_signal} signal to the service. Its current state is %\{current_state}. Failed with % \ { more_info }"2) Remove "Failed with" from the string"Failed to send the %\{control_signal} signal to the service. Its current state is %\{current_state}. " --- — From looking at the code, this text is an exception message. If we go with resolution #1, 1 string resource will have to be changed and code will have to be changed (minor) .If we go with resolution #2, 2 string resources will have to be changed.Can you point me where the exception catcher code is?
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title
Erwin Hom updated an issue
Puppet / PUP-9300
Text Fragmentation in Exception Message
Change By:
Erwin Hom
In our localization tool (Transifex), I encountered the following text:"Failed to send the %\{control_signal} signal to the service. Its current state is %\{current_state}. Failed with" I found the stringin puppet.pot and tracked it to this file:[https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/service.rb#L719] A localizable string should be a complete phrase.Here are two possible resolutions:1) Add placeholder to string"Failed to send the %\{control_signal} signal to the service. Its current state is %\{current_state}. Failed with %{}"2) Remove "Failed with" from the string"Failed to send the %\{control_signal} signal to the service. Its current state is %\{current_state}. " *** --- From looking at the code, this text is an exception message.If we go with resolution #1, 1 string resource will have to be changed and code will have to be changed.If we go with resolution #2, 2 string resources will have to be changed.Can you point me where the exception catcher code is?
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title
Erwin Hom updated an issue
Puppet / PUP-9300
Text Fragmentation in Exception Message
Change By:
Erwin Hom
In our localization tool (Transifex), I encountered the following text:"Failed to send the %\{control_signal} signal to the service. Its current state is %\{current_state}. Failed with" I found the stringin puppet.pot and tracked it to this file:[https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/service.rb#L719] A localizable string should be a complete phrase.Here are two possible resolutions:1) Add placeholder to string "Failed to send the %\{control_signal} signal to the service. Its current state is %\{current_state}. Failed with %{}" Or simply: 2) Remove "Failed with" from the string"Failed to send the %\{control_signal} signal to the service. Its current state is %\{current_state}. "From looking at the code, this text is an exception message.If we go with resolution #1, 1 string resource will have to be changed and code will have to be changed.If we go with resolution #2, 2 string resources will have to be changed.Can you point me where the exception catcher code is?
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title
Erwin Hom updated an issue
Puppet / PUP-9300
Text Fragmentation in Exception Message
Change By:
Erwin Hom
In our localization tool (Transifex), I encountered the following text:"Failed to send the %\{control_signal} signal to the service. Its current state is %\{current_state}. Failed with" I found the stringin puppet.pot and tracked it to this file:[https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/service.rb#L719] A localizable string should be a complete phrase.Here are two possible resolutions:1) Add placeholder to string"Failed to send the %\{control_signal} signal to the service. Its current state is %\{current_state}. Failed with %{}"2) Remove "Failed with" from the string"Failed to send the %\{control_signal} signal to the service. Its current state is %\{current_state}. " *** From looking at the code, this text is an exception message.If we go with resolution #1, 1 string resource will have to be changed and code will have to be changed.If we go with resolution #2, 2 string resources will have to be changed.Can you point me where the exception catcher code is?
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title
Erwin Hom updated an issue
Puppet / PUP-9300
Text Fragmentation in Exception Message
Change By:
Erwin Hom
In our localization tool (Transifex), I encountered the following text:"Failed to send the %\{control_signal} signal to the service. Its current state is %\{current_state}. Failed with" I found the stringin puppet.pot and tracked it to this file:[https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/service.rb#L719] A localizable string should be a complete phrase. Here are two possible resolutions: 1) "Failed to send the %\{control_signal} signal to the service. Its current state is %\{current_state}. Failed with %{}"Or simply:2) "Failed to send the %\{control_signal} signal to the service. Its current state is %\{current_state}. "From looking at the code, this text is an exception message.If we go with resolution #1, 1 string resource will have to be changed and code will have to be changed.If we go with resolution #2, 2 string resources will have to be changed.Can you point me where the exception catcher code is?
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title
Erwin Hom updated an issue
Puppet / PUP-9300
Text Fragmentation in Exception Message
Change By:
Erwin Hom
In our localization tool (Transifex), I encountered the following text:"Failed to send the %\{control_signal} signal to the service. Its current state is %\{current_state}. Failed with" A localizable string should be a complete phrase I found the stringin puppet . pot and tracked it to this file: ( [https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/service.rb#L719] ) A localizable string should be a complete phrase. 1) "Failed to send the %\{control_signal} signal to the service. Its current state is %\{current_state}. Failed with %{}"Or simply:2) "Failed to send the %\{control_signal} signal to the service. Its current state is %\{current_state}. "From looking at the code, this text is an exception message.If we go with resolution #1, 1 string resource will have to be changed and code will have to be changed.If we go with resolution #2, 2 string resources will have to be changed.Can you point me where the exception catcher code is?
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title
Erwin Hom updated an issue
Puppet / PUP-9300
Text Fragmentation in Exception Message
Change By:
Erwin Hom
In the our localization tool (Transifex) , I encountered the following text:"Failed to send the %\{control_signal} signal to the service. Its current state is %\{current_state}. Failed with"A localizable string should be a complete phrase.( [ https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/service.rb#L719 ] )1) "Failed to send the %\{control_signal} signal to the service. Its current state is %\{current_state}. Failed with %{}"Or simply:2) "Failed to send the %\{control_signal} signal to the service. Its current state is %\{current_state}. "From looking at the code, this text is an exception message.If we go with resolution #1, 1 string resource will have to be changed and code will have to be changed.If we go with resolution #2, 2 string resources will have to be changed.Can you point me where the exception catcher code is?
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title
Erwin Hom created an issue
Puppet / PUP-9300
Text Fragmentation in Exception Message
Issue Type:
Bug
Assignee:
Unassigned
Components:
Platform
Created:
2018/11/01 4:24 PM
Labels:
i18n
Priority:
Normal
Reporter:
Erwin Hom
In the localization tool, I encountered the following text: "Failed to send the %{control_signal} signal to the service. Its current state is %{current_state}. Failed with" A localizable string should be a complete phrase. (https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util/windows/service.rb#L719) 1) "Failed to send the %{control_signal} signal to the service. Its current state is %{current_state}. Failed with %{}" Or simply: 2) "Failed to send the %{control_signal} signal to the service. Its current state is %{current_state}. "From looking at the code, this text is an exception message. If we go with resolution #1, 1 string resource will have to be changed and code will have to be changed. If we go with resolution #2, 2 string resources will have to be changed. Can you point me where the exception catcher code is?
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title Erwin Hom assigned an issue to Enis Inan Puppet / PUP-9300 Text Fragmentation in Exception Message Change By: Erwin Hom Assignee: Erwin Hom Enis Inan Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9300) Text Fragmentation in Exception Message
Title: Message Title Erwin Hom assigned an issue to Erwin Hom Puppet / PUP-9300 Text Fragmentation in Exception Message Change By: Erwin Hom Assignee: Erwin Hom Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
