Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title Austin Boyd updated an issue Puppet / PUP-9324 Puppet agent run output to differentiate between corrective and intentional change Change By: Austin Boyd Zendesk Ticket IDs: 32715 Zendesk Ticket Count: 1 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.285550.1542593415000.6418.1576158661207%40Atlassian.JIRA.
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title Jean Bond updated an issue Puppet / PUP-9324 Puppet agent run output to differentiate between corrective and intentional change Change By: Jean Bond Labels: resolved-issue-added Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title Melissa Stone commented on PUP-9324 Re: Puppet agent run output to differentiate between corrective and intentional change David Swan no bother! Have you confirmed the agent version that's getting pulled in with your tests contains this change? I'm not very familiar with the modules pipelines, but from my brief encounter with them, I remember it was a little confusing figuring out how it figured out which puppet-agent version to install. And without knowing much about where that 2018.1 failure is happening, I can only speculate on why it's failing. However, I don't think it's related to the changes associated with this ticket. It's possible you're hitting some automation that loops through all our projects (facter, puppet, etc) to look for bat files that should be created at install time. Someone possibly added bolt to that list without updating the automation that builds the MSI to create that file. I have no idea if this is an issue with PE or with the puppet-agent package though. You should open either a PE or a PA ticket with more details on the failure, and those folks can track it down further. Include links to the failing jobs too. That'll help with figuring out what's going on. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title David Swan commented on PUP-9324 Re: Puppet agent run output to differentiate between corrective and intentional change Melissa Stone Have been running the agent against all of our modules and it's been going great except for one thing. We are getting consistent failures on are task modules on all windows machines when run on 2018.1. We are getting the error, ``` bash: /cygdrive/c/Program Files/Puppet Labs/Puppet/sys/ruby/bin/bolt.bat: No such file or directory ``` Was wondering if you could think of any reason we may be seeing this. Sorry to be a bother. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title Eric Sorenson commented on PUP-9324 Re: Puppet agent run output to differentiate between corrective and intentional change Halim Wijaya it will be in the next LTS patch release, PE2018.1.8. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title Halim Wijaya commented on PUP-9324 Re: Puppet agent run output to differentiate between corrective and intentional change Thanks Melissa Stone for the quick turnaround on this. There is a question from customer if there is a plan to backport this to current LTS? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title Melissa Stone updated an issue Puppet / PUP-9324 Puppet agent run output to differentiate between corrective and intentional change Change By: Melissa Stone Fix Version/s: PUP 6.1.z Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title Melissa Stone commented on PUP-9324 Re: Puppet agent run output to differentiate between corrective and intentional change And this has passed ci for the 6.0.x branch with puppet-agent 6.0.5.93.geeb6eb5 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title Melissa Stone updated an issue Puppet / PUP-9324 Puppet agent run output to differentiate between corrective and intentional change Change By: Melissa Stone Fix Version/s: PUP 6.0.6 Fix Version/s: PUP 6.2.1 Fix Version/s: PUP 6.1.z Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title Melissa Stone commented on PUP-9324 Re: Puppet agent run output to differentiate between corrective and intentional change This has passed ci for the 5.5.x branch with puppet-agent 5.5.10.27.g53d8298 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title Melissa Stone updated an issue Puppet / PUP-9324 Puppet agent run output to differentiate between corrective and intentional change Change By: Melissa Stone Release Notes Summary: Corrective changes in the logs are now explicitely called out as corrective. Release Notes: Enhancement Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title Josh Cooper commented on PUP-9324 Re: Puppet agent run output to differentiate between corrective and intentional change Merged to 5.5.x in https://github.com/puppetlabs/puppet/commit/a75153e214b8b466b0eed8d3b8df67fcd63a91cb Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title Melissa Stone commented on PUP-9324 Re: Puppet agent run output to differentiate between corrective and intentional change That works for me, thank you! I'll coordinate this change and update both here and in FM-7682 when we have agent builds in the different streams that contain this change Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title David Mallon commented on PUP-9324 Re: Puppet agent run output to differentiate between corrective and intentional change Hey Melissa Stone, first off, thanks for the heads up on this change, the Modules team can plan some testing around this to make sure things are good on our side. If possible we would like to : 1. Get access to a nightly Agent build with the change 2. Modules team will test against each of our supported modules 3. If there are issues in any modules we will merge our test fixes to master - no need for a release 4. Let you guys know when we are good to go 5. You guys can proceed with the Agent release with that change. Does that work for you guys? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title Melissa Stone commented on PUP-9324 Re: Puppet agent run output to differentiate between corrective and intentional change We've decided to move forward with Jarret Lavallee's PR as it is. We just need to figure out any coordination with the modules team in case this causes test failures there. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9324 Puppet agent run output to differentiate between corrective and intentional change Change By: Josh Cooper Fix Version/s: PUP 5.5.11 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title Melissa Stone updated an issue Puppet / PUP-9324 Puppet agent run output to differentiate between corrective and intentional change Change By: Melissa Stone Sprint: Platform Core KANBAN Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title Melissa Stone updated an issue Puppet / PUP-9324 Puppet agent run output to differentiate between corrective and intentional change Change By: Melissa Stone Team: Coremunity Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title Melissa Stone assigned an issue to Melissa Stone Puppet / PUP-9324 Puppet agent run output to differentiate between corrective and intentional change Change By: Melissa Stone Assignee: Melissa Stone Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title
Thomas Honey commented on PUP-9324
Re: Puppet agent run output to differentiate between corrective and intentional change
From a testing perspective there are generally 2 kinds of tests run.
Puppet apply, check for where there errors. status IE puppet returns a non zero status code if there was an error.
Run puppet apply with detailed exit codes. puppet returns a non zero status code if there was a change made.
There may be some tests that check for specific changes, eg expect(apply_manifest(pp, expect_failures: true).first['result']['stderr']).to match(%r{change from '?directory'? to '?file'? failed}) I think that the enhanced functionality is worth the change. I think that it will affect testing in modules! but it should be a small number of tests affected. We could grep through supported modules to find the size of this change.
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title Eric Sorenson commented on PUP-9324 Re: Puppet agent run output to differentiate between corrective and intentional change I rather like jarrett's second suggestion - just to flag the corrective changes rather than all changes. This seems like a low effort / low risk way to solve the problem. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title Halim Wijaya updated an issue Puppet / PUP-9324 Puppet agent run output to differentiate between corrective and intentional change Change By: Halim Wijaya Comment: A comment with security level 'Developers' was removed. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title
Jarret Lavallee commented on PUP-9324
Re: Puppet agent run output to differentiate between corrective and intentional change
I did some investigation into this issue and it seems like the change would be relatively easy to implement, however, I am not sure on the scope of the impact on implementing the change. To make a change to the logging, we can determine if the change is corrective or intentional prior to sending the log at https://github.com/puppetlabs/puppet/blob/5.5.x/lib/puppet/transaction/resource_harness.rb#L161-L163. A simple edit to this on an agent with the following ternary enabled this change. However, if we were to implement this, we may want it to be optional with a config option to minimize the impact.
if event
name = param.name.to_s
event.message ||= _("could not create change error message for %{name}") % { name: name }
event.calculate_corrective_change(@persistence.get_system_value(context.resource.ref, name))
event.message = event.corrective_change ? event.message + ' (corrective)' : event.message + ' (intentional)'
context.record(event)
event.send_log
context.synced_params << param.name
end
The resulting output is as follows.
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title Charlie Sharpsteen commented on PUP-9324 Re: Puppet agent run output to differentiate between corrective and intentional change Jorie Tappa In this case, the customer that requested the feature wants something that is as close to "realtime" as possible. They would rather parse the information directly from the syslog stream than wait for the report to make its way up to a puppet server and then through the report processor. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title Jorie Tappa commented on PUP-9324 Re: Puppet agent run output to differentiate between corrective and intentional change We could use more information around what would be involved in this feature. Do you currently have a script to workaround the functionality that's missing here? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9324) Puppet agent run output to differentiate between corrective and intentional change
Title: Message Title Geoff Nichols moved an issue Puppet / PUP-9324 Puppet agent run output to differentiate between corrective and intentional change Change By: Geoff Nichols Key: PA PUP - 2320 9324 Project: Puppet Agent Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
