Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9336 Ensure provider suitability is always lazily evaluated Change By: Josh Cooper Affects Version/s: PUP 5.5.z Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.287001.1543601928000.63120.1603497720052%40Atlassian.JIRA.
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title Jean Bond updated an issue Puppet / PUP-9336 Ensure provider suitability is always lazily evaluated Change By: Jean Bond Labels: resolved-issue-added Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9336 Ensure provider suitability is always lazily evaluated Change By: Josh Cooper Fix Version/s: PUP 6.2.1 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title Josh Cooper commented on PUP-9336 Re: Ensure provider suitability is always lazily evaluated These changes were reverted in 6.0.x in f785859681 and re-reverted in 6.0.x in a6f7ff57c9. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title Casey Williams commented on PUP-9336 Re: Ensure provider suitability is always lazily evaluated This work was reverted after merging up to the 6.0.x branch to allow the 6.2.0 release to proceed. I'll open a PR to un-revert it after the release is finished. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title Casey Williams updated an issue Puppet / PUP-9336 Ensure provider suitability is always lazily evaluated Change By: Casey Williams Fix Version/s: PUP 6.2.0 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title Enis Inan updated an issue Puppet / PUP-9336 Ensure provider suitability is always lazily evaluated Change By: Enis Inan Release Notes Summary: The upstart daemon-check confine in the upstart provider has been fixed so that it is now evaluated when provider suitability's being checked. Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title Josh Cooper commented on PUP-9336 Re: Ensure provider suitability is always lazily evaluated Enis Inan could you provide release notes? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9336 Ensure provider suitability is always lazily evaluated Change By: Josh Cooper Fix Version/s: PUP 6.2.0 Fix Version/s: PUP 6.0.6 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9336 Ensure provider suitability is always lazily evaluated Change By: Josh Cooper Fix Version/s: PUP 5.5.z Fix Version/s: PUP 5.5.11 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title Josh Cooper commented on PUP-9336 Re: Ensure provider suitability is always lazily evaluated Merged to 5.5.x in https://github.com/puppetlabs/puppet/commit/421ce0b22f1946bb7a35901e0e0c24e8370b3b99 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title Enis Inan updated an issue Puppet / PUP-9336 Ensure provider suitability is always lazily evaluated Change By: Enis Inan Sprint: Platform OS Kanban Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title Enis Inan assigned an issue to Enis Inan Puppet / PUP-9336 Ensure provider suitability is always lazily evaluated Change By: Enis Inan Assignee: Enis Inan Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-9336
Ensure provider suitability is always lazily evaluated
Change By:
Enis Inan
[Puppet::Provider::Service::Upstart|https://github.com/puppetlabs/puppet/blob/c6ee7ddcb80f2ec4be03edcafade20d1853a4aee/lib/puppet/provider/service/upstart.rb#L30-L35] had a confine added that is run when the provider is loaded.{code:ruby} confine :true => begininitctl('version', '--quiet')true rescuefalse end{code}This causes issues with running tests under things like JRuby, and also means that it is not possible for the provider to become suitable during the course of a transaction. Instead of using a begin/rescue/end block which will be evaluated during the provider definition, this should be something that will be evaluated only when checking if the provider is suitable. This probably means creating a new type of [Puppet::Confine|https://github.com/puppetlabs/puppet/tree/c6ee7ddcb80f2ec4be03edcafade20d1853a4aee/lib/puppet/confine] that is capable of taking a block to be lazily evaluated as the only existing one that does any sort of "call this code later" goes through the feature machinery. We could also modify the existing {{true}} and {{false}} confines to ( optionally ) accept a block.
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title
Enis Inan updated an issue
Puppet / PUP-9336
Ensure provider suitability is always lazily evaluated
Change By:
Enis Inan
[Puppet::Provider::Service::Upstart|https://github.com/puppetlabs/puppet/blob/c6ee7ddcb80f2ec4be03edcafade20d1853a4aee/lib/puppet/provider/service/upstart.rb#L30-L35] had a confine added that is run when the provider is loaded.{code:ruby} confine :true => begininitctl('version', '--quiet')true rescuefalse end{code}This causes issues with running tests under things like JRuby, and also means that it is not possible for the provider to become suitable during the course of a transaction. Instead of using a begin/rescue/end block which will be evaluated during the provider definition, this should be something that will be evaluated only when checking if the provider is suitable. This probably means creating a new type of [Puppet::Confine|https://github.com/puppetlabs/puppet/tree/c6ee7ddcb80f2ec4be03edcafade20d1853a4aee/lib/puppet/confine] that is capable of taking a block to be lazily evaluated as the only existing one that does any sort of "call this code later" goes through the feature machinery. We could also modify the existing {{true}} and {{false}} confines to (optionally) accept a block.
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title Enis Inan commented on PUP-9336 Re: Ensure provider suitability is always lazily evaluated Jacob Helwig Yeah that makes sense. Cool, I'll add that into the description. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title Jacob Helwig commented on PUP-9336 Re: Ensure provider suitability is always lazily evaluated Enis Inan, certainly. The main point was that there wasn't really a current facility that supported what needed to be done. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title
Enis Inan commented on PUP-9336
Re: Ensure provider suitability is always lazily evaluated
Couldn't we modify the boolean confines {true} and {false} to optionally take in a block and case the value on that? This would look something like:
confine :true,
OR
confine :true,
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9336 Ensure provider suitability is always lazily evaluated Change By: Josh Cooper Fix Version/s: PUP 5.5.z Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9336 Ensure provider suitability is always lazily evaluated Change By: Josh Cooper Team: Coremunity Platform OS Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title Josh Cooper commented on PUP-9336 Re: Ensure provider suitability is always lazily evaluated This change was made in https://github.com/puppetlabs/puppet/commit/c6ee7ddcb80f2ec4be03edcafade20d1853a4aee for PUP-9008. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9336 Ensure provider suitability is always lazily evaluated Change By: Josh Cooper Team: Coremunity Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9336) Ensure provider suitability is always lazily evaluated
Title: Message Title
Jacob Helwig created an issue
Puppet / PUP-9336
Ensure provider suitability is always lazily evaluated
Issue Type:
Bug
Affects Versions:
PUP 5.5.z
Assignee:
Unassigned
Created:
2018/11/30 10:18 AM
Priority:
Normal
Reporter:
Jacob Helwig
Puppet::Provider::Service::Upstart had a confine added that is run when the provider is loaded.
confine :true => begin
initctl('version', '--quiet')
true
rescue
false
end
