Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title Thomas Honey commented on PUP-9437 Re: Make it easier to set Puppets current locale I consider this solved. But i will leave the ticketing status to Melissa Stone Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title Thomas Honey commented on PUP-9437 Re: Make it easier to set Puppets current locale Massive HUGE shout out to Melissa Stone we have a solution and no code needs to change. It will allow us to deprecate the helper functions used in the content world. With this work around we were able to test against puppet 6 and puppet 5 agent for the following OSes The results for testing against MOTD are here https://travis-ci.org/puppetlabs/puppetlabs-motd/builds/512059979?utm_source=github_status_medium=notification travis_deb: provisioner: docker images: [‘debian:8’, ‘debian:9’, ‘ubuntu:14.04’, ‘ubuntu:16.04’, ‘ubuntu:18.04’] travis_el: provisioner: docker images: [‘centos:6’, ‘centos:7’, ‘oraclelinux:6’, ‘oraclelinux:7’, ‘scientificlinux/sl:6’, ‘scientificlinux/sl:7’] release_checks: provisioner: vmpooler images: [‘redhat-6-x86_64’, ‘redhat-7-x86_64’, ‘centos-6-x86_64’, ‘centos-7-x86_64’, ‘oracle-6-x86_64’, ‘oracle-7-x86_64’, ‘scientific-6-x86_64’, ‘scientific-7-x86_64’, ‘debian-8-x86_64’, ‘debian-9-x86_64’, ‘sles-11-x86_64’, ‘ubuntu-1404-x86_64’, ‘ubuntu-1604-x86_64’, ‘ubuntu-1804-x86_64’, ‘win-2008r2-x86_64’, ‘win-2012r2-x86_64’, ‘win-2016-x86_64’, ‘win-10-pro-x86_64’]
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title
Melissa Stone commented on PUP-9437
Re: Make it easier to set Puppets current locale
# puppet apply manifest.pp
Warning: Scope(Class[Motd]): Both $template and $content parameters passed to motd, ignoring content
Notice: Compiled catalog for 8945b688a4e6.eth.pdx.corp.puppet.net in environment production in 0.03 seconds
Notice: /Stage[main]/Motd/File[/etc/motd]/ensure: defined content as '{md5}cad8f5ed937a14f8ecb735d82678df56'
Notice: Applied catalog in 0.02 seconds
# locale -a
C
C.UTF-8
POSIX
# LANGUAGE='ja' puppet apply manifest.pp
Warning: Scope(Class[Motd]): $templateパラメータと$contentパラメータの両方がmotdに渡され、contentは無視されました。
Notice: Environmentproductionの8945b688a4e6.eth.pdx.corp.puppet.netのカタログを0.03秒でコンパイルしました。
Notice: 0.02秒でカタログを適用しました。
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title Melissa Stone commented on PUP-9437 Re: Make it easier to set Puppets current locale For anyone curious, TP and I had a conversation this morning that was very helpful. The issue is, when testing on a host that doesn't already have the necessary bits for a language installed, how do we force puppet to use the locales that we want. It seems that the `LANGUAGE` env var only works if the necessary locale/language packages have already been installed on the machine [root@ivlc6ng4tsmq8wz ~]# puppet module install puppetlabs/motd Notice: Preparing to install into /etc/puppetlabs/code/environments/production/modules ... Notice: Downloading from https://forgeapi.puppet.com ... Notice: Installing -- do not interrupt ... /etc/puppetlabs/code/environments/production/modules └─┬ puppetlabs-motd (v2.1.2) ├── puppetlabs-registry (v2.1.0) ├── puppetlabs-stdlib (v5.2.0) └── puppetlabs-translate (v1.2.0) [root@ivlc6ng4tsmq8wz ~]# vi manifest [root@ivlc6ng4tsmq8wz ~]# mv manifest manifest.pp
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title Thomas Honey commented on PUP-9437 Re: Make it easier to set Puppets current locale https://github.com/puppetlabs/beaker-i18n_helper/blob/master/lib/beaker/i18n_helper.rb https://github.com/puppetlabs/puppetlabs-motd/blob/master/spec/acceptance/locales_spec.rb Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title Melissa Stone commented on PUP-9437 Re: Make it easier to set Puppets current locale Thomas Honey what's happened when you set `LANGAUGE` when using Litmus to test? How are test hosts set up for Litmus? Does the setup process install any required language/local packages? Can we assume that language support had already been installed for the language you want to test? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title Melissa Stone commented on PUP-9437 Re: Make it easier to set Puppets current locale Josh Cooper what do you mean using gettext-setup at runtime versus generating the pot files? I found https://confluence.puppetlabs.com/display/systemsEngineering/I18N+Testing+Puppet+Agent which has a lot of i18n details. Of specific interest: The variables in order of precedence is LANGUAGE takes precedence over LC_ALL LC_ALL takes precedence over LC_MESSAGES LC_MESSAGES takes precedence over LANG LANG Windows If above not set, then fall back to systems locale id (I.E what region/locale is the system set to) So, I can use the LANGUAGE env var to manage which language the locale gem passes to fast_gettext [0] Melissa@bubba:~/puppet:(master)$ be ./bin/puppet agent -t [258, 267] in /Users/Melissa/puppet/lib/puppet/gettext/config.rb 258: # Sets FastGettext's locale to the current system locale 259: def self.setup_locale 260: return if @gettext_disabled || !gettext_loaded? 261:
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title Thomas Honey commented on PUP-9437 Re: Make it easier to set Puppets current locale +1 to what Josh Cooper is saying Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title Josh Cooper commented on PUP-9437 Re: Make it easier to set Puppets current locale I think that was from an earlier branch of puppet that still used gettext-setup at runtime, not when generating the pot files. I think the code that needs changing is in https://github.com/puppetlabs/puppet/blob/master/lib/puppet/gettext/config.rb#L259-L274. The way it works currently is we read the Locale.current.language and set FastGettext's default_locale to be that. If the new environment variable is set, say PUPPET_LOCALE, then puppet should set both Locale.default = and FastGettext.default_locale = . Note Locale.current = only sets the locale for the current thread. That said I have no idea what happens if you try to switch the locale, but the corresponding language support hasn't been installed? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title Melissa Stone commented on PUP-9437 Re: Make it easier to set Puppets current locale It looks like the beaker helper is modifying the locale in use by setting the environment variables `LANG` and `LANGUAGE`. Is that not sufficient for the use case with Litmus? https://github.com/puppetlabs/beaker-i18n_helper/blob/master/lib/beaker/i18n_helper.rb#L70-L73 The only other thing the helper does is install any required locale packages (https://github.com/puppetlabs/beaker-i18n_helper/blob/master/lib/beaker/i18n_helper.rb#L48-L52). I'd like to confirm that functionality isn't what you're asking for in this ticket. We just need to set which language to use (ie Japanese), not install any required packages for that language. Correct? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title Thomas Honey commented on PUP-9437 Re: Make it easier to set Puppets current locale Melissa Stone i think that was the ever knowledgeable Josh Cooper that found that nugget. At least i dont remember finding that. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title Melissa Stone updated an issue Puppet / PUP-9437 Make it easier to set Puppets current locale Change By: Melissa Stone Sprint: Coremunity Hopper Platform Core KANBAN Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title Melissa Stone commented on PUP-9437 Re: Make it easier to set Puppets current locale Thomas Honey could you point me to where the source code needs to be modified in order to change locale? I'm also not seeing where `GettextSetup.negotiate_locale(Locale.current.language)` is called in the puppet source code Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title Melissa Stone assigned an issue to Melissa Stone Puppet / PUP-9437 Make it easier to set Puppets current locale Change By: Melissa Stone Assignee: Melissa Stone Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title David Mallon commented on PUP-9437 Re: Make it easier to set Puppets current locale hey Rob Braden, just checking to see is a 'hopper' sprint a staging area for changes to be picked up imminently? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title Thomas Honey commented on PUP-9437 Re: Make it easier to set Puppets current locale I see it is scheduled for the coremunity hopper sprint, what is the timeline for that. out of interest Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title Rob Braden updated an issue Puppet / PUP-9437 Make it easier to set Puppets current locale Change By: Rob Braden Sprint: Coremunity Hopper Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title Geoff Nichols commented on PUP-9437 Re: Make it easier to set Puppets current locale Rob Braden, do we need any more information from the Modules team here? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title David Mallon commented on PUP-9437 Re: Make it easier to set Puppets current locale Hey Geoff Nichols, is there anything more you guys need from us on this ticket? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title David Mallon commented on PUP-9437 Re: Make it easier to set Puppets current locale Hey Josh Cooper, is there any more information you guys need from us? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title Thomas Honey commented on PUP-9437 Re: Make it easier to set Puppets current locale If " set the current locale without modifying puppet source code" is implemented. it removes the need for the helper library Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title Josh Cooper commented on PUP-9437 Re: Make it easier to set Puppets current locale I understand wanting to set the current locale without modifying puppet source code. That seems trivial. I didn't follow the part about the beaker i18n helper library. Are you wanting us to implement something in puppet so that the helper library can go away? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title Thomas Honey commented on PUP-9437 Re: Make it easier to set Puppets current locale Josh Cooper do you still need more information ? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title Thomas Honey commented on PUP-9437 Re: Make it easier to set Puppets current locale Josh Cooper do you still need more information ? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title Thomas Honey commented on PUP-9437 Re: Make it easier to set Puppets current locale Josh Cooper the beaker-i18n_helper library was used by the modules team to install language packs on a target OS, it only worked on debian and ubuntu. https://github.com/puppetlabs/beaker-i18n_helper/blob/master/lib/beaker/i18n_helper.rb#L48-L52 It also changed the locale on the target Os https://github.com/puppetlabs/beaker-i18n_helper/blob/master/lib/beaker/i18n_helper.rb#L70-L73 It was very limited in its capabilities. This was the only way we could test the japanese language output. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title Josh Cooper commented on PUP-9437 Re: Make it easier to set Puppets current locale David Mallon, Thomas Honey This ticket is only to set puppet's locale, and nothing more? I was a little confused about the beaker-i18n_helper comment, and whether other changes are needed in order to eliminate the helper library. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9437) Make it easier to set Puppets current locale
Title: Message Title David Mallon created an issue Puppet / PUP-9437 Make it easier to set Puppets current locale Issue Type: Story Assignee: Unassigned Created: 2019/01/14 6:35 AM Priority: Normal Reporter: David Mallon We should come up with a better way to set puppet's current locale instead of modifying the puppet source code. It'd be easy to add a "locale" puppet setting and have that take precedence over "GettextSetup.negotiate_locale(Locale.current.language)". Maybe it's already possible to change "GettextSetup.negotiate_locale(Locale.current.language)" via an environment variable? Currently, we have a helper library that is very limited and extremely clunky. https://github.com/puppetlabs/beaker-i18n_helper It was written in a pinch, and it needs to die. Can we get the above feature prioritised ? Add Comment
