Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title Claire Cadman updated an issue Puppet / PUP-9505 Fact yaml should quote mac addresses. Change By: Claire Cadman Labels: community doc_reviewed platform_7 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.296813.1550680699000.53369.1602509040029%40Atlassian.JIRA.
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title Oana Tanasoiu updated an issue Puppet / PUP-9505 Fact yaml should quote mac addresses. Change By: Oana Tanasoiu Release Notes Summary: Previously when puppet facts were called with `--render-as yaml` option, `macaddress` fact was unquoted which can result in some bad data if other tools will parse the resulted yaml and will interpret the value as a sexagesimal (base 60) integer if the address address doesn't contain any chars A-F.The fix consists in quoting all yaml strings that contain the `:` character (macaddress, ipv6 ip addresses and date/time facts) Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.296813.1550680699000.52180.1602189720027%40Atlassian.JIRA.
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title Oana Tanasoiu updated an issue Puppet / PUP-9505 Fact yaml should quote mac addresses. Change By: Oana Tanasoiu Release Notes: Bug Fix Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.296813.1550680699000.52178.1602189420031%40Atlassian.JIRA.
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9505 Fact yaml should quote mac addresses. Change By: Josh Cooper Fix Version/s: PUP 6.19.0 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.296813.1550680699000.51880.1602175200619%40Atlassian.JIRA.
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title Josh Cooper commented on PUP-9505 Re: Fact yaml should quote mac addresses. Merged to master in https://github.com/puppetlabs/puppet/commit/c12840426e42580d85271efd78062ebfe9840624 FACTER_QUOTED=64:52:11:22:03:25 bundle exec puppet facts find . --render_as yaml | grep quoted quoted: "64:52:11:22:03:25" Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.296813.1550680699000.51867.1602175140030%40Atlassian.JIRA.
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title Bogdan Irimie updated an issue Puppet / PUP-9505 Fact yaml should quote mac addresses. Change By: Bogdan Irimie Sprint: ghost-16.09, ghost-23.09, ghost-30.09, ghost-7.10 , ready for triage 2 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.296813.1550680699000.50470.1602075900659%40Atlassian.JIRA.
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title Oana Tanasoiu assigned an issue to Oana Tanasoiu Puppet / PUP-9505 Fact yaml should quote mac addresses. Change By: Oana Tanasoiu Assignee: Oana Tanasoiu Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.296813.1550680699000.46562.1601491980039%40Atlassian.JIRA.
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title Bogdan Irimie updated an issue Puppet / PUP-9505 Fact yaml should quote mac addresses. Change By: Bogdan Irimie Sprint: ghost-16.09, ghost-23.09, ghost-30.09 , ready for triage 2 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.296813.1550680699000.46122.1601471041903%40Atlassian.JIRA.
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title Bogdan Irimie updated an issue Puppet / PUP-9505 Fact yaml should quote mac addresses. Change By: Bogdan Irimie Sprint: ghost-16.09, ghost-23.09 , ready for triage 2 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.296813.1550680699000.41168.160080427%40Atlassian.JIRA.
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title Bogdan Irimie updated an issue Puppet / PUP-9505 Fact yaml should quote mac addresses. Change By: Bogdan Irimie Sprint: ghost-16.09 , ready for triage 2 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.296813.1550680699000.37107.1600261860170%40Atlassian.JIRA.
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title Bogdan Irimie updated an issue Puppet / PUP-9505 Fact yaml should quote mac addresses. Change By: Bogdan Irimie Story Points: 1 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.296813.1550680699000.32467.159966347%40Atlassian.JIRA.
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title Bogdan Irimie updated an issue Puppet / PUP-9505 Fact yaml should quote mac addresses. Change By: Bogdan Irimie Sprint: ready for triage ghost-16.09 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.296813.1550680699000.32466.1599659940027%40Atlassian.JIRA.
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title Alexander Fisher commented on PUP-9505 Re: Fact yaml should quote mac addresses. Yes, it's a ruby version issue and a bug IMO. I opened a ticket https://github.com/ruby/psych/issues/387 but got zero feedback. Could this be monkey-patched or similar in puppet?? Another Foreman user hit the same issue yesterday with a fact that contains scsi-ids. See https://community.theforeman.org/t/custom-facts-in-foreman/20036 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.296813.1550680699000.15462.1597312260023%40Atlassian.JIRA.
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title Mihai Buzgau updated an issue Puppet / PUP-9505 Fact yaml should quote mac addresses. Change By: Mihai Buzgau Sprint: ready for triage Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.296813.1550680699000.13632.1597148641923%40Atlassian.JIRA.
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title Bogdan Irimie updated an issue Puppet / PUP-9505 Fact yaml should quote mac addresses. Change By: Bogdan Irimie Attachment: puppet_facts__render_as_yaml Attachment: facter4_yaml_with_numbers Attachment: facter4_yaml_with_letters Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.296813.1550680699000.85744.1591955100040%40Atlassian.JIRA.
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9505 Fact yaml should quote mac addresses. Change By: Josh Cooper Team: Coremunity Night's Watch Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.296813.1550680699000.84745.1591850220042%40Atlassian.JIRA.
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9505 Fact yaml should quote mac addresses. Change By: Josh Cooper Sub-team: ghost Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.296813.1550680699000.84746.1591850220083%40Atlassian.JIRA.
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9505 Fact yaml should quote mac addresses. Change By: Josh Cooper Sprint: Coremunity Grooming Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.296813.1550680699000.103091.1568777281738%40Atlassian.JIRA.
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title
Branan Riley commented on PUP-9505
Re: Fact yaml should quote mac addresses.
Some quick poking shows we're properly passing the mac address as a String object to Ruby from CFacter, and that the YAML serialization correctly quotes a string that's possibly parseable as an integer:
irb(main):006:0> Facter.value('macaddress').class
=> String
irb(main):007:0> require 'yaml'
=> true
irb(main):008:0> YAML.dump(Facter.value('macaddress'))
=> "--- d4:81:d7:24:87:6f\n...\n"
irb(main):009:0> YAML.dump("44:49:56")
=> "--- '44:49:56'\n"
This is with Facter 3.11.5 and Ruby 2.4.3 on my laptop. I'm unsure how we're ending up with unquoted values in the YAML output - possibly this is a ruby version issue that causes different behaviors with the output here? This would probably be a Ruby bug, in that case.
Add
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title Josh Cooper commented on PUP-9505 Re: Fact yaml should quote mac addresses. Native facter defines macaddress to be a string in its schema, and knows to emit it as a quoted string: [root@ka8y738etxt42jh ~]# facter --version 3.13.1 (commit 4e1df48f76caa0eaeee90af4239a1df450d45cd7) [root@ka8y738etxt42jh ~]# facter -y macaddress macaddress: "00:50:56:9a:8f:a7" But puppet facts --render-as yaml doesn't know about the type information, and emits it in the plain style: [root@ka8y738etxt42jh ~]# puppet --version 6.4.0 [root@ka8y738etxt42jh ~]# puppet facts --render-as yaml | grep macaddress macaddress: 00:50:56:9a:8f:a7 macaddress_ens160: 00:50:56:9a:8f:a7 Since fact types are not sent along with the facts to the puppetserver, I don't know if there's anything that we can do differently? /cc Branan Riley, Henrik Lindberg
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9505 Fact yaml should quote mac addresses. Change By: Josh Cooper Sprint: Coremunity Hopper Grooming Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title Jorie Tappa updated an issue Puppet / PUP-9505 Fact yaml should quote mac addresses. Change By: Jorie Tappa Sprint: Coremunity Hopper Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title Jorie Tappa updated an issue Puppet / PUP-9505 Fact yaml should quote mac addresses. Change By: Jorie Tappa Team: Coremunity Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title
Alexander Fisher commented on PUP-9505
Re: Fact yaml should quote mac addresses.
At first I thought ruby 2.5.3 didn't parse unquoted mac addresses as sexagesimal because it implements yaml 1.2. Actually, I think it's because of this commit https://github.com/ruby/psych/commit/4ae7a3efbc5a423ee288bd734545f834b3cd426b
irb(main):007:0> YAML.load('macaddress: 44:49:56')
=> {"macaddress"=>161396}
irb(main):008:0> YAML.load('macaddress: 52:54:00:44:49:56')
=> {"macaddress"=>"52:54:00:44:49:56"}
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title
Ewoud Kohl van Wijngaarden commented on PUP-9505
Re: Fact yaml should quote mac addresses.
And Python does yet something else:
$ echo "import yaml ; print(yaml.load('macaddress: 52:54:00:44:49:56'))" | python
{'macaddress': 41135201396}
$ echo "import yaml ; print(yaml.load('macaddress: 52:54:00:44:49:56'))" | python3
{'macaddress': 41135201396}
Long term it might be better to store this as JSON.
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title
Alexander Fisher commented on PUP-9505
Re: Fact yaml should quote mac addresses.
How the yaml is parsed/emitted depends on the the version of ruby... System ruby: 2.0.0 (RHEL 7)
irb(main):002:0> YAML.load('macaddress: 52:54:00:44:49:56')
=> {"macaddress"=>12465480}
Puppet ruby 2.5.3
irb(main):003:0> YAML.load('macaddress: 52:54:00:44:49:56')
=> {"macaddress"=>"52:54:00:44:49:56"}
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-9505) Fact yaml should quote mac addresses.
Title: Message Title Alexander Fisher created an issue Puppet / PUP-9505 Fact yaml should quote mac addresses. Issue Type: Bug Affects Versions: PUP 6.2.0 Assignee: Unassigned Created: 2019/02/20 8:38 AM Priority: Normal Reporter: Alexander Fisher In puppet 6 (and not in 5), `puppet facts --render-as yaml` outputs mac addresses unquoted. If your mac address doesn't contain any chars A-F this is a problem as other tools parsing this yaml will interpret the value as a sexagesimal (base 60) integer. https://yaml.org/type/int.html Cached fact data in /opt/puppetlabs/server/data/puppetserver/yaml/facts is also broken. One tool affected by this problem is the enc script that ships with Foreman. It loads data from /opt/puppetlabs/server/data/puppetserver/yaml/facts/some_node.yaml and uploads the facts to foreman as json. Foreman understandably doesn't like the mac address it receives in the payload. Add Comment
