Jira (PUP-9566) Allow to send extra headers when requesting a catalog compilation

2019-09-25 Thread Nacho Barrientos (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Nacho Barrientos commented on  PUP-9566  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Allow to send extra headers when requesting a catalog compilation   
 

  
 
 
 
 

 
 Hi, For info we've had our proposed patch in production for a while now. We'll see if we can de-fork in the future, depending on how you implement the feature. Thanks!  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.300606.1552923936000.113267.1569394800493%40Atlassian.JIRA.


Jira (PUP-9566) Allow to send extra headers when requesting a catalog compilation

2019-09-24 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-9566  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Allow to send extra headers when requesting a catalog compilation   
 

  
 
 
 
 

 
 We are working on improvements to the agent's HTTP code, and it will be fairly straightforward to add additional HTTP headers when the agent is talking to the puppetserver service.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.300606.1552923936000.113003.1569369240664%40Atlassian.JIRA.


Jira (PUP-9566) Allow to send extra headers when requesting a catalog compilation

2019-08-13 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper assigned an issue to Unassigned  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9566  
 
 
  Allow to send extra headers when requesting a catalog compilation   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Assignee: 
 David Moreno García  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.300606.1552923936000.54914.1565741281344%40Atlassian.JIRA.


Jira (PUP-9566) Allow to send extra headers when requesting a catalog compilation

2019-06-17 Thread Ethan Brown (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Ethan Brown commented on  PUP-9566  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Allow to send extra headers when requesting a catalog compilation   
 

  
 
 
 
 

 
 Thanks for the comments Josh Cooper What other HTTP requests does Puppet make outside of requests to Puppetserver and HTTP backed file resources? Would hostname matching be a good mechanism for restricting headers for specific use cases? I'm thinking about something like csr_attributes - i.e. a separate YAML map of host -> array of additional headers. That's probably more complexity than we would want to add for this and it may become difficult to keep the server hostname in puppet.conf synchronized with a new sidecar file (rather than just using the servers hostname automatically to restrict) - but trying to come up with something that isn't so hardcoded around the identity of puppetserver.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.300606.1552923936000.49951.1560799860846%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9566) Allow to send extra headers when requesting a catalog compilation

2019-06-11 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper commented on  PUP-9566  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Allow to send extra headers when requesting a catalog compilation   
 

  
 
 
 
 

 
 One of our main concerns is people assuming puppet uses HTTPS to connect to puppetservers, and thinking it's ok to add sensitive headers, such as session ids. However, if puppet sends headers everywhere, then it could leak sensitive info when retrieving file content from insecure HTTP file servers. I think restricting the extra headers to puppet-y requests is possible, it's just unfortunately not as clean as it could be due to the various ways the agent makes http requests.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.300606.1552923936000.42713.1560280260305%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9566) Allow to send extra headers when requesting a catalog compilation

2019-06-06 Thread Nacho Barrientos (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Nacho Barrientos commented on  PUP-9566  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Allow to send extra headers when requesting a catalog compilation   
 

  
 
 
 
 

 
 Hi Rob, Thanks for coming back to us. In our case actually, as explained by David, we only need to add custom headers to the requests sent by the agents when they chat to the Puppet servers. It'd be perhaps interesting to configure the HTTP client to restrict what type of requests will be modified (by path, for instance) but indeed it's not worth to spend time on this due to how the client is implemented. This is totally an agent-oriented change proposal. In our case our agents only talk to the Puppet servers so to make use of this new feature the only thing that we had to do configuration-wise was to add the new setting to the [agent] section of the puppet.conf available on the agents and that was it. Puppet servers were left untouched as we don't need them to send any extra headers to any endpoint. I personally don't see a risk if the default behavior is to not to send anything extra so nothing changes, that indeed combined with a good description in the documentation. Obviously administrators could send anything they wanted but that's their choice. On top of that, there's nothing harmful that you could naively do (like when using a switch), users must explicitly configure what data to send in those arbitrary headers. Overloading the User-Agent could be a solution but I think it's far from being elegant. Actually we're already using that header for something else and adding non-standard data there could be painful as it'd require doing some post-processing on our monitoring pipelines to remove undesired stuff. We cannot provide much more information than what has been described in previous posts, not because we can't share more details but because there isn't much more really. We want to send metadata from the agent side that will be consumed by the ingress layer to make routing decisions. As Puppet talks HTTP we think that HTTP headers is a good fit for this. Using extended attributes in the client's certificate is unfortunately not an option for us at the moment. This new feature was born in the context of deploying our masters on Kubernetes clusters, however it could be useful in many more situations outside of the containers world.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
   

Jira (PUP-9566) Allow to send extra headers when requesting a catalog compilation

2019-06-05 Thread Rob Braden (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Rob Braden commented on  PUP-9566  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Allow to send extra headers when requesting a catalog compilation   
 

  
 
 
 
 

 
 Nacho Barrientos David Moreno García - I think we may want to get some additional context regarding your use case. The primary concern right now is that this adds headers to all requests made by Puppet, not just requests to Puppet servers. If we do adopt this patch we'll want to be careful to document the behavior, as there is some potential for information leakage if users don't understand the behavior. It seems like it would be possible to configure puppet to only add the custom header when connecting to a defined set of infrastructure, but the way the http client code is currently implemented, it would be messy and complex.  We do have some improvements planned that will help, but that doesn't address your immediate needs. The option exists now to change the User Agent string, does that help with your use case? If not, can you provide any other specifics that may help us understand what you're trying to accomplish?  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.300606.1552923936000.36403.1559777820616%40Atlassian.JIRA.
For more options, visit 

Jira (PUP-9566) Allow to send extra headers when requesting a catalog compilation

2019-05-21 Thread Jorie Tappa (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jorie Tappa commented on  PUP-9566  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Allow to send extra headers when requesting a catalog compilation   
 

  
 
 
 
 

 
 Hi Nacho Barrientos, this does mean for now we won't be accepting the patch. I'll close the PR and this ticket, and in the case that this gets prioritized and scoped out at some point, we can always reopen the ticket.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.300606.1552923936000.14281.1558454822137%40Atlassian.JIRA.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9566) Allow to send extra headers when requesting a catalog compilation

2019-05-02 Thread Nacho Barrientos (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Nacho Barrientos commented on  PUP-9566  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Allow to send extra headers when requesting a catalog compilation   
 

  
 
 
 
 

 
 Hi Rob, Thanks for your input. Does that mean that you're not going to consider the proposed patch? If so, please let us know as soon as possible as in that case unfortunately we'll have to fork.   Thanks.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9566) Allow to send extra headers when requesting a catalog compilation

2019-05-01 Thread Rob Braden (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Rob Braden commented on  PUP-9566  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Allow to send extra headers when requesting a catalog compilation   
 

  
 
 
 
 

 
 David Moreno García We're going to take a step back and work with our product management team to review the wider use cases of running puppet infrastructure on kubernetes and possible improvements to make that a better experience.  In that context, this is not going to be a short term priority but any input on use cases and problems is very welcome.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9566) Allow to send extra headers when requesting a catalog compilation

2019-03-21 Thread Nacho Barrientos (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Nacho Barrientos commented on  PUP-9566  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Allow to send extra headers when requesting a catalog compilation   
 

  
 
 
 
 

 
 I agree with David that in our case using headers is much more lightweight in terms of operational cost and maintenance. As he mentioned, we're planning on using an agent-generated header to give a "hint" to the load balancing layer and then verify on the backend that the node is actually authorised to make such request doing an RPC to a trusted source of information. Apart from the issue when changing the hostgroup, persuading the managers of the external CA to sign CSRs containing the extra header (that must be validated) might be a PITA for us.    
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9566) Allow to send extra headers when requesting a catalog compilation

2019-03-20 Thread Charlie Sharpsteen (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Charlie Sharpsteen commented on  PUP-9566  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Allow to send extra headers when requesting a catalog compilation   
 

  
 
 
 
 

 
 That is correct, changing trusted data would require the certificate to be re-issued. If that is a thing that happens frequently, then headers would be a better approach.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9566) Allow to send extra headers when requesting a catalog compilation

2019-03-20 Thread (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 David Moreno García commented on  PUP-9566  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Allow to send extra headers when requesting a catalog compilation   
 

  
 
 
 
 

 
 Charlie Sharpsteen Correct me if I'm mistaken but if using trusted facts, changing a node to a different hostgroup would require to regenerate the certificate, right? We have an external CA. Headers would be a much easier approach.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9566) Allow to send extra headers when requesting a catalog compilation

2019-03-20 Thread Charlie Sharpsteen (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Charlie Sharpsteen commented on  PUP-9566  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Allow to send extra headers when requesting a catalog compilation   
 

  
 
 
 
 

 
 Is the Ingress service able to make decisions based on attributes in the client's TLS certificate? If so, then Puppet's trusted facts might be a way to accomplish this.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9566) Allow to send extra headers when requesting a catalog compilation

2019-03-20 Thread (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 David Moreno García updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9566  
 
 
  Allow to send extra headers when requesting a catalog compilation   
 

  
 
 
 
 

 
Change By: 
 David Moreno García  
 
 
Attachment: 
 diagram.png  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9566) Allow to send extra headers when requesting a catalog compilation

2019-03-20 Thread (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 David Moreno García commented on  PUP-9566  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Allow to send extra headers when requesting a catalog compilation   
 

  
 
 
 
 

 
 The goal here is to have a single k8s cluster with a namespace for each of our top level hostgroups. Those namespaces will have several Puppet Servers to attend requests from nodes of that top level hostgroup. To loadbalance the traffic to those pods we have a k8s service and in front of all these namespaces with have Ingres. What we are trying to do is to have a single entry point to the cluster (single server and single port) for all our agents independently of their top level hostgroup. The header will be use in the ingress controller to decide to which service/namespace to send the request. I attached a diagram to show it a bit more clearly. Let me know if that helps.
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9566) Allow to send extra headers when requesting a catalog compilation

2019-03-20 Thread (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 David Moreno García updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9566  
 
 
  Allow to send extra headers when requesting a catalog compilation   
 

  
 
 
 
 

 
Change By: 
 David Moreno García  
 
 
Attachment: 
 diagram.png  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9566) Allow to send extra headers when requesting a catalog compilation

2019-03-20 Thread (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 David Moreno García updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9566  
 
 
  Allow to send extra headers when requesting a catalog compilation   
 

  
 
 
 
 

 
Change By: 
 David Moreno García  
 
 
Attachment: 
 diagram.png  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9566) Allow to send extra headers when requesting a catalog compilation

2019-03-20 Thread Jacob Helwig (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jacob Helwig commented on  PUP-9566  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Allow to send extra headers when requesting a catalog compilation   
 

  
 
 
 
 

 
 David Moreno García I'm trying to fully understand the use-case here, as the PR would also add the header(s) to HTTP(S) requests to non-Puppet servers, which seems like it might be troublesome. Is there a reason that splitting out what used to be separate Puppet servers into their own services in Kubernetes wouldn't work? This would give them each their own unique ingress port. You mentioned sending all the agents to the same "server" (Kubernetes service) and trying to redirect to individual instances in the pod, but I'm a bit confused why the requests would need to be redirected to specific instances within the pod, when all instances within a pod are supposed to be identical. I'm not sure what I'm missing about the setup you're describing.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9566) Allow to send extra headers when requesting a catalog compilation

2019-03-18 Thread Jorie Tappa (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jorie Tappa updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9566  
 
 
  Allow to send extra headers when requesting a catalog compilation   
 

  
 
 
 
 

 
Change By: 
 Jorie Tappa  
 
 
Team: 
 Coremunity  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9566) Allow to send extra headers when requesting a catalog compilation

2019-03-18 Thread (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 David Moreno García commented on  PUP-9566  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Allow to send extra headers when requesting a catalog compilation   
 

  
 
 
 
 

 
 Pull request with the change: https://github.com/puppetlabs/puppet/pull/7430  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-9566) Allow to send extra headers when requesting a catalog compilation

2019-03-18 Thread (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 David Moreno García created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-9566  
 
 
  Allow to send extra headers when requesting a catalog compilation   
 

  
 
 
 
 

 
Issue Type: 
  New Feature  
 
 
Assignee: 
 David Moreno García  
 
 
Created: 
 2019/03/18 8:45 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 David Moreno García  
 

  
 
 
 
 

 
 Pointing a set of Puppet Agents to different Puppet Servers is only possible by changing the "server" or "port" values in the puppet.conf. In this new approach, we are trying to deploy our servers in a Kubernetes cluster and point all the agents to the same server and port (the cluster's Ingress). For this to work, we need a mechanism to indicate where the traffic should be redirected. The easiest way to do this is by setting a header in the Puppet Agent's request. This change will allow to set extra headers to be send every time Puppet Agent is executed on the node. Our set up is just a use case for this new feature but the community could also benefit form it.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment