Jira (PUP-9601) mount resource should trigger 'systemctl daemon-reload'
Title: Message Title
Gheorghe Popescu commented on PUP-9601
Re: mount resource should trigger 'systemctl daemon-reload'
Hi Adam Winberg After looking more in-depth into this issue i believe this can be solved using a notify to 'systemctl daemon-reload' and the service created by systemd. For example:
$mount_name="test"
mount {"/mnt/${mount_name}":
ensure => 'present',
device => "fs_server:/opt/${mount_name}",
fstype => 'nfs',
options => 'noauto,x-systemd.automount,x-systemd.device-timeout=10,x-systemd.mount-timeout=30,x-systemd.idle-timeout=60,_netdev',
notify => [Exec['systemctl daemon-reload'], Service["mnt-${mount_name}.mount"]]
}
exec {'systemctl daemon-reload':
refreshonly => true,
path=> ['/usr/bin', '/usr/sbin',]
Jira (PUP-9601) mount resource should trigger 'systemctl daemon-reload'
Title: Message Title Mihai Buzgau updated an issue Puppet / PUP-9601 mount resource should trigger 'systemctl daemon-reload' Change By: Mihai Buzgau Sprint: PR - 2019-04-17, PR - 2019-05-02 , PR - 2019-05-15 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9601) mount resource should trigger 'systemctl daemon-reload'
Title: Message Title Gheorghe Popescu commented on PUP-9601 Re: mount resource should trigger 'systemctl daemon-reload' I understand, thanks Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9601) mount resource should trigger 'systemctl daemon-reload'
Title: Message Title Adam Winberg commented on PUP-9601 Re: mount resource should trigger 'systemctl daemon-reload' Regardless of which components you use that is more a question of automount vs. static mounts and I'm not sure why that is relevant here. But some of the advantages for us are: Automounting only mounts on access and automatically unmounts after inactivity so a server only activates a mount if it needs it (less network activity, less hassle if we need to change some mount options). If one mount is having an issue it wont affect system boot (and puppet wont error and time out trying to mount it). Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9601) mount resource should trigger 'systemctl daemon-reload'
Title: Message Title Gheorghe Popescu commented on PUP-9601 Re: mount resource should trigger 'systemctl daemon-reload' Is there any reason why are you relying on systemd for automount instead of letting puppet use "mounted" option? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9601) mount resource should trigger 'systemctl daemon-reload'
Title: Message Title Adam Winberg commented on PUP-9601 Re: mount resource should trigger 'systemctl daemon-reload' Gheorghe Popescu That doesnt really fit my usecase, since I use systemd for automount. So puppet should only make sure that the mount is added to the fstab but disregard whether the mount is mounted or not (i.e. 'present'). Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9601) mount resource should trigger 'systemctl daemon-reload'
Title: Message Title Gheorghe Popescu commented on PUP-9601 Re: mount resource should trigger 'systemctl daemon-reload' Adam Winberg i looked over the issue and on puppet documentation for the mount resource it says that you can specify different values for the ensure attribute. Could you check that using ensure => "mounted" instead of ensure => "present" solves your issue? https://puppet.com/docs/puppet/5.3/types/mount.html#mount-attribute-ensure Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9601) mount resource should trigger 'systemctl daemon-reload'
Title: Message Title Mihai Buzgau updated an issue Puppet / PUP-9601 mount resource should trigger 'systemctl daemon-reload' Change By: Mihai Buzgau Sprint: PR - 2019-04-17 , PR - 2019-05-02 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9601) mount resource should trigger 'systemctl daemon-reload'
Title: Message Title Gheorghe Popescu assigned an issue to Gheorghe Popescu Puppet / PUP-9601 mount resource should trigger 'systemctl daemon-reload' Change By: Gheorghe Popescu Assignee: Gheorghe Popescu Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9601) mount resource should trigger 'systemctl daemon-reload'
Title: Message Title Adam Winberg commented on PUP-9601 Re: mount resource should trigger 'systemctl daemon-reload' Additionally you would also need to trigger a systemctl restart remote-fs.target or systemctl restart local-fs.target , depending on whether the mount is remote (for example nfs) or local. Otherwise systemd will not create the mountpoints until next reboot. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because
Jira (PUP-9601) mount resource should trigger 'systemctl daemon-reload'
Title: Message Title Mihai Buzgau updated an issue Puppet / PUP-9601 mount resource should trigger 'systemctl daemon-reload' Change By: Mihai Buzgau Story Points: 3 Sprint: PR - 2019-04-17 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9601) mount resource should trigger 'systemctl daemon-reload'
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9601 mount resource should trigger 'systemctl daemon-reload' Change By: Josh Cooper Labels: mount Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9601) mount resource should trigger 'systemctl daemon-reload'
Title: Message Title Josh Cooper commented on PUP-9601 Re: mount resource should trigger 'systemctl daemon-reload' ping Mihai Buzgau Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9601) mount resource should trigger 'systemctl daemon-reload'
Title: Message Title Josh Cooper updated an issue Puppet / PUP-9601 mount resource should trigger 'systemctl daemon-reload' Change By: Josh Cooper Team: Puppet Romania Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-9601) mount resource should trigger 'systemctl daemon-reload'
Title: Message Title
Adam Winberg updated an issue
Puppet / PUP-9601
mount resource should trigger 'systemctl daemon-reload'
Change By:
Adam Winberg
*Puppet Version: 5.5.3* *Puppet Server Version: 5.3.3* *OS Name/Version: RHEL7*On systemd distributions entries in /etc/fstab automatically generates systemd .mount files, resulting in systemd effectively managing the mount. When changes are made to /etc/fstab, 'systemctl daemon-reload' must be called in order to generate new systemd mount files. It seems natural to me that puppets mount resource automatically should trigger this reload on changes in fstab if systemd is present, which it does not do currently. *Desired Behavior:*Changes in mount resources should always trigger a reload of systemd configuration (systemctl daemon-reload)*Actual Behavior:*Changes in mount resource only updates fstab. Changes will not update corresponding systemd .mount files until reboot or issuing a 'systemctl daemon-reload' manually. This is particularly inconvinient when using systemd automounting.Following puppet mount:{code:java} mount {"/temp": ensure => 'present', device => 'fs_server:/temp', fstype => 'nfs', options => 'noauto,x-systemd.automount,x-systemd.device-timeout=10,x-systemd.mount-timeout=30,x-systemd.idle-timeout=60,_netdev,vers=4.0,sec=krb5 , ' }{code}creates a line in fstab for this mount, but does not create any corresponding systemd mount files. So, in this case, 'mount /temp' will work but not 'systemctl start temp.mount'. On boot, however, systemd will generate mount files (one .mount and one .automount) for this mount automatically. On access the filesystem will be mounted automatically by systemd, and unmounted after 60s of inactivity. If I change mount options for this mount, the fstab will be updated but since the systemd files are not updated any automounting after the change will still use the old options.I can workaround this in my code by notifying a 'systemctl daemon-reload' in my mount definition, but if the mount fails for some reason (typically because of a failed remount) the reload command will not run leaving my system in an inconsistent state.
Add Comment
Jira (PUP-9601) mount resource should trigger 'systemctl daemon-reload'
Title: Message Title
Adam Winberg created an issue
Puppet / PUP-9601
mount resource should trigger 'systemctl daemon-reload'
Issue Type:
Bug
Affects Versions:
PUP 5.5.3
Assignee:
Unassigned
Created:
2019/04/03 4:01 AM
Priority:
Normal
Reporter:
Adam Winberg
Puppet Version: 5.5.3 Puppet Server Version: 5.3.3 OS Name/Version: RHEL7 On systemd distributions entries in /etc/fstab automatically generates systemd .mount files, resulting in systemd effectively managing the mount. When changes are made to /etc/fstab, 'systemctl daemon-reload' must be called in order to generate new systemd mount files. It seems natural to me that puppets mount resource automatically should trigger this reload on changes in fstab if systemd is present, which it does not do currently. Desired Behavior: Changes in mount resources should always trigger a reload of systemd configuration (systemctl daemon-reload) Actual Behavior: Changes in mount resource only updates fstab. Changes will not update corresponding systemd .mount files until reboot or issuing a 'systemctl daemon-reload' manually. This is particularly inconvinient when using systemd automounting. Following puppet mount:
mount {"/temp":
ensure => 'present',
device => 'fs_server:/temp',
