Jira (BOLT-566) Explore syntax options for applying manifest code from a plan
Title: Message Title Alex Dreyer updated an issue Puppet Task Runner / BOLT-566 Explore syntax options for applying manifest code from a plan Change By: Alex Dreyer What options are possible for applying a manifest from puppet code without relying on heredocs or external files. The result of this ticket should be a few options that are feasible in the parse and can be user tested.Requirements1. Accepts arguments2. Accepts a chunk of inline manifest code3. Probably starts with a recognizable understandable keyword4. Should not allow nested invocationsQuestions:1. How much should it look like a function call What examples do we want to use for the user test 2. How can What non-module syntax do we limit ambiguity want? 3. How should apply_file work? What is natural for users. the file path relative too? Is it a function? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsub
Jira (BOLT-566) Explore syntax options for applying manifest code from a plan
Title: Message Title Alex Dreyer commented on BOLT-566 Re: Explore syntax options for applying manifest code from a plan Henrik Lindberg see BOLT-567. Our plan is to compile the catalogs in a subprocess for now. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-566) Explore syntax options for applying manifest code from a plan
Title: Message Title
Henrik Lindberg commented on BOLT-566
Re: Explore syntax options for applying manifest code from a plan
You are right, by adding a keyword you are relatively free to do what you want after that. You are still reusing statements and parameters so it is pretty much the full language you get there. (Changing those are much harder). More work is required since the task compiler does not have a catalog and will validate all resource expressions, class definitions, etc. as errors (since the constructs are not supported). The start looks good - I noticed a few things:
There is an unused "parent" attribute in ApplyExpression
An entry is missing in "model_label_provider.rb" for ApplyExpression.
Something is probably wanted in the validator ("checker4_0.rb") - see how other things having parameters and a body are validated.
You probably want opt_statements rule as opposed to statements to make it possible to comment out the entire body of an apply (would otherwise be a syntax error).
One tricky thing is to clean up between applies - the regular compiler keeps track of if definitions have been evaluated or not, it does lazy resolution of dependencies, it validates the catalog at the end, etc. etc. (I am sure there will be other tickets for this, but maybe worth considering the consequences when designing the syntax as semantics may be affected).
Add Comment
This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (BOLT-566) Explore syntax options for applying manifest code from a plan
Title: Message Title Alex Dreyer assigned an issue to Michael Smith Puppet Task Runner / BOLT-566 Explore syntax options for applying manifest code from a plan Change By: Alex Dreyer Assignee: Michael Schietzsch Smith Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-566) Explore syntax options for applying manifest code from a plan
Title: Message Title Alex Dreyer assigned an issue to Michael Schietzsch Puppet Task Runner / BOLT-566 Explore syntax options for applying manifest code from a plan Change By: Alex Dreyer Assignee: Michael Schietzsch Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-566) Explore syntax options for applying manifest code from a plan
Title: Message Title Michael Smith commented on BOLT-566 Re: Explore syntax options for applying manifest code from a plan I took a stab at what grammar changes might be for the original proposal in https://github.com/puppetlabs/puppet/compare/master...MikaelSmith:apply-grammar. I don't think an unambiguous grammar following apply will be hard. It will prevent anyone else from writing a function or type named apply (or whatever keyword is selected). If we're going to allow manifest code to directly refer to things outside its scope, then I lean towards using curly braces to enclose the manifest code. If not, then I'd opt for something that makes it appear distinct from other code constructs. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (BOLT-566) Explore syntax options for applying manifest code from a plan
Title: Message Title Alex Dreyer created an issue Puppet Task Runner / BOLT-566 Explore syntax options for applying manifest code from a plan Issue Type: Task Assignee: Unassigned Created: 2018/06/06 2:27 PM Priority: Normal Reporter: Alex Dreyer What options are possible for applying a manifest from puppet code without relying on heredocs or external files. The result of this ticket should be a few options that are feasible in the parse and can be user tested. Requirements 1. Accepts arguments 2. Accepts a chunk of inline manifest code 3. Probably starts with a recognizable understandable keyword 4. Should not allow nested invocations Questions: 1. How much should it look like a function call 2. How can we limit ambiguity 3. What is natural for users. Add Comment
