Jira (FACT-1504) Uptime resolver fact for Windows uses unreliable metric for uptime

2018-04-09 Thread Enis Inan (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Enis Inan updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1504  
 
 
  Uptime resolver fact for Windows uses unreliable metric for uptime   
 

  
 
 
 
 

 
Change By: 
 Enis Inan  
 
 
Fix Version/s: 
 FACT 3.9.6  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1504) Uptime resolver fact for Windows uses unreliable metric for uptime

2018-04-06 Thread Jonathan Morris (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jonathan Morris updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1504  
 
 
  Uptime resolver fact for Windows uses unreliable metric for uptime   
 

  
 
 
 
 

 
Change By: 
 Jonathan Morris  
 
 
Fix Version/s: 
 FACT 3.6.10  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1504) Uptime resolver fact for Windows uses unreliable metric for uptime

2018-03-15 Thread Jayant Sane (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jayant Sane updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1504  
 
 
  Uptime resolver fact for Windows uses unreliable metric for uptime   
 

  
 
 
 
 

 
Change By: 
 Jayant Sane  
 
 
Release Notes Summary: 
 Windows uptime fact now uses GetTickCount64 which is more reliable, minimizes clock skews, and offers better resolution than the earlier method of computing using WMI BootUptime which has proved to be error prone.   
 
 
Release Notes: 
 Bug Fix  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1504) Uptime resolver fact for Windows uses unreliable metric for uptime

2018-03-14 Thread Geoff Nichols (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Geoff Nichols commented on  FACT-1504  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Uptime resolver fact for Windows uses unreliable metric for uptime   
 

  
 
 
 
 

 
 Jayant Sane, when you have a chance, could you please add release notes (or indicate they are not needed)? Thanks!  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1504) Uptime resolver fact for Windows uses unreliable metric for uptime

2018-03-14 Thread Enis Inan (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Enis Inan updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1504  
 
 
  Uptime resolver fact for Windows uses unreliable metric for uptime   
 

  
 
 
 
 

 
Change By: 
 Enis Inan  
 
 
Fix Version/s: 
 FACT 3.y  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1504) Uptime resolver fact for Windows uses unreliable metric for uptime

2018-03-14 Thread Enis Inan (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Enis Inan updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1504  
 
 
  Uptime resolver fact for Windows uses unreliable metric for uptime   
 

  
 
 
 
 

 
Change By: 
 Enis Inan  
 
 
Fix Version/s: 
 FACT 3.11.0  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1504) Uptime resolver fact for Windows uses unreliable metric for uptime

2018-02-21 Thread Sean McDonald (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Sean McDonald updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1504  
 
 
  Uptime resolver fact for Windows uses unreliable metric for uptime   
 

  
 
 
 
 

 
Change By: 
 Sean McDonald  
 
 
Labels: 
 triaged windows  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1504) Uptime resolver fact for Windows uses unreliable metric for uptime

2018-02-20 Thread Jayant Sane (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Jayant Sane assigned an issue to Jayant Sane  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-1504  
 
 
  Uptime resolver fact for Windows uses unreliable metric for uptime   
 

  
 
 
 
 

 
Change By: 
 Jayant Sane  
 
 
Assignee: 
 Jayant Sane  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1504) Uptime resolver fact for Windows uses unreliable metric for uptime

2018-01-18 Thread Jayant Sane (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Jayant Sane commented on  FACT-1504 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Uptime resolver fact for Windows uses unreliable metric for uptime  
 
 
 
 
 
 
 
 
 
 
So i changed the uptime fact windows implementation to return GetTickCount64()/1000 and it seems to pass adhoc PA CI (https://jenkins-master-prod-1.delivery.puppetlabs.net/view/puppet-agent/view/ad-hoc/job/platform_puppet-agent-extra_puppet-agent-integration-suite_adhoc-ad_hoc/58/). It is passing all facter tests on all windows versions. There are pxp-agent failures on all targets, incl non-windows, due to what looks like env issues or transiences and not related to uptime fact.  If that is reasonable I can put up a PR.  
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1504) Uptime resolver fact for Windows uses unreliable metric for uptime

2018-01-17 Thread Ethan Brown (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Ethan Brown commented on  FACT-1504 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Uptime resolver fact for Windows uses unreliable metric for uptime  
 
 
 
 
 
 
 
 
 
 
I could have sworn we implemented GetTickCount64 somewhere, but maybe we were just tossing around the idea at the time? 
I could only find this old gist that I put together with sample code - https://gist.github.com/Iristyle/a6cb43d3d6d9f3756b29ef1706120e8b 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1504) Uptime resolver fact for Windows uses unreliable metric for uptime

2018-01-17 Thread Justin Stoller (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Justin Stoller commented on  FACT-1504 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Uptime resolver fact for Windows uses unreliable metric for uptime  
 
 
 
 
 
 
 
 
 
 
This has just caused several days of broken CI while debugging. Would love to see this prioritized soon. 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1504) Uptime resolver fact for Windows uses unreliable metric for uptime

2016-09-20 Thread Geoff Nichols (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Geoff Nichols updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Facter /  FACT-1504 
 
 
 
  Uptime resolver fact for Windows uses unreliable metric for uptime  
 
 
 
 
 
 
 
 
 

Change By:
 
 Geoff Nichols 
 
 
 

Sprint:
 
 AP Triage 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (FACT-1504) Uptime resolver fact for Windows uses unreliable metric for uptime

2016-09-08 Thread Glenn Sarti (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Glenn Sarti created an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Facter /  FACT-1504 
 
 
 
  Uptime resolver fact for Windows uses unreliable metric for uptime  
 
 
 
 
 
 
 
 
 

Issue Type:
 
  Bug 
 
 
 

Assignee:
 

 Unassigned 
 
 
 

Created:
 

 2016/09/08 3:45 PM 
 
 
 

Fix Versions:
 

 FACT 3.y 
 
 
 

Priority:
 
  Normal 
 
 
 

Reporter:
 
 Glenn Sarti 
 
 
 
 
 
 
 
 
 
 
The Windows Uptime fact uses the WMI properties of LastBootupTime and LocalDateTime from the Win32_OperatingSystem class 
https://github.com/puppetlabs/facter/blob/master/lib/src/facts/windows/uptime_resolver.cc#L40-L47 
However these measurements are prone to large clock skews causing miscalculation or, worse, negative uptime values. e.g. 
 

BootUptime is 1pm
 

After Bootup clock synchronisation rolls back time to 11am (wrong timezone)
 
 
Therefore the current time is 11am but bootup time is in the future, 1pm. 
The windows uptime fact should instead use the GetTickCount64 function exported from kernel32.dll. This has been available since Windows Vista and Server 2008 
https://msdn.microsoft.com/en-us/library/ms724411%28v=VS.85%29.aspx?f=255=-2147217396