Jira (FACT-1772) libfacter install should support other directories than /lib
Title: Message Title Josh Cooper commented on FACT-1772 Re: libfacter install should support other directories than /lib Facter 3 is EOL and is not an issue in Facter 4, so I'm going to close this. Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.214207.1506986113000.9003.1682541420020%40Atlassian.JIRA.
Jira (FACT-1772) libfacter install should support other directories than /lib
Title: Message Title Branan Riley updated an issue Facter / FACT-1772 libfacter install should support other directories than /lib Change By: Branan Riley Sprint: Platform EOL - Blocked Tasks Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1772) libfacter install should support other directories than /lib
Title: Message Title Branan Riley updated an issue Facter / FACT-1772 libfacter install should support other directories than /lib Change By: Branan Riley Sprint: Platform EOL - Blocked Tasks Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1772) libfacter install should support other directories than /lib
Title: Message Title Branan Riley updated an issue Facter / FACT-1772 libfacter install should support other directories than /lib Change By: Branan Riley Sprint: Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1772) libfacter install should support other directories than /lib
Title: Message Title Geoff Nichols updated an issue Facter / FACT-1772 libfacter install should support other directories than /lib Change By: Geoff Nichols Sprint: Platform OS Ready for Eng. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1772) libfacter install should support other directories than /lib
Title: Message Title Geoff Nichols updated an issue Facter / FACT-1772 libfacter install should support other directories than /lib Change By: Geoff Nichols Sprint: Platform OS Kanban Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1772) libfacter install should support other directories than /lib
Title: Message Title Branan Riley updated an issue Facter / FACT-1772 libfacter install should support other directories than /lib Change By: Branan Riley Labels: distro triaged Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1772) libfacter install should support other directories than /lib
Title: Message Title Geoff Nichols assigned an issue to Branan Riley Facter / FACT-1772 libfacter install should support other directories than /lib Change By: Geoff Nichols Assignee: Enis Inan Branan Riley Add Comment This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1772) libfacter install should support other directories than /lib
Title: Message Title Branan Riley commented on FACT-1772 Re: libfacter install should support other directories than /lib Enis Inan Ideally, we'd use CMAKE_INSTALL_LIBDIR (which may just be the default?) unless we're part of the puppet-agent build, in which case we'd override it to always just be "lib" (possibly just by setting -DCMAKE_INSTALL_LIBDIR=lib in the vanagon build script). This probably requires the most effort, and needs us to coordinate some change between leatherman; facter; and p-a, but I think it will simplify our CMake code and make using Facter outside of p-a much more straightforward. Add Comment This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1772) libfacter install should support other directories than /lib
Title: Message Title Enis Inan commented on FACT-1772 Re: libfacter install should support other directories than /lib Branan Riley I did some digging through the CMakeLists files of Facter, Leatherman and Cpp-Hocon. It seems like the lib install directory for Faster is set here: https://github.com/puppetlabs/facter/blob/master/lib/CMakeLists.txt#L263 ^ What is interesting is that in 3.6.x and 3.9.x, that same line is https://github.com/puppetlabs/facter/blob/3.6.x/lib/CMakeLists.txt#L255 so will the changes required in FACT-1772 only apply to the “master” branch of Facter? The LIB_SUFFIX thing comes from Leatherman, which is used in the “leatherman_install” macro: https://github.com/puppetlabs/leatherman/blob/master/cmake/leatherman.cmake.in#L81-L91 (and here is where Facter uses it): https://github.com/puppetlabs/facter/blob/master/lib/CMakeLists.txt#L356 (for libfacter) https://github.com/puppetlabs/facter/blob/master/exe/CMakeLists.txt#L39 (for executable, dunno if this matters) The changes to specify a LIB_SUFFIX were made in this commit: https://github.com/puppetlabs/leatherman/commit/448dc6c71df95a84893407a4792efcd6ae52eab1 which go all the way back to Leatherman 0.12.x. From that commit, It seems like LIB_SUFFIX, as it is currently done, needs to be manually set in CMakeCache.txt. When I set LIB_SUFFIX to “64” there, things seem to work OK — libfacter is installed to lib64 (both libfacter.so and libfacter.so.3.9.5). This is also true for the other CPP components like Leatherman and Cpp-Hocon (their libraries are also installed to lib64). It looks like there are a set of sensible defaults we can use — https://cmake.org/cmake/help/v3.0/module/GNUInstallDirs.html has them. CMAKE_INSTALL_LIBDIR gives us what we want (it is set to "lib64" on a Fedora 26 VM). If we switch to specifying our lib directory as CMAKE_INSTALL_LIBDIR, it would require quite a bit of changes. I think a sensible solution would be to strip out the "lib" part in CMAKE_INSTALL_LIBDIR and use that as the LIB_SUFFIX. Both solutions would require an extra parameter passed into cmake so that when we build the puppet-agent, things install to the /lib directory because that is where the agent expects to find everything. Of course, better solutions are welcome. Add Comment
Jira (FACT-1772) libfacter install should support other directories than /lib
Title: Message Title Enis Inan updated an issue Facter / FACT-1772 libfacter install should support other directories than /lib Change By: Enis Inan Sprint: Platform OS Ready for Eng. Kanban Add Comment This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1772) libfacter install should support other directories than /lib
Title: Message Title Enis Inan assigned an issue to Enis Inan Facter / FACT-1772 libfacter install should support other directories than /lib Change By: Enis Inan Assignee: Enis Inan Add Comment This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1772) libfacter install should support other directories than /lib
Title: Message Title Geoff Nichols updated an issue Facter / FACT-1772 libfacter install should support other directories than /lib Change By: Geoff Nichols Sprint: Platform OS Grooming/Triage Ready for Eng. Add Comment This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1772) libfacter install should support other directories than /lib
Title: Message Title Geoff Nichols updated an issue Facter / FACT-1772 libfacter install should support other directories than /lib Change By: Geoff Nichols Sprint: Platform OS Grooming /Triage Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1772) libfacter install should support other directories than /lib
Title: Message Title Branan Riley updated an issue Facter / FACT-1772 libfacter install should support other directories than /lib Change By: Branan Riley Sprint: Platform Core Grooming Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1772) libfacter install should support other directories than /lib
Title: Message Title Branan Riley updated an issue Facter / FACT-1772 libfacter install should support other directories than /lib Change By: Branan Riley Team: Platform OS Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1772) libfacter install should support other directories than /lib
Title: Message Title Branan Riley updated an issue Facter / FACT-1772 libfacter install should support other directories than /lib Change By: Branan Riley Sprint: Platform Core OS Grooming Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1772) libfacter install should support other directories than /lib
Title: Message Title Branan Riley updated an issue Facter / FACT-1772 libfacter install should support other directories than /lib Change By: Branan Riley Labels: distro Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (FACT-1772) libfacter install should support other directories than /lib
Title: Message Title James Hogarth created an issue Facter / FACT-1772 libfacter install should support other directories than /lib Issue Type: Bug Assignee: Unassigned Created: 2017/10/02 4:15 PM Priority: Normal Reporter: James Hogarth As part of the update to 3.9.0 for Fedora the facter package needs to split into facter, development headers and any bindings (eg ruby bindings) to comply with guidelines. Currently the libfacter library installs directly to /lib and the ruby bindings call on libfacter.so in /lib specifically. The library should be able to be installed to /lib64 (well /usr/lib64 but /lib64 symlinks here) to comply with the guidelines whilst packaging the update. Add Comment
