Jira (FACT-2918) FACTER_ environmental facts overrides don't work with external facts

2021-02-05 Thread Gheorghe Popescu (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Gheorghe Popescu updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2918  
 
 
  FACTER_ environmental facts overrides don't work with external facts   
 

  
 
 
 
 

 
Change By: 
 Gheorghe Popescu  
 
 
Fix Version/s: 
 FACT 4.0.50  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.383195.1610609261000.134240.1612527900027%40Atlassian.JIRA.


Jira (FACT-2918) FACTER_ environmental facts overrides don't work with external facts

2021-02-05 Thread Claire Cadman (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Claire Cadman updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2918  
 
 
  FACTER_ environmental facts overrides don't work with external facts   
 

  
 
 
 
 

 
Change By: 
 Claire Cadman  
 
 
Labels: 
 doc_reviewed jira_escalated  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.383195.1610609261000.134142.1612517280045%40Atlassian.JIRA.


Jira (FACT-2918) FACTER_ environmental facts overrides don't work with external facts

2021-02-03 Thread Dorin Pleava (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Dorin Pleava updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2918  
 
 
  FACTER_ environmental facts overrides don't work with external facts   
 

  
 
 
 
 

 
Change By: 
 Dorin Pleava  
 
 
Release Notes: 
 Bug Fix  
 
 
Release Notes Summary: 
 When running puppet facts, environment facts were overwrittenby external facts.Now the flow was set to default facts -> external facts -> environment facts  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.383195.1610609261000.131797.1612357320283%40Atlassian.JIRA.


Jira (FACT-2918) FACTER_ environmental facts overrides don't work with external facts

2021-02-03 Thread Mihai Buzgau (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihai Buzgau updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2918  
 
 
  FACTER_ environmental facts overrides don't work with external facts   
 

  
 
 
 
 

 
Change By: 
 Mihai Buzgau  
 
 
Fix Version/s: 
 FACT 3.14.16  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.383195.1610609261000.131769.1612355520042%40Atlassian.JIRA.


Jira (FACT-2918) FACTER_ environmental facts overrides don't work with external facts

2021-02-03 Thread Mihai Buzgau (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihai Buzgau updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2918  
 
 
  FACTER_ environmental facts overrides don't work with external facts   
 

  
 
 
 
 

 
Change By: 
 Mihai Buzgau  
 
 
Sprint: 
 NW - 2021-02-03 , NW - 2021-02-17  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.383195.1610609261000.131648.1612345380191%40Atlassian.JIRA.


Jira (FACT-2918) FACTER_ environmental facts overrides don't work with external facts

2021-01-28 Thread Nate McCurdy (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Nate McCurdy commented on  FACT-2918  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: FACTER_ environmental facts overrides don't work with external facts   
 

  
 
 
 
 

 
 +1 to getting this fixed. Glad to see it's being triaged now. It's a common workflow where I am to allow unprivileged users to run Puppet and set FACTER_ environment variables to toggle feature flags that we've built in to our code. As the users are unprivileged, they aren't able to write files to disk to modify an external fact. but they do have the rights to set an ENV variable for a one-off Puppet run. This bug breaks that workflow. Also of note, there's a test for this exact behavior in Facter so it's definitely meant to be working: https://github.com/puppetlabs/facter/blob/4.0.49/acceptance/tests/external_facts/env_var_overrides_external_fact.rb#L35-L42 How is that test passing? ...I guess it works when using Facter directory, but not when run through puppet facts.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.383195.1610609261000.128169.1611882360257%40Atlassian.JIRA.


Jira (FACT-2918) FACTER_ environmental facts overrides don't work with external facts

2021-01-28 Thread Isaiah Frantz (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Isaiah Frantz commented on  FACT-2918  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: FACTER_ environmental facts overrides don't work with external facts   
 

  
 
 
 
 

 
 Im curious how these test could be passing considering the actual behavior: https://github.com/puppetlabs/facter/blob/main/acceptance/tests/external_facts/env_var_overrides_external_fact.rb  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.383195.1610609261000.128160.1611882180033%40Atlassian.JIRA.


Jira (FACT-2918) FACTER_ environmental facts overrides don't work with external facts

2021-01-28 Thread Josh Cooper (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2918  
 
 
  FACTER_ environmental facts overrides don't work with external facts   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Fix Version/s: 
 FACT 4.0.50  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.383195.1610609261000.128001.1611874740108%40Atlassian.JIRA.


Jira (FACT-2918) FACTER_ environmental facts overrides don't work with external facts

2021-01-27 Thread Dorin Pleava (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Dorin Pleava assigned an issue to Dorin Pleava  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2918  
 
 
  FACTER_ environmental facts overrides don't work with external facts   
 

  
 
 
 
 

 
Change By: 
 Dorin Pleava  
 
 
Assignee: 
 Dorin Pleava  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.383195.1610609261000.127117.1611820620040%40Atlassian.JIRA.


Jira (FACT-2918) FACTER_ environmental facts overrides don't work with external facts

2021-01-27 Thread Mihai Buzgau (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihai Buzgau updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2918  
 
 
  FACTER_ environmental facts overrides don't work with external facts   
 

  
 
 
 
 

 
Change By: 
 Mihai Buzgau  
 
 
Story Points: 
 3  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.383195.1610609261000.125814.1611738540083%40Atlassian.JIRA.


Jira (FACT-2918) FACTER_ environmental facts overrides don't work with external facts

2021-01-20 Thread Nick Walker (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Nick Walker commented on  FACT-2918  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: FACTER_ environmental facts overrides don't work with external facts   
 

  
 
 
 
 

 
 Kenneth Pepiton thanks for the response.  It wasn't clear from the description that this used to work and it is a regression.  During triage we thought it never worked in Puppet. I was able to reproduce that it worked in PE 2018.1.10 and does not work in PE 2019.8.4.    
 
 
 
 
 [root@master-masterbranch-centos ~]# puppet --version  
 
 
 6.20.0  
 
 
 [root@master-masterbranch-centos ~]# cat /opt/puppetlabs/server/pe_build  
 
 
 2019.8.5-rc2-160-g4af732b  
 
 
 [root@master-masterbranch-centos ~]# FACTER_test_fact=blah puppet facts show | grep test  
 
 
 "test_fact": "blah",  
 
 
 [root@master-masterbranch-centos ~]# mkdir /etc/puppetlabs/facter  
 
 
 [root@master-masterbranch-centos ~]# mkdir /etc/puppetlabs/facter/facts.d  
 
 
 [root@master-masterbranch-centos ~]# vim /etc/puppetlabs/facter/facts.d/test_fact.txt  
 
 
 [root@master-masterbranch-centos ~]# FACTER_test_fact=blah puppet facts show | grep test  
 
 
 "test_fact": "foo",  
 
 

Jira (FACT-2918) FACTER_ environmental facts overrides don't work with external facts

2021-01-19 Thread Kenneth Pepiton (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Kenneth Pepiton commented on  FACT-2918  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: FACTER_ environmental facts overrides don't work with external facts   
 

  
 
 
 
 

 
 There are two major problems with this response: 1) This was previously working and is no longer working 2) The exact use case is in the example.  The need to override the fact values while testing the agent allows for an alternative for testing. I am very sadly disappointed in this type of response  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.383195.1610609261000.118548.1611085440107%40Atlassian.JIRA.


Jira (FACT-2918) FACTER_ environmental facts overrides don't work with external facts

2021-01-19 Thread Nick Walker (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Nick Walker commented on  FACT-2918  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: FACTER_ environmental facts overrides don't work with external facts   
 

  
 
 
 
 

 
 While this is inconsistent behavior... it's unclear what use case makes this a problem over just setting an external fact in a file.  The recommendation is just to set the external fact in a file to get it to show in the puppet run.   We don't intend to fix this as when running from the puppet daemon setting facts from environment variables is likely not an expected use case.      
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.383195.1610609261000.117883.1611071280252%40Atlassian.JIRA.


Jira (FACT-2918) FACTER_ environmental facts overrides don't work with external facts

2021-01-19 Thread Mihai Buzgau (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Mihai Buzgau updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2918  
 
 
  FACTER_ environmental facts overrides don't work with external facts   
 

  
 
 
 
 

 
Change By: 
 Mihai Buzgau  
 
 
Sprint: 
 NW - 2021-02-03  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.383195.1610609261000.117687.1611054180035%40Atlassian.JIRA.


Jira (FACT-2918) FACTER_ environmental facts overrides don't work with external facts

2021-01-13 Thread zendesk.jira (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 zendesk.jira updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2918  
 
 
  FACTER_ environmental facts overrides don't work with external facts   
 

  
 
 
 
 

 
Change By: 
 zendesk.jira  
 
 
Zendesk Ticket Count: 
 1  
 
 
Zendesk Ticket IDs: 
 42719  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.383195.1610609261000.115031.1610609460040%40Atlassian.JIRA.


Jira (FACT-2918) FACTER_ environmental facts overrides don't work with external facts

2021-01-13 Thread zendesk.jira (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 zendesk.jira updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2918  
 
 
  FACTER_ environmental facts overrides don't work with external facts   
 

  
 
 
 
 

 
Change By: 
 zendesk.jira  
 
 
Labels: 
 jira_escalated  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.383195.1610609261000.115032.1610609460083%40Atlassian.JIRA.


Jira (FACT-2918) FACTER_ environmental facts overrides don't work with external facts

2021-01-13 Thread Henry Wang (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henry Wang updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2918  
 
 
  FACTER_ environmental facts overrides don't work with external facts   
 

  
 
 
 
 

 
Change By: 
 Henry Wang  
 

  
 
 
 
 

 
 Overriding Using cli, overriding  external facts from the cli works with facter but not in puppet.Reproducing steps:when the external fact things don't exist:{code:java}  [root@goat01 facts.d]# pwd/etc/puppetlabs/facter/facts.d[root@goat01 facts.d]# ll things.txtls: cannot access things.txt: No such file or directory[root@goat01 facts.d]# facter -p things[root@goat01 facts.d]# FACTER_things=stuff facter -p thingsstuff[root@goat01 facts.d]# FACTER_things=stuff puppet facts|grep things"things": "stuff",[root@goat01 facts.d]# FACTER_things=stuff puppet apply -e 'notify{"things=>${facts.get(things)}<":}'Notice: Compiled catalog for goat01.unix.gsm1900.org in environment production in 0.02 secondsNotice: things=>stuffstuff<]/message: defined 'message' as 'things=>stuff<'Notice: Applied catalog in 0.06 seconds{code}however, when external facts exist. create external fact things with value 'NOT_STUFF':{code:java}  [root@goat01 facts.d]# echo things=NOT_STUFF > things.txt[root@goat01 facts.d]# facter -p thingsNOT_STUFF[root@goat01 facts.d]# FACTER_things=stuff facter -p things #<-- worksstuff[root@goat01 facts.d]# FACTER_things=stuff puppet facts|grep things #<-- doesnt"things": "NOT_STUFF",[root@goat01 facts.d]# FACTER_things=stuff puppet apply -e 'notify{"things=>${facts.get(things)}<":}'Notice: Compiled catalog for goat01.unix.gsm1900.org in environment production in 0.02 secondsNotice: things=>NOT_STUFFNOT_STUFF<]/message: defined 'message' as 'things=>NOT_STUFF<'Notice: Applied catalog in 0.06 seconds {code}Conclusion:  using cli,  when external facts exist, environment facts FACTER_ will not overwrite the external facts in Puppet run. facter -p can display the overwritten value but puppet facts and puppet run can't.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 


Jira (FACT-2918) FACTER_ environmental facts overrides don't work with external facts

2021-01-13 Thread Henry Wang (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henry Wang created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Facter /  FACT-2918  
 
 
  FACTER_ environmental facts overrides don't work with external facts   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2021/01/13 11:27 PM  
 
 
Environment: 
 PE 2019.8.4  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Henry Wang  
 

  
 
 
 
 

 
 Overriding external facts from the cli works with facter but not in puppet. Reproducing steps: when the external fact things don't exist:  
 
 
 
 
 [root@goat01 facts.d]# pwd  
 
 
 /etc/puppetlabs/facter/facts.d  
 
 
 [root@goat01 facts.d]# ll things.txt  
 
 
 ls: cannot access things.txt: No such file or directory  
 
 
 [root@goat01 facts.d]# facter -p things