Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Maximilian Philipps commented on PUP-10017 Re: Collapse dependency failures into Class level failures From reading the release notes I hoped this would help us. However after renaming the apache package resource in our test environment I still get almost 7000 lines of Skipping because of failed dependencies and just one Skipping resources in class because of failed class dependencies. Is this supposed to only work on class dependencies and not on individual resources? We often tag resources and then build dependencies between them using resource collectors. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.324379.1568220393000.24250.1579077720375%40Atlassian.JIRA.
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Thomas Kishel updated an issue Puppet / PUP-10017 Collapse dependency failures into Class level failures Change By: Thomas Kishel Release Notes Summary: Merge dependency warningsIf a class has a failed dependency, every individual resource in that class generates a `notice` level message about the dependency failure, and a `warning` level message about skipping the resource. At large-node and/or large-code scale, one dependency failure can create an overwhelming number of warnings ... obscuring the root cause and increasing the use of system resources required to process and store the resulting reports.To collapse all messages caused by one class dependency failure into one message associated with the class, set `merge_dependency_warnings=true`. Release Notes: New Feature Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Thomas Kishel commented on PUP-10017 Re: Collapse dependency failures into Class level failures I've added something ... feel free to improve or replace. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.324379.1568220393000.45360.1574721480754%40Atlassian.JIRA.
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Josh Cooper commented on PUP-10017 Re: Collapse dependency failures into Class level failures Thomas Kishel or Gheorghe Popescu could you add release notes? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.324379.1568220393000.45209.1574718360494%40Atlassian.JIRA.
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Josh Cooper commented on PUP-10017 Re: Collapse dependency failures into Class level failures Passed 6.4.x CI in c08141b365b51bb248e94414e5ca31452371306c, and master in c89b3235935ec99ee5397c7691403361fc69167e Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.324379.1568220393000.45200.1574718300404%40Atlassian.JIRA.
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Josh Cooper updated an issue Puppet / PUP-10017 Collapse dependency failures into Class level failures Change By: Josh Cooper Fix Version/s: PUP 6.12.0 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.324379.1568220393000.45183.1574718244127%40Atlassian.JIRA.
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Josh Cooper updated an issue Puppet / PUP-10017 Collapse dependency failures into Class level failures Change By: Josh Cooper Fix Version/s: PUP 6.4.5 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.324379.1568220393000.45191.1574718244202%40Atlassian.JIRA.
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Mihai Buzgau updated an issue Puppet / PUP-10017 Collapse dependency failures into Class level failures Change By: Mihai Buzgau Sprint: NW - 2019-10-02, NW - 2019-10-16, NW - 2019-10-30, NW - 2019-11-13 , 2019-11-27 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.324379.1568220393000.32049.1573727283170%40Atlassian.JIRA.
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Mihai Buzgau updated an issue Puppet / PUP-10017 Collapse dependency failures into Class level failures Change By: Mihai Buzgau Sprint: NW - 2019-10-02, NW - 2019-10-16, NW - 2019-10-30 , NW - 2019-11-13 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.324379.1568220393000.12198.1572426004495%40Atlassian.JIRA.
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Mihai Buzgau updated an issue Puppet / PUP-10017 Collapse dependency failures into Class level failures Change By: Mihai Buzgau Sprint: NW - 2019-10-02, NW - 2019-10-16 , NW - 2019-10-30 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.324379.1568220393000.2328.1571214247196%40Atlassian.JIRA.
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Mihai Buzgau updated an issue Puppet / PUP-10017 Collapse dependency failures into Class level failures Change By: Mihai Buzgau Sprint: NW - 2019-10-02 , NW - 2019-10-16 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.324379.1568220393000.124737.1570005606548%40Atlassian.JIRA.
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Mihai Buzgau assigned an issue to Dorin Pleava Puppet / PUP-10017 Collapse dependency failures into Class level failures Change By: Mihai Buzgau Assignee: Dorin Pleava Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.324379.1568220393000.113281.1569397920928%40Atlassian.JIRA.
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title
Thomas Kishel commented on PUP-10017
Re: Collapse dependency failures into Class level failures
For a more extreme example:
class rrr {
file { '/fail/file_in_rrr.txt':
content => 'hello',
}
}
class ddd {
require rrr
range(1,99).each |$n| {
file { "/tmp/file_${n}_in_ddd.txt":
content => 'hello',
}
}
}
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Thomas Kishel commented on PUP-10017 Re: Collapse dependency failures into Class level failures The above is implemented in the PR. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.324379.1568220393000.105296.1568851260221%40Atlassian.JIRA.
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Thomas Kishel updated an issue Puppet / PUP-10017 Collapse dependency failures into Class level failures Change By: Thomas Kishel Attachment: without_coalesce.png Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.324379.1568220393000.105107.1568846401177%40Atlassian.JIRA.
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Thomas Kishel updated an issue Puppet / PUP-10017 Collapse dependency failures into Class level failures Change By: Thomas Kishel When a Class has a failed dependency, every individual resource in the class generates a notice level message about the dependency failure and a warning level message about skipping the resource, as well as a skip event in the report. This can generate a large number of messages and a large report if there are many dependencies, or multiple layers of dependencies. At large-node and/or large-code scale, one dependency failure can create an overwhelming number of warnings ... obscuring the root cause and increasing the use of system resources required to process and store the resulting reports. If possible, all of the skipped resources should be collapsed into the containing class and the messages and skip event should be done at the class level. It looks like the most recent work on this was done in PUP-3930 and commit 32e2bf2. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Thomas Kishel updated an issue Puppet / PUP-10017 Collapse dependency failures into Class level failures Change By: Thomas Kishel Attachment: with_coalesce.png Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.324379.1568220393000.105112.1568846401199%40Atlassian.JIRA.
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Thomas Kishel updated an issue Puppet / PUP-10017 Collapse dependency failures into Class level failures Change By: Thomas Kishel Attachment: with_and_without_coalesce.png Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.324379.1568220393000.105102.1568846401155%40Atlassian.JIRA.
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Gheorghe Popescu updated an issue Puppet / PUP-10017 Collapse dependency failures into Class level failures Change By: Gheorghe Popescu Story Points: 3 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.324379.1568220393000.103160.1568792640384%40Atlassian.JIRA.
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Mihai Buzgau updated an issue Puppet / PUP-10017 Collapse dependency failures into Class level failures Change By: Mihai Buzgau Sprint: PR NW - Triage 2019-10-02 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.324379.1568220393000.100939.1568710260712%40Atlassian.JIRA.
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Mihai Buzgau updated an issue Puppet / PUP-10017 Collapse dependency failures into Class level failures Change By: Mihai Buzgau Sprint: PR - Triage Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.324379.1568220393000.99132.1568629380973%40Atlassian.JIRA.
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Thomas Kishel commented on PUP-10017 Re: Collapse dependency failures into Class level failures A (let's say) suppress_inherited_dependency_failures option would affect the logic here: https://github.com/puppetlabs/puppet/blob/5.5.x/lib/puppet/transaction.rb#L285 https://github.com/puppetlabs/puppet/blob/5.5.x/lib/puppet/transaction.rb#L398 When suppress_inherited_dependency_failures is true ... if a resource has a parent if the parent is a class if the class has a dependency relationship if the dependent is a failed resource (or the dependent is a class containing a failed resource) mark the class as failed (and mark the resource as failed) report (just once) that we are skipping the containing class of the resource suppress the report that we are skipping the resource Use case when enabled: given a failure in a resource that is required by a class, a user would see (one) class failure in the report, and could perform a puppet run without suppress_inherited_dependency_failures to identify the resources in the class that were skipped, if necessary. But since the solution to the dependency failure is to resolve the failure in the dependent resource, that would only be valuable for auditing everything that was skipped: the user's attention should be focused on the failed resource (in the example, File['/impossible/xxx.txt']).
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Thomas Kishel commented on PUP-10017 Re: Collapse dependency failures into Class level failures Implementing this should also address the high volume of skips associated with resources using the schedule metaparameter when the run is outside the schedule window. Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.324379.1568220393000.97613.1568392800169%40Atlassian.JIRA.
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Jarret Lavallee updated an issue Puppet / PUP-10017 Collapse dependency failures into Class level failures Change By: Jarret Lavallee Team: Night's Watch Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.324379.1568220393000.96782.1568331660628%40Atlassian.JIRA.
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Jarret Lavallee updated an issue Puppet / PUP-10017 Collapse dependency failures into Class level failures Change By: Jarret Lavallee CS Priority: Needs Priority Reviewed Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.324379.1568220393000.96786.1568331660647%40Atlassian.JIRA.
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Jarret Lavallee updated an issue Puppet / PUP-10017 Collapse dependency failures into Class level failures Change By: Jarret Lavallee CS Priority: Needs Priority Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.324379.1568220393000.93936.1568224080190%40Atlassian.JIRA.
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title
Thomas Kishel commented on PUP-10017
Re: Collapse dependency failures into Class level failures
Given one class that requires another ...
class xxx {
file { '/impossible/xxx.txt':
content => 'hello',
}
}
class www {
require xxx
file { '/tmp/yyy.txt':
content => 'hello',
}
file { '/tmp/zzz.txt':
content => 'hello',
}
Jira (PUP-10017) Collapse dependency failures into Class level failures
Title: Message Title Adrian Parreiras Horta created an issue Puppet / PUP-10017 Collapse dependency failures into Class level failures Issue Type: Improvement Affects Versions: PUP 6.7.2 Assignee: Unassigned Components: Catalog Application Created: 2019/09/11 9:46 AM Priority: Normal Reporter: Adrian Parreiras Horta When a Class has a failed dependency, every individual resource in the class generates a notice level message about the dependency failure and a warning level message about skipping the resource, as well as a skip event in the report. This can generate a large number of messages and a large report if there are many dependencies, or multiple layers of dependencies. If possible, all of the skipped resources should be collapsed into the containing class and the messages and skip event should be done at the class level. It looks like the most recent work on this was done in PUP-3930 and commit 32e2bf2. Add Comment
