Jira (PUP-10524) Puppet tests fail with facter 4
Title: Message Title Gheorghe Popescu updated an issue Puppet / PUP-10524 Puppet tests fail with facter 4 Change By: Gheorghe Popescu Fix Version/s: PUP 6.16.0 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.359341.1589935505000.73283.1590739140152%40Atlassian.JIRA.
Jira (PUP-10524) Puppet tests fail with facter 4
Title: Message Title Bogdan Irimie updated an issue Puppet / PUP-10524 Puppet tests fail with facter 4 Change By: Bogdan Irimie Fix Version/s: PUP 6.16.0 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.359341.1589935505000.73277.1590738420041%40Atlassian.JIRA.
Jira (PUP-10524) Puppet tests fail with facter 4
Title: Message Title Gheorghe Popescu updated an issue Puppet / PUP-10524 Puppet tests fail with facter 4 Change By: Gheorghe Popescu Fix Version/s: PUP 6.16.0 Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.359341.1589935505000.70769.1590573480083%40Atlassian.JIRA.
Jira (PUP-10524) Puppet tests fail with facter 4
Title: Message Title Bogdan Irimie commented on PUP-10524 Re: Puppet tests fail with facter 4 Josh Cooper Melissa Stone we just released Facter [4.0.23|https://rubygems.org/gems/facter/versions/4.0.23] today and with the fixes from https://github.com/puppetlabs/puppet/pull/8165 puppet tests should pass. Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.359341.1589935505000.68343.1590151680029%40Atlassian.JIRA.
Jira (PUP-10524) Puppet tests fail with facter 4
Title: Message Title Bogdan Irimie commented on PUP-10524 Re: Puppet tests fail with facter 4 Josh Cooper with the fixes from Melissa Stone branch (https://github.com/puppetlabs/puppet/pull/8165/files), Facter 4 master and the fix for $CHILD_STATUS https://github.com/puppetlabs/puppet/pull/8165#issuecomment-632109253 the unit test for puppet pass. A new version of Facter 4 will be released tomorrow. Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.359341.1589935505000.67534.1590072900096%40Atlassian.JIRA.
Jira (PUP-10524) Puppet tests fail with facter 4
Title: Message Title Bogdan Irimie assigned an issue to Bogdan Irimie Puppet / PUP-10524 Puppet tests fail with facter 4 Change By: Bogdan Irimie Assignee: Bogdan Irimie Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.359341.1589935505000.67358.1590045240044%40Atlassian.JIRA.
Jira (PUP-10524) Puppet tests fail with facter 4
Title: Message Title Bogdan Irimie updated an issue Puppet / PUP-10524 Puppet tests fail with facter 4 Change By: Bogdan Irimie Priority: Normal High Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.359341.1589935505000.66354.1589959620363%40Atlassian.JIRA.
Jira (PUP-10524) Puppet tests fail with facter 4
Title: Message Title Bogdan Irimie updated an issue Puppet / PUP-10524 Puppet tests fail with facter 4 Change By: Bogdan Irimie Sub-team: ghost Team: Night's Watch Add Comment This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.359341.1589935505000.66346.1589959560031%40Atlassian.JIRA.
Jira (PUP-10524) Puppet tests fail with facter 4
Title: Message Title
Josh Cooper commented on PUP-10524
Re: Puppet tests fail with facter 4
Bogdan Irimie Melissa and I talked about this today and it looks like previously the tests passed because facter 2.5 executes some process (any successful process will work) prior to some of these tests executing. As a result $CHILD_STATUS is not nil. But when using facter 4 that doesn't happen and it's nil. One ugly hack is to do what I did for Windows a long time ago:
if Puppet::Util::Platform.windows?
# Get a pid for $CHILD_STATUS to latch on to
command = "cmd.exe /c \"exit 0\""
Puppet::Util::Execution.execute(command, {:failonfail => false})
end
Ideally the code should not be using CHILD_STATUS and instead using the ProcessOutput that the Puppet::Util::Execute.execute method returns, but that was looking like a bigger change than expected. Also there were two failures that seemed to be legit facter differences. Could you or someone on your team take a look as this is a blocker for puppet testing against facter4 in CI? Thanks!
Add Comment
Jira (PUP-10524) Puppet tests fail with facter 4
Title: Message Title
Melissa Stone updated an issue
Puppet / PUP-10524
Puppet tests fail with facter 4
Change By:
Melissa Stone
{code} Failures: 1) Puppet::Type::Service::Provider::Openbsd #status should use the status command from the resource Failure/Error: if $CHILD_STATUS.exitstatus == 0 NoMethodError: undefined method `exitstatus' for nil:NilClass # ./lib/puppet/provider/service/base.rb:74:in `status' # ./spec/unit/provider/service/openbsd_spec.rb:61:in `block (3 levels) in ' # ./spec/spec_helper.rb:180:in `block (2 levels) in ' # util/rspec_runner:44:in `run' # util/rspec_runner:59:in `' Finished in 29 32 . 52 11 seconds (files took 3.14 seconds to load) 1) Puppet::Node::Facts::Facter resolving file based facts should resolve external facts Failure/Error: expect do expect { apply.run }.to exit_with(0) end.to have_printed('bar') expected "bar" to be printed; got: Warning: Unknown variable: 'foo'. (line: 1, column: 10) Error: Evaluation Error: Missing title. The title _expression_ resulted in undef (line: 1, column: 10) on node pyewacket.vpn.puppet.net # ./spec/integration/indirector/facts/facter_spec.rb:61:in `block (3 levels) in ' # ./spec/spec_helper.rb:180:in `block ( 2 levels) in ' # util/rspec_runner:44:in `run' # util/rspec_runner:59:in `'Finished in 39 . 34 64 seconds (files took 3.6 seconds to load) 1) Puppet::Type::Service::Provider::Redhat when getting all service instances should call service status when initialized from provider Failure/Error: if $CHILD_STATUS.exitstatus == 0 NoMethodError: undefined method `exitstatus' for nil:NilClass # ./lib/puppet/provider/service/base.rb:74:in `status' # ./spec/unit/provider/service/redhat_spec.rb:60:in `block (3 levels) in ' # ./spec/spec_helper.rb:180:in `block (2 levels) in ' # util/rspec_runner:44:in `run' # util/rspec_runner:59:in `' 2) Puppet::Type::Service::Provider::Redhat when running status should use any provided explicit command Failure/Error: if $CHILD_STATUS.exitstatus == 0 NoMethodError: undefined method `exitstatus' for nil:NilClass # ./lib/puppet/provider/service/base.rb:74:in `status' # ./spec/unit/provider/service/redhat_spec.rb:122:in `block (4 levels) in ' # ./spec/spec_helper.rb:180:in `block (2 levels) in ' # util/rspec_runner:44:in `run' # util/rspec_runner:59:in `' 3) Puppet::Type::Service::Provider::Redhat when running status should execute the service script with status when no explicit command is provided Failure/Error: if $CHILD_STATUS.exitstatus == 0 NoMethodError: undefined method `exitstatus' for nil:NilClass # ./lib/puppet/provider/service/base.rb:74:in `status' # ./spec/unit/provider/service/redhat_spec.rb:128:in `block (4 levels) in ' # ./spec/spec_helper.rb:180:in `block (2 levels) in ' # util/rspec_runner:44:in `run' # util/rspec_runner:59:in `' 4) Puppet::Type::Service::Provider::Redhat when
