Jira (PUP-10615) Add facts and vars back to PAL ScriptCompiler scope

2020-08-20 Thread Claire Cadman (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Claire Cadman updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-10615  
 
 
  Add facts and vars back to PAL ScriptCompiler scope   
 

  
 
 
 
 

 
Change By: 
 Claire Cadman  
 
 
Labels: 
 docs-reviewed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.368742.1597093035000.19961.1597913820063%40Atlassian.JIRA.


Jira (PUP-10615) Add facts and vars back to PAL ScriptCompiler scope

2020-08-19 Thread Tom Beech (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom Beech updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-10615  
 
 
  Add facts and vars back to PAL ScriptCompiler scope   
 

  
 
 
 
 

 
Change By: 
 Tom Beech  
 
 
Comment: 
 PAL's script compiler now sets local facts for the compiler's scope. A previous change to PAL removed setting facts, which resulted in breaking changes to the script compiler API. Now, setting local facts in the script compiler's scope by setting the 'set_local_facts' option to 'false' for 'with_script_compiler'. This option is set to 'true' by default.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.368742.1597093035000.19283.1597854060171%40Atlassian.JIRA.


Jira (PUP-10615) Add facts and vars back to PAL ScriptCompiler scope

2020-08-19 Thread Tom Beech (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom Beech updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-10615  
 
 
  Add facts and vars back to PAL ScriptCompiler scope   
 

  
 
 
 
 

 
 PAL's script compiler now sets local facts for the compiler's scope. A previous change to PAL removed setting facts, which resulted in breaking changes to the script compiler API. Now, setting local facts in the script compiler's scope by setting the 'set_local_facts' option to 'false' for 'with_script_compiler'. This option is set to 'true' by default.  
 

  
 
 
 
 

 
Change By: 
 Tom Beech  
 
 
Release Notes: 
 Bug Fix  
 
 
Release Notes Summary: 
 Added local facts back to PAL's script compiler scope.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

 

Jira (PUP-10615) Add facts and vars back to PAL ScriptCompiler scope

2020-08-19 Thread Dorin Pleava (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Dorin Pleava updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-10615  
 
 
  Add facts and vars back to PAL ScriptCompiler scope   
 

  
 
 
 
 

 
Change By: 
 Dorin Pleava  
 
 
Fix Version/s: 
 PUP 6.18.0  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.368742.1597093035000.18982.1597841460125%40Atlassian.JIRA.


Jira (PUP-10615) Add facts and vars back to PAL ScriptCompiler scope

2020-08-10 Thread Tom Beech (Jira)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Tom Beech created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-10615  
 
 
  Add facts and vars back to PAL ScriptCompiler scope   
 

  
 
 
 
 

 
Issue Type: 
  Bug  
 
 
Assignee: 
 Tom Beech  
 
 
Created: 
 2020/08/10 1:57 PM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Tom Beech  
 

  
 
 
 
 

 
 Puppet Version: 6.15.0 - 6.17.0 As part of work on Bolt, PUP-10397 removed vars and facts for the current node from PAL's script compiler. This resulted in a breaking change to a public API, affecting downstream projects that rely on PAL. The script compiler should make the current node's vars and facts available again. Desired Behavior: **PAL's script compiler should have access to vars and facts for the node running the script. Actual Behavior: PAL's script compiler does not have access to the vars and facts for the node running the script, causing project's that rely on the PAL API to lose access to this data.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment