Jira (PUP-11751) Unexpected behavior after setting strict to :error
Title: Message Title Aria Li updated an issue Puppet / PUP-11751 Unexpected behavior after setting strict to :error Change By: Aria Li Release Notes: Not Needed Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.480628.167520764.6651.1681856940079%40Atlassian.JIRA.
Jira (PUP-11751) Unexpected behavior after setting strict to :error
Title: Message Title Aria Li updated an issue Puppet / PUP-11751 Unexpected behavior after setting strict to :error Change By: Aria Li Release Notes Summary: Previously, the strict_variables setting defaulted to false. For Puppet 8, strict mode will be on by default which means strict_variables will be on & default to true and strict will default to error. With strict_variables on, an evaluation error will be raised when referencing unknown variables but not when referencing variables that are explicitly set to undef. This change could potentially be a breaking change. Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.480628.167520764.6650.1681856940035%40Atlassian.JIRA.
Jira (PUP-11751) Unexpected behavior after setting strict to :error
Title: Message Title Josh Cooper updated an issue Puppet / PUP-11751 Unexpected behavior after setting strict to :error Change By: Josh Cooper Sprint: Phoenix 2023-03-01, Phoenix 2023-03-15 , Phoenix 2023-03-29 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.480628.167520764.1050.1678911540031%40Atlassian.JIRA.
Jira (PUP-11751) Unexpected behavior after setting strict to :error
Title: Message Title
Aria Li updated an issue
Puppet / PUP-11751
Unexpected behavior after setting strict to :error
Change By:
Aria Li
This ticket is a placeholder for all the unexpected behavior I found while working on PUP-11725 after setting strict to default to {{:error}} instead of {{:warning}} # When rich_data is enabled, users should be able to create and use their own rich data type derived from `Object`.However, [this test|https://github.com/puppetlabs/puppet/blob/f4fbaaac5b21731929e76a7218b3f735ef41cd15/spec/integration/application/apply_spec.rb#L205] that checks Puppet can apply a catalog from an environment with Pcore object types began failing after enabling strict mode. It seems like there was a warning (when strict was set to warning) before that got swallowed and was never noticed. I'll mark the test as pending for now. I also wrote another test that checks that a catalog can be applied without warnings/errors.2. The [lookup function|https://www.puppet.com/docs/puppet/6/function.html#lookup] can take in a {{default_values_hash}} as a parameter and should use that hash to check for the requested key. However, in this [lookup test|https://github.com/puppetlabs/puppet/blob/980a51e3b2e60132c1c00a417b7fc89d353c86f9/spec/unit/functions/lookup_spec.rb#L2414], it fails and does not use the passed in {{default_values_hash}} unless another {{lookup}} is used like [this test|https://github.com/puppetlabs/puppet/blob/980a51e3b2e60132c1c00a417b7fc89d353c86f9/spec/unit/functions/lookup_spec.rb#L2410] does.3. Dig more into this loaders_spec.rb [test|https://github.com/puppetlabs/puppet/blob/fa0250e7338fe156831599d2280339003b46ccc8/spec/unit/pops/loaders/loaders_spec.rb#L248-L251] that checks that a loader can load a function twice when loading from module. For now, I'll mark that test as pending.4. This [acceptance test|https://github.com/puppetlabs/puppet/blob/25a86b1/acceptance/tests/lookup/config5_interpolation.rb] was also failing in a strange way; `strict` errors caused the test to error out, but without it, the test completes correctly, indicating that `::roles` ends up not actually being undefined.
Add Comment
Jira (PUP-11751) Unexpected behavior after setting strict to :error
Title: Message Title Michael Hashizume updated an issue Puppet / PUP-11751 Unexpected behavior after setting strict to :error Change By: Michael Hashizume Sprint: Phoenix 2023-03-01 , Language Triage 2 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.480628.167520764.2293.1677694200024%40Atlassian.JIRA.
Jira (PUP-11751) Unexpected behavior after setting strict to :error
Title: Message Title Tony Vu assigned an issue to Tony Vu Puppet / PUP-11751 Unexpected behavior after setting strict to :error Change By: Tony Vu Assignee: Tony Vu Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.480628.167520764.10863.1676506560025%40Atlassian.JIRA.
Jira (PUP-11751) Unexpected behavior after setting strict to :error
Title: Message Title Josh Cooper updated an issue Puppet / PUP-11751 Unexpected behavior after setting strict to :error Change By: Josh Cooper Sprint: Phoenix 2023-03-01 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.480628.167520764.10693.1676480940026%40Atlassian.JIRA.
Jira (PUP-11751) Unexpected behavior after setting strict to :error
Title: Message Title
Tony Vu updated an issue
Puppet / PUP-11751
Unexpected behavior after setting strict to :error
Change By:
Tony Vu
This ticket is a placeholder for all the unexpected behavior I found while working on PUP-11725 after setting strict to default to {{:error}} instead of {{:warning}} # When rich_data is enabled, users should be able to create and use their own rich data type derived from `Object`.However, [this test|https://github.com/puppetlabs/puppet/blob/f4fbaaac5b21731929e76a7218b3f735ef41cd15/spec/integration/application/apply_spec.rb#L205] that checks Puppet can apply a catalog from an environment with Pcore object types began failing after enabling strict mode. It seems like there was a warning (when strict was set to warning) before that got swallowed and was never noticed. I'll mark the test as pending for now. I also wrote another test that checks that a catalog can be applied without warnings/errors.2. The [lookup function|https://www.puppet.com/docs/puppet/6/function.html#lookup] can take in a {{default_values_hash}} as a parameter and should use that hash to check for the requested key. However, in this [lookup test|https://github.com/puppetlabs/puppet/blob/980a51e3b2e60132c1c00a417b7fc89d353c86f9/spec/unit/functions/lookup_spec.rb#L2414], it fails and does not use the passed in {{default_values_hash}} unless another {{lookup}} is used like [this test|https://github.com/puppetlabs/puppet/blob/980a51e3b2e60132c1c00a417b7fc89d353c86f9/spec/unit/functions/lookup_spec.rb#L2410] does.3. Dig more into this loaders_spec.rb [test|https://github.com/puppetlabs/puppet/blob/fa0250e7338fe156831599d2280339003b46ccc8/spec/unit/pops/loaders/loaders_spec.rb#L248-L251] that checks that a loader can load a function twice when loading from module. For now, I'll mark that test as pending. 4. This [acceptance test|https://github.com/puppetlabs/puppet/blob/25a86b1/acceptance/tests/lookup/config5_interpolation.rb] was also failing in a strange way; `strict` errors caused the test to error out, but without it, the test completes correctly, indicating that `::roles` ends up not actually being undefined.
Add Comment
Jira (PUP-11751) Unexpected behavior after setting strict to :error
Title: Message Title Josh Cooper updated an issue Puppet / PUP-11751 Unexpected behavior after setting strict to :error Change By: Josh Cooper Story Points: 3 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.480628.167520764.9185.1675968420030%40Atlassian.JIRA.
Jira (PUP-11751) Unexpected behavior after setting strict to :error
Title: Message Title Aria Li updated an issue Puppet / PUP-11751 Unexpected behavior after setting strict to :error Change By: Aria Li Release Notes Summary: Previously, the strict_variables setting defaulted to false. For Puppet 8, strict mode will be on by default which means strict_variables will be on & default to true and strict will default to error. With strict_variables on, an evaluation error will be raised when referencing unknown variables but not when referencing variables that are explicitly set to undef. This change could potentially be a breaking change. Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.480628.167520764.8824.1675883280068%40Atlassian.JIRA.
Jira (PUP-11751) Unexpected behavior after setting strict to :error
Title: Message Title
Aria Li updated an issue
Puppet / PUP-11751
Unexpected behavior after setting strict to :error
Change By:
Aria Li
This ticket is a placeholder for all the unexpected behavior I found while working on PUP-11725 after setting strict to default to {{:error}} instead of {{:warning}} # When rich_data is enabled, users should be able to create and use their own rich data type derived from `Object`.However, [this test|https://github.com/puppetlabs/puppet/blob/f4fbaaac5b21731929e76a7218b3f735ef41cd15/spec/integration/application/apply_spec.rb#L205] that checks Puppet can apply a catalog from an environment with Pcore object types began failing after enabling strict mode. It seems like there was a warning (when strict was set to warning) before that got swallowed and was never noticed. I'll mark the test as pending for now. I also wrote another test that checks that a catalog can be applied without warnings/errors.2. The [lookup function|https://www.puppet.com/docs/puppet/6/function.html#lookup] can take in a {{default_values_hash}} as a parameter and should use that hash to check for the requested key. However, in this [lookup test|https://github.com/puppetlabs/puppet/blob/980a51e3b2e60132c1c00a417b7fc89d353c86f9/spec/unit/functions/lookup_spec.rb#L2414], it fails and does not use the passed in {{default_values_hash}} unless another {{lookup}} is used like [this test|https://github.com/puppetlabs/puppet/blob/980a51e3b2e60132c1c00a417b7fc89d353c86f9/spec/unit/functions/lookup_spec.rb#L2410] does. 3. Dig more into this loaders_spec.rb [test|https://github.com/puppetlabs/puppet/blob/fa0250e7338fe156831599d2280339003b46ccc8/spec/unit/pops/loaders/loaders_spec.rb#L248-L251] that checks that a loader can load a function twice when loading from module.
Add Comment
Jira (PUP-11751) Unexpected behavior after setting strict to :error
Title: Message Title
Aria Li updated an issue
Puppet / PUP-11751
Unexpected behavior after setting strict to :error
Change By:
Aria Li
This ticket is a placeholder for all the unexpected behavior I found while working on PUP-11725 after setting strict to default to {{:error}} instead of {{:warning}} # When rich_data is enabled, users should be able to create and use their own rich data type derived from `Object`.However, [this test|https://github.com/puppetlabs/puppet/blob/f4fbaaac5b21731929e76a7218b3f735ef41cd15/spec/integration/application/apply_spec.rb#L205] that checks Puppet can apply a catalog from an environment with Pcore object types began failing after enabling strict mode. It seems like there was a warning (when strict was set to warning) before that got swallowed and was never noticed. I'll mark the test as pending for now. I also wrote another test that checks that a catalog can be applied without warnings/errors.2. The [lookup function|https://www.puppet.com/docs/puppet/6/function.html#lookup] can take in a {{default_values_hash}} as a parameter and should use that hash to check for the requested key. However, in this [lookup test|https://github.com/puppetlabs/puppet/blob/980a51e3b2e60132c1c00a417b7fc89d353c86f9/spec/unit/functions/lookup_spec.rb#L2414], it fails and does not use the passed in {{default_values_hash}} unless another {{lookup}} is used like [this test|https://github.com/puppetlabs/puppet/blob/980a51e3b2e60132c1c00a417b7fc89d353c86f9/spec/unit/functions/lookup_spec.rb#L2410] does.3. Dig more into this loaders_spec.rb [test|https://github.com/puppetlabs/puppet/blob/fa0250e7338fe156831599d2280339003b46ccc8/spec/unit/pops/loaders/loaders_spec.rb#L248-L251] that checks that a loader can load a function twice when loading from module. For now, I'll mark that test as pending.
Add Comment
Jira (PUP-11751) Unexpected behavior after setting strict to :error
Title: Message Title Aria Li updated an issue Puppet / PUP-11751 Unexpected behavior after setting strict to :error Change By: Aria Li Epic Link: PA-4664 Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.480628.167520764.8320.1675797780025%40Atlassian.JIRA.
Jira (PUP-11751) Unexpected behavior after setting strict to :error
Title: Message Title
Aria Li updated an issue
Puppet / PUP-11751
Unexpected behavior after setting strict to :error
Change By:
Aria Li
This ticket is a placeholder for all the unexpected behavior I found while working on PUP-11725 after setting strict to default to {{:error}} instead of {{:warning}} # When rich_data is enabled, users should be able to create and use their own rich data type derived from `Object`.However, [this test|https://github.com/puppetlabs/puppet/blob/f4fbaaac5b21731929e76a7218b3f735ef41cd15/spec/integration/application/apply_spec.rb#L205] that checks Puppet can apply a catalog from an environment with Pcore object types began failing after enabling strict mode. It seems like there was a warning (when strict was set to warning) before that got swallowed and was never noticed. I'll mark the test as pending for now. I also wrote another test that checks that a catalog can be applied without warnings/errors.2. The [lookup function|https://www.puppet.com/docs/puppet/6/function.html#lookup] can take in a {{default_values_hash}} as a parameter and should use that hash to check for the requested key. However, in this [lookup test|https://github.com/puppetlabs/puppet/blob/980a51e3b2e60132c1c00a417b7fc89d353c86f9/spec/unit/functions/lookup_spec.rb#L2414], it fails and does not use the passed in {{default_values_hash }}unless another {{lookup}} is used like [this test|https://github.com/puppetlabs/puppet/blob/980a51e3b2e60132c1c00a417b7fc89d353c86f9/spec/unit/functions/lookup_spec.rb#L2410] does.
Add Comment
Jira (PUP-11751) Unexpected behavior after setting strict to :error
Title: Message Title
Aria Li updated an issue
Puppet / PUP-11751
Unexpected behavior after setting strict to :error
Change By:
Aria Li
This ticket is a placeholder for all the unexpected behavior I found while working on PUP-11725 after setting strict to default to {{:error}} instead of {{:warning}} # When rich_data is enabled, users should be able to create and use their own rich data type derived from `Object`. However, [this test|https://github.com/puppetlabs/puppet/blob/f4fbaaac5b21731929e76a7218b3f735ef41cd15/spec/integration/application/apply_spec.rb#L205] that checks Puppet can apply a catalog from an environment with Pcore object types began failing after enabling strict mode. It seems like there was a warning (when strict was set to warning) before that got swallowed and was never noticed. I'll mark the test as pending for now. I also wrote another test that checks that a catalog can be applied without warnings/errors. 2. The [lookup function|https://www.puppet.com/docs/puppet/6/function.html#lookup] can take in a {{default_values_hash}} as a parameter and should use that hash to check for the requested key. However, in this [lookup test|https://github.com/puppetlabs/puppet/blob/980a51e3b2e60132c1c00a417b7fc89d353c86f9/spec/unit/functions/lookup_spec.rb#L2414], it fails and does not use the passed in {{default_values_hash }}unless another {{lookup}} is used like [this test|https://github.com/puppetlabs/puppet/blob/980a51e3b2e60132c1c00a417b7fc89d353c86f9/spec/unit/functions/lookup_spec.rb#L2410] does.
Add Comment
Jira (PUP-11751) Unexpected behavior after setting strict to :error
Title: Message Title Aria Li updated an issue Puppet / PUP-11751 Unexpected behavior after setting strict to :error Change By: Aria Li Summary: Unable Unexpected behavior after setting strict to apply catalog from environment with pcore object types :error Add Comment This message was sent by Atlassian Jira (v8.20.11#820011-sha1:0629dd8) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.480628.167520764.7498.1675387080028%40Atlassian.JIRA.
