Jira (PUP-1627) Puppet agent's locking is subject to race conditions

2018-03-16 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-1627  
 
 
  Puppet agent's locking is subject to race conditions   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Sub-team: 
 Coremunity  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1627) Puppet agent's locking is subject to race conditions

2017-09-05 Thread Past Haus (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Past Haus updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-1627 
 
 
 
  Puppet agent's locking is subject to race conditions  
 
 
 
 
 
 
 
 
 

Change By:
 
 Past Haus 
 
 
 

Labels:
 
 AWS1 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1627) Puppet agent's locking is subject to race conditions

2017-05-18 Thread Moses Mendoza (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Moses Mendoza updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-1627 
 
 
 
  Puppet agent's locking is subject to race conditions  
 
 
 
 
 
 
 
 
 

Change By:
 
 Moses Mendoza 
 
 
 

Labels:
 
 triaged 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1627) Puppet agent's locking is subject to race conditions

2017-05-15 Thread Josh Cooper (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Josh Cooper updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-1627 
 
 
 
  Puppet agent's locking is subject to race conditions  
 
 
 
 
 
 
 
 
 

Change By:
 
 Josh Cooper 
 
 
 

Team:
 
 Agent 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1627) Puppet agent's locking is subject to race conditions

2017-05-15 Thread John Duarte (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 John Duarte updated an issue 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 Puppet /  PUP-1627 
 
 
 
  Puppet agent's locking is subject to race conditions  
 
 
 
 
 
 
 
 
 

Change By:
 
 John Duarte 
 
 
 

Labels:
 
 triaged 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1627) Puppet agent's locking is subject to race conditions

2016-11-08 Thread Josh Cooper (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Josh Cooper commented on  PUP-1627 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
  Re: Puppet agent's locking is subject to race conditions  
 
 
 
 
 
 
 
 
 
 
From 

PUP-6900
: 
 
Running puppet agent --disable or dropping a lock file in /opt/puppet/cache/state/agent_disabled.lock is currently not respected by the Puppet Agent if the agent does not have a signed / valid certificate.
 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 

 
 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1627) Puppet agent's locking is subject to race conditions

2015-06-04 Thread Owen Rodabaugh (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Owen Rodabaugh updated an issue 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 Puppet /  PUP-1627 
 
 
 
  Puppet agent's locking is subject to race conditions  
 
 
 
 
 
 
 
 
 

Change By:
 
 Owen Rodabaugh 
 
 
 

CS Priority:
 
 NeedsPriority Normal 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1627) Puppet agent's locking is subject to race conditions

2015-06-03 Thread Zack Smith (JIRA)
Title: Message Title
 
 
 
 
 
 
 
 
 
 
  
 
 Zack Smith updated an issue 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 Puppet /  PUP-1627 
 
 
 
  Puppet agent's locking is subject to race conditions  
 
 
 
 
 
 
 
 
 

Change By:
 
 Zack Smith 
 
 
 

CS Priority:
 
 NeedsPriority 
 
 
 
 
 
 
 
 
 
 
 
 

 
 Add Comment 
 
 
 
 
 
 
 
 
 
 


 
 
 
 
 
 
 
 
 

 This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d) 
 
 
 
 
  
 
 
 
 
 
 
 
 
   





-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1627) Puppet agent's locking is subject to race conditions

2014-10-01 Thread Josh Cooper (JIRA)
Title: Message Title










 

 Josh Cooper updated an issue


















 Puppet /  PUP-1627



  Puppet agent's locking is subject to race conditions 










Change By:

 Josh Cooper




Summary:

 puppetdoesnotlockcatalogwhengeneratingSSLkey Puppetagent'slockingissubjecttoraceconditions












   

 Add Comment






















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)




 














-- 
You received this message because you are subscribed to the Google Groups Puppet Bugs group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at http://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-1627) Puppet agent's locking is subject to race conditions

2014-10-01 Thread Josh Cooper (JIRA)
Title: Message Title










 

 Josh Cooper commented on an issue


















  Re: Puppet agent's locking is subject to race conditions 










From 

PUP-2574


The agent attempts to acquire its pidlock fairly late in the agent lifecycle.
If two agents start simultaneously, they will race until one of them acquires the lock. In between that time we perform a number of critical operations, e.g. generate SSL keys, checking if another instance is running?, etc.
The scope of the lock should be increased. And I think the attempt to acquire the lock should raise an exception on failure, with a type of exception that indicates why it failed (due to another instance running, being administratively disabled, or some other reason). Otherwise, if the lock method returns true/false, the caller has to check why it failed, and that will introduce another race.













   

 Add Comment

























 Puppet /  PUP-1627



  Puppet agent's locking is subject to race conditions 







 key generating takes some time, as result we can initiate it twice simultaneously by executing puppet agent -t when daemon generates key, and if autosigning enabled on master this issue can cause certificate mismatch error 















 This message was sent by Atlassian JIRA (v6.1.4#6159-sha1:44eaede)