Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title
Past Haus updated an issue
Puppet / PUP-5426
config set ignores --section and can insert duplicate settings if they are in [main]
Change By:
Past Haus
Comment:
We're seeing some surprising behavior in PE with this changeset in. I guess the first odd thing is that if a setting doesn't exist anywhere (and a [main] section exists), a new [main] section is added at the bottom of {{puppet.conf}}. This happens with each invocation, so after calling {{puppet config set}} 3 times, there are 4 {{[main]}} sections in {{puppet.conf}}. Starting with a puppet.conf that looks like the following:{code}# This file can be used to override the default puppet settings.# See the following links for more details on what settings are available:# - https://docs.puppetlabs.com/puppet/latest/reference/config_important_settings.html# - https://docs.puppetlabs.com/puppet/latest/reference/config_about_settings.html# - https://docs.puppetlabs.com/puppet/latest/reference/config_file_main.html# - https://docs.puppetlabs.com/puppet/latest/reference/configuration.html[main]certname = r1nc1m63jxi6u3e.delivery.puppetlabs.netserver = r1nc1m63jxi6u3e.delivery.puppetlabs.netuser = pe-puppetgroup = pe-puppetenvironment_timeout = unlimitedmodule_groups = base+pe_only[agent]graph = true[master]node_terminus = classifierstoreconfigs = truestoreconfigs_backend = puppetdbreports = puppetdbcertname = r1nc1m63jxi6u3e.delivery.puppetlabs.netalways_retry_plugins = falsedisable_i18n = true{code}I then run {{puppet config set masterport 8144}}.Now {{puppet.conf}} looks like this:{code}# This file can be used to override the default puppet settings.# See the following links for more details on what settings are available:# - https://docs.puppetlabs.com/puppet/latest/reference/config_important_settings.html# - https://docs.puppetlabs.com/puppet/latest/reference/config_about_settings.html# - https://docs.puppetlabs.com/puppet/latest/reference/config_file_main.html# - https://docs.puppetlabs.com/puppet/latest/reference/configuration.html[main]certname = r1nc1m63jxi6u3e.delivery.puppetlabs.netserver = r1nc1m63jxi6u3e.delivery.puppetlabs.netuser = pe-puppetgroup = pe-puppetenvironment_timeout = unlimitedmodule_groups = base+pe_only[agent]graph = true[master]node_terminus = classifierstoreconfigs = truestoreconfigs_backend = puppetdbreports = puppetdbcertname = r1nc1m63jxi6u3e.delivery.puppetlabs.netalways_retry_plugins = falsedisable_i18n = true[main]masterport = 8144{code}I then run {{puppet config set ca_port 8144}}.Now {{puppet.conf}} looks like:{code}# This file can be used to override the default puppet settings.# See the following links for more details on what settings are available:# - https://docs.puppetlabs.com/puppet/latest/reference/config_important_settings.html# - https://docs.puppetlabs.com/puppet/latest/reference/config_about_settings.html# - https://docs.puppetlabs.com/puppet/latest/reference/config_file_main.html# - https://docs.puppetlabs.com/puppet/latest/reference/configuration.html[main]certname = r1nc1m63jxi6u3e.delivery.puppetlabs.netserver = r1nc1m63jxi6u3e.delivery.puppetlabs.netuser = pe-puppetgroup = pe-puppetenvironment_timeout = unlimitedmodule_groups = base+pe_only[agent]graph = true[master]node_terminus =
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Past Haus commented on PUP-5426 Re: config set ignores --section and can insert duplicate settings if they are in [main] We're seeing some surprising behavior in PE with this changeset in. I guess the first odd thing is that if a setting doesn't exist anywhere (and a [main] section exists), a new [main] section is added at the bottom of puppet.conf. This happens with each invocation, so after calling puppet config set 3 times, there are 4 [main] sections in puppet.conf. Starting with a puppet.conf that looks like the following: # This file can be used to override the default puppet settings. # See the following links for more details on what settings are available: # - https://docs.puppetlabs.com/puppet/latest/reference/config_important_settings.html # - https://docs.puppetlabs.com/puppet/latest/reference/config_about_settings.html # - https://docs.puppetlabs.com/puppet/latest/reference/config_file_main.html # - https://docs.puppetlabs.com/puppet/latest/reference/configuration.html [main] certname = r1nc1m63jxi6u3e.delivery.puppetlabs.net server = r1nc1m63jxi6u3e.delivery.puppetlabs.net user = pe-puppet group = pe-puppet
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Josh Cooper commented on PUP-5426 Re: config set ignores --section and can insert duplicate settings if they are in [main] Merged to master in https://github.com/puppetlabs/puppet/commit/31ed4cfda46f5869f4cb978896081a5fc9c54f4e Verified original case works and changes the environment setting in the node_ordering section # This file can be used to override the default puppet settings. # See the following links for more details on what settings are available: # - https://docs.puppetlabs.com/puppet/latest/reference/config_important_settings.html # - https://docs.puppetlabs.com/puppet/latest/reference/config_about_settings.html # - https://docs.puppetlabs.com/puppet/latest/reference/config_file_main.html # - https://docs.puppetlabs.com/references/latest/configuration.html [main] server = exl7i0vi62ouagu.delivery.puppetlabs.net environment = production
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Jacob Helwig updated an issue Puppet / PUP-5426 config set ignores --section and can insert duplicate settings if they are in [main] Change By: Jacob Helwig Release Notes Summary: `puppet config set` no longer creates entries in the wrong section if there is a setting with the same value in multiple sections Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Jacob Helwig commented on PUP-5426 Re: config set ignores --section and can insert duplicate settings if they are in [main] So, the reason the order of the settings in the [agent] section matters, is that our IniFile implementation is trying to add the new environment setting after the last line in the [agent] section, but is unable to tell the difference between the server line in [main], and the one in [agent] as it's only keying off of the setting's name & values. When the certname setting is last, it's unique, so adding the new line doesn't get confused about which instance to add environment after. So, this bug has the general form of: If a setting would be inserted after an existing setting that has the same value as one in a previous section (according to line number) in puppet.conf, the new setting will be inserted after the first occurrence of the name/value, instead of the one in the desired section. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Jacob Helwig updated an issue Puppet / PUP-5426 config set ignores --section and can insert duplicate settings if they are in [main] Change By: Jacob Helwig Sprint: Platform Core Hopper KANBAN Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Jacob Helwig assigned an issue to Jacob Helwig Puppet / PUP-5426 config set ignores --section and can insert duplicate settings if they are in [main] Change By: Jacob Helwig Assignee: Jacob Helwig Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Josh Cooper updated an issue Puppet / PUP-5426 config set ignores --section and can insert duplicate settings if they are in [main] Change By: Josh Cooper Acceptance Criteria: Using puppet config set doesn't produce a duplicate setting as described in the steps to reproduce. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Craig Gomes updated an issue Puppet / PUP-5426 config set ignores --section and can insert duplicate settings if they are in [main] Change By: Craig Gomes Sprint: Platform Core Hopper Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Josh Cooper updated an issue Puppet / PUP-5426 config set ignores --section and can insert duplicate settings if they are in [main] Change By: Josh Cooper Sub-team: Coremunity Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Josh Cooper assigned an issue to Unassigned Puppet / PUP-5426 config set ignores --section and can insert duplicate settings if they are in [main] Change By: Josh Cooper Assignee: Kylo Ginsberg Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Josh Cooper updated an issue Puppet / PUP-5426 config set ignores --section and can insert duplicate settings if they are in [main] This is required to make puppet config set usable. Change By: Josh Cooper Team: Agent Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Ruth Linehan commented on PUP-5426 Re: config set ignores --section and can insert duplicate settings if they are in [main] Thank you for filing this issue. We agree it is likely an improvement, but due to other issues demanding precedence, we don’t anticipate being able to address this any time soon. As such we are closing this as “Won’t Fix.” We may revisit it at a later time, and if so will re-open this ticket. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Russell Mull updated an issue Puppet / PUP-5426 config set ignores --section and can insert duplicate settings if they are in [main] Change By: Russell Mull Labels: triaged Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Russell Mull commented on PUP-5426 Re: config set ignores --section and can insert duplicate settings if they are in [main] Just reproduced on puppet 4.10 Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Joshua Partlow commented on PUP-5426 Re: config set ignores --section and can insert duplicate settings if they are in [main] Ok, this is a truly bizarre bug. It seems to be the presence of the duplicate server setting, and also it's position that's involved. On 4.2.3: [main] server = exl7i0vi62ouagu.delivery.puppetlabs.net environment = production [agent] server = exl7i0vi62ouagu.delivery.puppetlabs.net certname = qcpd7c0tnvnp4kd.delivery.puppetlabs.net [main] server = exl7i0vi62ouagu.delivery.puppetlabs.net environment = production
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Eric Thompson commented on PUP-5426 Re: config set ignores --section and can insert duplicate settings if they are in [main] Joshua Partlow thanks for looking into this. did you have a [main] section when you tried it? i think it's the main section that makes things difficult. i'll try this on foss master Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-5426 config set ignores --section and can insert duplicate settings if they are in [main] Change By: Kylo Ginsberg Fix Version/s: PUP 4.4.0 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-5426 config set ignores --section and can insert duplicate settings if they are in [main] Change By: Kylo Ginsberg Sprint: Client 2016-01-27 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-5426 config set ignores --section and can insert duplicate settings if they are in [main] Change By: Kylo Ginsberg Sprint: Client 2015 2016 - 12 01 - 30 13 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Kylo Ginsberg updated an issue Puppet / PUP-5426 config set ignores --section and can insert duplicate settings if they are in [main] Change By: Kylo Ginsberg Sprint: Client 2016-01- 13 27 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Steve Barlow updated an issue Puppet / PUP-5426 config set ignores --section and can insert duplicate settings if they are in [main] Change By: Steve Barlow Sprint: Client Triage 2015-12-30 Add Comment This message was sent by Atlassian JIRA (v6.4.12#64027-sha1:e3691cc) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Josh Cooper commented on PUP-5426 Re: config set ignores --section and can insert duplicate settings if they are in [main] Is this a dup of PUP-4948? Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Steve Barlow updated an issue Puppet / PUP-5426 config set ignores --section and can insert duplicate settings if they are in [main] Change By: Steve Barlow Sprint: Client Triage Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Eric Thompson commented on PUP-5426 Re: config set ignores --section and can insert duplicate settings if they are in [main] possible history: https://github.com/puppetlabs/puppet/pull/2138 https://github.com/puppetlabs/puppet/pull/2158 Add Comment This message was sent by Atlassian JIRA (v6.4.11#64026-sha1:78f6ec4) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at http://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-5426) config set ignores --section and can insert duplicate settings if they are in [main]
Title: Message Title Eric Thompson created an issue Puppet / PUP-5426 config set ignores --section and can insert duplicate settings if they are in [main] Issue Type: Bug Assignee: Kylo Ginsberg Components: Client Created: 2015/10/23 2:27 PM Priority: Normal Reporter: Eric Thompson [root@qcpd7c0tnvnp4kd ~]# cat /etc/puppetlabs/puppet/puppet.conf # This file can be used to override the default puppet settings. # See the following links for more details on what settings are available:
