Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title John Duarte updated an issue Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: John Duarte QA Risk Assessment: Needs Assessment No Action Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.188237.1493320097000.8973.1571669282326%40Atlassian.JIRA.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title
Eric Delaney commented on PUP-7630
Re: "Successful" puppet agent reports hide provider errors
Tested on master SHA=7938d1daae36d9b7f77abeebb771475367e89022 SUITE_VERSION=5.3.3.588.g7938d1d
root@wt9n8bzzrillanz ~]# puppet apply -e 'file {"/tmp/foo": ensure => present, require => File["/tmp/foo"],}'
Notice: Compiled catalog for wt9n8bzzrillanz.delivery.puppetlabs.net in environment production in 0.02 seconds
Error: Found 1 dependency cycle:
(File[/tmp/foo] => File[/tmp/foo])\nTry the '--graph' option and opening the resulting '.dot' file in OmniGraffle or GraphViz
Error: Failed to apply catalog: One or more resource dependency cycles detected in graph
[root@wt9n8bzzrillanz ~]# echo $?
1
[root@wt9n8bzzrillanz ~]# find /opt -name last_run_report.yaml
/opt/puppetlabs/puppet/cache/state/last_run_report.yaml
[root@wt9n8bzzrillanz bin]# ./irb
irb(main):001:0> require 'puppet'
=> true
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Craig Gomes assigned an issue to Eric Delaney Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Craig Gomes Assignee: Kris Bosland Eric Delaney Add Comment This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Kris Bosland commented on PUP-7630 Re: "Successful" puppet agent reports hide provider errors Hi Kenn, I have added release notes, please let me know if you have any feedback. On Mon, Feb 5, 2018 at 7:36 AM, Kenn Hussey (JIRA) < Add Comment This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Kris Bosland updated an issue Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Kris Bosland Release Notes Summary: Providers that fail in prefetch will now cause the resources that use them to fail and not be evaluated. This will not affect other resources or providers that are not dependent on the failed provider and resources. Release Notes: Bug Fix Add Comment This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Kenn Hussey commented on PUP-7630 Re: "Successful" puppet agent reports hide provider errors Kris Bosland please add release notes for this issue, if needed. Thanks! Add Comment This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Kris Bosland commented on PUP-7630 Re: "Successful" puppet agent reports hide provider errors Merged into master at https://github.com/puppetlabs/puppet/commit/3aed5c03e9a4470798836892cc10c60e7683c298 Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Kris Bosland updated an issue Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Kris Bosland Acceptance Criteria: When a provider fails in prefetch: 1. The agent run should be reported as failed. 2. Resources that use that provider should be marked as failed and not evaluated. 3. Resources that depend on resources that use that provider should not be evaluated. 4. Unrelated resources should still run. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Verne Lindner commented on PUP-7630 Re: "Successful" puppet agent reports hide provider errors Josh Cooper That's good news! Watchers, I linked a document to the description, with errors we need to consider as failed run status assignment criteria. I added Charlie Sharpsteen's suggestions from his comment above. Please add any other warnings and errors you believe should be considered. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Verne Lindner updated an issue Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Verne Lindner It's possible to get a successful agent run report that on closer inspection include errors.For instance, an error points to a failure with the Chocolatey provider. Because the provider failed out, it did not return a complete list of resources to manage, and the agent run completes successfully on this smaller catalog without raising an alarm.There is no way for an administrator to notice this problem and correct it without drilling down into green agent reports to confirm whether an error has occurred or not. On large scale deployments this solution rapidly becomes unmanageable.Agent runs need to return some condition when providers fail that highlights that this has occurred. There needs to be a scaleable way to monitor and report on this kind of failure. Please add all errors and warnings for consideration as failed run status assignment criteria [here|https://docs.google.com/document/d/1PKLzYYPyPVt0pKS4Fc6r-1BbDAfK8eFOmTICcgT5gQ4/edit?usp=sharing]. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Josh Cooper commented on PUP-7630 Re: "Successful" puppet agent reports hide provider errors Note to watchers, we are making an immediate fix for this issue in PUP-8288 to be released in the next 4.10.x release so that we don't report success if we fail to apply the entire transaction. We are planning additional improvements for all of the issues described here in 5.4.0. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Josh Cooper updated an issue Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Josh Cooper Fix Version/s: PUP 4.10.z Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Josh Cooper updated an issue Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Josh Cooper Fix Version/s: PUP 5.4.0 Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Josh Cooper updated an issue Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Josh Cooper Comment: Fix merged into 4.10.x at https://github.com/puppetlabs/puppet/commit/e58f47581365541db09318aff697d93397ece31c. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Kris Bosland updated an issue Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Kris Bosland Sprint: Platform Core Hopper KANBAN Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Kris Bosland commented on PUP-7630 Re: "Successful" puppet agent reports hide provider errors Fix merged into 4.10.x at https://github.com/puppetlabs/puppet/commit/e58f47581365541db09318aff697d93397ece31c. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Kris Bosland updated an issue Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Kris Bosland Fix Version/s: PUP 6.0.0 Fix Version/s: PUP 4.10.z Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Craig Gomes updated an issue Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Craig Gomes Sprint: Platform Core KANBAN Hopper Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Craig Gomes updated an issue Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Craig Gomes Fix Version/s: PUP 4.10.z Fix Version/s: PUP 6.0.0 Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Craig Gomes updated an issue Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Craig Gomes Sprint: Platform Core Hopper KANBAN Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Craig Gomes updated an issue Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Craig Gomes Sub-team: Coremunity Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Craig Gomes updated an issue Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Craig Gomes Sprint: Platform Core Grooming Hopper Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Craig Gomes assigned an issue to Kris Bosland Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Craig Gomes Assignee: Kris Bosland Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Verne Lindner commented on PUP-7630 Re: "Successful" puppet agent reports hide provider errors Josh Cooper Charlie Sharpsteen If we want to broaden criteria for a red status to include errors, and some warnings, what do we need to do? Which team would do the work? Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Josh Cooper updated an issue Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Josh Cooper Fix Version/s: PUP 4.10.z Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Charlie Sharpsteen commented on PUP-7630 Re: "Successful" puppet agent reports hide provider errors Attached a break_stuff.tar.gz module that contains the above examples. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Charlie Sharpsteen updated an issue Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Charlie Sharpsteen Attachment: break_stuff.tar.gz Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Charlie Sharpsteen commented on PUP-7630 Re: "Successful" puppet agent reports hide provider errors Assuming the report failed unless the catalog applies correctly is something we already do as reports are initialized to a "failed" state: https://github.com/puppetlabs/puppet/blob/5.3.3/lib/puppet/transaction/report.rb#L226 So, it seems like there is a bug or regression if catalog application is failing completely but our reports are coming back indicating success. However, I think this approach is too limited even if we fix the regression — the reason being that it allows a successful catalog run to mask serious errors that just happened to be non-fatal to catalog application. Here's a list of some examples where major errors are logged during different parts of the agent lifecycle, but our Console Overview shows a green status: Catalog applied successfully, but pluginsync failed. This is problematic because we can't be sure the catalog was based on the latest facts and plugins. Catalog applied successfully, but a fact failed to resolve. This is problematic if the fact was critical to compiling a correct catalog. Catalog applied successfully, but it was a cached catalog because compilation failed. This is problematic if we expected to node to receive an up-to-date configuration. The above list is just three top-of-mind examples I came up with in 15 minutes and is by no means exhaustive. I've attached screen shots showing what the 2017.3.2 Console Overview page shows for node status vs. what the reports page shows is going on under the surface. Warnings are also something we should think about. These are more numerous and have a higher chance of being red herrings, but Puppet.deprecation_warning is one that we should think about: Catalog applied successfully, but is using deprecated functionality that will break on the next Puppet or Module upgrade. As Josh mentioned, this all flows from our use of resource status as the indicator of "success" in our node summaries with some finer detail in PE for intentional vs. corrective change. Basically, a visual representation of --detailed_exitcodes. However, the symbology we use for resource status, a "green checkmark", sends a powerful visual signal that "this puppet agent is healthy". Resource status is a major component of agent health, but the examples above show that actually declaring a node a healthy based on resource status alone is not correct. And that is the heart of this issue: variants of this problem will come back again and again until we broaden our overviews and summaries to
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Charlie Sharpsteen updated an issue Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Charlie Sharpsteen Attachment: pluginsync_failed.png Attachment: fact_failed.png Attachment: deprecation_warning.png Attachment: compile_failed.png Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Verne Lindner commented on PUP-7630 Re: "Successful" puppet agent reports hide provider errors Josh Cooper To your point, they would welcome accurate reporting - no argument there. My question is about identifying and accounting for any usability consequences of the change you're suggesting. From your answer, it seems that excessive reporting noise won't be an issue. One other consequence that I can think of is current console users will need to know that a Failed report will not always indicate failed resource events, so that if they open a Failed report, and see no failure events, they will understand that they need to look in the log. This seems minor to me, given that users frequently consult both log and events list when looking for information in a report. Charlie Sharpsteen What do you think? Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Josh Cooper commented on PUP-7630 Re: "Successful" puppet agent reports hide provider errors This should only increase the number of failed runs that we're incorrectly reporting as successful, not causing an increase in failed reports in general. The number of newly failed reports should be a small number. I think users would gladly welcome reporting the failure state correctly so that they don't assume everything is ok when it's not, e.g. they think puppet ran 30 mins about, but it really hasn't successfully applied the desired state for weeks. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Verne Lindner commented on PUP-7630 Re: "Successful" puppet agent reports hide provider errors Josh CooperCharlie Sharpsteen If assume the report failed unless the catalog applies successfully, how much of a spike in Failed reports could we expect; in other words, would Failed reports become so numerous that their volume would make it difficult for users to know which to investigate first? If so, could we lessen the noise by categorizing Failed reports by type of failures; for example, "fatal failures" (the catalog does not apply), major failures (a high percentage of failure events) and normal failures (don't know how to define 'normal')? Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Josh Cooper commented on PUP-7630 Re: "Successful" puppet agent reports hide provider errors Also due to issues like PUP-1542, it may be that we did try to generate a log event, but that fails, so it never makes it into the report. I think assuming the report failed unless proven otherwise will ensure we don't have false positives in the PE console. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Josh Cooper commented on PUP-7630 Re: "Successful" puppet agent reports hide provider errors The whack-a-mole game is because the agent marks the report as failed if and only if any of the applied resources failed. The problem is there are many failure modes before we even start applying resources, e.g. instances, prefetch, loading cached catalog, cycles in the graph, loading providers with gem dependencies, etc. I don't know that determining report success/failure based on log message error levels will work in all cases, as some failures may not cause an error message to be emitted. I think a simpler solution may be to assume the report has failed in the beginning and only mark the report as successful if we apply the catalog successfully. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Charlie Sharpsteen commented on PUP-7630 Re: "Successful" puppet agent reports hide provider errors I think we keep playing whack-a-mole with this issue because our fixes are too specific. In the past it was about using a cached catalog. This ticket is about "provider errors". To put this one to bed, I think we have to go for a general solution: if the logs from the puppet run contain any message at error level, turn the node red in the console or otherwise flag it so that folks know it needs attention. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Verne Lindner commented on PUP-7630 Re: "Successful" puppet agent reports hide provider errors Eric Sorenson ^^ It would be really lovely to put this thing to bed: on the Enterprise team, we also hear about it quite a bit when we talk to users about console reporting. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Adam Bottchen commented on PUP-7630 Re: "Successful" puppet agent reports hide provider errors Verne Lindner It is indeed. Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Verne Lindner commented on PUP-7630 Re: "Successful" puppet agent reports hide provider errors Owen Rodabaugh Is this issue still in the CS top 10? Add Comment This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Owen Rodabaugh updated an issue Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Owen Rodabaugh Method Found: Customer Feedback Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Karen Van der Veer updated an issue Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Karen Van der Veer Sprint: Platform Core Grooming Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Owen Rodabaugh updated an issue Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Owen Rodabaugh CS Priority: Needs Priority Major CS Impact: This has been a long standing issue. The console should not show a node as "unchanged" when there is an error in the report.Some customers never look into node reports unless it shows as an error on the front page of the console and due to this they probably won't notice these errors. False negatives are not good. CS Severity: 3 - Serious CS Business Value: 4 - $ CS Frequency: 4 - 50-90% of Customers Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe)
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Adam Bottchen updated an issue Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Adam Bottchen CS Priority: Needs Priority Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Dylan Zeleski commented on PUP-7630 Re: "Successful" puppet agent reports hide provider errors We are having the exact same issue as reported originally in the ticket as well as the dependency cycle one. Definitely a major issue with large deployments. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Paul Schaffer updated an issue Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Paul Schaffer A customer has noticed that they are getting It's possible to get a successful agent run reports report that on closer inspection include errors (ticket located here: https://puppetlabs . zendesk.com/agent/tickets/25207). The For instance, an error points to a failure with the Chocolatey provider. Because the provider failed out, it did not return a complete list of resources to manage, and the agent run completes successfully on this smaller catalog without raising an alarm. The issue with the Chocolatey provider was fixed in a later version of that module, however the overall issue There is still a problem: there is no way for an administrator to notice this problem and correct it without drilling down into green agent reports to confirm whether an error has occurred or not. On large scale deployments this solution rapidly becomes unmanageable.Agent runs need to return some condition when providers fail that highlights that this has occurred. There needs to be a scaleable way to monitor and report on this kind of failure. Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title
Past Haus commented on PUP-7630
Re: "Successful" puppet agent reports hide provider errors
Something similar happens if the entire run fails due to a cycle in the graph.
For example...
matthaus@wyclef-2 #> puppet apply -e 'file {"/tmp/foo": ensure => present, require => File["/tmp/foo"],}'
Notice: Compiled catalog for localhost in environment production in 0.08 seconds
Error: Failed to apply catalog: Found 1 dependency cycle:
(File[/tmp/foo] => File[/tmp/foo])
Try the '--graph' option and opening the resulting '.dot' file in OmniGraffle or GraphViz
matthaus@wyclef-2 #> echo $?
1
matthaus@wyclef-2 #> irb
irb(main):001:0> require 'puppet'
=> true
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Josh Cooper updated an issue Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Josh Cooper Team: Agent Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-7630) "Successful" puppet agent reports hide provider errors
Title: Message Title Paul Schaffer moved an issue Puppet / PUP-7630 "Successful" puppet agent reports hide provider errors Change By: Paul Schaffer Affects Version/s: PE 2017.1.1 Affects Version/s: PUP 4.7.0 Affects Version/s: PUP 4.9.4 Key: PE PUP - 20411 7630 Project: Puppet Enterprise [Internal] Add Comment This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from
