Jira (PUP-8494) Issue based errors are formatted too early and arguments are lost.

2018-03-13 Thread Josh Cooper (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Josh Cooper updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8494  
 
 
  Issue based errors are formatted too early and arguments are lost.   
 

  
 
 
 
 

 
Change By: 
 Josh Cooper  
 
 
Sub-team: 
 Language  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8494) Issue based errors are formatted too early and arguments are lost.

2018-03-09 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8494  
 
 
  Issue based errors are formatted too early and arguments are lost.   
 

  
 
 
 
 

 
Change By: 
 Henrik Lindberg  
 
 
Release Notes: 
 Not Needed  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8494) Issue based errors are formatted too early and arguments are lost.

2018-03-09 Thread Kenn Hussey (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Kenn Hussey commented on  PUP-8494  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
  Re: Issue based errors are formatted too early and arguments are lost.   
 

  
 
 
 
 

 
 Thomas Hallgren please add release notes for this issue, if needed. Thanks!    
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8494) Issue based errors are formatted too early and arguments are lost.

2018-03-08 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg updated an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8494  
 
 
  Issue based errors are formatted too early and arguments are lost.   
 

  
 
 
 
 

 
Change By: 
 Henrik Lindberg  
 
 
Fix Version/s: 
 PUP 5.5.0  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8494) Issue based errors are formatted too early and arguments are lost.

2018-03-08 Thread Henrik Lindberg (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Henrik Lindberg assigned an issue to Unassigned  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8494  
 
 
  Issue based errors are formatted too early and arguments are lost.   
 

  
 
 
 
 

 
Change By: 
 Henrik Lindberg  
 
 
Assignee: 
 Henrik Lindberg  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8494) Issue based errors are formatted too early and arguments are lost.

2018-03-06 Thread Thomas Hallgren (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Thomas Hallgren assigned an issue to Henrik Lindberg  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8494  
 
 
  Issue based errors are formatted too early and arguments are lost.   
 

  
 
 
 
 

 
Change By: 
 Thomas Hallgren  
 
 
Assignee: 
 Thomas Hallgren Henrik Lindberg  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8494) Issue based errors are formatted too early and arguments are lost.

2018-03-06 Thread Thomas Hallgren (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Thomas Hallgren assigned an issue to Thomas Hallgren  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8494  
 
 
  Issue based errors are formatted too early and arguments are lost.   
 

  
 
 
 
 

 
Change By: 
 Thomas Hallgren  
 
 
Assignee: 
 Thomas Hallgren  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment  
 

  
 

  
 
 
 
  
 

  
 
 
 
 

 
 This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93)  
 
 

 
   
 

  
 

  
 

   





-- 
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com.
To post to this group, send email to puppet-bugs@googlegroups.com.
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.


Jira (PUP-8494) Issue based errors are formatted too early and arguments are lost.

2018-02-27 Thread Thomas Hallgren (JIRA)
Title: Message Title


 
 
 
 

 
 
 

 
   
 Thomas Hallgren created an issue  
 

  
 
 
 
 

 
 
  
 
 
 
 

 
 Puppet /  PUP-8494  
 
 
  Issue based errors are formatted too early and arguments are lost.   
 

  
 
 
 
 

 
Issue Type: 
  Improvement  
 
 
Assignee: 
 Unassigned  
 
 
Created: 
 2018/02/27 6:39 AM  
 
 
Priority: 
  Normal  
 
 
Reporter: 
 Thomas Hallgren  
 

  
 
 
 
 

 
 One objective with formalizing all errors and warnings into an IssueCode with an associated argument Hash, is to make it possible to write tests asserting that the correct issues are raised and initialized with the correct arguments (as opposed to checking for specific pre-formatted messages which changes more often and differ from locale to locale). At present though, such tests are impossible because classes like Puppet::ParseErrorWithIssue performs the formatting of the final message when the actual error is instantiated and throws away the arguments in the process. Left is just the formatted message and the issue_code. This must change. Instead of storing a formatted message and the issue_code, the error should store the actual issue and the associated argument hash. The actual formatting of the issue can take place when the message is requested.  
 

  
 
 
 
 

 
 
 

 
 
 Add Comment