Jira (PUP-8610) PuppetStack.stacktrace is slow with a large stack
Title: Message Title John Duarte updated an issue Puppet / PUP-8610 PuppetStack.stacktrace is slow with a large stack Change By: John Duarte QA Risk Assessment: Needs Assessment No Action Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.243167.1522177769000.9132.1571669580620%40Atlassian.JIRA.
Jira (PUP-8610) PuppetStack.stacktrace is slow with a large stack
Title: Message Title Jacob Helwig commented on PUP-8610 Re: PuppetStack.stacktrace is slow with a large stack This was merged to 5.5.x in https://github.com/puppetlabs/puppet/commit/7af7246856b968658d48f74dcdb63c13749e6d54 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8610) PuppetStack.stacktrace is slow with a large stack
Title: Message Title Henrik Lindberg assigned an issue to Unassigned Puppet / PUP-8610 PuppetStack.stacktrace is slow with a large stack Change By: Henrik Lindberg Assignee: Nick Lewis Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8610) PuppetStack.stacktrace is slow with a large stack
Title: Message Title Josh Cooper updated an issue Puppet / PUP-8610 PuppetStack.stacktrace is slow with a large stack Change By: Josh Cooper Fix Version/s: PUP 5.5.z Fix Version/s: PUP 5.5.1 Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8610) PuppetStack.stacktrace is slow with a large stack
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-8610 PuppetStack.stacktrace is slow with a large stack Change By: Henrik Lindberg Sub-team: Language Release Notes Summary: optimization Team: Platform Core Sprint: Platform Core KANBAN Release Notes: Not Needed Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the
Jira (PUP-8610) PuppetStack.stacktrace is slow with a large stack
Title: Message Title Henrik Lindberg assigned an issue to Nick Lewis Puppet / PUP-8610 PuppetStack.stacktrace is slow with a large stack Change By: Henrik Lindberg Assignee: Nick Lewis Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8610) PuppetStack.stacktrace is slow with a large stack
Title: Message Title Henrik Lindberg updated an issue Puppet / PUP-8610 PuppetStack.stacktrace is slow with a large stack Change By: Henrik Lindberg Fix Version/s: PUP 6.0.0 Fix Version/s: PUP 5.5.z Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8610) PuppetStack.stacktrace is slow with a large stack
Title: Message Title Henrik Lindberg commented on PUP-8610 Re: PuppetStack.stacktrace is slow with a large stack The difficult bit is that the top of the "puppet stack" is at an unknown distance from the top of the "ruby stack" it is mixed into. A search would need to loop with a given batch size - remains to be seen if that is faster. We can certainly add a "get top of puppet stack" method to make it possible to optimize. Nick Lewis did you get a feel of if the increased time is because getting large stack from Kernel is slow, or because it gets large number of entries to match against and build new array? Add Comment This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.
Jira (PUP-8610) PuppetStack.stacktrace is slow with a large stack
Title: Message Title Nick Lewis created an issue Puppet / PUP-8610 PuppetStack.stacktrace is slow with a large stack Issue Type: Bug Assignee: Unassigned Created: 2018/03/27 12:09 PM Priority: Normal Reporter: Nick Lewis Several places in Puppet call PuppetStack.stacktrace[0] to get their "caller". Most notably, log messages where the "source" is a Scope object without an associated resource use that method to determine the "source" to log from. There are also some Puppet functions that use it (empty, create_resource, and more). Those calls become quite slow (I saw up to 50ms) when the stack is large. While it's probably uncommon for the stack to grow that deep, no caller currently uses anything but the top element of the stack, which means this is a straightforward opportunity for improvement. It probably makes sense to either make that method lazy, which is a bit of a challenge as it's both a filter and a map, or to add a method that specifically returns the top element of the stack, which satisfies every current caller. Add Comment
