Um, what Paul said. :)
We need tests, and the removal of most of the debugging, with the rest
switched to Puppet's internal logging system.
Also the inzoness property shouldn't need a retrieve method; that code
belongs on the provider. In fact, isn't it essentially equivalent to
the 'ensu
2009/1/19 James Turnbull :
>
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> James Turnbull wrote:
>> Signed-off-by: James Turnbull
>> ---
>> CHANGELOG|2 +
>> lib/puppet/provider/zenoss/zenoss.rb | 204
>> ++
>> lib/puppet/
Review inline
> +Puppet::Type.type(:zenoss_host).provide(:zenoss) do
> +desc "Provider for ZenOSS.
> + http://www.zenoss.com/community/docs/howtos/send-events/
> + http://www.zenoss.com/community/docs/howtos/add-device/";
> +
> +require "xmlrpc/client"
> +
> +def pri
>
> I was more around the automated Gems, the pretty graphs, the emailed
> pull requests don't rock my world or anything.
I'm with James here, and to be honest as we're supposed to be doing
code review, you've probably already got a pull url in the ticket or
on list via the emails. Pull requests
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
James Turnbull wrote:
> Signed-off-by: James Turnbull
> ---
> CHANGELOG|2 +
> lib/puppet/provider/zenoss/zenoss.rb | 204
> ++
> lib/puppet/type/zenoss_host.rb | 132 +
Signed-off-by: James Turnbull
---
CHANGELOG|2 +
lib/puppet/provider/zenoss/zenoss.rb | 204 ++
lib/puppet/type/zenoss_host.rb | 132 ++
3 files changed, 338 insertions(+), 0 deletions(-)
create mode 10
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Luke Kanies wrote:
> Am I doing it wrong? I find pull requests to be more annoying than
> useful. I can't trigger the pull from github, doing the pull doesn't
> make the pull request go away; how is a pull request on github any
> better than
> ok, i think i'm missing at least one step in the augeas deployment.
> [r...@puppetslave ~]# rpm -ivh augeas-
> augeas-0.3.4-1.el5.x86_64.rpm augeas-libs-0.3.4-1.el5.x86_64.rpm
> [r...@puppetslave ~]# rpm -ivh augeas-*x86_64*rpm
> Preparing...
> ###
Have you confirmed that the output still looks fine? I have forgotten
my original motivation for doing this newline stripping, but I assume
it still looks ok.
On Jan 19, 2009, at 9:26 AM, Thomas Bellman wrote:
>
> (Re-send of patch.)
>
> In order for ReST formatting to work properly, newlin
On Jan 16, 2009, at 5:59 PM, James Turnbull wrote:
>
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> Paul Lathrop wrote:
>> An alternative approach which addresses bot GitHub stability and
>> potential confusion, but still buys us the features available on
>> GitHub, is to have the RL repo
(Re-send of patch.)
In order for ReST formatting to work properly, newlines and
indentation of doc strings must be retained.
Signed-off-by: Thomas Bellman
---
lib/puppet/parser/functions.rb |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/lib/puppet/parser/functions.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I wrote:
| In order for ReST formatting to work properly, newlines and
| indentation of doc strings must be retained.
Thunderbird seems to do strange things to formatting when signing with PGP.
Why on earth it feels the need to prefix indented lines
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
In order for ReST formatting to work properly, newlines and
indentation of doc strings must be retained.
Signed-off-by: Thomas Bellman
- ---
~ lib/puppet/parser/functions.rb |2 +-
~ 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/
Hi Paul,
On Mon, 2009-01-19 at 09:16 +, Paul Nasrat wrote:
> > Unfortunately I completely halted what I did on the filebucket over REST
> > refactoring I did earlier. If it proves to be more important to have
> > this for 0.25 (on the same side what's the ETA for this version?), then
> > I'll
> Unfortunately I completely halted what I did on the filebucket over REST
> refactoring I did earlier. If it proves to be more important to have
> this for 0.25 (on the same side what's the ETA for this version?), then
> I'll perform a context switch to start working on the filebucket, but
> I'm
Hi,
I'm just posting a quick status update about the Application Controller
stuff I'm working on.
I started the conversion of the puppet applications, but couldn't finish
all the port and tests this week-end so I won't publish anything until
next week-end (that's the issue when you work only 5h
16 matches
Mail list logo
